Prepared by: | Krishna Addepalli |
---|---|
Workspace: | /cygdrive/d/Code_Base/jdk10_consolidated_new/client/open |
Compare against: | http://hg.openjdk.java.net/jdk/client |
Compare against version: | tip:tip~1 |
Summary of changes: | 126 lines changed: 125 ins; 0 del; 1 mod; 683 unchg |
Patch of changes: | open.patch |
Legend: |
Modified file Deleted file New file |
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/java.desktop/share/classes/javax/swing/plaf/basic/BasicMenuUI.java
rev 47711 : Fixed JDK-8178430: JMenu in GridBagLayout flickers when label text shows "..." and is updated. JDK-8178430: Fixed following issues with the test: 1. Throw exception in case the menu bar size is not proper. 2. Run the test for about 10 seconds, and then automatically close the window. 3. Moved the fix from BasicMenuItemUI.java to BasicMenuUI.java as per Sergey's suggestion. 4. Fixed the test case to correct the access to UI elements in EDT. Also, now made sure that the main thread won't exit until the test is complete. 5.Removed unnecessary space in BasicMenuItemUI.java 6. Removed unnecessary import. 7. Moved the declaration of member variables into the constructor scope. 8. Fixed the test case to update/access all the swing components inside SwingUtilities->invokeLater. 9. Modified the fix as suggested by Sergey.6 lines changed: 5 ins; 0 del; 1 mod; 683 unchg
------ ------ ------
------
---
New
Patch
Raw
test/jdk/javax/swing/JMenu/8178430/LabelDotTest.java
rev 47711 : Fixed JDK-8178430: JMenu in GridBagLayout flickers when label text shows "..." and is updated. JDK-8178430: Fixed following issues with the test: 1. Throw exception in case the menu bar size is not proper. 2. Run the test for about 10 seconds, and then automatically close the window. 3. Moved the fix from BasicMenuItemUI.java to BasicMenuUI.java as per Sergey's suggestion. 4. Fixed the test case to correct the access to UI elements in EDT. Also, now made sure that the main thread won't exit until the test is complete. 5.Removed unnecessary space in BasicMenuItemUI.java 6. Removed unnecessary import. 7. Moved the declaration of member variables into the constructor scope. 8. Fixed the test case to update/access all the swing components inside SwingUtilities->invokeLater. 9. Modified the fix as suggested by Sergey.120 lines changed: 120 ins; 0 del; 0 mod; 0 unchg
This code review page was prepared using webrev.ksh (vers 25.16-hg+openjdk.java.net).