Code Review for open

Prepared by:Krishna Addepalli on Wed Dec 13 13:59:45 IST 2017
Workspace:/cygdrive/d/Code_Base/jdk10_consolidated_new/client/open
Compare against: http://hg.openjdk.java.net/jdk/client
Compare against version:tip:tip~1
Summary of changes: 60 lines changed: 6 ins; 33 del; 21 mod; 1714 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/tree/VariableHeightLayoutCache.java

rev 47712 : Fixed JDK-8190281: Code cleanup in src\java.desktop\sharelasses\javax\swing ree\VariableHeightLayoutCache.java
Remove the streams related code changes, since it is increasing the class size by 1kb.
Moved the increment of nextIndex back into the conditional, since
moving it out makes it a functional changes, and needs to be accompanied with a testcase.
Properly align the code to the previous state at line no 1000,
so that unnecessary changes are not introduced.
Fixed condition check from == to <=.
Call getRowCount() only once, and cache it.
Removed the last remnant of getRowCount() and replaced it with max.
60 lines changed: 6 ins; 33 del; 21 mod; 1714 unchg

This code review page was prepared using webrev.ksh (vers 25.16-hg+openjdk.java.net).