Code Review for hotspot

Prepared by:kbarrett on Fri May 26 18:30:59 EDT 2017
Workspace:/home/kab/sandboxes/load_const/hs/hotspot
Compare against version:qparent
Summary of changes: 134 lines changed: 0 ins; 4 del; 130 mod; 7562 unchg
Patch of changes: hotspot.patch
Bug id: JDK-8166651 : OrderAccess::load_acquire &etc should have const parameters
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/aix_ppc/vm/atomic_aix_ppc.hpp

rev 13030 : [mq]: add_const
2 lines changed: 0 ins; 0 del; 2 mod; 477 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/aix_ppc/vm/orderAccess_aix_ppc.inline.hpp

rev 13030 : [mq]: add_const
5 lines changed: 0 ins; 0 del; 5 mod; 88 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/bsd_x86/vm/atomic_bsd_x86.hpp

rev 13030 : [mq]: add_const
3 lines changed: 0 ins; 0 del; 3 mod; 212 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/bsd_x86/vm/bsd_x86_32.s

rev 13030 : [mq]: add_const
2 lines changed: 0 ins; 0 del; 2 mod; 669 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/bsd_zero/vm/atomic_bsd_zero.hpp

rev 13030 : [mq]: add_const
2 lines changed: 0 ins; 0 del; 2 mod; 331 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/bsd_zero/vm/os_bsd_zero.hpp

rev 13032 : [mq]: atomic_copy64
3 lines changed: 0 ins; 0 del; 3 mod; 53 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/linux_aarch64/vm/atomic_linux_aarch64.hpp

rev 13030 : [mq]: add_const
2 lines changed: 0 ins; 0 del; 2 mod; 160 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/linux_aarch64/vm/orderAccess_linux_aarch64.inline.hpp

rev 13030 : [mq]: add_const
rev 13031 : [mq]: adinn_review
14 lines changed: 0 ins; 2 del; 12 mod; 130 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/linux_aarch64/vm/os_linux_aarch64.hpp

rev 13032 : [mq]: atomic_copy64
3 lines changed: 0 ins; 0 del; 3 mod; 42 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/linux_arm/vm/atomic_linux_arm.hpp

rev 13030 : [mq]: add_const
2 lines changed: 0 ins; 0 del; 2 mod; 263 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/linux_arm/vm/orderAccess_linux_arm.inline.hpp

rev 13030 : [mq]: add_const
11 lines changed: 0 ins; 0 del; 11 mod; 210 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/linux_arm/vm/os_linux_arm.cpp

rev 13030 : [mq]: add_const
3 lines changed: 0 ins; 0 del; 3 mod; 718 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/linux_arm/vm/os_linux_arm.hpp

rev 13030 : [mq]: add_const
3 lines changed: 0 ins; 0 del; 3 mod; 76 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/linux_ppc/vm/atomic_linux_ppc.hpp

rev 13030 : [mq]: add_const
2 lines changed: 0 ins; 0 del; 2 mod; 477 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/linux_ppc/vm/orderAccess_linux_ppc.inline.hpp

rev 13030 : [mq]: add_const
5 lines changed: 0 ins; 0 del; 5 mod; 91 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/linux_s390/vm/atomic_linux_s390.hpp

rev 13030 : [mq]: add_const
2 lines changed: 0 ins; 0 del; 2 mod; 525 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/linux_s390/vm/orderAccess_linux_s390.inline.hpp

rev 13030 : [mq]: add_const
5 lines changed: 0 ins; 0 del; 5 mod; 87 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/linux_sparc/vm/atomic_linux_sparc.inline.hpp

rev 13030 : [mq]: add_const
2 lines changed: 0 ins; 0 del; 2 mod; 157 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/linux_x86/vm/atomic_linux_x86.hpp

rev 13030 : [mq]: add_const
3 lines changed: 0 ins; 0 del; 3 mod; 212 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/linux_x86/vm/linux_x86_32.s

rev 13030 : [mq]: add_const
1 line changed: 0 ins; 0 del; 1 mod; 645 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/linux_zero/vm/atomic_linux_zero.hpp

rev 13030 : [mq]: add_const
2 lines changed: 0 ins; 0 del; 2 mod; 325 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/linux_zero/vm/os_linux_zero.hpp

rev 13032 : [mq]: atomic_copy64
3 lines changed: 0 ins; 0 del; 3 mod; 53 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/solaris_sparc/vm/atomic_solaris_sparc.hpp

rev 13030 : [mq]: add_const
1 line changed: 0 ins; 0 del; 1 mod; 227 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/solaris_x86/vm/atomic_solaris_x86.hpp

rev 13030 : [mq]: add_const
3 lines changed: 0 ins; 0 del; 3 mod; 257 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/solaris_x86/vm/solaris_x86_32.il

rev 13030 : [mq]: add_const
1 line changed: 0 ins; 0 del; 1 mod; 135 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/windows_x86/vm/atomic_windows_x86.hpp

rev 13030 : [mq]: add_const
2 lines changed: 0 ins; 0 del; 2 mod; 280 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/atomic.hpp

rev 13030 : [mq]: add_const
1 line changed: 0 ins; 0 del; 1 mod; 227 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/orderAccess.hpp

rev 13030 : [mq]: add_const
23 lines changed: 0 ins; 1 del; 22 mod; 335 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/orderAccess.inline.hpp

rev 13030 : [mq]: add_const
23 lines changed: 0 ins; 1 del; 22 mod; 100 unchg

This code review page was prepared using /home/kab/devtools/jdk/code-tools/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).