Code Review for hotspot

Prepared by:kbarrett on Sun Aug 13 21:55:30 EDT 2017
Workspace:/home/kab/sandboxes/atomic_templates/hs/hotspot
Compare against version:qparent
Summary of changes: 1306 lines changed: 784 ins; 318 del; 204 mod; 20311 unchg
Patch of changes: hotspot.patch
Bug id: JDK-8186166 : Generalize Atomic::cmpxchg with templates
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os/bsd/vm/os_bsd.cpp

rev 13441 : imported patch bsd_x86
1 line changed: 0 ins; 0 del; 1 mod; 4193 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os/solaris/vm/os_solaris.cpp

rev 13440 : imported patch solaris_fix
1 line changed: 0 ins; 0 del; 1 mod; 5613 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/aix_ppc/vm/atomic_aix_ppc.hpp

rev 13444 : imported patch aix_ppc
29 lines changed: 11 ins; 8 del; 10 mod; 461 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/bsd_x86/vm/atomic_bsd_x86.hpp

rev 13441 : imported patch bsd_x86
38 lines changed: 14 ins; 13 del; 11 mod; 191 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/bsd_zero/vm/atomic_bsd_zero.hpp

rev 13448 : imported patch bsd_zero
45 lines changed: 2 ins; 21 del; 22 mod; 290 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/linux_aarch64/vm/atomic_linux_aarch64.hpp

rev 13446 : imported patch linux_aarch64
35 lines changed: 3 ins; 29 del; 3 mod; 130 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/linux_arm/vm/atomic_linux_arm.hpp

rev 13443 : imported patch linux_arm
54 lines changed: 34 ins; 14 del; 6 mod; 245 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/linux_ppc/vm/atomic_linux_ppc.hpp

rev 13445 : imported patch linux_ppc
29 lines changed: 11 ins; 8 del; 10 mod; 461 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/linux_s390/vm/atomic_linux_s390.hpp

rev 13447 : imported patch linux_s390
25 lines changed: 13 ins; 8 del; 4 mod; 515 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/linux_sparc/vm/atomic_linux_sparc.hpp

rev 13450 : imported patch linux_sparc
31 lines changed: 13 ins; 14 del; 4 mod; 141 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/linux_x86/vm/atomic_linux_x86.hpp

rev 13429 : imported patch cmpxchg_template
rev 13436 : imported patch linux_x86
38 lines changed: 14 ins; 13 del; 11 mod; 191 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/linux_zero/vm/atomic_linux_zero.hpp

rev 13449 : imported patch linux_zero
45 lines changed: 2 ins; 21 del; 22 mod; 284 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/solaris_sparc/vm/atomic_solaris_sparc.hpp

rev 13437 : imported patch solaris_sparc
38 lines changed: 16 ins; 6 del; 16 mod; 96 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/solaris_sparc/vm/solaris_sparc.il

rev 13437 : imported patch solaris_sparc
68 lines changed: 0 ins; 68 del; 0 mod; 213 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/solaris_x86/vm/atomic_solaris_x86.hpp

rev 13438 : imported patch solaris_x86_remove_32bit
rev 13439 : imported patch solaris_x86
99 lines changed: 29 ins; 58 del; 12 mod; 95 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/windows_x86/vm/atomic_windows_x86.hpp

rev 13442 : imported patch windows_x86
52 lines changed: 23 ins; 19 del; 10 mod; 253 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/aot/aotCodeHeap.cpp

rev 13430 : imported patch fix_calls
3 lines changed: 0 ins; 0 del; 3 mod; 886 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/aot/aotCodeHeap.hpp

rev 13430 : imported patch fix_calls
4 lines changed: 4 ins; 0 del; 0 mod; 295 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc/parallel/psParallelCompact.hpp

rev 13430 : imported patch fix_calls
rev 13432 : imported patch fix_claim
4 lines changed: 0 ins; 1 del; 3 mod; 1329 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc/shared/workgroup.cpp

rev 13430 : imported patch fix_calls
rev 13451 : imported patch copyrights
7 lines changed: 0 ins; 0 del; 7 mod; 493 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/oops/oop.inline.hpp

rev 13431 : imported patch remove_cmpxchg_ptr_users
4 lines changed: 0 ins; 0 del; 4 mod; 760 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/oops/oopsHierarchy.hpp

rev 13429 : imported patch cmpxchg_template
rev 13451 : imported patch copyrights
12 lines changed: 11 ins; 0 del; 1 mod; 211 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/atomic.hpp

rev 13429 : imported patch cmpxchg_template
rev 13433 : imported patch comments
rev 13435 : imported patch better_cmpxchg_translate
252 lines changed: 210 ins; 10 del; 32 mod; 187 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/os.cpp

rev 13430 : imported patch fix_calls
2 lines changed: 0 ins; 0 del; 2 mod; 1749 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/utilities/bitMap.cpp

rev 13431 : imported patch remove_cmpxchg_ptr_users
10 lines changed: 0 ins; 3 del; 7 mod; 676 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/utilities/bitMap.inline.hpp

rev 13431 : imported patch remove_cmpxchg_ptr_users
6 lines changed: 0 ins; 4 del; 2 mod; 353 unchg

------ ------ ------ ------ --- New Patch Raw src/share/vm/metaprogramming/integerTypes.hpp

rev 13428 : imported patch integer_types
rev 13434 : imported patch categories
160 lines changed: 160 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/vm/metaprogramming/isRegisteredEnum.hpp

rev 13427 : imported patch registered_enum
42 lines changed: 42 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/native/metaprogramming/test_integerTypes.cpp

rev 13428 : imported patch integer_types
128 lines changed: 128 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/native/metaprogramming/test_isRegisteredEnum.cpp

rev 13427 : imported patch registered_enum
44 lines changed: 44 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/kab/devtools/jdk/code-tools/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).