Code Review for hotspot

Prepared by:kbarrett on Wed Aug 16 01:47:29 EDT 2017
Workspace:/home/kab/sandboxes/atomic_templates/hs/hotspot
Compare against version:copyrights
Summary of changes: 232 lines changed: 91 ins; 29 del; 112 mod; 5247 unchg
Patch of changes: hotspot.patch
Bug id: JDK-8186166 : Generalize Atomic::cmpxchg with templates
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/aix_ppc/vm/atomic_aix_ppc.hpp

rev 13452 : [mq]: coleen_review1
rev 13453 : [mq]: dholmes_review1
10 lines changed: 6 ins; 0 del; 4 mod; 478 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/bsd_x86/vm/atomic_bsd_x86.hpp

rev 13452 : [mq]: coleen_review1
rev 13458 : imported patch cmpxchg_using_helper
5 lines changed: 4 ins; 0 del; 1 mod; 215 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/bsd_zero/vm/atomic_bsd_zero.hpp

rev 13452 : [mq]: coleen_review1
rev 13458 : imported patch cmpxchg_using_helper
4 lines changed: 2 ins; 0 del; 2 mod; 312 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/linux_aarch64/vm/atomic_linux_aarch64.hpp

rev 13452 : [mq]: coleen_review1
1 line changed: 1 ins; 0 del; 0 mod; 136 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/linux_arm/vm/atomic_linux_arm.hpp

rev 13452 : [mq]: coleen_review1
rev 13458 : imported patch cmpxchg_using_helper
3 lines changed: 1 ins; 0 del; 2 mod; 283 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/linux_ppc/vm/atomic_linux_ppc.hpp

rev 13452 : [mq]: coleen_review1
rev 13453 : [mq]: dholmes_review1
10 lines changed: 6 ins; 0 del; 4 mod; 478 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/linux_s390/vm/atomic_linux_s390.hpp

rev 13452 : [mq]: coleen_review1
rev 13453 : [mq]: dholmes_review1
5 lines changed: 3 ins; 0 del; 2 mod; 530 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/linux_sparc/vm/atomic_linux_sparc.hpp

rev 13452 : [mq]: coleen_review1
2 lines changed: 2 ins; 0 del; 0 mod; 158 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/linux_x86/vm/atomic_linux_x86.hpp

rev 13452 : [mq]: coleen_review1
rev 13458 : imported patch cmpxchg_using_helper
5 lines changed: 4 ins; 0 del; 1 mod; 215 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/linux_zero/vm/atomic_linux_zero.hpp

rev 13452 : [mq]: coleen_review1
rev 13458 : imported patch cmpxchg_using_helper
4 lines changed: 2 ins; 0 del; 2 mod; 306 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/solaris_sparc/vm/atomic_solaris_sparc.hpp

rev 13452 : [mq]: coleen_review1
2 lines changed: 2 ins; 0 del; 0 mod; 128 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/solaris_x86/vm/atomic_solaris_x86.hpp

rev 13452 : [mq]: coleen_review1
rev 13458 : imported patch cmpxchg_using_helper
4 lines changed: 3 ins; 0 del; 1 mod; 135 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/windows_x86/vm/atomic_windows_x86.hpp

rev 13452 : [mq]: coleen_review1
rev 13458 : imported patch cmpxchg_using_helper
3 lines changed: 1 ins; 0 del; 2 mod; 284 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/metaprogramming/integerTypes.hpp

rev 13456 : [mq]: union_trick
114 lines changed: 38 ins; 28 del; 48 mod; 84 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/atomic.hpp

rev 13452 : [mq]: coleen_review1
rev 13454 : [mq]: roman_review1
rev 13455 : [mq]: replace_if_null
rev 13458 : imported patch cmpxchg_using_helper
57 lines changed: 16 ins; 1 del; 40 mod; 388 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/utilities/bitMap.cpp

rev 13455 : [mq]: replace_if_null
rev 13457 : [mq]: fix_popc_table
2 lines changed: 0 ins; 0 del; 2 mod; 681 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/utilities/bitMap.hpp

rev 13457 : [mq]: fix_popc_table
1 line changed: 0 ins; 0 del; 1 mod; 436 unchg

This code review page was prepared using /home/kab/devtools/jdk/code-tools/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).