Code Review for open

Prepared by:kbarrett on Tue Feb 20 19:06:28 EST 2018
Workspace:/home/kab/sandboxes/vsnprintf/hs/open
Compare against version:qparent
Summary of changes: 169 lines changed: 122 ins; 23 del; 24 mod; 18710 unchg
Patch of changes: open.patch
Bug id: JDK-8196882 : VS2017 Hotspot Defined vsnprintf Function Causes C2084 Already Defined Compilation Error
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/posix/os_posix.cpp

rev 48919 : [mq]: vsnprintf
11 lines changed: 10 ins; 0 del; 1 mod; 2053 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/windows/os_windows.cpp

rev 48919 : [mq]: vsnprintf
12 lines changed: 8 ins; 0 del; 4 mod; 5569 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/generateOopMap.cpp

rev 48919 : [mq]: vsnprintf
5 lines changed: 1 ins; 1 del; 3 mod; 2587 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvm.cpp

rev 48919 : [mq]: vsnprintf
16 lines changed: 0 ins; 7 del; 9 mod; 3649 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/os.cpp

rev 48919 : [mq]: vsnprintf
8 lines changed: 8 ins; 0 del; 0 mod; 1836 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/os.hpp

rev 48919 : [mq]: vsnprintf
15 lines changed: 14 ins; 0 del; 1 mod; 1021 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/exceptions.cpp

rev 48919 : [mq]: vsnprintf
4 lines changed: 1 ins; 1 del; 2 mod; 543 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/globalDefinitions_visCPP.hpp

rev 48919 : [mq]: vsnprintf
9 lines changed: 0 ins; 8 del; 1 mod; 214 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/ostream.cpp

rev 48919 : [mq]: vsnprintf
8 lines changed: 0 ins; 6 del; 2 mod; 1087 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/gtest/runtime/test_os.cpp

rev 48919 : [mq]: vsnprintf
81 lines changed: 80 ins; 0 del; 1 mod; 151 unchg

This code review page was prepared using /home/kab/devtools/jdk/code-tools/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).