Code Review for hotspot

Prepared by:Vinay K. Awasthi on Thu Jun 21 14:33:39 PDT 2018
Workspace:/home/vinay/OPENJDK-11/jdk-54fcaffa8fac/src/hotspot
Compare against version:0
Summary of changes: 365 lines changed: 332 ins; 2 del; 31 mod; 26129 unchg
Patch of changes: hotspot.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw os/posix/os_posix.cpp

rev 1 : G1GC+POGC+NVDIMM Patch with latest comments incorporated from all.
rev 2 : Removed fcntl and fixed hotspot else violation
rev 15 : Aded msync
28 lines changed: 20 ins; 1 del; 7 mod; 2083 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw os/windows/os_windows.cpp

rev 1 : G1GC+POGC+NVDIMM Patch with latest comments incorporated from all.
1 line changed: 0 ins; 0 del; 1 mod; 5665 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw share/gc/cms/cmsArguments.cpp

rev 1 : G1GC+POGC+NVDIMM Patch with latest comments incorporated from all.
4 lines changed: 4 ins; 0 del; 0 mod; 228 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw share/gc/g1/g1CollectedHeap.cpp

rev 1 : G1GC+POGC+NVDIMM Patch with latest comments incorporated from all.
rev 10 : Removed any AllocateOldGenAt handling in reservespace
37 lines changed: 34 ins; 1 del; 2 mod; 4968 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw share/gc/g1/g1CollectedHeap.hpp

rev 1 : G1GC+POGC+NVDIMM Patch with latest comments incorporated from all.
1 line changed: 1 ins; 0 del; 0 mod; 1448 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw share/gc/g1/g1PageBasedVirtualSpace.cpp

rev 1 : G1GC+POGC+NVDIMM Patch with latest comments incorporated from all.
rev 2 : Removed fcntl and fixed hotspot else violation
rev 8 : Final version addressing all Thomas S concerns
rev 9 : Cleaned up virtualspace.cpp
rev 10 : Removed any AllocateOldGenAt handling in reservespace
29 lines changed: 29 ins; 0 del; 0 mod; 295 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw share/gc/g1/g1PageBasedVirtualSpace.hpp

rev 8 : Final version addressing all Thomas S concerns
1 line changed: 1 ins; 0 del; 0 mod; 153 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw share/gc/g1/heapRegionManager.hpp

rev 1 : G1GC+POGC+NVDIMM Patch with latest comments incorporated from all.
rev 13 : Add null check for region
12 lines changed: 9 ins; 0 del; 3 mod; 283 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw share/gc/g1/heapRegionSet.hpp

rev 1 : G1GC+POGC+NVDIMM Patch with latest comments incorporated from all.
1 line changed: 0 ins; 0 del; 1 mod; 244 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw share/gc/parallel/adjoiningGenerations.cpp

rev 1 : G1GC+POGC+NVDIMM Patch with latest comments incorporated from all.
rev 10 : Removed any AllocateOldGenAt handling in reservespace
30 lines changed: 28 ins; 0 del; 2 mod; 279 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw share/gc/parallel/adjoiningVirtualSpaces.cpp

rev 1 : G1GC+POGC+NVDIMM Patch with latest comments incorporated from all.
17 lines changed: 12 ins; 0 del; 5 mod; 66 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw share/gc/parallel/adjoiningVirtualSpaces.hpp

rev 1 : G1GC+POGC+NVDIMM Patch with latest comments incorporated from all.
5 lines changed: 4 ins; 0 del; 1 mod; 114 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw share/gc/parallel/mutableSpace.cpp

rev 14 : Added pretouch at commit to see it fail..
1 line changed: 1 ins; 0 del; 0 mod; 257 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw share/gc/parallel/psMarkSweep.cpp

rev 1 : G1GC+POGC+NVDIMM Patch with latest comments incorporated from all.
0 lines changed: 0 ins; 0 del; 0 mod; 673 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw share/gc/parallel/psOldGen.cpp

rev 1 : G1GC+POGC+NVDIMM Patch with latest comments incorporated from all.
24 lines changed: 20 ins; 0 del; 4 mod; 493 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw share/gc/parallel/psOldGen.hpp

rev 1 : G1GC+POGC+NVDIMM Patch with latest comments incorporated from all.
7 lines changed: 5 ins; 0 del; 2 mod; 224 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw share/gc/parallel/psVirtualspace.cpp

rev 1 : G1GC+POGC+NVDIMM Patch with latest comments incorporated from all.
rev 14 : Added pretouch at commit to see it fail..
83 lines changed: 82 ins; 0 del; 1 mod; 337 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw share/gc/parallel/psVirtualspace.hpp

rev 1 : G1GC+POGC+NVDIMM Patch with latest comments incorporated from all.
4 lines changed: 4 ins; 0 del; 0 mod; 182 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw share/gc/serial/serialArguments.cpp

rev 1 : G1GC+POGC+NVDIMM Patch with latest comments incorporated from all.
3 lines changed: 3 ins; 0 del; 0 mod; 38 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw share/memory/virtualspace.cpp

rev 1 : G1GC+POGC+NVDIMM Patch with latest comments incorporated from all.
rev 3 : Removing _fd_for_nvdimm
rev 4 : Not working version of _fd_heap
rev 5 : Fixed closing _fd_for_heap
rev 6 : Allocate Whole Heap with G1GC fix
rev 7 : Prepare to do nothing in reservespace
rev 8 : Final version addressing all Thomas S concerns
rev 9 : Cleaned up virtualspace.cpp
rev 10 : Removed any AllocateOldGenAt handling in reservespace
rev 11 : Removed removal of a new line
rev 12 : Removed All virtualspace changes
0 lines changed: 0 ins; 0 del; 0 mod; 1421 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw share/memory/virtualspace.hpp

rev 1 : G1GC+POGC+NVDIMM Patch with latest comments incorporated from all.
rev 3 : Removing _fd_for_nvdimm
rev 4 : Not working version of _fd_heap
rev 7 : Prepare to do nothing in reservespace
rev 8 : Final version addressing all Thomas S concerns
2 lines changed: 2 ins; 0 del; 0 mod; 237 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw share/runtime/globals.hpp

rev 1 : G1GC+POGC+NVDIMM Patch with latest comments incorporated from all.
3 lines changed: 3 ins; 0 del; 0 mod; 2802 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw share/runtime/java.cpp

rev 1 : G1GC+POGC+NVDIMM Patch with latest comments incorporated from all.
10 lines changed: 10 ins; 0 del; 0 mod; 750 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw share/runtime/os.cpp

rev 1 : G1GC+POGC+NVDIMM Patch with latest comments incorporated from all.
28 lines changed: 28 ins; 0 del; 0 mod; 1857 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw share/runtime/os.hpp

rev 1 : G1GC+POGC+NVDIMM Patch with latest comments incorporated from all.
34 lines changed: 32 ins; 0 del; 2 mod; 1032 unchg

This code review page was prepared using ../../make/scripts/webrev.ksh (vers 25.17-hg+openjdk.java.net).