Code Review for jdk-OldOnAEP_G1GC

Prepared by:Kishor Kharbas on Thu Nov 29 10:15:14 PST 2018
Workspace:/cygdrive/c/Projects/3DXP_Old_Gen_on_3DXP/jdk-OldOnAEP_G1GC
Compare against: http://hg.openjdk.java.net/jdk/jdk/
Compare against version:52631
Summary of changes: 140 lines changed: 55 ins; 31 del; 54 mod; 18117 unchg
Patch of changes: jdk-OldOnAEP_G1GC.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CollectedHeap.cpp

rev 51649 : version 1
rev 51652 : Added support for eager mixed collection of evacuation failure regions
rev 51878 : Minor changes
rev 52017 : All changes for G1 GC moved from 'combined' repo folder
rev 52487 : Worked on comments from Sangheon, Stefan
rev 52488 : Merge
rev 52493 : Changing class name
rev 52494 : adding jtreg tests, whitebox api.
rev 52631 : Merge
rev 52632 : latest feedback
1 line changed: 0 ins; 0 del; 1 mod; 4719 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CollectedHeap.hpp

rev 51649 : version 1
rev 51652 : Added support for eager mixed collection of evacuation failure regions
rev 51878 : Minor changes
rev 52017 : All changes for G1 GC moved from 'combined' repo folder
rev 52487 : Worked on comments from Sangheon, Stefan
rev 52488 : Merge
rev 52493 : Changing class name
rev 52632 : latest feedback
2 lines changed: 1 ins; 1 del; 0 mod; 1446 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CollectorPolicy.cpp

rev 52487 : Worked on comments from Sangheon, Stefan
rev 52632 : latest feedback
12 lines changed: 0 ins; 8 del; 4 mod; 60 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CollectorPolicy.hpp

rev 52487 : Worked on comments from Sangheon, Stefan
rev 52632 : latest feedback
8 lines changed: 0 ins; 5 del; 3 mod; 46 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1RegionToSpaceMapper.cpp

rev 51649 : version 1
rev 51652 : Added support for eager mixed collection of evacuation failure regions
rev 51878 : Minor changes
rev 52017 : All changes for G1 GC moved from 'combined' repo folder
rev 52487 : Worked on comments from Sangheon, Stefan
rev 52492 : Reverting back this change which does not work
rev 52632 : latest feedback
32 lines changed: 9 ins; 3 del; 20 mod; 292 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1RegionToSpaceMapper.hpp

rev 51649 : version 1
rev 52017 : All changes for G1 GC moved from 'combined' repo folder
rev 52487 : Worked on comments from Sangheon, Stefan
rev 52632 : latest feedback
6 lines changed: 4 ins; 1 del; 1 mod; 118 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heapRegionManager.cpp

rev 51649 : version 1
rev 52017 : All changes for G1 GC moved from 'combined' repo folder
rev 52487 : Worked on comments from Sangheon, Stefan
rev 52489 : minor changes
rev 52493 : Changing class name
rev 52631 : Merge
rev 52632 : latest feedback
2 lines changed: 1 ins; 1 del; 0 mod; 552 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heapRegionManager.hpp

rev 51649 : version 1
rev 51650 : added comments
rev 52017 : All changes for G1 GC moved from 'combined' repo folder
rev 52487 : Worked on comments from Sangheon, Stefan
rev 52488 : Merge
rev 52489 : minor changes
rev 52497 : To compile without precompiled headers
rev 52632 : latest feedback
2 lines changed: 2 ins; 0 del; 0 mod; 296 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heapRegionType.cpp

rev 51653 : 1. Fix for expand_by() committing more than Xmx. 2. Some additions for PreMatureOld tag
rev 52017 : All changes for G1 GC moved from 'combined' repo folder
rev 52632 : latest feedback
1 line changed: 0 ins; 0 del; 1 mod; 97 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heterogeneousHeapRegionManager.cpp

rev 52493 : Changing class name
rev 52494 : adding jtreg tests, whitebox api.
rev 52632 : latest feedback
4 lines changed: 1 ins; 1 del; 2 mod; 443 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heterogeneousHeapRegionManager.hpp

rev 52493 : Changing class name
rev 52494 : adding jtreg tests, whitebox api.
rev 52632 : latest feedback
3 lines changed: 0 ins; 0 del; 3 mod; 128 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/gcArguments.cpp

rev 52487 : Worked on comments from Sangheon, Stefan
rev 52632 : latest feedback
1 line changed: 0 ins; 0 del; 1 mod; 71 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/whitebox.cpp

rev 52494 : adding jtreg tests, whitebox api.
rev 52631 : Merge
rev 52632 : latest feedback
rev 52633 : adding whitebox support for Parallel GC
8 lines changed: 0 ins; 1 del; 7 mod; 2312 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/arguments.cpp

rev 52017 : All changes for G1 GC moved from 'combined' repo folder
rev 52487 : Worked on comments from Sangheon, Stefan
rev 52488 : Merge
rev 52490 : Disabling compressedOops
rev 52494 : adding jtreg tests, whitebox api.
rev 52631 : Merge
rev 52632 : latest feedback
4 lines changed: 0 ins; 0 del; 4 mod; 4179 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/globals.hpp

rev 51649 : version 1
rev 51878 : Minor changes
rev 52017 : All changes for G1 GC moved from 'combined' repo folder
rev 52487 : Worked on comments from Sangheon, Stefan
rev 52488 : Merge
rev 52631 : Merge
rev 52632 : latest feedback
8 lines changed: 4 ins; 3 del; 1 mod; 2749 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/8202286/TestAllocateOldGenAt.java

rev 52494 : adding jtreg tests, whitebox api.
rev 52632 : latest feedback
rev 52633 : adding whitebox support for Parallel GC
rev 52634 : Adding ParallelGC patch
3 lines changed: 2 ins; 0 del; 1 mod; 78 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/8202286/TestAllocateOldGenAtError.java

rev 52494 : adding jtreg tests, whitebox api.
rev 52632 : latest feedback
rev 52633 : adding whitebox support for Parallel GC
rev 52634 : Adding ParallelGC patch
38 lines changed: 27 ins; 7 del; 4 mod; 82 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/8202286/TestAllocateOldGenAtMultiple.java

rev 52494 : adding jtreg tests, whitebox api.
rev 52632 : latest feedback
1 line changed: 1 ins; 0 del; 0 mod; 91 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/8202286/TestHumongousObjectsOnNvdimm.java

rev 52494 : adding jtreg tests, whitebox api.
rev 52632 : latest feedback
rev 52633 : adding whitebox support for Parallel GC
rev 52634 : Adding ParallelGC patch
2 lines changed: 1 ins; 0 del; 1 mod; 116 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/8202286/TestOldObjectsOnNvdimm.java

rev 52494 : adding jtreg tests, whitebox api.
rev 52632 : latest feedback
rev 52634 : Adding ParallelGC patch
1 line changed: 1 ins; 0 del; 0 mod; 119 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/8202286/TestYoungObjectsOnDram.java

rev 52494 : adding jtreg tests, whitebox api.
rev 52632 : latest feedback
rev 52634 : Adding ParallelGC patch
1 line changed: 1 ins; 0 del; 0 mod; 123 unchg

This code review page was prepared using ./webrev.ksh (vers 25.17-hg+openjdk.java.net).