Code Review for jdk-OldOnAEP_G1GC

Prepared by:Kishor Kharbas on Thu Nov 29 10:04:52 PST 2018
Workspace:/cygdrive/c/Projects/3DXP_Old_Gen_on_3DXP/jdk-OldOnAEP_G1GC
Compare against: http://hg.openjdk.java.net/jdk/jdk/
Compare against version:52630
Summary of changes: 1771 lines changed: 1658 ins; 11 del; 102 mod; 23718 unchg
Patch of changes: jdk-OldOnAEP_G1GC.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/collectionSetChooser.cpp

rev 51652 : Added support for eager mixed collection of evacuation failure regions
rev 52017 : All changes for G1 GC moved from 'combined' repo folder
9 lines changed: 8 ins; 0 del; 1 mod; 301 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1Allocator.inline.hpp

rev 51649 : version 1
rev 52017 : All changes for G1 GC moved from 'combined' repo folder
rev 52487 : Worked on comments from Sangheon, Stefan
rev 52488 : Merge
1 line changed: 0 ins; 0 del; 1 mod; 148 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1Arguments.cpp

rev 52487 : Worked on comments from Sangheon, Stefan
rev 52488 : Merge
4 lines changed: 4 ins; 0 del; 0 mod; 151 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CardCounts.cpp

rev 51649 : version 1
rev 52017 : All changes for G1 GC moved from 'combined' repo folder
1 line changed: 0 ins; 0 del; 1 mod; 156 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CollectedHeap.cpp

rev 51649 : version 1
rev 51652 : Added support for eager mixed collection of evacuation failure regions
rev 51878 : Minor changes
rev 52017 : All changes for G1 GC moved from 'combined' repo folder
rev 52487 : Worked on comments from Sangheon, Stefan
rev 52488 : Merge
rev 52493 : Changing class name
rev 52494 : adding jtreg tests, whitebox api.
rev 52631 : Merge
rev 52632 : latest feedback
94 lines changed: 36 ins; 0 del; 58 mod; 4626 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CollectedHeap.hpp

rev 51649 : version 1
rev 51652 : Added support for eager mixed collection of evacuation failure regions
rev 51878 : Minor changes
rev 52017 : All changes for G1 GC moved from 'combined' repo folder
rev 52487 : Worked on comments from Sangheon, Stefan
rev 52488 : Merge
rev 52493 : Changing class name
rev 52632 : latest feedback
24 lines changed: 15 ins; 0 del; 9 mod; 1423 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CollectedHeap.inline.hpp

rev 51649 : version 1
rev 52017 : All changes for G1 GC moved from 'combined' repo folder
rev 52488 : Merge
rev 52489 : minor changes
rev 52631 : Merge
7 lines changed: 0 ins; 0 del; 7 mod; 289 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CollectorPolicy.cpp

rev 52487 : Worked on comments from Sangheon, Stefan
rev 52632 : latest feedback
9 lines changed: 8 ins; 0 del; 1 mod; 56 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CollectorPolicy.hpp

rev 52487 : Worked on comments from Sangheon, Stefan
rev 52632 : latest feedback
7 lines changed: 6 ins; 0 del; 1 mod; 42 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1FullCollector.cpp

rev 51649 : version 1
rev 51878 : Minor changes
rev 52017 : All changes for G1 GC moved from 'combined' repo folder
rev 52487 : Worked on comments from Sangheon, Stefan
1 line changed: 1 ins; 0 del; 0 mod; 300 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1HeapRegionTraceType.hpp

rev 51653 : 1. Fix for expand_by() committing more than Xmx. 2. Some additions for PreMatureOld tag
rev 52017 : All changes for G1 GC moved from 'combined' repo folder
2 lines changed: 2 ins; 0 del; 0 mod; 60 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1HeapVerifier.cpp

rev 51649 : version 1
rev 52017 : All changes for G1 GC moved from 'combined' repo folder
rev 52488 : Merge
4 lines changed: 0 ins; 0 del; 4 mod; 789 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1Policy.cpp

rev 51649 : version 1
rev 51650 : added comments
rev 51878 : Minor changes
rev 52017 : All changes for G1 GC moved from 'combined' repo folder
rev 52487 : Worked on comments from Sangheon, Stefan
2 lines changed: 1 ins; 0 del; 1 mod; 1186 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1RegionToSpaceMapper.cpp

rev 51649 : version 1
rev 51652 : Added support for eager mixed collection of evacuation failure regions
rev 51878 : Minor changes
rev 52017 : All changes for G1 GC moved from 'combined' repo folder
rev 52487 : Worked on comments from Sangheon, Stefan
rev 52492 : Reverting back this change which does not work
rev 52632 : latest feedback
139 lines changed: 137 ins; 1 del; 1 mod; 183 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1RegionToSpaceMapper.hpp

rev 51649 : version 1
rev 52017 : All changes for G1 GC moved from 'combined' repo folder
rev 52487 : Worked on comments from Sangheon, Stefan
rev 52632 : latest feedback
31 lines changed: 31 ins; 0 del; 0 mod; 92 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1_globals.hpp

rev 52487 : Worked on comments from Sangheon, Stefan
rev 52494 : adding jtreg tests, whitebox api.
10 lines changed: 9 ins; 0 del; 1 mod; 306 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heapRegion.cpp

rev 51652 : Added support for eager mixed collection of evacuation failure regions
rev 52017 : All changes for G1 GC moved from 'combined' repo folder
5 lines changed: 5 ins; 0 del; 0 mod; 888 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heapRegion.hpp

rev 51652 : Added support for eager mixed collection of evacuation failure regions
rev 52017 : All changes for G1 GC moved from 'combined' repo folder
3 lines changed: 3 ins; 0 del; 0 mod; 726 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heapRegionManager.cpp

rev 51649 : version 1
rev 52017 : All changes for G1 GC moved from 'combined' repo folder
rev 52487 : Worked on comments from Sangheon, Stefan
rev 52489 : minor changes
rev 52493 : Changing class name
rev 52631 : Merge
rev 52632 : latest feedback
15 lines changed: 11 ins; 2 del; 2 mod; 540 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heapRegionManager.hpp

rev 51649 : version 1
rev 51650 : added comments
rev 52017 : All changes for G1 GC moved from 'combined' repo folder
rev 52487 : Worked on comments from Sangheon, Stefan
rev 52488 : Merge
rev 52489 : minor changes
rev 52497 : To compile without precompiled headers
rev 52632 : latest feedback
37 lines changed: 20 ins; 8 del; 9 mod; 269 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heapRegionSet.cpp

rev 51649 : version 1
rev 51878 : Minor changes
rev 52017 : All changes for G1 GC moved from 'combined' repo folder
rev 52487 : Worked on comments from Sangheon, Stefan
15 lines changed: 15 ins; 0 del; 0 mod; 290 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heapRegionSet.hpp

rev 51649 : version 1
rev 51878 : Minor changes
rev 52017 : All changes for G1 GC moved from 'combined' repo folder
2 lines changed: 2 ins; 0 del; 0 mod; 231 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heapRegionType.cpp

rev 51653 : 1. Fix for expand_by() committing more than Xmx. 2. Some additions for PreMatureOld tag
rev 52017 : All changes for G1 GC moved from 'combined' repo folder
rev 52632 : latest feedback
5 lines changed: 4 ins; 0 del; 1 mod; 93 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heapRegionType.hpp

rev 51652 : Added support for eager mixed collection of evacuation failure regions
rev 52017 : All changes for G1 GC moved from 'combined' repo folder
rev 52487 : Worked on comments from Sangheon, Stefan
6 lines changed: 6 ins; 0 del; 0 mod; 191 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/vmStructs_g1.hpp

rev 51649 : version 1
rev 52017 : All changes for G1 GC moved from 'combined' repo folder
rev 52491 : Changes in jdk.hotspot.agent
2 lines changed: 1 ins; 0 del; 1 mod; 112 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/gcArguments.cpp

rev 52487 : Worked on comments from Sangheon, Stefan
rev 52632 : latest feedback
16 lines changed: 16 ins; 0 del; 0 mod; 56 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/gcArguments.hpp

rev 52487 : Worked on comments from Sangheon, Stefan
1 line changed: 1 ins; 0 del; 0 mod; 44 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/whitebox.cpp

rev 52494 : adding jtreg tests, whitebox api.
rev 52631 : Merge
rev 52632 : latest feedback
rev 52633 : adding whitebox support for Parallel GC
63 lines changed: 63 ins; 0 del; 0 mod; 2256 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/arguments.cpp

rev 52017 : All changes for G1 GC moved from 'combined' repo folder
rev 52487 : Worked on comments from Sangheon, Stefan
rev 52488 : Merge
rev 52490 : Disabling compressedOops
rev 52494 : adding jtreg tests, whitebox api.
rev 52631 : Merge
rev 52632 : latest feedback
7 lines changed: 7 ins; 0 del; 0 mod; 4176 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/globals.hpp

rev 51649 : version 1
rev 51878 : Minor changes
rev 52017 : All changes for G1 GC moved from 'combined' repo folder
rev 52487 : Worked on comments from Sangheon, Stefan
rev 52488 : Merge
rev 52631 : Merge
rev 52632 : latest feedback
4 lines changed: 4 ins; 0 del; 0 mod; 2750 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/g1/G1CollectedHeap.java

rev 52491 : Changes in jdk.hotspot.agent
3 lines changed: 0 ins; 0 del; 3 mod; 157 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/g1/HeapRegion.java

rev 52491 : Changes in jdk.hotspot.agent
4 lines changed: 4 ins; 0 del; 0 mod; 133 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/g1/HeapRegionType.java

rev 52491 : Changes in jdk.hotspot.agent
9 lines changed: 9 ins; 0 del; 0 mod; 150 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/lib/sun/hotspot/WhiteBox.java

rev 52494 : adding jtreg tests, whitebox api.
4 lines changed: 4 ins; 0 del; 0 mod; 548 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/g1/heterogeneousHeapRegionManager.cpp

rev 52493 : Changing class name
rev 52494 : adding jtreg tests, whitebox api.
rev 52632 : latest feedback
446 lines changed: 446 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/g1/heterogeneousHeapRegionManager.hpp

rev 52493 : Changing class name
rev 52494 : adding jtreg tests, whitebox api.
rev 52632 : latest feedback
131 lines changed: 131 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/gc/8202286/TestAllocateOldGenAt.java

rev 52494 : adding jtreg tests, whitebox api.
rev 52632 : latest feedback
rev 52633 : adding whitebox support for Parallel GC
rev 52634 : Adding ParallelGC patch
81 lines changed: 81 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/gc/8202286/TestAllocateOldGenAtError.java

rev 52494 : adding jtreg tests, whitebox api.
rev 52632 : latest feedback
rev 52633 : adding whitebox support for Parallel GC
rev 52634 : Adding ParallelGC patch
113 lines changed: 113 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/gc/8202286/TestAllocateOldGenAtMultiple.java

rev 52494 : adding jtreg tests, whitebox api.
rev 52632 : latest feedback
92 lines changed: 92 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/gc/8202286/TestHumongousObjectsOnNvdimm.java

rev 52494 : adding jtreg tests, whitebox api.
rev 52632 : latest feedback
rev 52633 : adding whitebox support for Parallel GC
rev 52634 : Adding ParallelGC patch
118 lines changed: 118 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/gc/8202286/TestOldObjectsOnNvdimm.java

rev 52494 : adding jtreg tests, whitebox api.
rev 52632 : latest feedback
rev 52634 : Adding ParallelGC patch
120 lines changed: 120 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/gc/8202286/TestYoungObjectsOnDram.java

rev 52494 : adding jtreg tests, whitebox api.
rev 52632 : latest feedback
rev 52634 : Adding ParallelGC patch
124 lines changed: 124 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using ./webrev.ksh (vers 25.17-hg+openjdk.java.net).