Code Review for jdk

Prepared by:ksrini on Thu Apr 25 10:12:01 PDT 2013
Workspace:/w/ksrini/JDK/hg-tl8/jdk8/jdk
Compare against: ssh://hg.openjdk.java.net/jdk8/tl-gate/jdk
Compare against version:6970
Summary of changes: 16340 lines changed: 6584 ins; 3444 del; 6312 mod; 28045 unchg
Patch of changes: jdk.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/AnnotationVisitor.java

40 lines changed: 12 ins; 0 del; 28 mod; 158 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/AnnotationWriter.java

94 lines changed: 62 ins; 13 del; 19 mod; 319 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/Attribute.java

118 lines changed: 22 ins; 21 del; 75 mod; 187 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/ByteVector.java

32 lines changed: 14 ins; 1 del; 17 mod; 304 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/ClassReader.java

2369 lines changed: 879 ins; 600 del; 890 mod; 755 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/ClassVisitor.java

176 lines changed: 63 ins; 20 del; 93 mod; 193 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/ClassWriter.java

375 lines changed: 135 ins; 63 del; 177 mod; 1461 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/FieldVisitor.java

50 lines changed: 35 ins; 0 del; 15 mod; 129 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/FieldWriter.java

102 lines changed: 66 ins; 8 del; 28 mod; 264 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/Frame.java

816 lines changed: 313 ins; 295 del; 208 mod; 961 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/Handle.java

30 lines changed: 10 ins; 2 del; 18 mod; 168 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/Handler.java

6 lines changed: 3 ins; 0 del; 3 mod; 144 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/Item.java

107 lines changed: 33 ins; 19 del; 55 mod; 252 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/Label.java

79 lines changed: 18 ins; 13 del; 48 mod; 523 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/MethodVisitor.java

494 lines changed: 269 ins; 18 del; 207 mod; 392 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/MethodWriter.java

1001 lines changed: 443 ins; 257 del; 301 mod; 2137 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/Opcodes.java

5 lines changed: 3 ins; 0 del; 2 mod; 385 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/Type.java

155 lines changed: 41 ins; 10 del; 104 mod; 780 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/commons/AdviceAdapter.java

343 lines changed: 12 ins; 52 del; 279 mod; 363 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/commons/AnalyzerAdapter.java

747 lines changed: 254 ins; 280 del; 213 mod; 482 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/commons/CodeSizeEvaluator.java

30 lines changed: 0 ins; 19 del; 11 mod; 235 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/commons/GeneratorAdapter.java

539 lines changed: 157 ins; 83 del; 299 mod; 1196 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/commons/InstructionAdapter.java

618 lines changed: 30 ins; 81 del; 507 mod; 582 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/commons/JSRInlinerAdapter.java

160 lines changed: 27 ins; 32 del; 101 mod; 637 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/commons/LocalVariablesSorter.java

133 lines changed: 46 ins; 13 del; 74 mod; 284 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/commons/Method.java

49 lines changed: 10 ins; 6 del; 33 mod; 268 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/commons/Remapper.java

58 lines changed: 9 ins; 7 del; 42 mod; 201 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/commons/RemappingAnnotationAdapter.java

14 lines changed: 0 ins; 7 del; 7 mod; 101 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/commons/RemappingClassAdapter.java

70 lines changed: 5 ins; 30 del; 35 mod; 124 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/commons/RemappingFieldAdapter.java

19 lines changed: 10 ins; 4 del; 5 mod; 85 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/commons/RemappingMethodAdapter.java

115 lines changed: 33 ins; 45 del; 37 mod; 154 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/commons/RemappingSignatureAdapter.java

13 lines changed: 1 ins; 6 del; 6 mod; 175 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/commons/SerialVersionUIDAdder.java

86 lines changed: 28 ins; 25 del; 33 mod; 501 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/commons/StaticInitMerger.java

21 lines changed: 0 ins; 13 del; 8 mod; 117 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/commons/TableSwitchGenerator.java

4 lines changed: 2 ins; 0 del; 2 mod; 82 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/commons/TryCatchBlockSorter.java

23 lines changed: 5 ins; 11 del; 7 mod; 114 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/signature/SignatureReader.java

120 lines changed: 29 ins; 30 del; 61 mod; 167 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/signature/SignatureVisitor.java

34 lines changed: 11 ins; 1 del; 22 mod; 234 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/signature/SignatureWriter.java

1 line changed: 0 ins; 0 del; 1 mod; 255 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/tree/AbstractInsnNode.java

98 lines changed: 88 ins; 0 del; 10 mod; 257 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/tree/AnnotationNode.java

38 lines changed: 10 ins; 8 del; 20 mod; 225 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/tree/ClassNode.java

125 lines changed: 69 ins; 29 del; 27 mod; 344 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/tree/FieldInsnNode.java

25 lines changed: 8 ins; 4 del; 13 mod; 118 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/tree/FieldNode.java

122 lines changed: 73 ins; 13 del; 36 mod; 223 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/tree/FrameNode.java

68 lines changed: 7 ins; 8 del; 53 mod; 179 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/tree/IincInsnNode.java

6 lines changed: 3 ins; 0 del; 3 mod; 106 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/tree/InnerClassNode.java

24 lines changed: 4 ins; 4 del; 16 mod; 110 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/tree/InsnList.java

73 lines changed: 24 ins; 2 del; 47 mod; 558 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/tree/InsnNode.java

20 lines changed: 4 ins; 0 del; 16 mod; 97 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/tree/IntInsnNode.java

10 lines changed: 4 ins; 0 del; 6 mod; 107 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/tree/InvokeDynamicInsnNode.java

17 lines changed: 6 ins; 4 del; 7 mod; 118 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/tree/JumpInsnNode.java

17 lines changed: 5 ins; 0 del; 12 mod; 109 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/tree/LdcInsnNode.java

6 lines changed: 2 ins; 0 del; 4 mod; 102 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/tree/LineNumberNode.java

5 lines changed: 2 ins; 0 del; 3 mod; 108 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/tree/LocalVariableNode.java

30 lines changed: 6 ins; 9 del; 15 mod; 120 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/tree/LookupSwitchInsnNode.java

16 lines changed: 5 ins; 3 del; 8 mod; 134 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/tree/MethodInsnNode.java

21 lines changed: 6 ins; 4 del; 11 mod; 121 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/tree/MethodNode.java

350 lines changed: 212 ins; 50 del; 88 mod; 537 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/tree/MultiANewArrayInsnNode.java

6 lines changed: 3 ins; 0 del; 3 mod; 107 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/tree/TableSwitchInsnNode.java

20 lines changed: 5 ins; 6 del; 9 mod; 129 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/tree/TryCatchBlockNode.java

79 lines changed: 63 ins; 4 del; 12 mod; 107 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/tree/TypeInsnNode.java

11 lines changed: 4 ins; 0 del; 7 mod; 109 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/tree/VarInsnNode.java

13 lines changed: 4 ins; 0 del; 9 mod; 110 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/Analyzer.java

101 lines changed: 20 ins; 21 del; 60 mod; 498 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/AnalyzerException.java

8 lines changed: 1 ins; 4 del; 3 mod; 86 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/BasicInterpreter.java

293 lines changed: 47 ins; 54 del; 192 mod; 148 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/BasicValue.java

6 lines changed: 3 ins; 0 del; 3 mod; 134 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/BasicVerifier.java

317 lines changed: 4 ins; 30 del; 283 mod; 175 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/Frame.java

682 lines changed: 264 ins; 244 del; 174 mod; 320 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/Interpreter.java

72 lines changed: 28 ins; 6 del; 38 mod; 189 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/SimpleVerifier.java

73 lines changed: 9 ins; 18 del; 46 mod; 294 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/SourceInterpreter.java

82 lines changed: 3 ins; 11 del; 68 mod; 156 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/SourceValue.java

3 lines changed: 0 ins; 0 del; 3 mod; 123 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/Subroutine.java

5 lines changed: 0 ins; 3 del; 2 mod; 117 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/util/ASMifiable.java

8 lines changed: 3 ins; 0 del; 5 mod; 77 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/util/ASMifier.java

391 lines changed: 104 ins; 95 del; 192 mod; 981 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/util/CheckAnnotationAdapter.java

20 lines changed: 2 ins; 8 del; 10 mod; 153 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/util/CheckClassAdapter.java

583 lines changed: 442 ins; 49 del; 92 mod; 491 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/util/CheckFieldAdapter.java

33 lines changed: 22 ins; 2 del; 9 mod; 115 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/util/CheckMethodAdapter.java

856 lines changed: 251 ins; 416 del; 189 mod; 1092 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/util/CheckSignatureAdapter.java

37 lines changed: 8 ins; 7 del; 22 mod; 329 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/util/Printer.java

252 lines changed: 66 ins; 60 del; 126 mod; 401 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/util/Textifiable.java

5 lines changed: 2 ins; 0 del; 3 mod; 80 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/util/Textifier.java

484 lines changed: 217 ins; 100 del; 167 mod; 1048 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/util/TraceAnnotationVisitor.java

16 lines changed: 0 ins; 7 del; 9 mod; 109 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/util/TraceClassVisitor.java

109 lines changed: 28 ins; 41 del; 40 mod; 181 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/util/TraceFieldVisitor.java

17 lines changed: 11 ins; 3 del; 3 mod; 102 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/util/TraceMethodVisitor.java

105 lines changed: 38 ins; 31 del; 36 mod; 227 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/util/TraceSignatureVisitor.java

32 lines changed: 0 ins; 1 del; 31 mod; 315 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/Context.java

174 lines changed: 174 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/TypePath.java

222 lines changed: 222 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/TypeReference.java

481 lines changed: 481 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/tree/LocalVariableAnnotationNode.java

186 lines changed: 186 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/tree/ParameterNode.java

105 lines changed: 105 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/tree/TypeAnnotationNode.java

124 lines changed: 124 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/jdk/internal/org/objectweb/asm/version.txt

12 lines changed: 12 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /java/devtools/share/bin/webrev (vers 23.18-hg+jbs).