1 /*
   2  * Copyright (c) 1997, 2009, Oracle and/or its affiliates. All rights reserved.
   3  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
   4  *
   5  * This code is free software; you can redistribute it and/or modify it
   6  * under the terms of the GNU General Public License version 2 only, as
   7  * published by the Free Software Foundation.
   8  *
   9  * This code is distributed in the hope that it will be useful, but WITHOUT
  10  * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
  11  * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
  12  * version 2 for more details (a copy is included in the LICENSE file that
  13  * accompanied this code).
  14  *
  15  * You should have received a copy of the GNU General Public License version
  16  * 2 along with this work; if not, write to the Free Software Foundation,
  17  * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
  18  *
  19  * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
  20  * or visit www.oracle.com if you need additional information or have any
  21  * questions.
  22  *
  23  */
  24 
  25 #include "incls/_precompiled.incl"
  26 #include "incls/_classFileParser.cpp.incl"
  27 
  28 // We generally try to create the oops directly when parsing, rather than
  29 // allocating temporary data structures and copying the bytes twice. A
  30 // temporary area is only needed when parsing utf8 entries in the constant
  31 // pool and when parsing line number tables.
  32 
  33 // We add assert in debug mode when class format is not checked.
  34 
  35 #define JAVA_CLASSFILE_MAGIC              0xCAFEBABE
  36 #define JAVA_MIN_SUPPORTED_VERSION        45
  37 #define JAVA_MAX_SUPPORTED_VERSION        51
  38 #define JAVA_MAX_SUPPORTED_MINOR_VERSION  0
  39 
  40 // Used for two backward compatibility reasons:
  41 // - to check for new additions to the class file format in JDK1.5
  42 // - to check for bug fixes in the format checker in JDK1.5
  43 #define JAVA_1_5_VERSION                  49
  44 
  45 // Used for backward compatibility reasons:
  46 // - to check for javac bug fixes that happened after 1.5
  47 // - also used as the max version when running in jdk6
  48 #define JAVA_6_VERSION                    50
  49 
  50 // Used for backward compatibility reasons:
  51 // - to check NameAndType_info signatures more aggressively
  52 #define JAVA_7_VERSION                    51
  53 
  54 
  55 void ClassFileParser::parse_constant_pool_entries(constantPoolHandle cp, int length, TRAPS) {
  56   // Use a local copy of ClassFileStream. It helps the C++ compiler to optimize
  57   // this function (_current can be allocated in a register, with scalar
  58   // replacement of aggregates). The _current pointer is copied back to
  59   // stream() when this function returns. DON'T call another method within
  60   // this method that uses stream().
  61   ClassFileStream* cfs0 = stream();
  62   ClassFileStream cfs1 = *cfs0;
  63   ClassFileStream* cfs = &cfs1;
  64 #ifdef ASSERT
  65   u1* old_current = cfs0->current();
  66 #endif
  67 
  68   // Used for batching symbol allocations.
  69   const char* names[SymbolTable::symbol_alloc_batch_size];
  70   int lengths[SymbolTable::symbol_alloc_batch_size];
  71   int indices[SymbolTable::symbol_alloc_batch_size];
  72   unsigned int hashValues[SymbolTable::symbol_alloc_batch_size];
  73   int names_count = 0;
  74 
  75   // parsing  Index 0 is unused
  76   for (int index = 1; index < length; index++) {
  77     // Each of the following case guarantees one more byte in the stream
  78     // for the following tag or the access_flags following constant pool,
  79     // so we don't need bounds-check for reading tag.
  80     u1 tag = cfs->get_u1_fast();
  81     switch (tag) {
  82       case JVM_CONSTANT_Class :
  83         {
  84           cfs->guarantee_more(3, CHECK);  // name_index, tag/access_flags
  85           u2 name_index = cfs->get_u2_fast();
  86           cp->klass_index_at_put(index, name_index);
  87         }
  88         break;
  89       case JVM_CONSTANT_Fieldref :
  90         {
  91           cfs->guarantee_more(5, CHECK);  // class_index, name_and_type_index, tag/access_flags
  92           u2 class_index = cfs->get_u2_fast();
  93           u2 name_and_type_index = cfs->get_u2_fast();
  94           cp->field_at_put(index, class_index, name_and_type_index);
  95         }
  96         break;
  97       case JVM_CONSTANT_Methodref :
  98         {
  99           cfs->guarantee_more(5, CHECK);  // class_index, name_and_type_index, tag/access_flags
 100           u2 class_index = cfs->get_u2_fast();
 101           u2 name_and_type_index = cfs->get_u2_fast();
 102           cp->method_at_put(index, class_index, name_and_type_index);
 103         }
 104         break;
 105       case JVM_CONSTANT_InterfaceMethodref :
 106         {
 107           cfs->guarantee_more(5, CHECK);  // class_index, name_and_type_index, tag/access_flags
 108           u2 class_index = cfs->get_u2_fast();
 109           u2 name_and_type_index = cfs->get_u2_fast();
 110           cp->interface_method_at_put(index, class_index, name_and_type_index);
 111         }
 112         break;
 113       case JVM_CONSTANT_String :
 114         {
 115           cfs->guarantee_more(3, CHECK);  // string_index, tag/access_flags
 116           u2 string_index = cfs->get_u2_fast();
 117           cp->string_index_at_put(index, string_index);
 118         }
 119         break;
 120       case JVM_CONSTANT_MethodHandle :
 121       case JVM_CONSTANT_MethodType :
 122         if (!EnableMethodHandles ||
 123             _major_version < Verifier::INVOKEDYNAMIC_MAJOR_VERSION) {
 124           classfile_parse_error(
 125             (!EnableMethodHandles ?
 126              "This JVM does not support constant tag %u in class file %s" :
 127              "Class file version does not support constant tag %u in class file %s"),
 128             tag, CHECK);
 129         }
 130         if (tag == JVM_CONSTANT_MethodHandle) {
 131           cfs->guarantee_more(4, CHECK);  // ref_kind, method_index, tag/access_flags
 132           u1 ref_kind = cfs->get_u1_fast();
 133           u2 method_index = cfs->get_u2_fast();
 134           cp->method_handle_index_at_put(index, ref_kind, method_index);
 135         } else if (tag == JVM_CONSTANT_MethodType) {
 136           cfs->guarantee_more(3, CHECK);  // signature_index, tag/access_flags
 137           u2 signature_index = cfs->get_u2_fast();
 138           cp->method_type_index_at_put(index, signature_index);
 139         } else {
 140           ShouldNotReachHere();
 141         }
 142         break;
 143       case JVM_CONSTANT_InvokeDynamic :
 144         {
 145           if (!EnableInvokeDynamic ||
 146               _major_version < Verifier::INVOKEDYNAMIC_MAJOR_VERSION) {
 147             classfile_parse_error(
 148               (!EnableInvokeDynamic ?
 149                "This JVM does not support constant tag %u in class file %s" :
 150                "Class file version does not support constant tag %u in class file %s"),
 151               tag, CHECK);
 152           }
 153           cfs->guarantee_more(5, CHECK);  // bsm_index, name_and_type_index, tag/access_flags
 154           u2 bootstrap_method_index = cfs->get_u2_fast();
 155           u2 name_and_type_index = cfs->get_u2_fast();
 156           cp->invoke_dynamic_at_put(index, bootstrap_method_index, name_and_type_index);
 157         }
 158         break;
 159       case JVM_CONSTANT_Integer :
 160         {
 161           cfs->guarantee_more(5, CHECK);  // bytes, tag/access_flags
 162           u4 bytes = cfs->get_u4_fast();
 163           cp->int_at_put(index, (jint) bytes);
 164         }
 165         break;
 166       case JVM_CONSTANT_Float :
 167         {
 168           cfs->guarantee_more(5, CHECK);  // bytes, tag/access_flags
 169           u4 bytes = cfs->get_u4_fast();
 170           cp->float_at_put(index, *(jfloat*)&bytes);
 171         }
 172         break;
 173       case JVM_CONSTANT_Long :
 174         // A mangled type might cause you to overrun allocated memory
 175         guarantee_property(index+1 < length,
 176                            "Invalid constant pool entry %u in class file %s",
 177                            index, CHECK);
 178         {
 179           cfs->guarantee_more(9, CHECK);  // bytes, tag/access_flags
 180           u8 bytes = cfs->get_u8_fast();
 181           cp->long_at_put(index, bytes);
 182         }
 183         index++;   // Skip entry following eigth-byte constant, see JVM book p. 98
 184         break;
 185       case JVM_CONSTANT_Double :
 186         // A mangled type might cause you to overrun allocated memory
 187         guarantee_property(index+1 < length,
 188                            "Invalid constant pool entry %u in class file %s",
 189                            index, CHECK);
 190         {
 191           cfs->guarantee_more(9, CHECK);  // bytes, tag/access_flags
 192           u8 bytes = cfs->get_u8_fast();
 193           cp->double_at_put(index, *(jdouble*)&bytes);
 194         }
 195         index++;   // Skip entry following eigth-byte constant, see JVM book p. 98
 196         break;
 197       case JVM_CONSTANT_NameAndType :
 198         {
 199           cfs->guarantee_more(5, CHECK);  // name_index, signature_index, tag/access_flags
 200           u2 name_index = cfs->get_u2_fast();
 201           u2 signature_index = cfs->get_u2_fast();
 202           cp->name_and_type_at_put(index, name_index, signature_index);
 203         }
 204         break;
 205       case JVM_CONSTANT_Utf8 :
 206         {
 207           cfs->guarantee_more(2, CHECK);  // utf8_length
 208           u2  utf8_length = cfs->get_u2_fast();
 209           u1* utf8_buffer = cfs->get_u1_buffer();
 210           assert(utf8_buffer != NULL, "null utf8 buffer");
 211           // Got utf8 string, guarantee utf8_length+1 bytes, set stream position forward.
 212           cfs->guarantee_more(utf8_length+1, CHECK);  // utf8 string, tag/access_flags
 213           cfs->skip_u1_fast(utf8_length);
 214 
 215           // Before storing the symbol, make sure it's legal
 216           if (_need_verify) {
 217             verify_legal_utf8((unsigned char*)utf8_buffer, utf8_length, CHECK);
 218           }
 219 
 220           if (AnonymousClasses && has_cp_patch_at(index)) {
 221             Handle patch = clear_cp_patch_at(index);
 222             guarantee_property(java_lang_String::is_instance(patch()),
 223                                "Illegal utf8 patch at %d in class file %s",
 224                                index, CHECK);
 225             char* str = java_lang_String::as_utf8_string(patch());
 226             // (could use java_lang_String::as_symbol instead, but might as well batch them)
 227             utf8_buffer = (u1*) str;
 228             utf8_length = (int) strlen(str);
 229           }
 230 
 231           unsigned int hash;
 232           symbolOop result = SymbolTable::lookup_only((char*)utf8_buffer, utf8_length, hash);
 233           if (result == NULL) {
 234             names[names_count] = (char*)utf8_buffer;
 235             lengths[names_count] = utf8_length;
 236             indices[names_count] = index;
 237             hashValues[names_count++] = hash;
 238             if (names_count == SymbolTable::symbol_alloc_batch_size) {
 239               oopFactory::new_symbols(cp, names_count, names, lengths, indices, hashValues, CHECK);
 240               names_count = 0;
 241             }
 242           } else {
 243             cp->symbol_at_put(index, result);
 244           }
 245         }
 246         break;
 247       default:
 248         classfile_parse_error(
 249           "Unknown constant tag %u in class file %s", tag, CHECK);
 250         break;
 251     }
 252   }
 253 
 254   // Allocate the remaining symbols
 255   if (names_count > 0) {
 256     oopFactory::new_symbols(cp, names_count, names, lengths, indices, hashValues, CHECK);
 257   }
 258 
 259   // Copy _current pointer of local copy back to stream().
 260 #ifdef ASSERT
 261   assert(cfs0->current() == old_current, "non-exclusive use of stream()");
 262 #endif
 263   cfs0->set_current(cfs1.current());
 264 }
 265 
 266 bool inline valid_cp_range(int index, int length) { return (index > 0 && index < length); }
 267 
 268 constantPoolHandle ClassFileParser::parse_constant_pool(TRAPS) {
 269   ClassFileStream* cfs = stream();
 270   constantPoolHandle nullHandle;
 271 
 272   cfs->guarantee_more(3, CHECK_(nullHandle)); // length, first cp tag
 273   u2 length = cfs->get_u2_fast();
 274   guarantee_property(
 275     length >= 1, "Illegal constant pool size %u in class file %s",
 276     length, CHECK_(nullHandle));
 277   constantPoolOop constant_pool =
 278                       oopFactory::new_constantPool(length,
 279                                                    methodOopDesc::IsSafeConc,
 280                                                    CHECK_(nullHandle));
 281   constantPoolHandle cp (THREAD, constant_pool);
 282 
 283   cp->set_partially_loaded();    // Enables heap verify to work on partial constantPoolOops
 284 
 285   // parsing constant pool entries
 286   parse_constant_pool_entries(cp, length, CHECK_(nullHandle));
 287 
 288   int index = 1;  // declared outside of loops for portability
 289 
 290   // first verification pass - validate cross references and fixup class and string constants
 291   for (index = 1; index < length; index++) {          // Index 0 is unused
 292     switch (cp->tag_at(index).value()) {
 293       case JVM_CONSTANT_Class :
 294         ShouldNotReachHere();     // Only JVM_CONSTANT_ClassIndex should be present
 295         break;
 296       case JVM_CONSTANT_Fieldref :
 297         // fall through
 298       case JVM_CONSTANT_Methodref :
 299         // fall through
 300       case JVM_CONSTANT_InterfaceMethodref : {
 301         if (!_need_verify) break;
 302         int klass_ref_index = cp->klass_ref_index_at(index);
 303         int name_and_type_ref_index = cp->name_and_type_ref_index_at(index);
 304         check_property(valid_cp_range(klass_ref_index, length) &&
 305                        is_klass_reference(cp, klass_ref_index),
 306                        "Invalid constant pool index %u in class file %s",
 307                        klass_ref_index,
 308                        CHECK_(nullHandle));
 309         check_property(valid_cp_range(name_and_type_ref_index, length) &&
 310                        cp->tag_at(name_and_type_ref_index).is_name_and_type(),
 311                        "Invalid constant pool index %u in class file %s",
 312                        name_and_type_ref_index,
 313                        CHECK_(nullHandle));
 314         break;
 315       }
 316       case JVM_CONSTANT_String :
 317         ShouldNotReachHere();     // Only JVM_CONSTANT_StringIndex should be present
 318         break;
 319       case JVM_CONSTANT_Integer :
 320         break;
 321       case JVM_CONSTANT_Float :
 322         break;
 323       case JVM_CONSTANT_Long :
 324       case JVM_CONSTANT_Double :
 325         index++;
 326         check_property(
 327           (index < length && cp->tag_at(index).is_invalid()),
 328           "Improper constant pool long/double index %u in class file %s",
 329           index, CHECK_(nullHandle));
 330         break;
 331       case JVM_CONSTANT_NameAndType : {
 332         if (!_need_verify) break;
 333         int name_ref_index = cp->name_ref_index_at(index);
 334         int signature_ref_index = cp->signature_ref_index_at(index);
 335         check_property(
 336           valid_cp_range(name_ref_index, length) &&
 337             cp->tag_at(name_ref_index).is_utf8(),
 338           "Invalid constant pool index %u in class file %s",
 339           name_ref_index, CHECK_(nullHandle));
 340         check_property(
 341           valid_cp_range(signature_ref_index, length) &&
 342             cp->tag_at(signature_ref_index).is_utf8(),
 343           "Invalid constant pool index %u in class file %s",
 344           signature_ref_index, CHECK_(nullHandle));
 345         break;
 346       }
 347       case JVM_CONSTANT_Utf8 :
 348         break;
 349       case JVM_CONSTANT_UnresolvedClass :         // fall-through
 350       case JVM_CONSTANT_UnresolvedClassInError:
 351         ShouldNotReachHere();     // Only JVM_CONSTANT_ClassIndex should be present
 352         break;
 353       case JVM_CONSTANT_ClassIndex :
 354         {
 355           int class_index = cp->klass_index_at(index);
 356           check_property(
 357             valid_cp_range(class_index, length) &&
 358               cp->tag_at(class_index).is_utf8(),
 359             "Invalid constant pool index %u in class file %s",
 360             class_index, CHECK_(nullHandle));
 361           cp->unresolved_klass_at_put(index, cp->symbol_at(class_index));
 362         }
 363         break;
 364       case JVM_CONSTANT_UnresolvedString :
 365         ShouldNotReachHere();     // Only JVM_CONSTANT_StringIndex should be present
 366         break;
 367       case JVM_CONSTANT_StringIndex :
 368         {
 369           int string_index = cp->string_index_at(index);
 370           check_property(
 371             valid_cp_range(string_index, length) &&
 372               cp->tag_at(string_index).is_utf8(),
 373             "Invalid constant pool index %u in class file %s",
 374             string_index, CHECK_(nullHandle));
 375           symbolOop sym = cp->symbol_at(string_index);
 376           cp->unresolved_string_at_put(index, sym);
 377         }
 378         break;
 379       case JVM_CONSTANT_MethodHandle :
 380         {
 381           int ref_index = cp->method_handle_index_at(index);
 382           check_property(
 383             valid_cp_range(ref_index, length) &&
 384                 EnableMethodHandles,
 385               "Invalid constant pool index %u in class file %s",
 386               ref_index, CHECK_(nullHandle));
 387           constantTag tag = cp->tag_at(ref_index);
 388           int ref_kind  = cp->method_handle_ref_kind_at(index);
 389           switch (ref_kind) {
 390           case JVM_REF_getField:
 391           case JVM_REF_getStatic:
 392           case JVM_REF_putField:
 393           case JVM_REF_putStatic:
 394             check_property(
 395               tag.is_field(),
 396               "Invalid constant pool index %u in class file %s (not a field)",
 397               ref_index, CHECK_(nullHandle));
 398             break;
 399           case JVM_REF_invokeVirtual:
 400           case JVM_REF_invokeStatic:
 401           case JVM_REF_invokeSpecial:
 402           case JVM_REF_newInvokeSpecial:
 403             check_property(
 404               tag.is_method(),
 405               "Invalid constant pool index %u in class file %s (not a method)",
 406               ref_index, CHECK_(nullHandle));
 407             break;
 408           case JVM_REF_invokeInterface:
 409             check_property(
 410               tag.is_interface_method(),
 411               "Invalid constant pool index %u in class file %s (not an interface method)",
 412               ref_index, CHECK_(nullHandle));
 413             break;
 414           default:
 415             classfile_parse_error(
 416               "Bad method handle kind at constant pool index %u in class file %s",
 417               index, CHECK_(nullHandle));
 418           }
 419           // Keep the ref_index unchanged.  It will be indirected at link-time.
 420         }
 421         break;
 422       case JVM_CONSTANT_MethodType :
 423         {
 424           int ref_index = cp->method_type_index_at(index);
 425           check_property(
 426             valid_cp_range(ref_index, length) &&
 427                 cp->tag_at(ref_index).is_utf8() &&
 428                 EnableMethodHandles,
 429               "Invalid constant pool index %u in class file %s",
 430               ref_index, CHECK_(nullHandle));
 431         }
 432         break;
 433       case JVM_CONSTANT_InvokeDynamic :
 434         {
 435           int bootstrap_method_ref_index = cp->invoke_dynamic_bootstrap_method_ref_index_at(index);
 436           int name_and_type_ref_index = cp->invoke_dynamic_name_and_type_ref_index_at(index);
 437           check_property((bootstrap_method_ref_index == 0 && AllowTransitionalJSR292)
 438                          ||
 439                          (valid_cp_range(bootstrap_method_ref_index, length) &&
 440                           cp->tag_at(bootstrap_method_ref_index).is_method_handle()),
 441                          "Invalid constant pool index %u in class file %s",
 442                          bootstrap_method_ref_index,
 443                          CHECK_(nullHandle));
 444           check_property(valid_cp_range(name_and_type_ref_index, length) &&
 445                          cp->tag_at(name_and_type_ref_index).is_name_and_type(),
 446                          "Invalid constant pool index %u in class file %s",
 447                          name_and_type_ref_index,
 448                          CHECK_(nullHandle));
 449           break;
 450         }
 451       default:
 452         fatal(err_msg("bad constant pool tag value %u",
 453                       cp->tag_at(index).value()));
 454         ShouldNotReachHere();
 455         break;
 456     } // end of switch
 457   } // end of for
 458 
 459   if (_cp_patches != NULL) {
 460     // need to treat this_class specially...
 461     assert(AnonymousClasses, "");
 462     int this_class_index;
 463     {
 464       cfs->guarantee_more(8, CHECK_(nullHandle));  // flags, this_class, super_class, infs_len
 465       u1* mark = cfs->current();
 466       u2 flags         = cfs->get_u2_fast();
 467       this_class_index = cfs->get_u2_fast();
 468       cfs->set_current(mark);  // revert to mark
 469     }
 470 
 471     for (index = 1; index < length; index++) {          // Index 0 is unused
 472       if (has_cp_patch_at(index)) {
 473         guarantee_property(index != this_class_index,
 474                            "Illegal constant pool patch to self at %d in class file %s",
 475                            index, CHECK_(nullHandle));
 476         patch_constant_pool(cp, index, cp_patch_at(index), CHECK_(nullHandle));
 477       }
 478     }
 479     // Ensure that all the patches have been used.
 480     for (index = 0; index < _cp_patches->length(); index++) {
 481       guarantee_property(!has_cp_patch_at(index),
 482                          "Unused constant pool patch at %d in class file %s",
 483                          index, CHECK_(nullHandle));
 484     }
 485   }
 486 
 487   if (!_need_verify) {
 488     return cp;
 489   }
 490 
 491   // second verification pass - checks the strings are of the right format.
 492   // but not yet to the other entries
 493   for (index = 1; index < length; index++) {
 494     jbyte tag = cp->tag_at(index).value();
 495     switch (tag) {
 496       case JVM_CONSTANT_UnresolvedClass: {
 497         symbolHandle class_name(THREAD, cp->unresolved_klass_at(index));
 498         // check the name, even if _cp_patches will overwrite it
 499         verify_legal_class_name(class_name, CHECK_(nullHandle));
 500         break;
 501       }
 502       case JVM_CONSTANT_NameAndType: {
 503         if (_need_verify && _major_version >= JAVA_7_VERSION) {
 504           int sig_index = cp->signature_ref_index_at(index);
 505           int name_index = cp->name_ref_index_at(index);
 506           symbolHandle name(THREAD, cp->symbol_at(name_index));
 507           symbolHandle sig(THREAD, cp->symbol_at(sig_index));
 508           if (sig->byte_at(0) == JVM_SIGNATURE_FUNC) {
 509             verify_legal_method_signature(name, sig, CHECK_(nullHandle));
 510           } else {
 511             verify_legal_field_signature(name, sig, CHECK_(nullHandle));
 512           }
 513         }
 514         break;
 515       }
 516       case JVM_CONSTANT_Fieldref:
 517       case JVM_CONSTANT_Methodref:
 518       case JVM_CONSTANT_InterfaceMethodref: {
 519         int name_and_type_ref_index = cp->name_and_type_ref_index_at(index);
 520         // already verified to be utf8
 521         int name_ref_index = cp->name_ref_index_at(name_and_type_ref_index);
 522         // already verified to be utf8
 523         int signature_ref_index = cp->signature_ref_index_at(name_and_type_ref_index);
 524         symbolHandle name(THREAD, cp->symbol_at(name_ref_index));
 525         symbolHandle signature(THREAD, cp->symbol_at(signature_ref_index));
 526         if (tag == JVM_CONSTANT_Fieldref) {
 527           verify_legal_field_name(name, CHECK_(nullHandle));
 528           if (_need_verify && _major_version >= JAVA_7_VERSION) {
 529             // Signature is verified above, when iterating NameAndType_info.
 530             // Need only to be sure it's the right type.
 531             if (signature->byte_at(0) == JVM_SIGNATURE_FUNC) {
 532               throwIllegalSignature(
 533                   "Field", name, signature, CHECK_(nullHandle));
 534             }
 535           } else {
 536             verify_legal_field_signature(name, signature, CHECK_(nullHandle));
 537           }
 538         } else {
 539           verify_legal_method_name(name, CHECK_(nullHandle));
 540           if (_need_verify && _major_version >= JAVA_7_VERSION) {
 541             // Signature is verified above, when iterating NameAndType_info.
 542             // Need only to be sure it's the right type.
 543             if (signature->byte_at(0) != JVM_SIGNATURE_FUNC) {
 544               throwIllegalSignature(
 545                   "Method", name, signature, CHECK_(nullHandle));
 546             }
 547           } else {
 548             verify_legal_method_signature(name, signature, CHECK_(nullHandle));
 549           }
 550           if (tag == JVM_CONSTANT_Methodref) {
 551             // 4509014: If a class method name begins with '<', it must be "<init>".
 552             assert(!name.is_null(), "method name in constant pool is null");
 553             unsigned int name_len = name->utf8_length();
 554             assert(name_len > 0, "bad method name");  // already verified as legal name
 555             if (name->byte_at(0) == '<') {
 556               if (name() != vmSymbols::object_initializer_name()) {
 557                 classfile_parse_error(
 558                   "Bad method name at constant pool index %u in class file %s",
 559                   name_ref_index, CHECK_(nullHandle));
 560               }
 561             }
 562           }
 563         }
 564         break;
 565       }
 566       case JVM_CONSTANT_MethodHandle: {
 567         int ref_index = cp->method_handle_index_at(index);
 568         int ref_kind  = cp->method_handle_ref_kind_at(index);
 569         switch (ref_kind) {
 570         case JVM_REF_invokeVirtual:
 571         case JVM_REF_invokeStatic:
 572         case JVM_REF_invokeSpecial:
 573         case JVM_REF_newInvokeSpecial:
 574           {
 575             int name_and_type_ref_index = cp->name_and_type_ref_index_at(ref_index);
 576             int name_ref_index = cp->name_ref_index_at(name_and_type_ref_index);
 577             symbolHandle name(THREAD, cp->symbol_at(name_ref_index));
 578             if (ref_kind == JVM_REF_newInvokeSpecial) {
 579               if (name() != vmSymbols::object_initializer_name()) {
 580                 classfile_parse_error(
 581                   "Bad constructor name at constant pool index %u in class file %s",
 582                   name_ref_index, CHECK_(nullHandle));
 583               }
 584             } else {
 585               if (name() == vmSymbols::object_initializer_name()) {
 586                 classfile_parse_error(
 587                   "Bad method name at constant pool index %u in class file %s",
 588                   name_ref_index, CHECK_(nullHandle));
 589               }
 590             }
 591           }
 592           break;
 593           // Other ref_kinds are already fully checked in previous pass.
 594         }
 595         break;
 596       }
 597       case JVM_CONSTANT_MethodType: {
 598         symbolHandle no_name = vmSymbolHandles::type_name(); // place holder
 599         symbolHandle signature(THREAD, cp->method_type_signature_at(index));
 600         verify_legal_method_signature(no_name, signature, CHECK_(nullHandle));
 601         break;
 602       }
 603     }  // end of switch
 604   }  // end of for
 605 
 606   return cp;
 607 }
 608 
 609 
 610 void ClassFileParser::patch_constant_pool(constantPoolHandle cp, int index, Handle patch, TRAPS) {
 611   assert(AnonymousClasses, "");
 612   BasicType patch_type = T_VOID;
 613   switch (cp->tag_at(index).value()) {
 614 
 615   case JVM_CONSTANT_UnresolvedClass :
 616     // Patching a class means pre-resolving it.
 617     // The name in the constant pool is ignored.
 618     if (java_lang_Class::is_instance(patch())) {
 619       guarantee_property(!java_lang_Class::is_primitive(patch()),
 620                          "Illegal class patch at %d in class file %s",
 621                          index, CHECK);
 622       cp->klass_at_put(index, java_lang_Class::as_klassOop(patch()));
 623     } else {
 624       guarantee_property(java_lang_String::is_instance(patch()),
 625                          "Illegal class patch at %d in class file %s",
 626                          index, CHECK);
 627       symbolHandle name = java_lang_String::as_symbol(patch(), CHECK);
 628       cp->unresolved_klass_at_put(index, name());
 629     }
 630     break;
 631 
 632   case JVM_CONSTANT_UnresolvedString :
 633     // Patching a string means pre-resolving it.
 634     // The spelling in the constant pool is ignored.
 635     // The constant reference may be any object whatever.
 636     // If it is not a real interned string, the constant is referred
 637     // to as a "pseudo-string", and must be presented to the CP
 638     // explicitly, because it may require scavenging.
 639     cp->pseudo_string_at_put(index, patch());
 640     break;
 641 
 642   case JVM_CONSTANT_Integer : patch_type = T_INT;    goto patch_prim;
 643   case JVM_CONSTANT_Float :   patch_type = T_FLOAT;  goto patch_prim;
 644   case JVM_CONSTANT_Long :    patch_type = T_LONG;   goto patch_prim;
 645   case JVM_CONSTANT_Double :  patch_type = T_DOUBLE; goto patch_prim;
 646   patch_prim:
 647     {
 648       jvalue value;
 649       BasicType value_type = java_lang_boxing_object::get_value(patch(), &value);
 650       guarantee_property(value_type == patch_type,
 651                          "Illegal primitive patch at %d in class file %s",
 652                          index, CHECK);
 653       switch (value_type) {
 654       case T_INT:    cp->int_at_put(index,   value.i); break;
 655       case T_FLOAT:  cp->float_at_put(index, value.f); break;
 656       case T_LONG:   cp->long_at_put(index,  value.j); break;
 657       case T_DOUBLE: cp->double_at_put(index, value.d); break;
 658       default:       assert(false, "");
 659       }
 660     }
 661     break;
 662 
 663   default:
 664     // %%% TODO: put method handles into CONSTANT_InterfaceMethodref, etc.
 665     guarantee_property(!has_cp_patch_at(index),
 666                        "Illegal unexpected patch at %d in class file %s",
 667                        index, CHECK);
 668     return;
 669   }
 670 
 671   // On fall-through, mark the patch as used.
 672   clear_cp_patch_at(index);
 673 }
 674 
 675 
 676 
 677 class NameSigHash: public ResourceObj {
 678  public:
 679   symbolOop     _name;       // name
 680   symbolOop     _sig;        // signature
 681   NameSigHash*  _next;       // Next entry in hash table
 682 };
 683 
 684 
 685 #define HASH_ROW_SIZE 256
 686 
 687 unsigned int hash(symbolOop name, symbolOop sig) {
 688   unsigned int raw_hash = 0;
 689   raw_hash += ((unsigned int)(uintptr_t)name) >> (LogHeapWordSize + 2);
 690   raw_hash += ((unsigned int)(uintptr_t)sig) >> LogHeapWordSize;
 691 
 692   return (raw_hash + (unsigned int)(uintptr_t)name) % HASH_ROW_SIZE;
 693 }
 694 
 695 
 696 void initialize_hashtable(NameSigHash** table) {
 697   memset((void*)table, 0, sizeof(NameSigHash*) * HASH_ROW_SIZE);
 698 }
 699 
 700 // Return false if the name/sig combination is found in table.
 701 // Return true if no duplicate is found. And name/sig is added as a new entry in table.
 702 // The old format checker uses heap sort to find duplicates.
 703 // NOTE: caller should guarantee that GC doesn't happen during the life cycle
 704 // of table since we don't expect symbolOop's to move.
 705 bool put_after_lookup(symbolOop name, symbolOop sig, NameSigHash** table) {
 706   assert(name != NULL, "name in constant pool is NULL");
 707 
 708   // First lookup for duplicates
 709   int index = hash(name, sig);
 710   NameSigHash* entry = table[index];
 711   while (entry != NULL) {
 712     if (entry->_name == name && entry->_sig == sig) {
 713       return false;
 714     }
 715     entry = entry->_next;
 716   }
 717 
 718   // No duplicate is found, allocate a new entry and fill it.
 719   entry = new NameSigHash();
 720   entry->_name = name;
 721   entry->_sig = sig;
 722 
 723   // Insert into hash table
 724   entry->_next = table[index];
 725   table[index] = entry;
 726 
 727   return true;
 728 }
 729 
 730 
 731 objArrayHandle ClassFileParser::parse_interfaces(constantPoolHandle cp,
 732                                                  int length,
 733                                                  Handle class_loader,
 734                                                  Handle protection_domain,
 735                                                  symbolHandle class_name,
 736                                                  TRAPS) {
 737   ClassFileStream* cfs = stream();
 738   assert(length > 0, "only called for length>0");
 739   objArrayHandle nullHandle;
 740   objArrayOop interface_oop = oopFactory::new_system_objArray(length, CHECK_(nullHandle));
 741   objArrayHandle interfaces (THREAD, interface_oop);
 742 
 743   int index;
 744   for (index = 0; index < length; index++) {
 745     u2 interface_index = cfs->get_u2(CHECK_(nullHandle));
 746     KlassHandle interf;
 747     check_property(
 748       valid_cp_range(interface_index, cp->length()) &&
 749       is_klass_reference(cp, interface_index),
 750       "Interface name has bad constant pool index %u in class file %s",
 751       interface_index, CHECK_(nullHandle));
 752     if (cp->tag_at(interface_index).is_klass()) {
 753       interf = KlassHandle(THREAD, cp->resolved_klass_at(interface_index));
 754     } else {
 755       symbolHandle unresolved_klass (THREAD, cp->klass_name_at(interface_index));
 756 
 757       // Don't need to check legal name because it's checked when parsing constant pool.
 758       // But need to make sure it's not an array type.
 759       guarantee_property(unresolved_klass->byte_at(0) != JVM_SIGNATURE_ARRAY,
 760                          "Bad interface name in class file %s", CHECK_(nullHandle));
 761 
 762       // Call resolve_super so classcircularity is checked
 763       klassOop k = SystemDictionary::resolve_super_or_fail(class_name,
 764                     unresolved_klass, class_loader, protection_domain,
 765                     false, CHECK_(nullHandle));
 766       interf = KlassHandle(THREAD, k);
 767 
 768       if (LinkWellKnownClasses)  // my super type is well known to me
 769         cp->klass_at_put(interface_index, interf()); // eagerly resolve
 770     }
 771 
 772     if (!Klass::cast(interf())->is_interface()) {
 773       THROW_MSG_(vmSymbols::java_lang_IncompatibleClassChangeError(), "Implementing class", nullHandle);
 774     }
 775     interfaces->obj_at_put(index, interf());
 776   }
 777 
 778   if (!_need_verify || length <= 1) {
 779     return interfaces;
 780   }
 781 
 782   // Check if there's any duplicates in interfaces
 783   ResourceMark rm(THREAD);
 784   NameSigHash** interface_names = NEW_RESOURCE_ARRAY_IN_THREAD(
 785     THREAD, NameSigHash*, HASH_ROW_SIZE);
 786   initialize_hashtable(interface_names);
 787   bool dup = false;
 788   {
 789     debug_only(No_Safepoint_Verifier nsv;)
 790     for (index = 0; index < length; index++) {
 791       klassOop k = (klassOop)interfaces->obj_at(index);
 792       symbolOop name = instanceKlass::cast(k)->name();
 793       // If no duplicates, add (name, NULL) in hashtable interface_names.
 794       if (!put_after_lookup(name, NULL, interface_names)) {
 795         dup = true;
 796         break;
 797       }
 798     }
 799   }
 800   if (dup) {
 801     classfile_parse_error("Duplicate interface name in class file %s",
 802                           CHECK_(nullHandle));
 803   }
 804 
 805   return interfaces;
 806 }
 807 
 808 
 809 void ClassFileParser::verify_constantvalue(int constantvalue_index, int signature_index, constantPoolHandle cp, TRAPS) {
 810   // Make sure the constant pool entry is of a type appropriate to this field
 811   guarantee_property(
 812     (constantvalue_index > 0 &&
 813       constantvalue_index < cp->length()),
 814     "Bad initial value index %u in ConstantValue attribute in class file %s",
 815     constantvalue_index, CHECK);
 816   constantTag value_type = cp->tag_at(constantvalue_index);
 817   switch ( cp->basic_type_for_signature_at(signature_index) ) {
 818     case T_LONG:
 819       guarantee_property(value_type.is_long(), "Inconsistent constant value type in class file %s", CHECK);
 820       break;
 821     case T_FLOAT:
 822       guarantee_property(value_type.is_float(), "Inconsistent constant value type in class file %s", CHECK);
 823       break;
 824     case T_DOUBLE:
 825       guarantee_property(value_type.is_double(), "Inconsistent constant value type in class file %s", CHECK);
 826       break;
 827     case T_BYTE: case T_CHAR: case T_SHORT: case T_BOOLEAN: case T_INT:
 828       guarantee_property(value_type.is_int(), "Inconsistent constant value type in class file %s", CHECK);
 829       break;
 830     case T_OBJECT:
 831       guarantee_property((cp->symbol_at(signature_index)->equals("Ljava/lang/String;")
 832                          && (value_type.is_string() || value_type.is_unresolved_string())),
 833                          "Bad string initial value in class file %s", CHECK);
 834       break;
 835     default:
 836       classfile_parse_error(
 837         "Unable to set initial value %u in class file %s",
 838         constantvalue_index, CHECK);
 839   }
 840 }
 841 
 842 
 843 // Parse attributes for a field.
 844 void ClassFileParser::parse_field_attributes(constantPoolHandle cp,
 845                                              u2 attributes_count,
 846                                              bool is_static, u2 signature_index,
 847                                              u2* constantvalue_index_addr,
 848                                              bool* is_synthetic_addr,
 849                                              u2* generic_signature_index_addr,
 850                                              typeArrayHandle* field_annotations,
 851                                              TRAPS) {
 852   ClassFileStream* cfs = stream();
 853   assert(attributes_count > 0, "length should be greater than 0");
 854   u2 constantvalue_index = 0;
 855   u2 generic_signature_index = 0;
 856   bool is_synthetic = false;
 857   u1* runtime_visible_annotations = NULL;
 858   int runtime_visible_annotations_length = 0;
 859   u1* runtime_invisible_annotations = NULL;
 860   int runtime_invisible_annotations_length = 0;
 861   while (attributes_count--) {
 862     cfs->guarantee_more(6, CHECK);  // attribute_name_index, attribute_length
 863     u2 attribute_name_index = cfs->get_u2_fast();
 864     u4 attribute_length = cfs->get_u4_fast();
 865     check_property(valid_cp_range(attribute_name_index, cp->length()) &&
 866                    cp->tag_at(attribute_name_index).is_utf8(),
 867                    "Invalid field attribute index %u in class file %s",
 868                    attribute_name_index,
 869                    CHECK);
 870     symbolOop attribute_name = cp->symbol_at(attribute_name_index);
 871     if (is_static && attribute_name == vmSymbols::tag_constant_value()) {
 872       // ignore if non-static
 873       if (constantvalue_index != 0) {
 874         classfile_parse_error("Duplicate ConstantValue attribute in class file %s", CHECK);
 875       }
 876       check_property(
 877         attribute_length == 2,
 878         "Invalid ConstantValue field attribute length %u in class file %s",
 879         attribute_length, CHECK);
 880       constantvalue_index = cfs->get_u2(CHECK);
 881       if (_need_verify) {
 882         verify_constantvalue(constantvalue_index, signature_index, cp, CHECK);
 883       }
 884     } else if (attribute_name == vmSymbols::tag_synthetic()) {
 885       if (attribute_length != 0) {
 886         classfile_parse_error(
 887           "Invalid Synthetic field attribute length %u in class file %s",
 888           attribute_length, CHECK);
 889       }
 890       is_synthetic = true;
 891     } else if (attribute_name == vmSymbols::tag_deprecated()) { // 4276120
 892       if (attribute_length != 0) {
 893         classfile_parse_error(
 894           "Invalid Deprecated field attribute length %u in class file %s",
 895           attribute_length, CHECK);
 896       }
 897     } else if (_major_version >= JAVA_1_5_VERSION) {
 898       if (attribute_name == vmSymbols::tag_signature()) {
 899         if (attribute_length != 2) {
 900           classfile_parse_error(
 901             "Wrong size %u for field's Signature attribute in class file %s",
 902             attribute_length, CHECK);
 903         }
 904         generic_signature_index = cfs->get_u2(CHECK);
 905       } else if (attribute_name == vmSymbols::tag_runtime_visible_annotations()) {
 906         runtime_visible_annotations_length = attribute_length;
 907         runtime_visible_annotations = cfs->get_u1_buffer();
 908         assert(runtime_visible_annotations != NULL, "null visible annotations");
 909         cfs->skip_u1(runtime_visible_annotations_length, CHECK);
 910       } else if (PreserveAllAnnotations && attribute_name == vmSymbols::tag_runtime_invisible_annotations()) {
 911         runtime_invisible_annotations_length = attribute_length;
 912         runtime_invisible_annotations = cfs->get_u1_buffer();
 913         assert(runtime_invisible_annotations != NULL, "null invisible annotations");
 914         cfs->skip_u1(runtime_invisible_annotations_length, CHECK);
 915       } else {
 916         cfs->skip_u1(attribute_length, CHECK);  // Skip unknown attributes
 917       }
 918     } else {
 919       cfs->skip_u1(attribute_length, CHECK);  // Skip unknown attributes
 920     }
 921   }
 922 
 923   *constantvalue_index_addr = constantvalue_index;
 924   *is_synthetic_addr = is_synthetic;
 925   *generic_signature_index_addr = generic_signature_index;
 926   *field_annotations = assemble_annotations(runtime_visible_annotations,
 927                                             runtime_visible_annotations_length,
 928                                             runtime_invisible_annotations,
 929                                             runtime_invisible_annotations_length,
 930                                             CHECK);
 931   return;
 932 }
 933 
 934 
 935 // Field allocation types. Used for computing field offsets.
 936 
 937 enum FieldAllocationType {
 938   STATIC_OOP,           // Oops
 939   STATIC_BYTE,          // Boolean, Byte, char
 940   STATIC_SHORT,         // shorts
 941   STATIC_WORD,          // ints
 942   STATIC_DOUBLE,        // long or double
 943   STATIC_ALIGNED_DOUBLE,// aligned long or double
 944   NONSTATIC_OOP,
 945   NONSTATIC_BYTE,
 946   NONSTATIC_SHORT,
 947   NONSTATIC_WORD,
 948   NONSTATIC_DOUBLE,
 949   NONSTATIC_ALIGNED_DOUBLE
 950 };
 951 
 952 
 953 struct FieldAllocationCount {
 954   unsigned int static_oop_count;
 955   unsigned int static_byte_count;
 956   unsigned int static_short_count;
 957   unsigned int static_word_count;
 958   unsigned int static_double_count;
 959   unsigned int nonstatic_oop_count;
 960   unsigned int nonstatic_byte_count;
 961   unsigned int nonstatic_short_count;
 962   unsigned int nonstatic_word_count;
 963   unsigned int nonstatic_double_count;
 964 };
 965 
 966 typeArrayHandle ClassFileParser::parse_fields(constantPoolHandle cp, bool is_interface,
 967                                               struct FieldAllocationCount *fac,
 968                                               objArrayHandle* fields_annotations, TRAPS) {
 969   ClassFileStream* cfs = stream();
 970   typeArrayHandle nullHandle;
 971   cfs->guarantee_more(2, CHECK_(nullHandle));  // length
 972   u2 length = cfs->get_u2_fast();
 973   // Tuples of shorts [access, name index, sig index, initial value index, byte offset, generic signature index]
 974   typeArrayOop new_fields = oopFactory::new_permanent_shortArray(length*instanceKlass::next_offset, CHECK_(nullHandle));
 975   typeArrayHandle fields(THREAD, new_fields);
 976 
 977   int index = 0;
 978   typeArrayHandle field_annotations;
 979   for (int n = 0; n < length; n++) {
 980     cfs->guarantee_more(8, CHECK_(nullHandle));  // access_flags, name_index, descriptor_index, attributes_count
 981 
 982     AccessFlags access_flags;
 983     jint flags = cfs->get_u2_fast() & JVM_RECOGNIZED_FIELD_MODIFIERS;
 984     verify_legal_field_modifiers(flags, is_interface, CHECK_(nullHandle));
 985     access_flags.set_flags(flags);
 986 
 987     u2 name_index = cfs->get_u2_fast();
 988     int cp_size = cp->length();
 989     check_property(
 990       valid_cp_range(name_index, cp_size) && cp->tag_at(name_index).is_utf8(),
 991       "Invalid constant pool index %u for field name in class file %s",
 992       name_index, CHECK_(nullHandle));
 993     symbolHandle name(THREAD, cp->symbol_at(name_index));
 994     verify_legal_field_name(name, CHECK_(nullHandle));
 995 
 996     u2 signature_index = cfs->get_u2_fast();
 997     check_property(
 998       valid_cp_range(signature_index, cp_size) &&
 999         cp->tag_at(signature_index).is_utf8(),
1000       "Invalid constant pool index %u for field signature in class file %s",
1001       signature_index, CHECK_(nullHandle));
1002     symbolHandle sig(THREAD, cp->symbol_at(signature_index));
1003     verify_legal_field_signature(name, sig, CHECK_(nullHandle));
1004 
1005     u2 constantvalue_index = 0;
1006     bool is_synthetic = false;
1007     u2 generic_signature_index = 0;
1008     bool is_static = access_flags.is_static();
1009 
1010     u2 attributes_count = cfs->get_u2_fast();
1011     if (attributes_count > 0) {
1012       parse_field_attributes(cp, attributes_count, is_static, signature_index,
1013                              &constantvalue_index, &is_synthetic,
1014                              &generic_signature_index, &field_annotations,
1015                              CHECK_(nullHandle));
1016       if (field_annotations.not_null()) {
1017         if (fields_annotations->is_null()) {
1018           objArrayOop md = oopFactory::new_system_objArray(length, CHECK_(nullHandle));
1019           *fields_annotations = objArrayHandle(THREAD, md);
1020         }
1021         (*fields_annotations)->obj_at_put(n, field_annotations());
1022       }
1023       if (is_synthetic) {
1024         access_flags.set_is_synthetic();
1025       }
1026     }
1027 
1028     fields->short_at_put(index++, access_flags.as_short());
1029     fields->short_at_put(index++, name_index);
1030     fields->short_at_put(index++, signature_index);
1031     fields->short_at_put(index++, constantvalue_index);
1032 
1033     // Remember how many oops we encountered and compute allocation type
1034     BasicType type = cp->basic_type_for_signature_at(signature_index);
1035     FieldAllocationType atype;
1036     if ( is_static ) {
1037       switch ( type ) {
1038         case  T_BOOLEAN:
1039         case  T_BYTE:
1040           fac->static_byte_count++;
1041           atype = STATIC_BYTE;
1042           break;
1043         case  T_LONG:
1044         case  T_DOUBLE:
1045           if (Universe::field_type_should_be_aligned(type)) {
1046             atype = STATIC_ALIGNED_DOUBLE;
1047           } else {
1048             atype = STATIC_DOUBLE;
1049           }
1050           fac->static_double_count++;
1051           break;
1052         case  T_CHAR:
1053         case  T_SHORT:
1054           fac->static_short_count++;
1055           atype = STATIC_SHORT;
1056           break;
1057         case  T_FLOAT:
1058         case  T_INT:
1059           fac->static_word_count++;
1060           atype = STATIC_WORD;
1061           break;
1062         case  T_ARRAY:
1063         case  T_OBJECT:
1064           fac->static_oop_count++;
1065           atype = STATIC_OOP;
1066           break;
1067         case  T_ADDRESS:
1068         case  T_VOID:
1069         default:
1070           assert(0, "bad field type");
1071       }
1072     } else {
1073       switch ( type ) {
1074         case  T_BOOLEAN:
1075         case  T_BYTE:
1076           fac->nonstatic_byte_count++;
1077           atype = NONSTATIC_BYTE;
1078           break;
1079         case  T_LONG:
1080         case  T_DOUBLE:
1081           if (Universe::field_type_should_be_aligned(type)) {
1082             atype = NONSTATIC_ALIGNED_DOUBLE;
1083           } else {
1084             atype = NONSTATIC_DOUBLE;
1085           }
1086           fac->nonstatic_double_count++;
1087           break;
1088         case  T_CHAR:
1089         case  T_SHORT:
1090           fac->nonstatic_short_count++;
1091           atype = NONSTATIC_SHORT;
1092           break;
1093         case  T_FLOAT:
1094         case  T_INT:
1095           fac->nonstatic_word_count++;
1096           atype = NONSTATIC_WORD;
1097           break;
1098         case  T_ARRAY:
1099         case  T_OBJECT:
1100           fac->nonstatic_oop_count++;
1101           atype = NONSTATIC_OOP;
1102           break;
1103         case  T_ADDRESS:
1104         case  T_VOID:
1105         default:
1106           assert(0, "bad field type");
1107       }
1108     }
1109 
1110     // The correct offset is computed later (all oop fields will be located together)
1111     // We temporarily store the allocation type in the offset field
1112     fields->short_at_put(index++, atype);
1113     fields->short_at_put(index++, 0);  // Clear out high word of byte offset
1114     fields->short_at_put(index++, generic_signature_index);
1115   }
1116 
1117   if (_need_verify && length > 1) {
1118     // Check duplicated fields
1119     ResourceMark rm(THREAD);
1120     NameSigHash** names_and_sigs = NEW_RESOURCE_ARRAY_IN_THREAD(
1121       THREAD, NameSigHash*, HASH_ROW_SIZE);
1122     initialize_hashtable(names_and_sigs);
1123     bool dup = false;
1124     {
1125       debug_only(No_Safepoint_Verifier nsv;)
1126       for (int i = 0; i < length*instanceKlass::next_offset; i += instanceKlass::next_offset) {
1127         int name_index = fields->ushort_at(i + instanceKlass::name_index_offset);
1128         symbolOop name = cp->symbol_at(name_index);
1129         int sig_index = fields->ushort_at(i + instanceKlass::signature_index_offset);
1130         symbolOop sig = cp->symbol_at(sig_index);
1131         // If no duplicates, add name/signature in hashtable names_and_sigs.
1132         if (!put_after_lookup(name, sig, names_and_sigs)) {
1133           dup = true;
1134           break;
1135         }
1136       }
1137     }
1138     if (dup) {
1139       classfile_parse_error("Duplicate field name&signature in class file %s",
1140                             CHECK_(nullHandle));
1141     }
1142   }
1143 
1144   return fields;
1145 }
1146 
1147 
1148 static void copy_u2_with_conversion(u2* dest, u2* src, int length) {
1149   while (length-- > 0) {
1150     *dest++ = Bytes::get_Java_u2((u1*) (src++));
1151   }
1152 }
1153 
1154 
1155 typeArrayHandle ClassFileParser::parse_exception_table(u4 code_length,
1156                                                        u4 exception_table_length,
1157                                                        constantPoolHandle cp,
1158                                                        TRAPS) {
1159   ClassFileStream* cfs = stream();
1160   typeArrayHandle nullHandle;
1161 
1162   // 4-tuples of ints [start_pc, end_pc, handler_pc, catch_type index]
1163   typeArrayOop eh = oopFactory::new_permanent_intArray(exception_table_length*4, CHECK_(nullHandle));
1164   typeArrayHandle exception_handlers = typeArrayHandle(THREAD, eh);
1165 
1166   int index = 0;
1167   cfs->guarantee_more(8 * exception_table_length, CHECK_(nullHandle)); // start_pc, end_pc, handler_pc, catch_type_index
1168   for (unsigned int i = 0; i < exception_table_length; i++) {
1169     u2 start_pc = cfs->get_u2_fast();
1170     u2 end_pc = cfs->get_u2_fast();
1171     u2 handler_pc = cfs->get_u2_fast();
1172     u2 catch_type_index = cfs->get_u2_fast();
1173     // Will check legal target after parsing code array in verifier.
1174     if (_need_verify) {
1175       guarantee_property((start_pc < end_pc) && (end_pc <= code_length),
1176                          "Illegal exception table range in class file %s", CHECK_(nullHandle));
1177       guarantee_property(handler_pc < code_length,
1178                          "Illegal exception table handler in class file %s", CHECK_(nullHandle));
1179       if (catch_type_index != 0) {
1180         guarantee_property(valid_cp_range(catch_type_index, cp->length()) &&
1181                            is_klass_reference(cp, catch_type_index),
1182                            "Catch type in exception table has bad constant type in class file %s", CHECK_(nullHandle));
1183       }
1184     }
1185     exception_handlers->int_at_put(index++, start_pc);
1186     exception_handlers->int_at_put(index++, end_pc);
1187     exception_handlers->int_at_put(index++, handler_pc);
1188     exception_handlers->int_at_put(index++, catch_type_index);
1189   }
1190   return exception_handlers;
1191 }
1192 
1193 void ClassFileParser::parse_linenumber_table(
1194     u4 code_attribute_length, u4 code_length,
1195     CompressedLineNumberWriteStream** write_stream, TRAPS) {
1196   ClassFileStream* cfs = stream();
1197   unsigned int num_entries = cfs->get_u2(CHECK);
1198 
1199   // Each entry is a u2 start_pc, and a u2 line_number
1200   unsigned int length_in_bytes = num_entries * (sizeof(u2) + sizeof(u2));
1201 
1202   // Verify line number attribute and table length
1203   check_property(
1204     code_attribute_length == sizeof(u2) + length_in_bytes,
1205     "LineNumberTable attribute has wrong length in class file %s", CHECK);
1206 
1207   cfs->guarantee_more(length_in_bytes, CHECK);
1208 
1209   if ((*write_stream) == NULL) {
1210     if (length_in_bytes > fixed_buffer_size) {
1211       (*write_stream) = new CompressedLineNumberWriteStream(length_in_bytes);
1212     } else {
1213       (*write_stream) = new CompressedLineNumberWriteStream(
1214         linenumbertable_buffer, fixed_buffer_size);
1215     }
1216   }
1217 
1218   while (num_entries-- > 0) {
1219     u2 bci  = cfs->get_u2_fast(); // start_pc
1220     u2 line = cfs->get_u2_fast(); // line_number
1221     guarantee_property(bci < code_length,
1222         "Invalid pc in LineNumberTable in class file %s", CHECK);
1223     (*write_stream)->write_pair(bci, line);
1224   }
1225 }
1226 
1227 
1228 // Class file LocalVariableTable elements.
1229 class Classfile_LVT_Element VALUE_OBJ_CLASS_SPEC {
1230  public:
1231   u2 start_bci;
1232   u2 length;
1233   u2 name_cp_index;
1234   u2 descriptor_cp_index;
1235   u2 slot;
1236 };
1237 
1238 
1239 class LVT_Hash: public CHeapObj {
1240  public:
1241   LocalVariableTableElement  *_elem;  // element
1242   LVT_Hash*                   _next;  // Next entry in hash table
1243 };
1244 
1245 unsigned int hash(LocalVariableTableElement *elem) {
1246   unsigned int raw_hash = elem->start_bci;
1247 
1248   raw_hash = elem->length        + raw_hash * 37;
1249   raw_hash = elem->name_cp_index + raw_hash * 37;
1250   raw_hash = elem->slot          + raw_hash * 37;
1251 
1252   return raw_hash % HASH_ROW_SIZE;
1253 }
1254 
1255 void initialize_hashtable(LVT_Hash** table) {
1256   for (int i = 0; i < HASH_ROW_SIZE; i++) {
1257     table[i] = NULL;
1258   }
1259 }
1260 
1261 void clear_hashtable(LVT_Hash** table) {
1262   for (int i = 0; i < HASH_ROW_SIZE; i++) {
1263     LVT_Hash* current = table[i];
1264     LVT_Hash* next;
1265     while (current != NULL) {
1266       next = current->_next;
1267       current->_next = NULL;
1268       delete(current);
1269       current = next;
1270     }
1271     table[i] = NULL;
1272   }
1273 }
1274 
1275 LVT_Hash* LVT_lookup(LocalVariableTableElement *elem, int index, LVT_Hash** table) {
1276   LVT_Hash* entry = table[index];
1277 
1278   /*
1279    * 3-tuple start_bci/length/slot has to be unique key,
1280    * so the following comparison seems to be redundant:
1281    *       && elem->name_cp_index == entry->_elem->name_cp_index
1282    */
1283   while (entry != NULL) {
1284     if (elem->start_bci           == entry->_elem->start_bci
1285      && elem->length              == entry->_elem->length
1286      && elem->name_cp_index       == entry->_elem->name_cp_index
1287      && elem->slot                == entry->_elem->slot
1288     ) {
1289       return entry;
1290     }
1291     entry = entry->_next;
1292   }
1293   return NULL;
1294 }
1295 
1296 // Return false if the local variable is found in table.
1297 // Return true if no duplicate is found.
1298 // And local variable is added as a new entry in table.
1299 bool LVT_put_after_lookup(LocalVariableTableElement *elem, LVT_Hash** table) {
1300   // First lookup for duplicates
1301   int index = hash(elem);
1302   LVT_Hash* entry = LVT_lookup(elem, index, table);
1303 
1304   if (entry != NULL) {
1305       return false;
1306   }
1307   // No duplicate is found, allocate a new entry and fill it.
1308   if ((entry = new LVT_Hash()) == NULL) {
1309     return false;
1310   }
1311   entry->_elem = elem;
1312 
1313   // Insert into hash table
1314   entry->_next = table[index];
1315   table[index] = entry;
1316 
1317   return true;
1318 }
1319 
1320 void copy_lvt_element(Classfile_LVT_Element *src, LocalVariableTableElement *lvt) {
1321   lvt->start_bci           = Bytes::get_Java_u2((u1*) &src->start_bci);
1322   lvt->length              = Bytes::get_Java_u2((u1*) &src->length);
1323   lvt->name_cp_index       = Bytes::get_Java_u2((u1*) &src->name_cp_index);
1324   lvt->descriptor_cp_index = Bytes::get_Java_u2((u1*) &src->descriptor_cp_index);
1325   lvt->signature_cp_index  = 0;
1326   lvt->slot                = Bytes::get_Java_u2((u1*) &src->slot);
1327 }
1328 
1329 // Function is used to parse both attributes:
1330 //       LocalVariableTable (LVT) and LocalVariableTypeTable (LVTT)
1331 u2* ClassFileParser::parse_localvariable_table(u4 code_length,
1332                                                u2 max_locals,
1333                                                u4 code_attribute_length,
1334                                                constantPoolHandle cp,
1335                                                u2* localvariable_table_length,
1336                                                bool isLVTT,
1337                                                TRAPS) {
1338   ClassFileStream* cfs = stream();
1339   const char * tbl_name = (isLVTT) ? "LocalVariableTypeTable" : "LocalVariableTable";
1340   *localvariable_table_length = cfs->get_u2(CHECK_NULL);
1341   unsigned int size = (*localvariable_table_length) * sizeof(Classfile_LVT_Element) / sizeof(u2);
1342   // Verify local variable table attribute has right length
1343   if (_need_verify) {
1344     guarantee_property(code_attribute_length == (sizeof(*localvariable_table_length) + size * sizeof(u2)),
1345                        "%s has wrong length in class file %s", tbl_name, CHECK_NULL);
1346   }
1347   u2* localvariable_table_start = cfs->get_u2_buffer();
1348   assert(localvariable_table_start != NULL, "null local variable table");
1349   if (!_need_verify) {
1350     cfs->skip_u2_fast(size);
1351   } else {
1352     cfs->guarantee_more(size * 2, CHECK_NULL);
1353     for(int i = 0; i < (*localvariable_table_length); i++) {
1354       u2 start_pc = cfs->get_u2_fast();
1355       u2 length = cfs->get_u2_fast();
1356       u2 name_index = cfs->get_u2_fast();
1357       u2 descriptor_index = cfs->get_u2_fast();
1358       u2 index = cfs->get_u2_fast();
1359       // Assign to a u4 to avoid overflow
1360       u4 end_pc = (u4)start_pc + (u4)length;
1361 
1362       if (start_pc >= code_length) {
1363         classfile_parse_error(
1364           "Invalid start_pc %u in %s in class file %s",
1365           start_pc, tbl_name, CHECK_NULL);
1366       }
1367       if (end_pc > code_length) {
1368         classfile_parse_error(
1369           "Invalid length %u in %s in class file %s",
1370           length, tbl_name, CHECK_NULL);
1371       }
1372       int cp_size = cp->length();
1373       guarantee_property(
1374         valid_cp_range(name_index, cp_size) &&
1375           cp->tag_at(name_index).is_utf8(),
1376         "Name index %u in %s has bad constant type in class file %s",
1377         name_index, tbl_name, CHECK_NULL);
1378       guarantee_property(
1379         valid_cp_range(descriptor_index, cp_size) &&
1380           cp->tag_at(descriptor_index).is_utf8(),
1381         "Signature index %u in %s has bad constant type in class file %s",
1382         descriptor_index, tbl_name, CHECK_NULL);
1383 
1384       symbolHandle name(THREAD, cp->symbol_at(name_index));
1385       symbolHandle sig(THREAD, cp->symbol_at(descriptor_index));
1386       verify_legal_field_name(name, CHECK_NULL);
1387       u2 extra_slot = 0;
1388       if (!isLVTT) {
1389         verify_legal_field_signature(name, sig, CHECK_NULL);
1390 
1391         // 4894874: check special cases for double and long local variables
1392         if (sig() == vmSymbols::type_signature(T_DOUBLE) ||
1393             sig() == vmSymbols::type_signature(T_LONG)) {
1394           extra_slot = 1;
1395         }
1396       }
1397       guarantee_property((index + extra_slot) < max_locals,
1398                           "Invalid index %u in %s in class file %s",
1399                           index, tbl_name, CHECK_NULL);
1400     }
1401   }
1402   return localvariable_table_start;
1403 }
1404 
1405 
1406 void ClassFileParser::parse_type_array(u2 array_length, u4 code_length, u4* u1_index, u4* u2_index,
1407                                       u1* u1_array, u2* u2_array, constantPoolHandle cp, TRAPS) {
1408   ClassFileStream* cfs = stream();
1409   u2 index = 0; // index in the array with long/double occupying two slots
1410   u4 i1 = *u1_index;
1411   u4 i2 = *u2_index + 1;
1412   for(int i = 0; i < array_length; i++) {
1413     u1 tag = u1_array[i1++] = cfs->get_u1(CHECK);
1414     index++;
1415     if (tag == ITEM_Long || tag == ITEM_Double) {
1416       index++;
1417     } else if (tag == ITEM_Object) {
1418       u2 class_index = u2_array[i2++] = cfs->get_u2(CHECK);
1419       guarantee_property(valid_cp_range(class_index, cp->length()) &&
1420                          is_klass_reference(cp, class_index),
1421                          "Bad class index %u in StackMap in class file %s",
1422                          class_index, CHECK);
1423     } else if (tag == ITEM_Uninitialized) {
1424       u2 offset = u2_array[i2++] = cfs->get_u2(CHECK);
1425       guarantee_property(
1426         offset < code_length,
1427         "Bad uninitialized type offset %u in StackMap in class file %s",
1428         offset, CHECK);
1429     } else {
1430       guarantee_property(
1431         tag <= (u1)ITEM_Uninitialized,
1432         "Unknown variable type %u in StackMap in class file %s",
1433         tag, CHECK);
1434     }
1435   }
1436   u2_array[*u2_index] = index;
1437   *u1_index = i1;
1438   *u2_index = i2;
1439 }
1440 
1441 typeArrayOop ClassFileParser::parse_stackmap_table(
1442     u4 code_attribute_length, TRAPS) {
1443   if (code_attribute_length == 0)
1444     return NULL;
1445 
1446   ClassFileStream* cfs = stream();
1447   u1* stackmap_table_start = cfs->get_u1_buffer();
1448   assert(stackmap_table_start != NULL, "null stackmap table");
1449 
1450   // check code_attribute_length first
1451   stream()->skip_u1(code_attribute_length, CHECK_NULL);
1452 
1453   if (!_need_verify && !DumpSharedSpaces) {
1454     return NULL;
1455   }
1456 
1457   typeArrayOop stackmap_data =
1458     oopFactory::new_permanent_byteArray(code_attribute_length, CHECK_NULL);
1459 
1460   stackmap_data->set_length(code_attribute_length);
1461   memcpy((void*)stackmap_data->byte_at_addr(0),
1462          (void*)stackmap_table_start, code_attribute_length);
1463   return stackmap_data;
1464 }
1465 
1466 u2* ClassFileParser::parse_checked_exceptions(u2* checked_exceptions_length,
1467                                               u4 method_attribute_length,
1468                                               constantPoolHandle cp, TRAPS) {
1469   ClassFileStream* cfs = stream();
1470   cfs->guarantee_more(2, CHECK_NULL);  // checked_exceptions_length
1471   *checked_exceptions_length = cfs->get_u2_fast();
1472   unsigned int size = (*checked_exceptions_length) * sizeof(CheckedExceptionElement) / sizeof(u2);
1473   u2* checked_exceptions_start = cfs->get_u2_buffer();
1474   assert(checked_exceptions_start != NULL, "null checked exceptions");
1475   if (!_need_verify) {
1476     cfs->skip_u2_fast(size);
1477   } else {
1478     // Verify each value in the checked exception table
1479     u2 checked_exception;
1480     u2 len = *checked_exceptions_length;
1481     cfs->guarantee_more(2 * len, CHECK_NULL);
1482     for (int i = 0; i < len; i++) {
1483       checked_exception = cfs->get_u2_fast();
1484       check_property(
1485         valid_cp_range(checked_exception, cp->length()) &&
1486         is_klass_reference(cp, checked_exception),
1487         "Exception name has bad type at constant pool %u in class file %s",
1488         checked_exception, CHECK_NULL);
1489     }
1490   }
1491   // check exceptions attribute length
1492   if (_need_verify) {
1493     guarantee_property(method_attribute_length == (sizeof(*checked_exceptions_length) +
1494                                                    sizeof(u2) * size),
1495                       "Exceptions attribute has wrong length in class file %s", CHECK_NULL);
1496   }
1497   return checked_exceptions_start;
1498 }
1499 
1500 void ClassFileParser::throwIllegalSignature(
1501     const char* type, symbolHandle name, symbolHandle sig, TRAPS) {
1502   ResourceMark rm(THREAD);
1503   Exceptions::fthrow(THREAD_AND_LOCATION,
1504       vmSymbols::java_lang_ClassFormatError(),
1505       "%s \"%s\" in class %s has illegal signature \"%s\"", type,
1506       name->as_C_string(), _class_name->as_C_string(), sig->as_C_string());
1507 }
1508 
1509 #define MAX_ARGS_SIZE 255
1510 #define MAX_CODE_SIZE 65535
1511 #define INITIAL_MAX_LVT_NUMBER 256
1512 
1513 // Note: the parse_method below is big and clunky because all parsing of the code and exceptions
1514 // attribute is inlined. This is curbersome to avoid since we inline most of the parts in the
1515 // methodOop to save footprint, so we only know the size of the resulting methodOop when the
1516 // entire method attribute is parsed.
1517 //
1518 // The promoted_flags parameter is used to pass relevant access_flags
1519 // from the method back up to the containing klass. These flag values
1520 // are added to klass's access_flags.
1521 
1522 methodHandle ClassFileParser::parse_method(constantPoolHandle cp, bool is_interface,
1523                                            AccessFlags *promoted_flags,
1524                                            typeArrayHandle* method_annotations,
1525                                            typeArrayHandle* method_parameter_annotations,
1526                                            typeArrayHandle* method_default_annotations,
1527                                            TRAPS) {
1528   ClassFileStream* cfs = stream();
1529   methodHandle nullHandle;
1530   ResourceMark rm(THREAD);
1531   // Parse fixed parts
1532   cfs->guarantee_more(8, CHECK_(nullHandle)); // access_flags, name_index, descriptor_index, attributes_count
1533 
1534   int flags = cfs->get_u2_fast();
1535   u2 name_index = cfs->get_u2_fast();
1536   int cp_size = cp->length();
1537   check_property(
1538     valid_cp_range(name_index, cp_size) &&
1539       cp->tag_at(name_index).is_utf8(),
1540     "Illegal constant pool index %u for method name in class file %s",
1541     name_index, CHECK_(nullHandle));
1542   symbolHandle name(THREAD, cp->symbol_at(name_index));
1543   verify_legal_method_name(name, CHECK_(nullHandle));
1544 
1545   u2 signature_index = cfs->get_u2_fast();
1546   guarantee_property(
1547     valid_cp_range(signature_index, cp_size) &&
1548       cp->tag_at(signature_index).is_utf8(),
1549     "Illegal constant pool index %u for method signature in class file %s",
1550     signature_index, CHECK_(nullHandle));
1551   symbolHandle signature(THREAD, cp->symbol_at(signature_index));
1552 
1553   AccessFlags access_flags;
1554   if (name == vmSymbols::class_initializer_name()) {
1555     // We ignore the access flags for a class initializer. (JVM Spec. p. 116)
1556     flags = JVM_ACC_STATIC;
1557   } else {
1558     verify_legal_method_modifiers(flags, is_interface, name, CHECK_(nullHandle));
1559   }
1560 
1561   int args_size = -1;  // only used when _need_verify is true
1562   if (_need_verify) {
1563     args_size = ((flags & JVM_ACC_STATIC) ? 0 : 1) +
1564                  verify_legal_method_signature(name, signature, CHECK_(nullHandle));
1565     if (args_size > MAX_ARGS_SIZE) {
1566       classfile_parse_error("Too many arguments in method signature in class file %s", CHECK_(nullHandle));
1567     }
1568   }
1569 
1570   access_flags.set_flags(flags & JVM_RECOGNIZED_METHOD_MODIFIERS);
1571 
1572   // Default values for code and exceptions attribute elements
1573   u2 max_stack = 0;
1574   u2 max_locals = 0;
1575   u4 code_length = 0;
1576   u1* code_start = 0;
1577   u2 exception_table_length = 0;
1578   typeArrayHandle exception_handlers(THREAD, Universe::the_empty_int_array());
1579   u2 checked_exceptions_length = 0;
1580   u2* checked_exceptions_start = NULL;
1581   CompressedLineNumberWriteStream* linenumber_table = NULL;
1582   int linenumber_table_length = 0;
1583   int total_lvt_length = 0;
1584   u2 lvt_cnt = 0;
1585   u2 lvtt_cnt = 0;
1586   bool lvt_allocated = false;
1587   u2 max_lvt_cnt = INITIAL_MAX_LVT_NUMBER;
1588   u2 max_lvtt_cnt = INITIAL_MAX_LVT_NUMBER;
1589   u2* localvariable_table_length;
1590   u2** localvariable_table_start;
1591   u2* localvariable_type_table_length;
1592   u2** localvariable_type_table_start;
1593   bool parsed_code_attribute = false;
1594   bool parsed_checked_exceptions_attribute = false;
1595   bool parsed_stackmap_attribute = false;
1596   // stackmap attribute - JDK1.5
1597   typeArrayHandle stackmap_data;
1598   u2 generic_signature_index = 0;
1599   u1* runtime_visible_annotations = NULL;
1600   int runtime_visible_annotations_length = 0;
1601   u1* runtime_invisible_annotations = NULL;
1602   int runtime_invisible_annotations_length = 0;
1603   u1* runtime_visible_parameter_annotations = NULL;
1604   int runtime_visible_parameter_annotations_length = 0;
1605   u1* runtime_invisible_parameter_annotations = NULL;
1606   int runtime_invisible_parameter_annotations_length = 0;
1607   u1* annotation_default = NULL;
1608   int annotation_default_length = 0;
1609 
1610   // Parse code and exceptions attribute
1611   u2 method_attributes_count = cfs->get_u2_fast();
1612   while (method_attributes_count--) {
1613     cfs->guarantee_more(6, CHECK_(nullHandle));  // method_attribute_name_index, method_attribute_length
1614     u2 method_attribute_name_index = cfs->get_u2_fast();
1615     u4 method_attribute_length = cfs->get_u4_fast();
1616     check_property(
1617       valid_cp_range(method_attribute_name_index, cp_size) &&
1618         cp->tag_at(method_attribute_name_index).is_utf8(),
1619       "Invalid method attribute name index %u in class file %s",
1620       method_attribute_name_index, CHECK_(nullHandle));
1621 
1622     symbolOop method_attribute_name = cp->symbol_at(method_attribute_name_index);
1623     if (method_attribute_name == vmSymbols::tag_code()) {
1624       // Parse Code attribute
1625       if (_need_verify) {
1626         guarantee_property(!access_flags.is_native() && !access_flags.is_abstract(),
1627                         "Code attribute in native or abstract methods in class file %s",
1628                          CHECK_(nullHandle));
1629       }
1630       if (parsed_code_attribute) {
1631         classfile_parse_error("Multiple Code attributes in class file %s", CHECK_(nullHandle));
1632       }
1633       parsed_code_attribute = true;
1634 
1635       // Stack size, locals size, and code size
1636       if (_major_version == 45 && _minor_version <= 2) {
1637         cfs->guarantee_more(4, CHECK_(nullHandle));
1638         max_stack = cfs->get_u1_fast();
1639         max_locals = cfs->get_u1_fast();
1640         code_length = cfs->get_u2_fast();
1641       } else {
1642         cfs->guarantee_more(8, CHECK_(nullHandle));
1643         max_stack = cfs->get_u2_fast();
1644         max_locals = cfs->get_u2_fast();
1645         code_length = cfs->get_u4_fast();
1646       }
1647       if (_need_verify) {
1648         guarantee_property(args_size <= max_locals,
1649                            "Arguments can't fit into locals in class file %s", CHECK_(nullHandle));
1650         guarantee_property(code_length > 0 && code_length <= MAX_CODE_SIZE,
1651                            "Invalid method Code length %u in class file %s",
1652                            code_length, CHECK_(nullHandle));
1653       }
1654       // Code pointer
1655       code_start = cfs->get_u1_buffer();
1656       assert(code_start != NULL, "null code start");
1657       cfs->guarantee_more(code_length, CHECK_(nullHandle));
1658       cfs->skip_u1_fast(code_length);
1659 
1660       // Exception handler table
1661       cfs->guarantee_more(2, CHECK_(nullHandle));  // exception_table_length
1662       exception_table_length = cfs->get_u2_fast();
1663       if (exception_table_length > 0) {
1664         exception_handlers =
1665               parse_exception_table(code_length, exception_table_length, cp, CHECK_(nullHandle));
1666       }
1667 
1668       // Parse additional attributes in code attribute
1669       cfs->guarantee_more(2, CHECK_(nullHandle));  // code_attributes_count
1670       u2 code_attributes_count = cfs->get_u2_fast();
1671 
1672       unsigned int calculated_attribute_length = 0;
1673 
1674       if (_major_version > 45 || (_major_version == 45 && _minor_version > 2)) {
1675         calculated_attribute_length =
1676             sizeof(max_stack) + sizeof(max_locals) + sizeof(code_length);
1677       } else {
1678         // max_stack, locals and length are smaller in pre-version 45.2 classes
1679         calculated_attribute_length = sizeof(u1) + sizeof(u1) + sizeof(u2);
1680       }
1681       calculated_attribute_length +=
1682         code_length +
1683         sizeof(exception_table_length) +
1684         sizeof(code_attributes_count) +
1685         exception_table_length *
1686             ( sizeof(u2) +   // start_pc
1687               sizeof(u2) +   // end_pc
1688               sizeof(u2) +   // handler_pc
1689               sizeof(u2) );  // catch_type_index
1690 
1691       while (code_attributes_count--) {
1692         cfs->guarantee_more(6, CHECK_(nullHandle));  // code_attribute_name_index, code_attribute_length
1693         u2 code_attribute_name_index = cfs->get_u2_fast();
1694         u4 code_attribute_length = cfs->get_u4_fast();
1695         calculated_attribute_length += code_attribute_length +
1696                                        sizeof(code_attribute_name_index) +
1697                                        sizeof(code_attribute_length);
1698         check_property(valid_cp_range(code_attribute_name_index, cp_size) &&
1699                        cp->tag_at(code_attribute_name_index).is_utf8(),
1700                        "Invalid code attribute name index %u in class file %s",
1701                        code_attribute_name_index,
1702                        CHECK_(nullHandle));
1703         if (LoadLineNumberTables &&
1704             cp->symbol_at(code_attribute_name_index) == vmSymbols::tag_line_number_table()) {
1705           // Parse and compress line number table
1706           parse_linenumber_table(code_attribute_length, code_length,
1707             &linenumber_table, CHECK_(nullHandle));
1708 
1709         } else if (LoadLocalVariableTables &&
1710                    cp->symbol_at(code_attribute_name_index) == vmSymbols::tag_local_variable_table()) {
1711           // Parse local variable table
1712           if (!lvt_allocated) {
1713             localvariable_table_length = NEW_RESOURCE_ARRAY_IN_THREAD(
1714               THREAD, u2,  INITIAL_MAX_LVT_NUMBER);
1715             localvariable_table_start = NEW_RESOURCE_ARRAY_IN_THREAD(
1716               THREAD, u2*, INITIAL_MAX_LVT_NUMBER);
1717             localvariable_type_table_length = NEW_RESOURCE_ARRAY_IN_THREAD(
1718               THREAD, u2,  INITIAL_MAX_LVT_NUMBER);
1719             localvariable_type_table_start = NEW_RESOURCE_ARRAY_IN_THREAD(
1720               THREAD, u2*, INITIAL_MAX_LVT_NUMBER);
1721             lvt_allocated = true;
1722           }
1723           if (lvt_cnt == max_lvt_cnt) {
1724             max_lvt_cnt <<= 1;
1725             REALLOC_RESOURCE_ARRAY(u2, localvariable_table_length, lvt_cnt, max_lvt_cnt);
1726             REALLOC_RESOURCE_ARRAY(u2*, localvariable_table_start, lvt_cnt, max_lvt_cnt);
1727           }
1728           localvariable_table_start[lvt_cnt] =
1729             parse_localvariable_table(code_length,
1730                                       max_locals,
1731                                       code_attribute_length,
1732                                       cp,
1733                                       &localvariable_table_length[lvt_cnt],
1734                                       false,    // is not LVTT
1735                                       CHECK_(nullHandle));
1736           total_lvt_length += localvariable_table_length[lvt_cnt];
1737           lvt_cnt++;
1738         } else if (LoadLocalVariableTypeTables &&
1739                    _major_version >= JAVA_1_5_VERSION &&
1740                    cp->symbol_at(code_attribute_name_index) == vmSymbols::tag_local_variable_type_table()) {
1741           if (!lvt_allocated) {
1742             localvariable_table_length = NEW_RESOURCE_ARRAY_IN_THREAD(
1743               THREAD, u2,  INITIAL_MAX_LVT_NUMBER);
1744             localvariable_table_start = NEW_RESOURCE_ARRAY_IN_THREAD(
1745               THREAD, u2*, INITIAL_MAX_LVT_NUMBER);
1746             localvariable_type_table_length = NEW_RESOURCE_ARRAY_IN_THREAD(
1747               THREAD, u2,  INITIAL_MAX_LVT_NUMBER);
1748             localvariable_type_table_start = NEW_RESOURCE_ARRAY_IN_THREAD(
1749               THREAD, u2*, INITIAL_MAX_LVT_NUMBER);
1750             lvt_allocated = true;
1751           }
1752           // Parse local variable type table
1753           if (lvtt_cnt == max_lvtt_cnt) {
1754             max_lvtt_cnt <<= 1;
1755             REALLOC_RESOURCE_ARRAY(u2, localvariable_type_table_length, lvtt_cnt, max_lvtt_cnt);
1756             REALLOC_RESOURCE_ARRAY(u2*, localvariable_type_table_start, lvtt_cnt, max_lvtt_cnt);
1757           }
1758           localvariable_type_table_start[lvtt_cnt] =
1759             parse_localvariable_table(code_length,
1760                                       max_locals,
1761                                       code_attribute_length,
1762                                       cp,
1763                                       &localvariable_type_table_length[lvtt_cnt],
1764                                       true,     // is LVTT
1765                                       CHECK_(nullHandle));
1766           lvtt_cnt++;
1767         } else if (UseSplitVerifier &&
1768                    _major_version >= Verifier::STACKMAP_ATTRIBUTE_MAJOR_VERSION &&
1769                    cp->symbol_at(code_attribute_name_index) == vmSymbols::tag_stack_map_table()) {
1770           // Stack map is only needed by the new verifier in JDK1.5.
1771           if (parsed_stackmap_attribute) {
1772             classfile_parse_error("Multiple StackMapTable attributes in class file %s", CHECK_(nullHandle));
1773           }
1774           typeArrayOop sm =
1775             parse_stackmap_table(code_attribute_length, CHECK_(nullHandle));
1776           stackmap_data = typeArrayHandle(THREAD, sm);
1777           parsed_stackmap_attribute = true;
1778         } else {
1779           // Skip unknown attributes
1780           cfs->skip_u1(code_attribute_length, CHECK_(nullHandle));
1781         }
1782       }
1783       // check method attribute length
1784       if (_need_verify) {
1785         guarantee_property(method_attribute_length == calculated_attribute_length,
1786                            "Code segment has wrong length in class file %s", CHECK_(nullHandle));
1787       }
1788     } else if (method_attribute_name == vmSymbols::tag_exceptions()) {
1789       // Parse Exceptions attribute
1790       if (parsed_checked_exceptions_attribute) {
1791         classfile_parse_error("Multiple Exceptions attributes in class file %s", CHECK_(nullHandle));
1792       }
1793       parsed_checked_exceptions_attribute = true;
1794       checked_exceptions_start =
1795             parse_checked_exceptions(&checked_exceptions_length,
1796                                      method_attribute_length,
1797                                      cp, CHECK_(nullHandle));
1798     } else if (method_attribute_name == vmSymbols::tag_synthetic()) {
1799       if (method_attribute_length != 0) {
1800         classfile_parse_error(
1801           "Invalid Synthetic method attribute length %u in class file %s",
1802           method_attribute_length, CHECK_(nullHandle));
1803       }
1804       // Should we check that there hasn't already been a synthetic attribute?
1805       access_flags.set_is_synthetic();
1806     } else if (method_attribute_name == vmSymbols::tag_deprecated()) { // 4276120
1807       if (method_attribute_length != 0) {
1808         classfile_parse_error(
1809           "Invalid Deprecated method attribute length %u in class file %s",
1810           method_attribute_length, CHECK_(nullHandle));
1811       }
1812     } else if (_major_version >= JAVA_1_5_VERSION) {
1813       if (method_attribute_name == vmSymbols::tag_signature()) {
1814         if (method_attribute_length != 2) {
1815           classfile_parse_error(
1816             "Invalid Signature attribute length %u in class file %s",
1817             method_attribute_length, CHECK_(nullHandle));
1818         }
1819         cfs->guarantee_more(2, CHECK_(nullHandle));  // generic_signature_index
1820         generic_signature_index = cfs->get_u2_fast();
1821       } else if (method_attribute_name == vmSymbols::tag_runtime_visible_annotations()) {
1822         runtime_visible_annotations_length = method_attribute_length;
1823         runtime_visible_annotations = cfs->get_u1_buffer();
1824         assert(runtime_visible_annotations != NULL, "null visible annotations");
1825         cfs->skip_u1(runtime_visible_annotations_length, CHECK_(nullHandle));
1826       } else if (PreserveAllAnnotations && method_attribute_name == vmSymbols::tag_runtime_invisible_annotations()) {
1827         runtime_invisible_annotations_length = method_attribute_length;
1828         runtime_invisible_annotations = cfs->get_u1_buffer();
1829         assert(runtime_invisible_annotations != NULL, "null invisible annotations");
1830         cfs->skip_u1(runtime_invisible_annotations_length, CHECK_(nullHandle));
1831       } else if (method_attribute_name == vmSymbols::tag_runtime_visible_parameter_annotations()) {
1832         runtime_visible_parameter_annotations_length = method_attribute_length;
1833         runtime_visible_parameter_annotations = cfs->get_u1_buffer();
1834         assert(runtime_visible_parameter_annotations != NULL, "null visible parameter annotations");
1835         cfs->skip_u1(runtime_visible_parameter_annotations_length, CHECK_(nullHandle));
1836       } else if (PreserveAllAnnotations && method_attribute_name == vmSymbols::tag_runtime_invisible_parameter_annotations()) {
1837         runtime_invisible_parameter_annotations_length = method_attribute_length;
1838         runtime_invisible_parameter_annotations = cfs->get_u1_buffer();
1839         assert(runtime_invisible_parameter_annotations != NULL, "null invisible parameter annotations");
1840         cfs->skip_u1(runtime_invisible_parameter_annotations_length, CHECK_(nullHandle));
1841       } else if (method_attribute_name == vmSymbols::tag_annotation_default()) {
1842         annotation_default_length = method_attribute_length;
1843         annotation_default = cfs->get_u1_buffer();
1844         assert(annotation_default != NULL, "null annotation default");
1845         cfs->skip_u1(annotation_default_length, CHECK_(nullHandle));
1846       } else {
1847         // Skip unknown attributes
1848         cfs->skip_u1(method_attribute_length, CHECK_(nullHandle));
1849       }
1850     } else {
1851       // Skip unknown attributes
1852       cfs->skip_u1(method_attribute_length, CHECK_(nullHandle));
1853     }
1854   }
1855 
1856   if (linenumber_table != NULL) {
1857     linenumber_table->write_terminator();
1858     linenumber_table_length = linenumber_table->position();
1859   }
1860 
1861   // Make sure there's at least one Code attribute in non-native/non-abstract method
1862   if (_need_verify) {
1863     guarantee_property(access_flags.is_native() || access_flags.is_abstract() || parsed_code_attribute,
1864                       "Absent Code attribute in method that is not native or abstract in class file %s", CHECK_(nullHandle));
1865   }
1866 
1867   // All sizing information for a methodOop is finally available, now create it
1868   methodOop m_oop  = oopFactory::new_method(
1869     code_length, access_flags, linenumber_table_length,
1870     total_lvt_length, checked_exceptions_length,
1871     methodOopDesc::IsSafeConc, CHECK_(nullHandle));
1872   methodHandle m (THREAD, m_oop);
1873 
1874   ClassLoadingService::add_class_method_size(m_oop->size()*HeapWordSize);
1875 
1876   // Fill in information from fixed part (access_flags already set)
1877   m->set_constants(cp());
1878   m->set_name_index(name_index);
1879   m->set_signature_index(signature_index);
1880   m->set_generic_signature_index(generic_signature_index);
1881 #ifdef CC_INTERP
1882   // hmm is there a gc issue here??
1883   ResultTypeFinder rtf(cp->symbol_at(signature_index));
1884   m->set_result_index(rtf.type());
1885 #endif
1886 
1887   if (args_size >= 0) {
1888     m->set_size_of_parameters(args_size);
1889   } else {
1890     m->compute_size_of_parameters(THREAD);
1891   }
1892 #ifdef ASSERT
1893   if (args_size >= 0) {
1894     m->compute_size_of_parameters(THREAD);
1895     assert(args_size == m->size_of_parameters(), "");
1896   }
1897 #endif
1898 
1899   // Fill in code attribute information
1900   m->set_max_stack(max_stack);
1901   m->set_max_locals(max_locals);
1902   m->constMethod()->set_stackmap_data(stackmap_data());
1903 
1904   /**
1905    * The exception_table field is the flag used to indicate
1906    * that the methodOop and it's associated constMethodOop are partially
1907    * initialized and thus are exempt from pre/post GC verification.  Once
1908    * the field is set, the oops are considered fully initialized so make
1909    * sure that the oops can pass verification when this field is set.
1910    */
1911   m->set_exception_table(exception_handlers());
1912 
1913   // Copy byte codes
1914   m->set_code(code_start);
1915 
1916   // Copy line number table
1917   if (linenumber_table != NULL) {
1918     memcpy(m->compressed_linenumber_table(),
1919            linenumber_table->buffer(), linenumber_table_length);
1920   }
1921 
1922   // Copy checked exceptions
1923   if (checked_exceptions_length > 0) {
1924     int size = checked_exceptions_length * sizeof(CheckedExceptionElement) / sizeof(u2);
1925     copy_u2_with_conversion((u2*) m->checked_exceptions_start(), checked_exceptions_start, size);
1926   }
1927 
1928   /* Copy class file LVT's/LVTT's into the HotSpot internal LVT.
1929    *
1930    * Rules for LVT's and LVTT's are:
1931    *   - There can be any number of LVT's and LVTT's.
1932    *   - If there are n LVT's, it is the same as if there was just
1933    *     one LVT containing all the entries from the n LVT's.
1934    *   - There may be no more than one LVT entry per local variable.
1935    *     Two LVT entries are 'equal' if these fields are the same:
1936    *        start_pc, length, name, slot
1937    *   - There may be no more than one LVTT entry per each LVT entry.
1938    *     Each LVTT entry has to match some LVT entry.
1939    *   - HotSpot internal LVT keeps natural ordering of class file LVT entries.
1940    */
1941   if (total_lvt_length > 0) {
1942     int tbl_no, idx;
1943 
1944     promoted_flags->set_has_localvariable_table();
1945 
1946     LVT_Hash** lvt_Hash = NEW_RESOURCE_ARRAY(LVT_Hash*, HASH_ROW_SIZE);
1947     initialize_hashtable(lvt_Hash);
1948 
1949     // To fill LocalVariableTable in
1950     Classfile_LVT_Element*  cf_lvt;
1951     LocalVariableTableElement* lvt = m->localvariable_table_start();
1952 
1953     for (tbl_no = 0; tbl_no < lvt_cnt; tbl_no++) {
1954       cf_lvt = (Classfile_LVT_Element *) localvariable_table_start[tbl_no];
1955       for (idx = 0; idx < localvariable_table_length[tbl_no]; idx++, lvt++) {
1956         copy_lvt_element(&cf_lvt[idx], lvt);
1957         // If no duplicates, add LVT elem in hashtable lvt_Hash.
1958         if (LVT_put_after_lookup(lvt, lvt_Hash) == false
1959           && _need_verify
1960           && _major_version >= JAVA_1_5_VERSION ) {
1961           clear_hashtable(lvt_Hash);
1962           classfile_parse_error("Duplicated LocalVariableTable attribute "
1963                                 "entry for '%s' in class file %s",
1964                                  cp->symbol_at(lvt->name_cp_index)->as_utf8(),
1965                                  CHECK_(nullHandle));
1966         }
1967       }
1968     }
1969 
1970     // To merge LocalVariableTable and LocalVariableTypeTable
1971     Classfile_LVT_Element* cf_lvtt;
1972     LocalVariableTableElement lvtt_elem;
1973 
1974     for (tbl_no = 0; tbl_no < lvtt_cnt; tbl_no++) {
1975       cf_lvtt = (Classfile_LVT_Element *) localvariable_type_table_start[tbl_no];
1976       for (idx = 0; idx < localvariable_type_table_length[tbl_no]; idx++) {
1977         copy_lvt_element(&cf_lvtt[idx], &lvtt_elem);
1978         int index = hash(&lvtt_elem);
1979         LVT_Hash* entry = LVT_lookup(&lvtt_elem, index, lvt_Hash);
1980         if (entry == NULL) {
1981           if (_need_verify) {
1982             clear_hashtable(lvt_Hash);
1983             classfile_parse_error("LVTT entry for '%s' in class file %s "
1984                                   "does not match any LVT entry",
1985                                    cp->symbol_at(lvtt_elem.name_cp_index)->as_utf8(),
1986                                    CHECK_(nullHandle));
1987           }
1988         } else if (entry->_elem->signature_cp_index != 0 && _need_verify) {
1989           clear_hashtable(lvt_Hash);
1990           classfile_parse_error("Duplicated LocalVariableTypeTable attribute "
1991                                 "entry for '%s' in class file %s",
1992                                  cp->symbol_at(lvtt_elem.name_cp_index)->as_utf8(),
1993                                  CHECK_(nullHandle));
1994         } else {
1995           // to add generic signatures into LocalVariableTable
1996           entry->_elem->signature_cp_index = lvtt_elem.descriptor_cp_index;
1997         }
1998       }
1999     }
2000     clear_hashtable(lvt_Hash);
2001   }
2002 
2003   *method_annotations = assemble_annotations(runtime_visible_annotations,
2004                                              runtime_visible_annotations_length,
2005                                              runtime_invisible_annotations,
2006                                              runtime_invisible_annotations_length,
2007                                              CHECK_(nullHandle));
2008   *method_parameter_annotations = assemble_annotations(runtime_visible_parameter_annotations,
2009                                                        runtime_visible_parameter_annotations_length,
2010                                                        runtime_invisible_parameter_annotations,
2011                                                        runtime_invisible_parameter_annotations_length,
2012                                                        CHECK_(nullHandle));
2013   *method_default_annotations = assemble_annotations(annotation_default,
2014                                                      annotation_default_length,
2015                                                      NULL,
2016                                                      0,
2017                                                      CHECK_(nullHandle));
2018 
2019   if (name() == vmSymbols::finalize_method_name() &&
2020       signature() == vmSymbols::void_method_signature()) {
2021     if (m->is_empty_method()) {
2022       _has_empty_finalizer = true;
2023     } else {
2024       _has_finalizer = true;
2025     }
2026   }
2027   if (name() == vmSymbols::object_initializer_name() &&
2028       signature() == vmSymbols::void_method_signature() &&
2029       m->is_vanilla_constructor()) {
2030     _has_vanilla_constructor = true;
2031   }
2032 
2033   if (EnableMethodHandles && (m->is_method_handle_invoke() ||
2034                               m->is_method_handle_adapter())) {
2035     THROW_MSG_(vmSymbols::java_lang_VirtualMachineError(),
2036                "Method handle invokers must be defined internally to the VM", nullHandle);
2037   }
2038 
2039   return m;
2040 }
2041 
2042 
2043 // The promoted_flags parameter is used to pass relevant access_flags
2044 // from the methods back up to the containing klass. These flag values
2045 // are added to klass's access_flags.
2046 
2047 objArrayHandle ClassFileParser::parse_methods(constantPoolHandle cp, bool is_interface,
2048                                               AccessFlags* promoted_flags,
2049                                               bool* has_final_method,
2050                                               objArrayOop* methods_annotations_oop,
2051                                               objArrayOop* methods_parameter_annotations_oop,
2052                                               objArrayOop* methods_default_annotations_oop,
2053                                               TRAPS) {
2054   ClassFileStream* cfs = stream();
2055   objArrayHandle nullHandle;
2056   typeArrayHandle method_annotations;
2057   typeArrayHandle method_parameter_annotations;
2058   typeArrayHandle method_default_annotations;
2059   cfs->guarantee_more(2, CHECK_(nullHandle));  // length
2060   u2 length = cfs->get_u2_fast();
2061   if (length == 0) {
2062     return objArrayHandle(THREAD, Universe::the_empty_system_obj_array());
2063   } else {
2064     objArrayOop m = oopFactory::new_system_objArray(length, CHECK_(nullHandle));
2065     objArrayHandle methods(THREAD, m);
2066     HandleMark hm(THREAD);
2067     objArrayHandle methods_annotations;
2068     objArrayHandle methods_parameter_annotations;
2069     objArrayHandle methods_default_annotations;
2070     for (int index = 0; index < length; index++) {
2071       methodHandle method = parse_method(cp, is_interface,
2072                                          promoted_flags,
2073                                          &method_annotations,
2074                                          &method_parameter_annotations,
2075                                          &method_default_annotations,
2076                                          CHECK_(nullHandle));
2077       if (method->is_final()) {
2078         *has_final_method = true;
2079       }
2080       methods->obj_at_put(index, method());
2081       if (method_annotations.not_null()) {
2082         if (methods_annotations.is_null()) {
2083           objArrayOop md = oopFactory::new_system_objArray(length, CHECK_(nullHandle));
2084           methods_annotations = objArrayHandle(THREAD, md);
2085         }
2086         methods_annotations->obj_at_put(index, method_annotations());
2087       }
2088       if (method_parameter_annotations.not_null()) {
2089         if (methods_parameter_annotations.is_null()) {
2090           objArrayOop md = oopFactory::new_system_objArray(length, CHECK_(nullHandle));
2091           methods_parameter_annotations = objArrayHandle(THREAD, md);
2092         }
2093         methods_parameter_annotations->obj_at_put(index, method_parameter_annotations());
2094       }
2095       if (method_default_annotations.not_null()) {
2096         if (methods_default_annotations.is_null()) {
2097           objArrayOop md = oopFactory::new_system_objArray(length, CHECK_(nullHandle));
2098           methods_default_annotations = objArrayHandle(THREAD, md);
2099         }
2100         methods_default_annotations->obj_at_put(index, method_default_annotations());
2101       }
2102     }
2103     if (_need_verify && length > 1) {
2104       // Check duplicated methods
2105       ResourceMark rm(THREAD);
2106       NameSigHash** names_and_sigs = NEW_RESOURCE_ARRAY_IN_THREAD(
2107         THREAD, NameSigHash*, HASH_ROW_SIZE);
2108       initialize_hashtable(names_and_sigs);
2109       bool dup = false;
2110       {
2111         debug_only(No_Safepoint_Verifier nsv;)
2112         for (int i = 0; i < length; i++) {
2113           methodOop m = (methodOop)methods->obj_at(i);
2114           // If no duplicates, add name/signature in hashtable names_and_sigs.
2115           if (!put_after_lookup(m->name(), m->signature(), names_and_sigs)) {
2116             dup = true;
2117             break;
2118           }
2119         }
2120       }
2121       if (dup) {
2122         classfile_parse_error("Duplicate method name&signature in class file %s",
2123                               CHECK_(nullHandle));
2124       }
2125     }
2126 
2127     *methods_annotations_oop = methods_annotations();
2128     *methods_parameter_annotations_oop = methods_parameter_annotations();
2129     *methods_default_annotations_oop = methods_default_annotations();
2130 
2131     return methods;
2132   }
2133 }
2134 
2135 
2136 typeArrayHandle ClassFileParser::sort_methods(objArrayHandle methods,
2137                                               objArrayHandle methods_annotations,
2138                                               objArrayHandle methods_parameter_annotations,
2139                                               objArrayHandle methods_default_annotations,
2140                                               TRAPS) {
2141   typeArrayHandle nullHandle;
2142   int length = methods()->length();
2143   // If JVMTI original method ordering is enabled we have to
2144   // remember the original class file ordering.
2145   // We temporarily use the vtable_index field in the methodOop to store the
2146   // class file index, so we can read in after calling qsort.
2147   if (JvmtiExport::can_maintain_original_method_order()) {
2148     for (int index = 0; index < length; index++) {
2149       methodOop m = methodOop(methods->obj_at(index));
2150       assert(!m->valid_vtable_index(), "vtable index should not be set");
2151       m->set_vtable_index(index);
2152     }
2153   }
2154   // Sort method array by ascending method name (for faster lookups & vtable construction)
2155   // Note that the ordering is not alphabetical, see symbolOopDesc::fast_compare
2156   methodOopDesc::sort_methods(methods(),
2157                               methods_annotations(),
2158                               methods_parameter_annotations(),
2159                               methods_default_annotations());
2160 
2161   // If JVMTI original method ordering is enabled construct int array remembering the original ordering
2162   if (JvmtiExport::can_maintain_original_method_order()) {
2163     typeArrayOop new_ordering = oopFactory::new_permanent_intArray(length, CHECK_(nullHandle));
2164     typeArrayHandle method_ordering(THREAD, new_ordering);
2165     for (int index = 0; index < length; index++) {
2166       methodOop m = methodOop(methods->obj_at(index));
2167       int old_index = m->vtable_index();
2168       assert(old_index >= 0 && old_index < length, "invalid method index");
2169       method_ordering->int_at_put(index, old_index);
2170       m->set_vtable_index(methodOopDesc::invalid_vtable_index);
2171     }
2172     return method_ordering;
2173   } else {
2174     return typeArrayHandle(THREAD, Universe::the_empty_int_array());
2175   }
2176 }
2177 
2178 
2179 void ClassFileParser::parse_classfile_sourcefile_attribute(constantPoolHandle cp, instanceKlassHandle k, TRAPS) {
2180   ClassFileStream* cfs = stream();
2181   cfs->guarantee_more(2, CHECK);  // sourcefile_index
2182   u2 sourcefile_index = cfs->get_u2_fast();
2183   check_property(
2184     valid_cp_range(sourcefile_index, cp->length()) &&
2185       cp->tag_at(sourcefile_index).is_utf8(),
2186     "Invalid SourceFile attribute at constant pool index %u in class file %s",
2187     sourcefile_index, CHECK);
2188   k->set_source_file_name(cp->symbol_at(sourcefile_index));
2189 }
2190 
2191 
2192 
2193 void ClassFileParser::parse_classfile_source_debug_extension_attribute(constantPoolHandle cp,
2194                                                                        instanceKlassHandle k,
2195                                                                        int length, TRAPS) {
2196   ClassFileStream* cfs = stream();
2197   u1* sde_buffer = cfs->get_u1_buffer();
2198   assert(sde_buffer != NULL, "null sde buffer");
2199 
2200   // Don't bother storing it if there is no way to retrieve it
2201   if (JvmtiExport::can_get_source_debug_extension()) {
2202     // Optimistically assume that only 1 byte UTF format is used
2203     // (common case)
2204     symbolOop sde_symbol = oopFactory::new_symbol((char*)sde_buffer,
2205                                                   length, CHECK);
2206     k->set_source_debug_extension(sde_symbol);
2207   }
2208   // Got utf8 string, set stream position forward
2209   cfs->skip_u1(length, CHECK);
2210 }
2211 
2212 
2213 // Inner classes can be static, private or protected (classic VM does this)
2214 #define RECOGNIZED_INNER_CLASS_MODIFIERS (JVM_RECOGNIZED_CLASS_MODIFIERS | JVM_ACC_PRIVATE | JVM_ACC_PROTECTED | JVM_ACC_STATIC)
2215 
2216 // Return number of classes in the inner classes attribute table
2217 u2 ClassFileParser::parse_classfile_inner_classes_attribute(constantPoolHandle cp, instanceKlassHandle k, TRAPS) {
2218   ClassFileStream* cfs = stream();
2219   cfs->guarantee_more(2, CHECK_0);  // length
2220   u2 length = cfs->get_u2_fast();
2221 
2222   // 4-tuples of shorts [inner_class_info_index, outer_class_info_index, inner_name_index, inner_class_access_flags]
2223   typeArrayOop ic = oopFactory::new_permanent_shortArray(length*4, CHECK_0);
2224   typeArrayHandle inner_classes(THREAD, ic);
2225   int index = 0;
2226   int cp_size = cp->length();
2227   cfs->guarantee_more(8 * length, CHECK_0);  // 4-tuples of u2
2228   for (int n = 0; n < length; n++) {
2229     // Inner class index
2230     u2 inner_class_info_index = cfs->get_u2_fast();
2231     check_property(
2232       inner_class_info_index == 0 ||
2233         (valid_cp_range(inner_class_info_index, cp_size) &&
2234         is_klass_reference(cp, inner_class_info_index)),
2235       "inner_class_info_index %u has bad constant type in class file %s",
2236       inner_class_info_index, CHECK_0);
2237     // Outer class index
2238     u2 outer_class_info_index = cfs->get_u2_fast();
2239     check_property(
2240       outer_class_info_index == 0 ||
2241         (valid_cp_range(outer_class_info_index, cp_size) &&
2242         is_klass_reference(cp, outer_class_info_index)),
2243       "outer_class_info_index %u has bad constant type in class file %s",
2244       outer_class_info_index, CHECK_0);
2245     // Inner class name
2246     u2 inner_name_index = cfs->get_u2_fast();
2247     check_property(
2248       inner_name_index == 0 || (valid_cp_range(inner_name_index, cp_size) &&
2249         cp->tag_at(inner_name_index).is_utf8()),
2250       "inner_name_index %u has bad constant type in class file %s",
2251       inner_name_index, CHECK_0);
2252     if (_need_verify) {
2253       guarantee_property(inner_class_info_index != outer_class_info_index,
2254                          "Class is both outer and inner class in class file %s", CHECK_0);
2255     }
2256     // Access flags
2257     AccessFlags inner_access_flags;
2258     jint flags = cfs->get_u2_fast() & RECOGNIZED_INNER_CLASS_MODIFIERS;
2259     if ((flags & JVM_ACC_INTERFACE) && _major_version < JAVA_6_VERSION) {
2260       // Set abstract bit for old class files for backward compatibility
2261       flags |= JVM_ACC_ABSTRACT;
2262     }
2263     verify_legal_class_modifiers(flags, CHECK_0);
2264     inner_access_flags.set_flags(flags);
2265 
2266     inner_classes->short_at_put(index++, inner_class_info_index);
2267     inner_classes->short_at_put(index++, outer_class_info_index);
2268     inner_classes->short_at_put(index++, inner_name_index);
2269     inner_classes->short_at_put(index++, inner_access_flags.as_short());
2270   }
2271 
2272   // 4347400: make sure there's no duplicate entry in the classes array
2273   if (_need_verify && _major_version >= JAVA_1_5_VERSION) {
2274     for(int i = 0; i < inner_classes->length(); i += 4) {
2275       for(int j = i + 4; j < inner_classes->length(); j += 4) {
2276         guarantee_property((inner_classes->ushort_at(i)   != inner_classes->ushort_at(j) ||
2277                             inner_classes->ushort_at(i+1) != inner_classes->ushort_at(j+1) ||
2278                             inner_classes->ushort_at(i+2) != inner_classes->ushort_at(j+2) ||
2279                             inner_classes->ushort_at(i+3) != inner_classes->ushort_at(j+3)),
2280                             "Duplicate entry in InnerClasses in class file %s",
2281                             CHECK_0);
2282       }
2283     }
2284   }
2285 
2286   // Update instanceKlass with inner class info.
2287   k->set_inner_classes(inner_classes());
2288   return length;
2289 }
2290 
2291 void ClassFileParser::parse_classfile_synthetic_attribute(constantPoolHandle cp, instanceKlassHandle k, TRAPS) {
2292   k->set_is_synthetic();
2293 }
2294 
2295 void ClassFileParser::parse_classfile_signature_attribute(constantPoolHandle cp, instanceKlassHandle k, TRAPS) {
2296   ClassFileStream* cfs = stream();
2297   u2 signature_index = cfs->get_u2(CHECK);
2298   check_property(
2299     valid_cp_range(signature_index, cp->length()) &&
2300       cp->tag_at(signature_index).is_utf8(),
2301     "Invalid constant pool index %u in Signature attribute in class file %s",
2302     signature_index, CHECK);
2303   k->set_generic_signature(cp->symbol_at(signature_index));
2304 }
2305 
2306 void ClassFileParser::parse_classfile_attributes(constantPoolHandle cp, instanceKlassHandle k, TRAPS) {
2307   ClassFileStream* cfs = stream();
2308   // Set inner classes attribute to default sentinel
2309   k->set_inner_classes(Universe::the_empty_short_array());
2310   cfs->guarantee_more(2, CHECK);  // attributes_count
2311   u2 attributes_count = cfs->get_u2_fast();
2312   bool parsed_sourcefile_attribute = false;
2313   bool parsed_innerclasses_attribute = false;
2314   bool parsed_enclosingmethod_attribute = false;
2315   u1* runtime_visible_annotations = NULL;
2316   int runtime_visible_annotations_length = 0;
2317   u1* runtime_invisible_annotations = NULL;
2318   int runtime_invisible_annotations_length = 0;
2319   // Iterate over attributes
2320   while (attributes_count--) {
2321     cfs->guarantee_more(6, CHECK);  // attribute_name_index, attribute_length
2322     u2 attribute_name_index = cfs->get_u2_fast();
2323     u4 attribute_length = cfs->get_u4_fast();
2324     check_property(
2325       valid_cp_range(attribute_name_index, cp->length()) &&
2326         cp->tag_at(attribute_name_index).is_utf8(),
2327       "Attribute name has bad constant pool index %u in class file %s",
2328       attribute_name_index, CHECK);
2329     symbolOop tag = cp->symbol_at(attribute_name_index);
2330     if (tag == vmSymbols::tag_source_file()) {
2331       // Check for SourceFile tag
2332       if (_need_verify) {
2333         guarantee_property(attribute_length == 2, "Wrong SourceFile attribute length in class file %s", CHECK);
2334       }
2335       if (parsed_sourcefile_attribute) {
2336         classfile_parse_error("Multiple SourceFile attributes in class file %s", CHECK);
2337       } else {
2338         parsed_sourcefile_attribute = true;
2339       }
2340       parse_classfile_sourcefile_attribute(cp, k, CHECK);
2341     } else if (tag == vmSymbols::tag_source_debug_extension()) {
2342       // Check for SourceDebugExtension tag
2343       parse_classfile_source_debug_extension_attribute(cp, k, (int)attribute_length, CHECK);
2344     } else if (tag == vmSymbols::tag_inner_classes()) {
2345       // Check for InnerClasses tag
2346       if (parsed_innerclasses_attribute) {
2347         classfile_parse_error("Multiple InnerClasses attributes in class file %s", CHECK);
2348       } else {
2349         parsed_innerclasses_attribute = true;
2350       }
2351       u2 num_of_classes = parse_classfile_inner_classes_attribute(cp, k, CHECK);
2352       if (_need_verify && _major_version >= JAVA_1_5_VERSION) {
2353         guarantee_property(attribute_length == sizeof(num_of_classes) + 4 * sizeof(u2) * num_of_classes,
2354                           "Wrong InnerClasses attribute length in class file %s", CHECK);
2355       }
2356     } else if (tag == vmSymbols::tag_synthetic()) {
2357       // Check for Synthetic tag
2358       // Shouldn't we check that the synthetic flags wasn't already set? - not required in spec
2359       if (attribute_length != 0) {
2360         classfile_parse_error(
2361           "Invalid Synthetic classfile attribute length %u in class file %s",
2362           attribute_length, CHECK);
2363       }
2364       parse_classfile_synthetic_attribute(cp, k, CHECK);
2365     } else if (tag == vmSymbols::tag_deprecated()) {
2366       // Check for Deprecatd tag - 4276120
2367       if (attribute_length != 0) {
2368         classfile_parse_error(
2369           "Invalid Deprecated classfile attribute length %u in class file %s",
2370           attribute_length, CHECK);
2371       }
2372     } else if (_major_version >= JAVA_1_5_VERSION) {
2373       if (tag == vmSymbols::tag_signature()) {
2374         if (attribute_length != 2) {
2375           classfile_parse_error(
2376             "Wrong Signature attribute length %u in class file %s",
2377             attribute_length, CHECK);
2378         }
2379         parse_classfile_signature_attribute(cp, k, CHECK);
2380       } else if (tag == vmSymbols::tag_runtime_visible_annotations()) {
2381         runtime_visible_annotations_length = attribute_length;
2382         runtime_visible_annotations = cfs->get_u1_buffer();
2383         assert(runtime_visible_annotations != NULL, "null visible annotations");
2384         cfs->skip_u1(runtime_visible_annotations_length, CHECK);
2385       } else if (PreserveAllAnnotations && tag == vmSymbols::tag_runtime_invisible_annotations()) {
2386         runtime_invisible_annotations_length = attribute_length;
2387         runtime_invisible_annotations = cfs->get_u1_buffer();
2388         assert(runtime_invisible_annotations != NULL, "null invisible annotations");
2389         cfs->skip_u1(runtime_invisible_annotations_length, CHECK);
2390       } else if (tag == vmSymbols::tag_enclosing_method()) {
2391         if (parsed_enclosingmethod_attribute) {
2392           classfile_parse_error("Multiple EnclosingMethod attributes in class file %s", CHECK);
2393         }   else {
2394           parsed_enclosingmethod_attribute = true;
2395         }
2396         cfs->guarantee_more(4, CHECK);  // class_index, method_index
2397         u2 class_index  = cfs->get_u2_fast();
2398         u2 method_index = cfs->get_u2_fast();
2399         if (class_index == 0) {
2400           classfile_parse_error("Invalid class index in EnclosingMethod attribute in class file %s", CHECK);
2401         }
2402         // Validate the constant pool indices and types
2403         if (!cp->is_within_bounds(class_index) ||
2404             !is_klass_reference(cp, class_index)) {
2405           classfile_parse_error("Invalid or out-of-bounds class index in EnclosingMethod attribute in class file %s", CHECK);
2406         }
2407         if (method_index != 0 &&
2408             (!cp->is_within_bounds(method_index) ||
2409              !cp->tag_at(method_index).is_name_and_type())) {
2410           classfile_parse_error("Invalid or out-of-bounds method index in EnclosingMethod attribute in class file %s", CHECK);
2411         }
2412         k->set_enclosing_method_indices(class_index, method_index);
2413       } else {
2414         // Unknown attribute
2415         cfs->skip_u1(attribute_length, CHECK);
2416       }
2417     } else {
2418       // Unknown attribute
2419       cfs->skip_u1(attribute_length, CHECK);
2420     }
2421   }
2422   typeArrayHandle annotations = assemble_annotations(runtime_visible_annotations,
2423                                                      runtime_visible_annotations_length,
2424                                                      runtime_invisible_annotations,
2425                                                      runtime_invisible_annotations_length,
2426                                                      CHECK);
2427   k->set_class_annotations(annotations());
2428 }
2429 
2430 
2431 typeArrayHandle ClassFileParser::assemble_annotations(u1* runtime_visible_annotations,
2432                                                       int runtime_visible_annotations_length,
2433                                                       u1* runtime_invisible_annotations,
2434                                                       int runtime_invisible_annotations_length, TRAPS) {
2435   typeArrayHandle annotations;
2436   if (runtime_visible_annotations != NULL ||
2437       runtime_invisible_annotations != NULL) {
2438     typeArrayOop anno = oopFactory::new_permanent_byteArray(runtime_visible_annotations_length +
2439                                                             runtime_invisible_annotations_length, CHECK_(annotations));
2440     annotations = typeArrayHandle(THREAD, anno);
2441     if (runtime_visible_annotations != NULL) {
2442       memcpy(annotations->byte_at_addr(0), runtime_visible_annotations, runtime_visible_annotations_length);
2443     }
2444     if (runtime_invisible_annotations != NULL) {
2445       memcpy(annotations->byte_at_addr(runtime_visible_annotations_length), runtime_invisible_annotations, runtime_invisible_annotations_length);
2446     }
2447   }
2448   return annotations;
2449 }
2450 
2451 
2452 static void initialize_static_field(fieldDescriptor* fd, TRAPS) {
2453   KlassHandle h_k (THREAD, fd->field_holder());
2454   assert(h_k.not_null() && fd->is_static(), "just checking");
2455   if (fd->has_initial_value()) {
2456     BasicType t = fd->field_type();
2457     switch (t) {
2458       case T_BYTE:
2459         h_k()->byte_field_put(fd->offset(), fd->int_initial_value());
2460               break;
2461       case T_BOOLEAN:
2462         h_k()->bool_field_put(fd->offset(), fd->int_initial_value());
2463               break;
2464       case T_CHAR:
2465         h_k()->char_field_put(fd->offset(), fd->int_initial_value());
2466               break;
2467       case T_SHORT:
2468         h_k()->short_field_put(fd->offset(), fd->int_initial_value());
2469               break;
2470       case T_INT:
2471         h_k()->int_field_put(fd->offset(), fd->int_initial_value());
2472         break;
2473       case T_FLOAT:
2474         h_k()->float_field_put(fd->offset(), fd->float_initial_value());
2475         break;
2476       case T_DOUBLE:
2477         h_k()->double_field_put(fd->offset(), fd->double_initial_value());
2478         break;
2479       case T_LONG:
2480         h_k()->long_field_put(fd->offset(), fd->long_initial_value());
2481         break;
2482       case T_OBJECT:
2483         {
2484           #ifdef ASSERT
2485           symbolOop sym = oopFactory::new_symbol("Ljava/lang/String;", CHECK);
2486           assert(fd->signature() == sym, "just checking");
2487           #endif
2488           oop string = fd->string_initial_value(CHECK);
2489           h_k()->obj_field_put(fd->offset(), string);
2490         }
2491         break;
2492       default:
2493         THROW_MSG(vmSymbols::java_lang_ClassFormatError(),
2494                   "Illegal ConstantValue attribute in class file");
2495     }
2496   }
2497 }
2498 
2499 
2500 void ClassFileParser::java_lang_ref_Reference_fix_pre(typeArrayHandle* fields_ptr,
2501   constantPoolHandle cp, FieldAllocationCount *fac_ptr, TRAPS) {
2502   // This code is for compatibility with earlier jdk's that do not
2503   // have the "discovered" field in java.lang.ref.Reference.  For 1.5
2504   // the check for the "discovered" field should issue a warning if
2505   // the field is not found.  For 1.6 this code should be issue a
2506   // fatal error if the "discovered" field is not found.
2507   //
2508   // Increment fac.nonstatic_oop_count so that the start of the
2509   // next type of non-static oops leaves room for the fake oop.
2510   // Do not increment next_nonstatic_oop_offset so that the
2511   // fake oop is place after the java.lang.ref.Reference oop
2512   // fields.
2513   //
2514   // Check the fields in java.lang.ref.Reference for the "discovered"
2515   // field.  If it is not present, artifically create a field for it.
2516   // This allows this VM to run on early JDK where the field is not
2517   // present.
2518 
2519   //
2520   // Increment fac.nonstatic_oop_count so that the start of the
2521   // next type of non-static oops leaves room for the fake oop.
2522   // Do not increment next_nonstatic_oop_offset so that the
2523   // fake oop is place after the java.lang.ref.Reference oop
2524   // fields.
2525   //
2526   // Check the fields in java.lang.ref.Reference for the "discovered"
2527   // field.  If it is not present, artifically create a field for it.
2528   // This allows this VM to run on early JDK where the field is not
2529   // present.
2530   int reference_sig_index = 0;
2531   int reference_name_index = 0;
2532   int reference_index = 0;
2533   int extra = java_lang_ref_Reference::number_of_fake_oop_fields;
2534   const int n = (*fields_ptr)()->length();
2535   for (int i = 0; i < n; i += instanceKlass::next_offset ) {
2536     int name_index =
2537     (*fields_ptr)()->ushort_at(i + instanceKlass::name_index_offset);
2538     int sig_index  =
2539       (*fields_ptr)()->ushort_at(i + instanceKlass::signature_index_offset);
2540     symbolOop f_name = cp->symbol_at(name_index);
2541     symbolOop f_sig  = cp->symbol_at(sig_index);
2542     if (f_sig == vmSymbols::reference_signature() && reference_index == 0) {
2543       // Save the index for reference signature for later use.
2544       // The fake discovered field does not entries in the
2545       // constant pool so the index for its signature cannot
2546       // be extracted from the constant pool.  It will need
2547       // later, however.  It's signature is vmSymbols::reference_signature()
2548       // so same an index for that signature.
2549       reference_sig_index = sig_index;
2550       reference_name_index = name_index;
2551       reference_index = i;
2552     }
2553     if (f_name == vmSymbols::reference_discovered_name() &&
2554       f_sig == vmSymbols::reference_signature()) {
2555       // The values below are fake but will force extra
2556       // non-static oop fields and a corresponding non-static
2557       // oop map block to be allocated.
2558       extra = 0;
2559       break;
2560     }
2561   }
2562   if (extra != 0) {
2563     fac_ptr->nonstatic_oop_count += extra;
2564     // Add the additional entry to "fields" so that the klass
2565     // contains the "discoverd" field and the field will be initialized
2566     // in instances of the object.
2567     int fields_with_fix_length = (*fields_ptr)()->length() +
2568       instanceKlass::next_offset;
2569     typeArrayOop ff = oopFactory::new_permanent_shortArray(
2570                                                 fields_with_fix_length, CHECK);
2571     typeArrayHandle fields_with_fix(THREAD, ff);
2572 
2573     // Take everything from the original but the length.
2574     for (int idx = 0; idx < (*fields_ptr)->length(); idx++) {
2575       fields_with_fix->ushort_at_put(idx, (*fields_ptr)->ushort_at(idx));
2576     }
2577 
2578     // Add the fake field at the end.
2579     int i = (*fields_ptr)->length();
2580     // There is no name index for the fake "discovered" field nor
2581     // signature but a signature is needed so that the field will
2582     // be properly initialized.  Use one found for
2583     // one of the other reference fields. Be sure the index for the
2584     // name is 0.  In fieldDescriptor::initialize() the index of the
2585     // name is checked.  That check is by passed for the last nonstatic
2586     // oop field in a java.lang.ref.Reference which is assumed to be
2587     // this artificial "discovered" field.  An assertion checks that
2588     // the name index is 0.
2589     assert(reference_index != 0, "Missing signature for reference");
2590 
2591     int j;
2592     for (j = 0; j < instanceKlass::next_offset; j++) {
2593       fields_with_fix->ushort_at_put(i + j,
2594         (*fields_ptr)->ushort_at(reference_index +j));
2595     }
2596     // Clear the public access flag and set the private access flag.
2597     short flags;
2598     flags =
2599       fields_with_fix->ushort_at(i + instanceKlass::access_flags_offset);
2600     assert(!(flags & JVM_RECOGNIZED_FIELD_MODIFIERS), "Unexpected access flags set");
2601     flags = flags & (~JVM_ACC_PUBLIC);
2602     flags = flags | JVM_ACC_PRIVATE;
2603     AccessFlags access_flags;
2604     access_flags.set_flags(flags);
2605     assert(!access_flags.is_public(), "Failed to clear public flag");
2606     assert(access_flags.is_private(), "Failed to set private flag");
2607     fields_with_fix->ushort_at_put(i + instanceKlass::access_flags_offset,
2608       flags);
2609 
2610     assert(fields_with_fix->ushort_at(i + instanceKlass::name_index_offset)
2611       == reference_name_index, "The fake reference name is incorrect");
2612     assert(fields_with_fix->ushort_at(i + instanceKlass::signature_index_offset)
2613       == reference_sig_index, "The fake reference signature is incorrect");
2614     // The type of the field is stored in the low_offset entry during
2615     // parsing.
2616     assert(fields_with_fix->ushort_at(i + instanceKlass::low_offset) ==
2617       NONSTATIC_OOP, "The fake reference type is incorrect");
2618 
2619     // "fields" is allocated in the permanent generation.  Disgard
2620     // it and let it be collected.
2621     (*fields_ptr) = fields_with_fix;
2622   }
2623   return;
2624 }
2625 
2626 
2627 void ClassFileParser::java_lang_Class_fix_pre(objArrayHandle* methods_ptr,
2628   FieldAllocationCount *fac_ptr, TRAPS) {
2629   // Add fake fields for java.lang.Class instances
2630   //
2631   // This is not particularly nice. We should consider adding a
2632   // private transient object field at the Java level to
2633   // java.lang.Class. Alternatively we could add a subclass of
2634   // instanceKlass which provides an accessor and size computer for
2635   // this field, but that appears to be more code than this hack.
2636   //
2637   // NOTE that we wedge these in at the beginning rather than the
2638   // end of the object because the Class layout changed between JDK
2639   // 1.3 and JDK 1.4 with the new reflection implementation; some
2640   // nonstatic oop fields were added at the Java level. The offsets
2641   // of these fake fields can't change between these two JDK
2642   // versions because when the offsets are computed at bootstrap
2643   // time we don't know yet which version of the JDK we're running in.
2644 
2645   // The values below are fake but will force two non-static oop fields and
2646   // a corresponding non-static oop map block to be allocated.
2647   const int extra = java_lang_Class::number_of_fake_oop_fields;
2648   fac_ptr->nonstatic_oop_count += extra;
2649 }
2650 
2651 
2652 void ClassFileParser::java_lang_Class_fix_post(int* next_nonstatic_oop_offset_ptr) {
2653   // Cause the extra fake fields in java.lang.Class to show up before
2654   // the Java fields for layout compatibility between 1.3 and 1.4
2655   // Incrementing next_nonstatic_oop_offset here advances the
2656   // location where the real java fields are placed.
2657   const int extra = java_lang_Class::number_of_fake_oop_fields;
2658   (*next_nonstatic_oop_offset_ptr) += (extra * heapOopSize);
2659 }
2660 
2661 
2662 // Force MethodHandle.vmentry to be an unmanaged pointer.
2663 // There is no way for a classfile to express this, so we must help it.
2664 void ClassFileParser::java_dyn_MethodHandle_fix_pre(constantPoolHandle cp,
2665                                                     typeArrayHandle* fields_ptr,
2666                                                     FieldAllocationCount *fac_ptr,
2667                                                     TRAPS) {
2668   // Add fake fields for java.dyn.MethodHandle instances
2669   //
2670   // This is not particularly nice, but since there is no way to express
2671   // a native wordSize field in Java, we must do it at this level.
2672 
2673   if (!EnableMethodHandles)  return;
2674 
2675   int word_sig_index = 0;
2676   const int cp_size = cp->length();
2677   for (int index = 1; index < cp_size; index++) {
2678     if (cp->tag_at(index).is_utf8() &&
2679         cp->symbol_at(index) == vmSymbols::machine_word_signature()) {
2680       word_sig_index = index;
2681       break;
2682     }
2683   }
2684 
2685   if (word_sig_index == 0)
2686     THROW_MSG(vmSymbols::java_lang_VirtualMachineError(),
2687               "missing I or J signature (for vmentry) in java.dyn.MethodHandle");
2688 
2689   bool found_vmentry = false;
2690 
2691   const int n = (*fields_ptr)()->length();
2692   for (int i = 0; i < n; i += instanceKlass::next_offset) {
2693     int name_index = (*fields_ptr)->ushort_at(i + instanceKlass::name_index_offset);
2694     int sig_index  = (*fields_ptr)->ushort_at(i + instanceKlass::signature_index_offset);
2695     int acc_flags  = (*fields_ptr)->ushort_at(i + instanceKlass::access_flags_offset);
2696     symbolOop f_name = cp->symbol_at(name_index);
2697     symbolOop f_sig  = cp->symbol_at(sig_index);
2698     if (f_sig == vmSymbols::byte_signature() &&
2699         f_name == vmSymbols::vmentry_name() &&
2700         (acc_flags & JVM_ACC_STATIC) == 0) {
2701       // Adjust the field type from byte to an unmanaged pointer.
2702       assert(fac_ptr->nonstatic_byte_count > 0, "");
2703       fac_ptr->nonstatic_byte_count -= 1;
2704       (*fields_ptr)->ushort_at_put(i + instanceKlass::signature_index_offset,
2705                                    word_sig_index);
2706       fac_ptr->nonstatic_word_count += 1;
2707 
2708       FieldAllocationType atype = (FieldAllocationType) (*fields_ptr)->ushort_at(i + instanceKlass::low_offset);
2709       assert(atype == NONSTATIC_BYTE, "");
2710       FieldAllocationType new_atype = NONSTATIC_WORD;
2711       (*fields_ptr)->ushort_at_put(i + instanceKlass::low_offset, new_atype);
2712 
2713       found_vmentry = true;
2714       break;
2715     }
2716   }
2717 
2718   if (!found_vmentry)
2719     THROW_MSG(vmSymbols::java_lang_VirtualMachineError(),
2720               "missing vmentry byte field in java.dyn.MethodHandle");
2721 
2722 }
2723 
2724 
2725 instanceKlassHandle ClassFileParser::parseClassFile(symbolHandle name,
2726                                                     Handle class_loader,
2727                                                     Handle protection_domain,
2728                                                     KlassHandle host_klass,
2729                                                     GrowableArray<Handle>* cp_patches,
2730                                                     symbolHandle& parsed_name,
2731                                                     bool verify,
2732                                                     TRAPS) {
2733   // So that JVMTI can cache class file in the state before retransformable agents
2734   // have modified it
2735   unsigned char *cached_class_file_bytes = NULL;
2736   jint cached_class_file_length;
2737 
2738   ClassFileStream* cfs = stream();
2739   // Timing
2740   assert(THREAD->is_Java_thread(), "must be a JavaThread");
2741   JavaThread* jt = (JavaThread*) THREAD;
2742 
2743   PerfClassTraceTime ctimer(ClassLoader::perf_class_parse_time(),
2744                             ClassLoader::perf_class_parse_selftime(),
2745                             NULL,
2746                             jt->get_thread_stat()->perf_recursion_counts_addr(),
2747                             jt->get_thread_stat()->perf_timers_addr(),
2748                             PerfClassTraceTime::PARSE_CLASS);
2749 
2750   _has_finalizer = _has_empty_finalizer = _has_vanilla_constructor = false;
2751 
2752   if (JvmtiExport::should_post_class_file_load_hook()) {
2753     unsigned char* ptr = cfs->buffer();
2754     unsigned char* end_ptr = cfs->buffer() + cfs->length();
2755 
2756     JvmtiExport::post_class_file_load_hook(name, class_loader, protection_domain,
2757                                            &ptr, &end_ptr,
2758                                            &cached_class_file_bytes,
2759                                            &cached_class_file_length);
2760 
2761     if (ptr != cfs->buffer()) {
2762       // JVMTI agent has modified class file data.
2763       // Set new class file stream using JVMTI agent modified
2764       // class file data.
2765       cfs = new ClassFileStream(ptr, end_ptr - ptr, cfs->source());
2766       set_stream(cfs);
2767     }
2768   }
2769 
2770   _host_klass = host_klass;
2771   _cp_patches = cp_patches;
2772 
2773   instanceKlassHandle nullHandle;
2774 
2775   // Figure out whether we can skip format checking (matching classic VM behavior)
2776   _need_verify = Verifier::should_verify_for(class_loader(), verify);
2777 
2778   // Set the verify flag in stream
2779   cfs->set_verify(_need_verify);
2780 
2781   // Save the class file name for easier error message printing.
2782   _class_name = name.not_null()? name : vmSymbolHandles::unknown_class_name();
2783 
2784   cfs->guarantee_more(8, CHECK_(nullHandle));  // magic, major, minor
2785   // Magic value
2786   u4 magic = cfs->get_u4_fast();
2787   guarantee_property(magic == JAVA_CLASSFILE_MAGIC,
2788                      "Incompatible magic value %u in class file %s",
2789                      magic, CHECK_(nullHandle));
2790 
2791   // Version numbers
2792   u2 minor_version = cfs->get_u2_fast();
2793   u2 major_version = cfs->get_u2_fast();
2794 
2795   // Check version numbers - we check this even with verifier off
2796   if (!is_supported_version(major_version, minor_version)) {
2797     if (name.is_null()) {
2798       Exceptions::fthrow(
2799         THREAD_AND_LOCATION,
2800         vmSymbolHandles::java_lang_UnsupportedClassVersionError(),
2801         "Unsupported major.minor version %u.%u",
2802         major_version,
2803         minor_version);
2804     } else {
2805       ResourceMark rm(THREAD);
2806       Exceptions::fthrow(
2807         THREAD_AND_LOCATION,
2808         vmSymbolHandles::java_lang_UnsupportedClassVersionError(),
2809         "%s : Unsupported major.minor version %u.%u",
2810         name->as_C_string(),
2811         major_version,
2812         minor_version);
2813     }
2814     return nullHandle;
2815   }
2816 
2817   _major_version = major_version;
2818   _minor_version = minor_version;
2819 
2820 
2821   // Check if verification needs to be relaxed for this class file
2822   // Do not restrict it to jdk1.0 or jdk1.1 to maintain backward compatibility (4982376)
2823   _relax_verify = Verifier::relax_verify_for(class_loader());
2824 
2825   // Constant pool
2826   constantPoolHandle cp = parse_constant_pool(CHECK_(nullHandle));
2827   int cp_size = cp->length();
2828 
2829   cfs->guarantee_more(8, CHECK_(nullHandle));  // flags, this_class, super_class, infs_len
2830 
2831   // Access flags
2832   AccessFlags access_flags;
2833   jint flags = cfs->get_u2_fast() & JVM_RECOGNIZED_CLASS_MODIFIERS;
2834 
2835   if ((flags & JVM_ACC_INTERFACE) && _major_version < JAVA_6_VERSION) {
2836     // Set abstract bit for old class files for backward compatibility
2837     flags |= JVM_ACC_ABSTRACT;
2838   }
2839   verify_legal_class_modifiers(flags, CHECK_(nullHandle));
2840   access_flags.set_flags(flags);
2841 
2842   // This class and superclass
2843   instanceKlassHandle super_klass;
2844   u2 this_class_index = cfs->get_u2_fast();
2845   check_property(
2846     valid_cp_range(this_class_index, cp_size) &&
2847       cp->tag_at(this_class_index).is_unresolved_klass(),
2848     "Invalid this class index %u in constant pool in class file %s",
2849     this_class_index, CHECK_(nullHandle));
2850 
2851   symbolHandle class_name (THREAD, cp->unresolved_klass_at(this_class_index));
2852   assert(class_name.not_null(), "class_name can't be null");
2853 
2854   // It's important to set parsed_name *before* resolving the super class.
2855   // (it's used for cleanup by the caller if parsing fails)
2856   parsed_name = class_name;
2857 
2858   // Update _class_name which could be null previously to be class_name
2859   _class_name = class_name;
2860 
2861   // Don't need to check whether this class name is legal or not.
2862   // It has been checked when constant pool is parsed.
2863   // However, make sure it is not an array type.
2864   if (_need_verify) {
2865     guarantee_property(class_name->byte_at(0) != JVM_SIGNATURE_ARRAY,
2866                        "Bad class name in class file %s",
2867                        CHECK_(nullHandle));
2868   }
2869 
2870   klassOop preserve_this_klass;   // for storing result across HandleMark
2871 
2872   // release all handles when parsing is done
2873   { HandleMark hm(THREAD);
2874 
2875     // Checks if name in class file matches requested name
2876     if (name.not_null() && class_name() != name()) {
2877       ResourceMark rm(THREAD);
2878       Exceptions::fthrow(
2879         THREAD_AND_LOCATION,
2880         vmSymbolHandles::java_lang_NoClassDefFoundError(),
2881         "%s (wrong name: %s)",
2882         name->as_C_string(),
2883         class_name->as_C_string()
2884       );
2885       return nullHandle;
2886     }
2887 
2888     if (TraceClassLoadingPreorder) {
2889       tty->print("[Loading %s", name()->as_klass_external_name());
2890       if (cfs->source() != NULL) tty->print(" from %s", cfs->source());
2891       tty->print_cr("]");
2892     }
2893 
2894     u2 super_class_index = cfs->get_u2_fast();
2895     if (super_class_index == 0) {
2896       check_property(class_name() == vmSymbols::java_lang_Object(),
2897                      "Invalid superclass index %u in class file %s",
2898                      super_class_index,
2899                      CHECK_(nullHandle));
2900     } else {
2901       check_property(valid_cp_range(super_class_index, cp_size) &&
2902                      is_klass_reference(cp, super_class_index),
2903                      "Invalid superclass index %u in class file %s",
2904                      super_class_index,
2905                      CHECK_(nullHandle));
2906       // The class name should be legal because it is checked when parsing constant pool.
2907       // However, make sure it is not an array type.
2908       bool is_array = false;
2909       if (cp->tag_at(super_class_index).is_klass()) {
2910         super_klass = instanceKlassHandle(THREAD, cp->resolved_klass_at(super_class_index));
2911         if (_need_verify)
2912           is_array = super_klass->oop_is_array();
2913       } else if (_need_verify) {
2914         is_array = (cp->unresolved_klass_at(super_class_index)->byte_at(0) == JVM_SIGNATURE_ARRAY);
2915       }
2916       if (_need_verify) {
2917         guarantee_property(!is_array,
2918                           "Bad superclass name in class file %s", CHECK_(nullHandle));
2919       }
2920     }
2921 
2922     // Interfaces
2923     u2 itfs_len = cfs->get_u2_fast();
2924     objArrayHandle local_interfaces;
2925     if (itfs_len == 0) {
2926       local_interfaces = objArrayHandle(THREAD, Universe::the_empty_system_obj_array());
2927     } else {
2928       local_interfaces = parse_interfaces(cp, itfs_len, class_loader, protection_domain, _class_name, CHECK_(nullHandle));
2929     }
2930 
2931     // Fields (offsets are filled in later)
2932     struct FieldAllocationCount fac = {0,0,0,0,0,0,0,0,0,0};
2933     objArrayHandle fields_annotations;
2934     typeArrayHandle fields = parse_fields(cp, access_flags.is_interface(), &fac, &fields_annotations, CHECK_(nullHandle));
2935     // Methods
2936     bool has_final_method = false;
2937     AccessFlags promoted_flags;
2938     promoted_flags.set_flags(0);
2939     // These need to be oop pointers because they are allocated lazily
2940     // inside parse_methods inside a nested HandleMark
2941     objArrayOop methods_annotations_oop = NULL;
2942     objArrayOop methods_parameter_annotations_oop = NULL;
2943     objArrayOop methods_default_annotations_oop = NULL;
2944     objArrayHandle methods = parse_methods(cp, access_flags.is_interface(),
2945                                            &promoted_flags,
2946                                            &has_final_method,
2947                                            &methods_annotations_oop,
2948                                            &methods_parameter_annotations_oop,
2949                                            &methods_default_annotations_oop,
2950                                            CHECK_(nullHandle));
2951 
2952     objArrayHandle methods_annotations(THREAD, methods_annotations_oop);
2953     objArrayHandle methods_parameter_annotations(THREAD, methods_parameter_annotations_oop);
2954     objArrayHandle methods_default_annotations(THREAD, methods_default_annotations_oop);
2955 
2956     // We check super class after class file is parsed and format is checked
2957     if (super_class_index > 0 && super_klass.is_null()) {
2958       symbolHandle sk (THREAD, cp->klass_name_at(super_class_index));
2959       if (access_flags.is_interface()) {
2960         // Before attempting to resolve the superclass, check for class format
2961         // errors not checked yet.
2962         guarantee_property(sk() == vmSymbols::java_lang_Object(),
2963                            "Interfaces must have java.lang.Object as superclass in class file %s",
2964                            CHECK_(nullHandle));
2965       }
2966       klassOop k = SystemDictionary::resolve_super_or_fail(class_name,
2967                                                            sk,
2968                                                            class_loader,
2969                                                            protection_domain,
2970                                                            true,
2971                                                            CHECK_(nullHandle));
2972 
2973       KlassHandle kh (THREAD, k);
2974       super_klass = instanceKlassHandle(THREAD, kh());
2975       if (LinkWellKnownClasses)  // my super class is well known to me
2976         cp->klass_at_put(super_class_index, super_klass()); // eagerly resolve
2977     }
2978     if (super_klass.not_null()) {
2979       if (super_klass->is_interface()) {
2980         ResourceMark rm(THREAD);
2981         Exceptions::fthrow(
2982           THREAD_AND_LOCATION,
2983           vmSymbolHandles::java_lang_IncompatibleClassChangeError(),
2984           "class %s has interface %s as super class",
2985           class_name->as_klass_external_name(),
2986           super_klass->external_name()
2987         );
2988         return nullHandle;
2989       }
2990       // Make sure super class is not final
2991       if (super_klass->is_final()) {
2992         THROW_MSG_(vmSymbols::java_lang_VerifyError(), "Cannot inherit from final class", nullHandle);
2993       }
2994     }
2995 
2996     // Compute the transitive list of all unique interfaces implemented by this class
2997     objArrayHandle transitive_interfaces = compute_transitive_interfaces(super_klass, local_interfaces, CHECK_(nullHandle));
2998 
2999     // sort methods
3000     typeArrayHandle method_ordering = sort_methods(methods,
3001                                                    methods_annotations,
3002                                                    methods_parameter_annotations,
3003                                                    methods_default_annotations,
3004                                                    CHECK_(nullHandle));
3005 
3006     // promote flags from parse_methods() to the klass' flags
3007     access_flags.add_promoted_flags(promoted_flags.as_int());
3008 
3009     // Size of Java vtable (in words)
3010     int vtable_size = 0;
3011     int itable_size = 0;
3012     int num_miranda_methods = 0;
3013 
3014     klassVtable::compute_vtable_size_and_num_mirandas(vtable_size,
3015                                                       num_miranda_methods,
3016                                                       super_klass(),
3017                                                       methods(),
3018                                                       access_flags,
3019                                                       class_loader,
3020                                                       class_name,
3021                                                       local_interfaces(),
3022                                                       CHECK_(nullHandle));
3023 
3024     // Size of Java itable (in words)
3025     itable_size = access_flags.is_interface() ? 0 : klassItable::compute_itable_size(transitive_interfaces);
3026 
3027     // Field size and offset computation
3028     int nonstatic_field_size = super_klass() == NULL ? 0 : super_klass->nonstatic_field_size();
3029 #ifndef PRODUCT
3030     int orig_nonstatic_field_size = 0;
3031 #endif
3032     int static_field_size = 0;
3033     int next_static_oop_offset;
3034     int next_static_double_offset;
3035     int next_static_word_offset;
3036     int next_static_short_offset;
3037     int next_static_byte_offset;
3038     int next_static_type_offset;
3039     int next_nonstatic_oop_offset;
3040     int next_nonstatic_double_offset;
3041     int next_nonstatic_word_offset;
3042     int next_nonstatic_short_offset;
3043     int next_nonstatic_byte_offset;
3044     int next_nonstatic_type_offset;
3045     int first_nonstatic_oop_offset;
3046     int first_nonstatic_field_offset;
3047     int next_nonstatic_field_offset;
3048 
3049     // Calculate the starting byte offsets
3050     next_static_oop_offset      = (instanceKlass::header_size() +
3051                                   align_object_offset(vtable_size) +
3052                                   align_object_offset(itable_size)) * wordSize;
3053     next_static_double_offset   = next_static_oop_offset +
3054                                   (fac.static_oop_count * heapOopSize);
3055     if ( fac.static_double_count &&
3056          (Universe::field_type_should_be_aligned(T_DOUBLE) ||
3057           Universe::field_type_should_be_aligned(T_LONG)) ) {
3058       next_static_double_offset = align_size_up(next_static_double_offset, BytesPerLong);
3059     }
3060 
3061     next_static_word_offset     = next_static_double_offset +
3062                                   (fac.static_double_count * BytesPerLong);
3063     next_static_short_offset    = next_static_word_offset +
3064                                   (fac.static_word_count * BytesPerInt);
3065     next_static_byte_offset     = next_static_short_offset +
3066                                   (fac.static_short_count * BytesPerShort);
3067     next_static_type_offset     = align_size_up((next_static_byte_offset +
3068                                   fac.static_byte_count ), wordSize );
3069     static_field_size           = (next_static_type_offset -
3070                                   next_static_oop_offset) / wordSize;
3071     first_nonstatic_field_offset = instanceOopDesc::base_offset_in_bytes() +
3072                                    nonstatic_field_size * heapOopSize;
3073     next_nonstatic_field_offset = first_nonstatic_field_offset;
3074 
3075     // Add fake fields for java.lang.Class instances (also see below)
3076     if (class_name() == vmSymbols::java_lang_Class() && class_loader.is_null()) {
3077       java_lang_Class_fix_pre(&methods, &fac, CHECK_(nullHandle));
3078     }
3079 
3080     // adjust the vmentry field declaration in java.dyn.MethodHandle
3081     if (EnableMethodHandles && class_name() == vmSymbols::sun_dyn_MethodHandleImpl() && class_loader.is_null()) {
3082       java_dyn_MethodHandle_fix_pre(cp, &fields, &fac, CHECK_(nullHandle));
3083     }
3084 
3085     // Add a fake "discovered" field if it is not present
3086     // for compatibility with earlier jdk's.
3087     if (class_name() == vmSymbols::java_lang_ref_Reference()
3088       && class_loader.is_null()) {
3089       java_lang_ref_Reference_fix_pre(&fields, cp, &fac, CHECK_(nullHandle));
3090     }
3091     // end of "discovered" field compactibility fix
3092 
3093     unsigned int nonstatic_double_count = fac.nonstatic_double_count;
3094     unsigned int nonstatic_word_count   = fac.nonstatic_word_count;
3095     unsigned int nonstatic_short_count  = fac.nonstatic_short_count;
3096     unsigned int nonstatic_byte_count   = fac.nonstatic_byte_count;
3097     unsigned int nonstatic_oop_count    = fac.nonstatic_oop_count;
3098 
3099     bool super_has_nonstatic_fields =
3100             (super_klass() != NULL && super_klass->has_nonstatic_fields());
3101     bool has_nonstatic_fields  =  super_has_nonstatic_fields ||
3102             ((nonstatic_double_count + nonstatic_word_count +
3103               nonstatic_short_count + nonstatic_byte_count +
3104               nonstatic_oop_count) != 0);
3105 
3106 
3107     // Prepare list of oops for oop map generation.
3108     int* nonstatic_oop_offsets;
3109     unsigned int* nonstatic_oop_counts;
3110     unsigned int nonstatic_oop_map_count = 0;
3111 
3112     nonstatic_oop_offsets = NEW_RESOURCE_ARRAY_IN_THREAD(
3113               THREAD, int, nonstatic_oop_count + 1);
3114     nonstatic_oop_counts  = NEW_RESOURCE_ARRAY_IN_THREAD(
3115               THREAD, unsigned int, nonstatic_oop_count + 1);
3116 
3117     // Add fake fields for java.lang.Class instances (also see above).
3118     // FieldsAllocationStyle and CompactFields values will be reset to default.
3119     if(class_name() == vmSymbols::java_lang_Class() && class_loader.is_null()) {
3120       java_lang_Class_fix_post(&next_nonstatic_field_offset);
3121       nonstatic_oop_offsets[0] = first_nonstatic_field_offset;
3122       const uint fake_oop_count = (next_nonstatic_field_offset -
3123                                    first_nonstatic_field_offset) / heapOopSize;
3124       nonstatic_oop_counts[0] = fake_oop_count;
3125       nonstatic_oop_map_count = 1;
3126       nonstatic_oop_count -= fake_oop_count;
3127       first_nonstatic_oop_offset = first_nonstatic_field_offset;
3128     } else {
3129       first_nonstatic_oop_offset = 0; // will be set for first oop field
3130     }
3131 
3132 #ifndef PRODUCT
3133     if( PrintCompactFieldsSavings ) {
3134       next_nonstatic_double_offset = next_nonstatic_field_offset +
3135                                      (nonstatic_oop_count * heapOopSize);
3136       if ( nonstatic_double_count > 0 ) {
3137         next_nonstatic_double_offset = align_size_up(next_nonstatic_double_offset, BytesPerLong);
3138       }
3139       next_nonstatic_word_offset  = next_nonstatic_double_offset +
3140                                     (nonstatic_double_count * BytesPerLong);
3141       next_nonstatic_short_offset = next_nonstatic_word_offset +
3142                                     (nonstatic_word_count * BytesPerInt);
3143       next_nonstatic_byte_offset  = next_nonstatic_short_offset +
3144                                     (nonstatic_short_count * BytesPerShort);
3145       next_nonstatic_type_offset  = align_size_up((next_nonstatic_byte_offset +
3146                                     nonstatic_byte_count ), heapOopSize );
3147       orig_nonstatic_field_size   = nonstatic_field_size +
3148       ((next_nonstatic_type_offset - first_nonstatic_field_offset)/heapOopSize);
3149     }
3150 #endif
3151     bool compact_fields   = CompactFields;
3152     int  allocation_style = FieldsAllocationStyle;
3153     if( allocation_style < 0 || allocation_style > 2 ) { // Out of range?
3154       assert(false, "0 <= FieldsAllocationStyle <= 2");
3155       allocation_style = 1; // Optimistic
3156     }
3157 
3158     // The next classes have predefined hard-coded fields offsets
3159     // (see in JavaClasses::compute_hard_coded_offsets()).
3160     // Use default fields allocation order for them.
3161     if( (allocation_style != 0 || compact_fields ) && class_loader.is_null() &&
3162         (class_name() == vmSymbols::java_lang_AssertionStatusDirectives() ||
3163          class_name() == vmSymbols::java_lang_Class() ||
3164          class_name() == vmSymbols::java_lang_ClassLoader() ||
3165          class_name() == vmSymbols::java_lang_ref_Reference() ||
3166          class_name() == vmSymbols::java_lang_ref_SoftReference() ||
3167          class_name() == vmSymbols::java_lang_StackTraceElement() ||
3168          class_name() == vmSymbols::java_lang_String() ||
3169          class_name() == vmSymbols::java_lang_Throwable() ||
3170          class_name() == vmSymbols::java_lang_Boolean() ||
3171          class_name() == vmSymbols::java_lang_Character() ||
3172          class_name() == vmSymbols::java_lang_Float() ||
3173          class_name() == vmSymbols::java_lang_Double() ||
3174          class_name() == vmSymbols::java_lang_Byte() ||
3175          class_name() == vmSymbols::java_lang_Short() ||
3176          class_name() == vmSymbols::java_lang_Integer() ||
3177          class_name() == vmSymbols::java_lang_Long())) {
3178       allocation_style = 0;     // Allocate oops first
3179       compact_fields   = false; // Don't compact fields
3180     }
3181 
3182     if( allocation_style == 0 ) {
3183       // Fields order: oops, longs/doubles, ints, shorts/chars, bytes
3184       next_nonstatic_oop_offset    = next_nonstatic_field_offset;
3185       next_nonstatic_double_offset = next_nonstatic_oop_offset +
3186                                       (nonstatic_oop_count * heapOopSize);
3187     } else if( allocation_style == 1 ) {
3188       // Fields order: longs/doubles, ints, shorts/chars, bytes, oops
3189       next_nonstatic_double_offset = next_nonstatic_field_offset;
3190     } else if( allocation_style == 2 ) {
3191       // Fields allocation: oops fields in super and sub classes are together.
3192       if( nonstatic_field_size > 0 && super_klass() != NULL &&
3193           super_klass->nonstatic_oop_map_size() > 0 ) {
3194         int map_size = super_klass->nonstatic_oop_map_size();
3195         OopMapBlock* first_map = super_klass->start_of_nonstatic_oop_maps();
3196         OopMapBlock* last_map = first_map + map_size - 1;
3197         int next_offset = last_map->offset() + (last_map->count() * heapOopSize);
3198         if (next_offset == next_nonstatic_field_offset) {
3199           allocation_style = 0;   // allocate oops first
3200           next_nonstatic_oop_offset    = next_nonstatic_field_offset;
3201           next_nonstatic_double_offset = next_nonstatic_oop_offset +
3202                                          (nonstatic_oop_count * heapOopSize);
3203         }
3204       }
3205       if( allocation_style == 2 ) {
3206         allocation_style = 1;     // allocate oops last
3207         next_nonstatic_double_offset = next_nonstatic_field_offset;
3208       }
3209     } else {
3210       ShouldNotReachHere();
3211     }
3212 
3213     int nonstatic_oop_space_count   = 0;
3214     int nonstatic_word_space_count  = 0;
3215     int nonstatic_short_space_count = 0;
3216     int nonstatic_byte_space_count  = 0;
3217     int nonstatic_oop_space_offset;
3218     int nonstatic_word_space_offset;
3219     int nonstatic_short_space_offset;
3220     int nonstatic_byte_space_offset;
3221 
3222     if( nonstatic_double_count > 0 ) {
3223       int offset = next_nonstatic_double_offset;
3224       next_nonstatic_double_offset = align_size_up(offset, BytesPerLong);
3225       if( compact_fields && offset != next_nonstatic_double_offset ) {
3226         // Allocate available fields into the gap before double field.
3227         int length = next_nonstatic_double_offset - offset;
3228         assert(length == BytesPerInt, "");
3229         nonstatic_word_space_offset = offset;
3230         if( nonstatic_word_count > 0 ) {
3231           nonstatic_word_count      -= 1;
3232           nonstatic_word_space_count = 1; // Only one will fit
3233           length -= BytesPerInt;
3234           offset += BytesPerInt;
3235         }
3236         nonstatic_short_space_offset = offset;
3237         while( length >= BytesPerShort && nonstatic_short_count > 0 ) {
3238           nonstatic_short_count       -= 1;
3239           nonstatic_short_space_count += 1;
3240           length -= BytesPerShort;
3241           offset += BytesPerShort;
3242         }
3243         nonstatic_byte_space_offset = offset;
3244         while( length > 0 && nonstatic_byte_count > 0 ) {
3245           nonstatic_byte_count       -= 1;
3246           nonstatic_byte_space_count += 1;
3247           length -= 1;
3248         }
3249         // Allocate oop field in the gap if there are no other fields for that.
3250         nonstatic_oop_space_offset = offset;
3251         if( length >= heapOopSize && nonstatic_oop_count > 0 &&
3252             allocation_style != 0 ) { // when oop fields not first
3253           nonstatic_oop_count      -= 1;
3254           nonstatic_oop_space_count = 1; // Only one will fit
3255           length -= heapOopSize;
3256           offset += heapOopSize;
3257         }
3258       }
3259     }
3260 
3261     next_nonstatic_word_offset  = next_nonstatic_double_offset +
3262                                   (nonstatic_double_count * BytesPerLong);
3263     next_nonstatic_short_offset = next_nonstatic_word_offset +
3264                                   (nonstatic_word_count * BytesPerInt);
3265     next_nonstatic_byte_offset  = next_nonstatic_short_offset +
3266                                   (nonstatic_short_count * BytesPerShort);
3267 
3268     int notaligned_offset;
3269     if( allocation_style == 0 ) {
3270       notaligned_offset = next_nonstatic_byte_offset + nonstatic_byte_count;
3271     } else { // allocation_style == 1
3272       next_nonstatic_oop_offset = next_nonstatic_byte_offset + nonstatic_byte_count;
3273       if( nonstatic_oop_count > 0 ) {
3274         next_nonstatic_oop_offset = align_size_up(next_nonstatic_oop_offset, heapOopSize);
3275       }
3276       notaligned_offset = next_nonstatic_oop_offset + (nonstatic_oop_count * heapOopSize);
3277     }
3278     next_nonstatic_type_offset = align_size_up(notaligned_offset, heapOopSize );
3279     nonstatic_field_size = nonstatic_field_size + ((next_nonstatic_type_offset
3280                                    - first_nonstatic_field_offset)/heapOopSize);
3281 
3282     // Iterate over fields again and compute correct offsets.
3283     // The field allocation type was temporarily stored in the offset slot.
3284     // oop fields are located before non-oop fields (static and non-static).
3285     int len = fields->length();
3286     for (int i = 0; i < len; i += instanceKlass::next_offset) {
3287       int real_offset;
3288       FieldAllocationType atype = (FieldAllocationType) fields->ushort_at(i + instanceKlass::low_offset);
3289       switch (atype) {
3290         case STATIC_OOP:
3291           real_offset = next_static_oop_offset;
3292           next_static_oop_offset += heapOopSize;
3293           break;
3294         case STATIC_BYTE:
3295           real_offset = next_static_byte_offset;
3296           next_static_byte_offset += 1;
3297           break;
3298         case STATIC_SHORT:
3299           real_offset = next_static_short_offset;
3300           next_static_short_offset += BytesPerShort;
3301           break;
3302         case STATIC_WORD:
3303           real_offset = next_static_word_offset;
3304           next_static_word_offset += BytesPerInt;
3305           break;
3306         case STATIC_ALIGNED_DOUBLE:
3307         case STATIC_DOUBLE:
3308           real_offset = next_static_double_offset;
3309           next_static_double_offset += BytesPerLong;
3310           break;
3311         case NONSTATIC_OOP:
3312           if( nonstatic_oop_space_count > 0 ) {
3313             real_offset = nonstatic_oop_space_offset;
3314             nonstatic_oop_space_offset += heapOopSize;
3315             nonstatic_oop_space_count  -= 1;
3316           } else {
3317             real_offset = next_nonstatic_oop_offset;
3318             next_nonstatic_oop_offset += heapOopSize;
3319           }
3320           // Update oop maps
3321           if( nonstatic_oop_map_count > 0 &&
3322               nonstatic_oop_offsets[nonstatic_oop_map_count - 1] ==
3323               real_offset -
3324               int(nonstatic_oop_counts[nonstatic_oop_map_count - 1]) *
3325               heapOopSize ) {
3326             // Extend current oop map
3327             nonstatic_oop_counts[nonstatic_oop_map_count - 1] += 1;
3328           } else {
3329             // Create new oop map
3330             nonstatic_oop_offsets[nonstatic_oop_map_count] = real_offset;
3331             nonstatic_oop_counts [nonstatic_oop_map_count] = 1;
3332             nonstatic_oop_map_count += 1;
3333             if( first_nonstatic_oop_offset == 0 ) { // Undefined
3334               first_nonstatic_oop_offset = real_offset;
3335             }
3336           }
3337           break;
3338         case NONSTATIC_BYTE:
3339           if( nonstatic_byte_space_count > 0 ) {
3340             real_offset = nonstatic_byte_space_offset;
3341             nonstatic_byte_space_offset += 1;
3342             nonstatic_byte_space_count  -= 1;
3343           } else {
3344             real_offset = next_nonstatic_byte_offset;
3345             next_nonstatic_byte_offset += 1;
3346           }
3347           break;
3348         case NONSTATIC_SHORT:
3349           if( nonstatic_short_space_count > 0 ) {
3350             real_offset = nonstatic_short_space_offset;
3351             nonstatic_short_space_offset += BytesPerShort;
3352             nonstatic_short_space_count  -= 1;
3353           } else {
3354             real_offset = next_nonstatic_short_offset;
3355             next_nonstatic_short_offset += BytesPerShort;
3356           }
3357           break;
3358         case NONSTATIC_WORD:
3359           if( nonstatic_word_space_count > 0 ) {
3360             real_offset = nonstatic_word_space_offset;
3361             nonstatic_word_space_offset += BytesPerInt;
3362             nonstatic_word_space_count  -= 1;
3363           } else {
3364             real_offset = next_nonstatic_word_offset;
3365             next_nonstatic_word_offset += BytesPerInt;
3366           }
3367           break;
3368         case NONSTATIC_ALIGNED_DOUBLE:
3369         case NONSTATIC_DOUBLE:
3370           real_offset = next_nonstatic_double_offset;
3371           next_nonstatic_double_offset += BytesPerLong;
3372           break;
3373         default:
3374           ShouldNotReachHere();
3375       }
3376       fields->short_at_put(i + instanceKlass::low_offset,  extract_low_short_from_int(real_offset));
3377       fields->short_at_put(i + instanceKlass::high_offset, extract_high_short_from_int(real_offset));
3378     }
3379 
3380     // Size of instances
3381     int instance_size;
3382 
3383     next_nonstatic_type_offset = align_size_up(notaligned_offset, wordSize );
3384     instance_size = align_object_size(next_nonstatic_type_offset / wordSize);
3385 
3386     assert(instance_size == align_object_size(align_size_up((instanceOopDesc::base_offset_in_bytes() + nonstatic_field_size*heapOopSize), wordSize) / wordSize), "consistent layout helper value");
3387 
3388     // Number of non-static oop map blocks allocated at end of klass.
3389     const unsigned int total_oop_map_count =
3390       compute_oop_map_count(super_klass, nonstatic_oop_map_count,
3391                             first_nonstatic_oop_offset);
3392 
3393     // Compute reference type
3394     ReferenceType rt;
3395     if (super_klass() == NULL) {
3396       rt = REF_NONE;
3397     } else {
3398       rt = super_klass->reference_type();
3399     }
3400 
3401     // We can now create the basic klassOop for this klass
3402     klassOop ik = oopFactory::new_instanceKlass(vtable_size, itable_size,
3403                                                 static_field_size,
3404                                                 total_oop_map_count,
3405                                                 rt, CHECK_(nullHandle));
3406     instanceKlassHandle this_klass (THREAD, ik);
3407 
3408     assert(this_klass->static_field_size() == static_field_size, "sanity");
3409     assert(this_klass->nonstatic_oop_map_count() == total_oop_map_count,
3410            "sanity");
3411 
3412     // Fill in information already parsed
3413     this_klass->set_access_flags(access_flags);
3414     this_klass->set_should_verify_class(verify);
3415     jint lh = Klass::instance_layout_helper(instance_size, false);
3416     this_klass->set_layout_helper(lh);
3417     assert(this_klass->oop_is_instance(), "layout is correct");
3418     assert(this_klass->size_helper() == instance_size, "correct size_helper");
3419     // Not yet: supers are done below to support the new subtype-checking fields
3420     //this_klass->set_super(super_klass());
3421     this_klass->set_class_loader(class_loader());
3422     this_klass->set_nonstatic_field_size(nonstatic_field_size);
3423     this_klass->set_has_nonstatic_fields(has_nonstatic_fields);
3424     this_klass->set_static_oop_field_size(fac.static_oop_count);
3425     cp->set_pool_holder(this_klass());
3426     this_klass->set_constants(cp());
3427     this_klass->set_local_interfaces(local_interfaces());
3428     this_klass->set_fields(fields());
3429     this_klass->set_methods(methods());
3430     if (has_final_method) {
3431       this_klass->set_has_final_method();
3432     }
3433     this_klass->set_method_ordering(method_ordering());
3434     // The instanceKlass::_methods_jmethod_ids cache and the
3435     // instanceKlass::_methods_cached_itable_indices cache are
3436     // both managed on the assumption that the initial cache
3437     // size is equal to the number of methods in the class. If
3438     // that changes, then instanceKlass::idnum_can_increment()
3439     // has to be changed accordingly.
3440     this_klass->set_initial_method_idnum(methods->length());
3441     this_klass->set_name(cp->klass_name_at(this_class_index));
3442     if (LinkWellKnownClasses || is_anonymous())  // I am well known to myself
3443       cp->klass_at_put(this_class_index, this_klass()); // eagerly resolve
3444     this_klass->set_protection_domain(protection_domain());
3445     this_klass->set_fields_annotations(fields_annotations());
3446     this_klass->set_methods_annotations(methods_annotations());
3447     this_klass->set_methods_parameter_annotations(methods_parameter_annotations());
3448     this_klass->set_methods_default_annotations(methods_default_annotations());
3449 
3450     this_klass->set_minor_version(minor_version);
3451     this_klass->set_major_version(major_version);
3452 
3453     // Set up methodOop::intrinsic_id as soon as we know the names of methods.
3454     // (We used to do this lazily, but now we query it in Rewriter,
3455     // which is eagerly done for every method, so we might as well do it now,
3456     // when everything is fresh in memory.)
3457     if (methodOopDesc::klass_id_for_intrinsics(this_klass->as_klassOop()) != vmSymbols::NO_SID) {
3458       for (int j = 0; j < methods->length(); j++) {
3459         ((methodOop)methods->obj_at(j))->init_intrinsic_id();
3460       }
3461     }
3462 
3463     if (cached_class_file_bytes != NULL) {
3464       // JVMTI: we have an instanceKlass now, tell it about the cached bytes
3465       this_klass->set_cached_class_file(cached_class_file_bytes,
3466                                         cached_class_file_length);
3467     }
3468 
3469     // Miranda methods
3470     if ((num_miranda_methods > 0) ||
3471         // if this class introduced new miranda methods or
3472         (super_klass.not_null() && (super_klass->has_miranda_methods()))
3473         // super class exists and this class inherited miranda methods
3474         ) {
3475       this_klass->set_has_miranda_methods(); // then set a flag
3476     }
3477 
3478     // Additional attributes
3479     parse_classfile_attributes(cp, this_klass, CHECK_(nullHandle));
3480 
3481     // Make sure this is the end of class file stream
3482     guarantee_property(cfs->at_eos(), "Extra bytes at the end of class file %s", CHECK_(nullHandle));
3483 
3484     // Initialize static fields
3485     this_klass->do_local_static_fields(&initialize_static_field, CHECK_(nullHandle));
3486 
3487     // VerifyOops believes that once this has been set, the object is completely loaded.
3488     // Compute transitive closure of interfaces this class implements
3489     this_klass->set_transitive_interfaces(transitive_interfaces());
3490 
3491     // Fill in information needed to compute superclasses.
3492     this_klass->initialize_supers(super_klass(), CHECK_(nullHandle));
3493 
3494     // Initialize itable offset tables
3495     klassItable::setup_itable_offset_table(this_klass);
3496 
3497     // Do final class setup
3498     fill_oop_maps(this_klass, nonstatic_oop_map_count, nonstatic_oop_offsets, nonstatic_oop_counts);
3499 
3500     set_precomputed_flags(this_klass);
3501 
3502     // reinitialize modifiers, using the InnerClasses attribute
3503     int computed_modifiers = this_klass->compute_modifier_flags(CHECK_(nullHandle));
3504     this_klass->set_modifier_flags(computed_modifiers);
3505 
3506     // check if this class can access its super class
3507     check_super_class_access(this_klass, CHECK_(nullHandle));
3508 
3509     // check if this class can access its superinterfaces
3510     check_super_interface_access(this_klass, CHECK_(nullHandle));
3511 
3512     // check if this class overrides any final method
3513     check_final_method_override(this_klass, CHECK_(nullHandle));
3514 
3515     // check that if this class is an interface then it doesn't have static methods
3516     if (this_klass->is_interface()) {
3517       check_illegal_static_method(this_klass, CHECK_(nullHandle));
3518     }
3519 
3520     ClassLoadingService::notify_class_loaded(instanceKlass::cast(this_klass()),
3521                                              false /* not shared class */);
3522 
3523     if (TraceClassLoading) {
3524       // print in a single call to reduce interleaving of output
3525       if (cfs->source() != NULL) {
3526         tty->print("[Loaded %s from %s]\n", this_klass->external_name(),
3527                    cfs->source());
3528       } else if (class_loader.is_null()) {
3529         if (THREAD->is_Java_thread()) {
3530           klassOop caller = ((JavaThread*)THREAD)->security_get_caller_class(1);
3531           tty->print("[Loaded %s by instance of %s]\n",
3532                      this_klass->external_name(),
3533                      instanceKlass::cast(caller)->external_name());
3534         } else {
3535           tty->print("[Loaded %s]\n", this_klass->external_name());
3536         }
3537       } else {
3538         ResourceMark rm;
3539         tty->print("[Loaded %s from %s]\n", this_klass->external_name(),
3540                    instanceKlass::cast(class_loader->klass())->external_name());
3541       }
3542     }
3543 
3544     if (TraceClassResolution) {
3545       // print out the superclass.
3546       const char * from = Klass::cast(this_klass())->external_name();
3547       if (this_klass->java_super() != NULL) {
3548         tty->print("RESOLVE %s %s (super)\n", from, instanceKlass::cast(this_klass->java_super())->external_name());
3549       }
3550       // print out each of the interface classes referred to by this class.
3551       objArrayHandle local_interfaces(THREAD, this_klass->local_interfaces());
3552       if (!local_interfaces.is_null()) {
3553         int length = local_interfaces->length();
3554         for (int i = 0; i < length; i++) {
3555           klassOop k = klassOop(local_interfaces->obj_at(i));
3556           instanceKlass* to_class = instanceKlass::cast(k);
3557           const char * to = to_class->external_name();
3558           tty->print("RESOLVE %s %s (interface)\n", from, to);
3559         }
3560       }
3561     }
3562 
3563 #ifndef PRODUCT
3564     if( PrintCompactFieldsSavings ) {
3565       if( nonstatic_field_size < orig_nonstatic_field_size ) {
3566         tty->print("[Saved %d of %d bytes in %s]\n",
3567                  (orig_nonstatic_field_size - nonstatic_field_size)*heapOopSize,
3568                  orig_nonstatic_field_size*heapOopSize,
3569                  this_klass->external_name());
3570       } else if( nonstatic_field_size > orig_nonstatic_field_size ) {
3571         tty->print("[Wasted %d over %d bytes in %s]\n",
3572                  (nonstatic_field_size - orig_nonstatic_field_size)*heapOopSize,
3573                  orig_nonstatic_field_size*heapOopSize,
3574                  this_klass->external_name());
3575       }
3576     }
3577 #endif
3578 
3579     // preserve result across HandleMark
3580     preserve_this_klass = this_klass();
3581   }
3582 
3583   // Create new handle outside HandleMark
3584   instanceKlassHandle this_klass (THREAD, preserve_this_klass);
3585   debug_only(this_klass->as_klassOop()->verify();)
3586 
3587   return this_klass;
3588 }
3589 
3590 
3591 unsigned int
3592 ClassFileParser::compute_oop_map_count(instanceKlassHandle super,
3593                                        unsigned int nonstatic_oop_map_count,
3594                                        int first_nonstatic_oop_offset) {
3595   unsigned int map_count =
3596     super.is_null() ? 0 : super->nonstatic_oop_map_count();
3597   if (nonstatic_oop_map_count > 0) {
3598     // We have oops to add to map
3599     if (map_count == 0) {
3600       map_count = nonstatic_oop_map_count;
3601     } else {
3602       // Check whether we should add a new map block or whether the last one can
3603       // be extended
3604       OopMapBlock* const first_map = super->start_of_nonstatic_oop_maps();
3605       OopMapBlock* const last_map = first_map + map_count - 1;
3606 
3607       int next_offset = last_map->offset() + last_map->count() * heapOopSize;
3608       if (next_offset == first_nonstatic_oop_offset) {
3609         // There is no gap bettwen superklass's last oop field and first
3610         // local oop field, merge maps.
3611         nonstatic_oop_map_count -= 1;
3612       } else {
3613         // Superklass didn't end with a oop field, add extra maps
3614         assert(next_offset < first_nonstatic_oop_offset, "just checking");
3615       }
3616       map_count += nonstatic_oop_map_count;
3617     }
3618   }
3619   return map_count;
3620 }
3621 
3622 
3623 void ClassFileParser::fill_oop_maps(instanceKlassHandle k,
3624                                     unsigned int nonstatic_oop_map_count,
3625                                     int* nonstatic_oop_offsets,
3626                                     unsigned int* nonstatic_oop_counts) {
3627   OopMapBlock* this_oop_map = k->start_of_nonstatic_oop_maps();
3628   const instanceKlass* const super = k->superklass();
3629   const unsigned int super_count = super ? super->nonstatic_oop_map_count() : 0;
3630   if (super_count > 0) {
3631     // Copy maps from superklass
3632     OopMapBlock* super_oop_map = super->start_of_nonstatic_oop_maps();
3633     for (unsigned int i = 0; i < super_count; ++i) {
3634       *this_oop_map++ = *super_oop_map++;
3635     }
3636   }
3637 
3638   if (nonstatic_oop_map_count > 0) {
3639     if (super_count + nonstatic_oop_map_count > k->nonstatic_oop_map_count()) {
3640       // The counts differ because there is no gap between superklass's last oop
3641       // field and the first local oop field.  Extend the last oop map copied
3642       // from the superklass instead of creating new one.
3643       nonstatic_oop_map_count--;
3644       nonstatic_oop_offsets++;
3645       this_oop_map--;
3646       this_oop_map->set_count(this_oop_map->count() + *nonstatic_oop_counts++);
3647       this_oop_map++;
3648     }
3649 
3650     // Add new map blocks, fill them
3651     while (nonstatic_oop_map_count-- > 0) {
3652       this_oop_map->set_offset(*nonstatic_oop_offsets++);
3653       this_oop_map->set_count(*nonstatic_oop_counts++);
3654       this_oop_map++;
3655     }
3656     assert(k->start_of_nonstatic_oop_maps() + k->nonstatic_oop_map_count() ==
3657            this_oop_map, "sanity");
3658   }
3659 }
3660 
3661 
3662 void ClassFileParser::set_precomputed_flags(instanceKlassHandle k) {
3663   klassOop super = k->super();
3664 
3665   // Check if this klass has an empty finalize method (i.e. one with return bytecode only),
3666   // in which case we don't have to register objects as finalizable
3667   if (!_has_empty_finalizer) {
3668     if (_has_finalizer ||
3669         (super != NULL && super->klass_part()->has_finalizer())) {
3670       k->set_has_finalizer();
3671     }
3672   }
3673 
3674 #ifdef ASSERT
3675   bool f = false;
3676   methodOop m = k->lookup_method(vmSymbols::finalize_method_name(),
3677                                  vmSymbols::void_method_signature());
3678   if (m != NULL && !m->is_empty_method()) {
3679     f = true;
3680   }
3681   assert(f == k->has_finalizer(), "inconsistent has_finalizer");
3682 #endif
3683 
3684   // Check if this klass supports the java.lang.Cloneable interface
3685   if (SystemDictionary::Cloneable_klass_loaded()) {
3686     if (k->is_subtype_of(SystemDictionary::Cloneable_klass())) {
3687       k->set_is_cloneable();
3688     }
3689   }
3690 
3691   // Check if this klass has a vanilla default constructor
3692   if (super == NULL) {
3693     // java.lang.Object has empty default constructor
3694     k->set_has_vanilla_constructor();
3695   } else {
3696     if (Klass::cast(super)->has_vanilla_constructor() &&
3697         _has_vanilla_constructor) {
3698       k->set_has_vanilla_constructor();
3699     }
3700 #ifdef ASSERT
3701     bool v = false;
3702     if (Klass::cast(super)->has_vanilla_constructor()) {
3703       methodOop constructor = k->find_method(vmSymbols::object_initializer_name(
3704 ), vmSymbols::void_method_signature());
3705       if (constructor != NULL && constructor->is_vanilla_constructor()) {
3706         v = true;
3707       }
3708     }
3709     assert(v == k->has_vanilla_constructor(), "inconsistent has_vanilla_constructor");
3710 #endif
3711   }
3712 
3713   // If it cannot be fast-path allocated, set a bit in the layout helper.
3714   // See documentation of instanceKlass::can_be_fastpath_allocated().
3715   assert(k->size_helper() > 0, "layout_helper is initialized");
3716   if ((!RegisterFinalizersAtInit && k->has_finalizer())
3717       || k->is_abstract() || k->is_interface()
3718       || (k->name() == vmSymbols::java_lang_Class()
3719           && k->class_loader() == NULL)
3720       || k->size_helper() >= FastAllocateSizeLimit) {
3721     // Forbid fast-path allocation.
3722     jint lh = Klass::instance_layout_helper(k->size_helper(), true);
3723     k->set_layout_helper(lh);
3724   }
3725 }
3726 
3727 
3728 // utility method for appending and array with check for duplicates
3729 
3730 void append_interfaces(objArrayHandle result, int& index, objArrayOop ifs) {
3731   // iterate over new interfaces
3732   for (int i = 0; i < ifs->length(); i++) {
3733     oop e = ifs->obj_at(i);
3734     assert(e->is_klass() && instanceKlass::cast(klassOop(e))->is_interface(), "just checking");
3735     // check for duplicates
3736     bool duplicate = false;
3737     for (int j = 0; j < index; j++) {
3738       if (result->obj_at(j) == e) {
3739         duplicate = true;
3740         break;
3741       }
3742     }
3743     // add new interface
3744     if (!duplicate) {
3745       result->obj_at_put(index++, e);
3746     }
3747   }
3748 }
3749 
3750 objArrayHandle ClassFileParser::compute_transitive_interfaces(instanceKlassHandle super, objArrayHandle local_ifs, TRAPS) {
3751   // Compute maximum size for transitive interfaces
3752   int max_transitive_size = 0;
3753   int super_size = 0;
3754   // Add superclass transitive interfaces size
3755   if (super.not_null()) {
3756     super_size = super->transitive_interfaces()->length();
3757     max_transitive_size += super_size;
3758   }
3759   // Add local interfaces' super interfaces
3760   int local_size = local_ifs->length();
3761   for (int i = 0; i < local_size; i++) {
3762     klassOop l = klassOop(local_ifs->obj_at(i));
3763     max_transitive_size += instanceKlass::cast(l)->transitive_interfaces()->length();
3764   }
3765   // Finally add local interfaces
3766   max_transitive_size += local_size;
3767   // Construct array
3768   objArrayHandle result;
3769   if (max_transitive_size == 0) {
3770     // no interfaces, use canonicalized array
3771     result = objArrayHandle(THREAD, Universe::the_empty_system_obj_array());
3772   } else if (max_transitive_size == super_size) {
3773     // no new local interfaces added, share superklass' transitive interface array
3774     result = objArrayHandle(THREAD, super->transitive_interfaces());
3775   } else if (max_transitive_size == local_size) {
3776     // only local interfaces added, share local interface array
3777     result = local_ifs;
3778   } else {
3779     objArrayHandle nullHandle;
3780     objArrayOop new_objarray = oopFactory::new_system_objArray(max_transitive_size, CHECK_(nullHandle));
3781     result = objArrayHandle(THREAD, new_objarray);
3782     int index = 0;
3783     // Copy down from superclass
3784     if (super.not_null()) {
3785       append_interfaces(result, index, super->transitive_interfaces());
3786     }
3787     // Copy down from local interfaces' superinterfaces
3788     for (int i = 0; i < local_ifs->length(); i++) {
3789       klassOop l = klassOop(local_ifs->obj_at(i));
3790       append_interfaces(result, index, instanceKlass::cast(l)->transitive_interfaces());
3791     }
3792     // Finally add local interfaces
3793     append_interfaces(result, index, local_ifs());
3794 
3795     // Check if duplicates were removed
3796     if (index != max_transitive_size) {
3797       assert(index < max_transitive_size, "just checking");
3798       objArrayOop new_result = oopFactory::new_system_objArray(index, CHECK_(nullHandle));
3799       for (int i = 0; i < index; i++) {
3800         oop e = result->obj_at(i);
3801         assert(e != NULL, "just checking");
3802         new_result->obj_at_put(i, e);
3803       }
3804       result = objArrayHandle(THREAD, new_result);
3805     }
3806   }
3807   return result;
3808 }
3809 
3810 
3811 void ClassFileParser::check_super_class_access(instanceKlassHandle this_klass, TRAPS) {
3812   klassOop super = this_klass->super();
3813   if ((super != NULL) &&
3814       (!Reflection::verify_class_access(this_klass->as_klassOop(), super, false))) {
3815     ResourceMark rm(THREAD);
3816     Exceptions::fthrow(
3817       THREAD_AND_LOCATION,
3818       vmSymbolHandles::java_lang_IllegalAccessError(),
3819       "class %s cannot access its superclass %s",
3820       this_klass->external_name(),
3821       instanceKlass::cast(super)->external_name()
3822     );
3823     return;
3824   }
3825 }
3826 
3827 
3828 void ClassFileParser::check_super_interface_access(instanceKlassHandle this_klass, TRAPS) {
3829   objArrayHandle local_interfaces (THREAD, this_klass->local_interfaces());
3830   int lng = local_interfaces->length();
3831   for (int i = lng - 1; i >= 0; i--) {
3832     klassOop k = klassOop(local_interfaces->obj_at(i));
3833     assert (k != NULL && Klass::cast(k)->is_interface(), "invalid interface");
3834     if (!Reflection::verify_class_access(this_klass->as_klassOop(), k, false)) {
3835       ResourceMark rm(THREAD);
3836       Exceptions::fthrow(
3837         THREAD_AND_LOCATION,
3838         vmSymbolHandles::java_lang_IllegalAccessError(),
3839         "class %s cannot access its superinterface %s",
3840         this_klass->external_name(),
3841         instanceKlass::cast(k)->external_name()
3842       );
3843       return;
3844     }
3845   }
3846 }
3847 
3848 
3849 void ClassFileParser::check_final_method_override(instanceKlassHandle this_klass, TRAPS) {
3850   objArrayHandle methods (THREAD, this_klass->methods());
3851   int num_methods = methods->length();
3852 
3853   // go thru each method and check if it overrides a final method
3854   for (int index = 0; index < num_methods; index++) {
3855     methodOop m = (methodOop)methods->obj_at(index);
3856 
3857     // skip private, static and <init> methods
3858     if ((!m->is_private()) &&
3859         (!m->is_static()) &&
3860         (m->name() != vmSymbols::object_initializer_name())) {
3861 
3862       symbolOop name = m->name();
3863       symbolOop signature = m->signature();
3864       klassOop k = this_klass->super();
3865       methodOop super_m = NULL;
3866       while (k != NULL) {
3867         // skip supers that don't have final methods.
3868         if (k->klass_part()->has_final_method()) {
3869           // lookup a matching method in the super class hierarchy
3870           super_m = instanceKlass::cast(k)->lookup_method(name, signature);
3871           if (super_m == NULL) {
3872             break; // didn't find any match; get out
3873           }
3874 
3875           if (super_m->is_final() &&
3876               // matching method in super is final
3877               (Reflection::verify_field_access(this_klass->as_klassOop(),
3878                                                super_m->method_holder(),
3879                                                super_m->method_holder(),
3880                                                super_m->access_flags(), false))
3881             // this class can access super final method and therefore override
3882             ) {
3883             ResourceMark rm(THREAD);
3884             Exceptions::fthrow(
3885               THREAD_AND_LOCATION,
3886               vmSymbolHandles::java_lang_VerifyError(),
3887               "class %s overrides final method %s.%s",
3888               this_klass->external_name(),
3889               name->as_C_string(),
3890               signature->as_C_string()
3891             );
3892             return;
3893           }
3894 
3895           // continue to look from super_m's holder's super.
3896           k = instanceKlass::cast(super_m->method_holder())->super();
3897           continue;
3898         }
3899 
3900         k = k->klass_part()->super();
3901       }
3902     }
3903   }
3904 }
3905 
3906 
3907 // assumes that this_klass is an interface
3908 void ClassFileParser::check_illegal_static_method(instanceKlassHandle this_klass, TRAPS) {
3909   assert(this_klass->is_interface(), "not an interface");
3910   objArrayHandle methods (THREAD, this_klass->methods());
3911   int num_methods = methods->length();
3912 
3913   for (int index = 0; index < num_methods; index++) {
3914     methodOop m = (methodOop)methods->obj_at(index);
3915     // if m is static and not the init method, throw a verify error
3916     if ((m->is_static()) && (m->name() != vmSymbols::class_initializer_name())) {
3917       ResourceMark rm(THREAD);
3918       Exceptions::fthrow(
3919         THREAD_AND_LOCATION,
3920         vmSymbolHandles::java_lang_VerifyError(),
3921         "Illegal static method %s in interface %s",
3922         m->name()->as_C_string(),
3923         this_klass->external_name()
3924       );
3925       return;
3926     }
3927   }
3928 }
3929 
3930 // utility methods for format checking
3931 
3932 void ClassFileParser::verify_legal_class_modifiers(jint flags, TRAPS) {
3933   if (!_need_verify) { return; }
3934 
3935   const bool is_interface  = (flags & JVM_ACC_INTERFACE)  != 0;
3936   const bool is_abstract   = (flags & JVM_ACC_ABSTRACT)   != 0;
3937   const bool is_final      = (flags & JVM_ACC_FINAL)      != 0;
3938   const bool is_super      = (flags & JVM_ACC_SUPER)      != 0;
3939   const bool is_enum       = (flags & JVM_ACC_ENUM)       != 0;
3940   const bool is_annotation = (flags & JVM_ACC_ANNOTATION) != 0;
3941   const bool major_gte_15  = _major_version >= JAVA_1_5_VERSION;
3942 
3943   if ((is_abstract && is_final) ||
3944       (is_interface && !is_abstract) ||
3945       (is_interface && major_gte_15 && (is_super || is_enum)) ||
3946       (!is_interface && major_gte_15 && is_annotation)) {
3947     ResourceMark rm(THREAD);
3948     Exceptions::fthrow(
3949       THREAD_AND_LOCATION,
3950       vmSymbolHandles::java_lang_ClassFormatError(),
3951       "Illegal class modifiers in class %s: 0x%X",
3952       _class_name->as_C_string(), flags
3953     );
3954     return;
3955   }
3956 }
3957 
3958 bool ClassFileParser::has_illegal_visibility(jint flags) {
3959   const bool is_public    = (flags & JVM_ACC_PUBLIC)    != 0;
3960   const bool is_protected = (flags & JVM_ACC_PROTECTED) != 0;
3961   const bool is_private   = (flags & JVM_ACC_PRIVATE)   != 0;
3962 
3963   return ((is_public && is_protected) ||
3964           (is_public && is_private) ||
3965           (is_protected && is_private));
3966 }
3967 
3968 bool ClassFileParser::is_supported_version(u2 major, u2 minor) {
3969   u2 max_version =
3970     JDK_Version::is_gte_jdk17x_version() ? JAVA_MAX_SUPPORTED_VERSION :
3971     (JDK_Version::is_gte_jdk16x_version() ? JAVA_6_VERSION : JAVA_1_5_VERSION);
3972   return (major >= JAVA_MIN_SUPPORTED_VERSION) &&
3973          (major <= max_version) &&
3974          ((major != max_version) ||
3975           (minor <= JAVA_MAX_SUPPORTED_MINOR_VERSION));
3976 }
3977 
3978 void ClassFileParser::verify_legal_field_modifiers(
3979     jint flags, bool is_interface, TRAPS) {
3980   if (!_need_verify) { return; }
3981 
3982   const bool is_public    = (flags & JVM_ACC_PUBLIC)    != 0;
3983   const bool is_protected = (flags & JVM_ACC_PROTECTED) != 0;
3984   const bool is_private   = (flags & JVM_ACC_PRIVATE)   != 0;
3985   const bool is_static    = (flags & JVM_ACC_STATIC)    != 0;
3986   const bool is_final     = (flags & JVM_ACC_FINAL)     != 0;
3987   const bool is_volatile  = (flags & JVM_ACC_VOLATILE)  != 0;
3988   const bool is_transient = (flags & JVM_ACC_TRANSIENT) != 0;
3989   const bool is_enum      = (flags & JVM_ACC_ENUM)      != 0;
3990   const bool major_gte_15 = _major_version >= JAVA_1_5_VERSION;
3991 
3992   bool is_illegal = false;
3993 
3994   if (is_interface) {
3995     if (!is_public || !is_static || !is_final || is_private ||
3996         is_protected || is_volatile || is_transient ||
3997         (major_gte_15 && is_enum)) {
3998       is_illegal = true;
3999     }
4000   } else { // not interface
4001     if (has_illegal_visibility(flags) || (is_final && is_volatile)) {
4002       is_illegal = true;
4003     }
4004   }
4005 
4006   if (is_illegal) {
4007     ResourceMark rm(THREAD);
4008     Exceptions::fthrow(
4009       THREAD_AND_LOCATION,
4010       vmSymbolHandles::java_lang_ClassFormatError(),
4011       "Illegal field modifiers in class %s: 0x%X",
4012       _class_name->as_C_string(), flags);
4013     return;
4014   }
4015 }
4016 
4017 void ClassFileParser::verify_legal_method_modifiers(
4018     jint flags, bool is_interface, symbolHandle name, TRAPS) {
4019   if (!_need_verify) { return; }
4020 
4021   const bool is_public       = (flags & JVM_ACC_PUBLIC)       != 0;
4022   const bool is_private      = (flags & JVM_ACC_PRIVATE)      != 0;
4023   const bool is_static       = (flags & JVM_ACC_STATIC)       != 0;
4024   const bool is_final        = (flags & JVM_ACC_FINAL)        != 0;
4025   const bool is_native       = (flags & JVM_ACC_NATIVE)       != 0;
4026   const bool is_abstract     = (flags & JVM_ACC_ABSTRACT)     != 0;
4027   const bool is_bridge       = (flags & JVM_ACC_BRIDGE)       != 0;
4028   const bool is_strict       = (flags & JVM_ACC_STRICT)       != 0;
4029   const bool is_synchronized = (flags & JVM_ACC_SYNCHRONIZED) != 0;
4030   const bool major_gte_15    = _major_version >= JAVA_1_5_VERSION;
4031   const bool is_initializer  = (name == vmSymbols::object_initializer_name());
4032 
4033   bool is_illegal = false;
4034 
4035   if (is_interface) {
4036     if (!is_abstract || !is_public || is_static || is_final ||
4037         is_native || (major_gte_15 && (is_synchronized || is_strict))) {
4038       is_illegal = true;
4039     }
4040   } else { // not interface
4041     if (is_initializer) {
4042       if (is_static || is_final || is_synchronized || is_native ||
4043           is_abstract || (major_gte_15 && is_bridge)) {
4044         is_illegal = true;
4045       }
4046     } else { // not initializer
4047       if (is_abstract) {
4048         if ((is_final || is_native || is_private || is_static ||
4049             (major_gte_15 && (is_synchronized || is_strict)))) {
4050           is_illegal = true;
4051         }
4052       }
4053       if (has_illegal_visibility(flags)) {
4054         is_illegal = true;
4055       }
4056     }
4057   }
4058 
4059   if (is_illegal) {
4060     ResourceMark rm(THREAD);
4061     Exceptions::fthrow(
4062       THREAD_AND_LOCATION,
4063       vmSymbolHandles::java_lang_ClassFormatError(),
4064       "Method %s in class %s has illegal modifiers: 0x%X",
4065       name->as_C_string(), _class_name->as_C_string(), flags);
4066     return;
4067   }
4068 }
4069 
4070 void ClassFileParser::verify_legal_utf8(const unsigned char* buffer, int length, TRAPS) {
4071   assert(_need_verify, "only called when _need_verify is true");
4072   int i = 0;
4073   int count = length >> 2;
4074   for (int k=0; k<count; k++) {
4075     unsigned char b0 = buffer[i];
4076     unsigned char b1 = buffer[i+1];
4077     unsigned char b2 = buffer[i+2];
4078     unsigned char b3 = buffer[i+3];
4079     // For an unsigned char v,
4080     // (v | v - 1) is < 128 (highest bit 0) for 0 < v < 128;
4081     // (v | v - 1) is >= 128 (highest bit 1) for v == 0 or v >= 128.
4082     unsigned char res = b0 | b0 - 1 |
4083                         b1 | b1 - 1 |
4084                         b2 | b2 - 1 |
4085                         b3 | b3 - 1;
4086     if (res >= 128) break;
4087     i += 4;
4088   }
4089   for(; i < length; i++) {
4090     unsigned short c;
4091     // no embedded zeros
4092     guarantee_property((buffer[i] != 0), "Illegal UTF8 string in constant pool in class file %s", CHECK);
4093     if(buffer[i] < 128) {
4094       continue;
4095     }
4096     if ((i + 5) < length) { // see if it's legal supplementary character
4097       if (UTF8::is_supplementary_character(&buffer[i])) {
4098         c = UTF8::get_supplementary_character(&buffer[i]);
4099         i += 5;
4100         continue;
4101       }
4102     }
4103     switch (buffer[i] >> 4) {
4104       default: break;
4105       case 0x8: case 0x9: case 0xA: case 0xB: case 0xF:
4106         classfile_parse_error("Illegal UTF8 string in constant pool in class file %s", CHECK);
4107       case 0xC: case 0xD:  // 110xxxxx  10xxxxxx
4108         c = (buffer[i] & 0x1F) << 6;
4109         i++;
4110         if ((i < length) && ((buffer[i] & 0xC0) == 0x80)) {
4111           c += buffer[i] & 0x3F;
4112           if (_major_version <= 47 || c == 0 || c >= 0x80) {
4113             // for classes with major > 47, c must a null or a character in its shortest form
4114             break;
4115           }
4116         }
4117         classfile_parse_error("Illegal UTF8 string in constant pool in class file %s", CHECK);
4118       case 0xE:  // 1110xxxx 10xxxxxx 10xxxxxx
4119         c = (buffer[i] & 0xF) << 12;
4120         i += 2;
4121         if ((i < length) && ((buffer[i-1] & 0xC0) == 0x80) && ((buffer[i] & 0xC0) == 0x80)) {
4122           c += ((buffer[i-1] & 0x3F) << 6) + (buffer[i] & 0x3F);
4123           if (_major_version <= 47 || c >= 0x800) {
4124             // for classes with major > 47, c must be in its shortest form
4125             break;
4126           }
4127         }
4128         classfile_parse_error("Illegal UTF8 string in constant pool in class file %s", CHECK);
4129     }  // end of switch
4130   } // end of for
4131 }
4132 
4133 // Checks if name is a legal class name.
4134 void ClassFileParser::verify_legal_class_name(symbolHandle name, TRAPS) {
4135   if (!_need_verify || _relax_verify) { return; }
4136 
4137   char buf[fixed_buffer_size];
4138   char* bytes = name->as_utf8_flexible_buffer(THREAD, buf, fixed_buffer_size);
4139   unsigned int length = name->utf8_length();
4140   bool legal = false;
4141 
4142   if (length > 0) {
4143     char* p;
4144     if (bytes[0] == JVM_SIGNATURE_ARRAY) {
4145       p = skip_over_field_signature(bytes, false, length, CHECK);
4146       legal = (p != NULL) && ((p - bytes) == (int)length);
4147     } else if (_major_version < JAVA_1_5_VERSION) {
4148       if (bytes[0] != '<') {
4149         p = skip_over_field_name(bytes, true, length);
4150         legal = (p != NULL) && ((p - bytes) == (int)length);
4151       }
4152     } else {
4153       // 4900761: relax the constraints based on JSR202 spec
4154       // Class names may be drawn from the entire Unicode character set.
4155       // Identifiers between '/' must be unqualified names.
4156       // The utf8 string has been verified when parsing cpool entries.
4157       legal = verify_unqualified_name(bytes, length, LegalClass);
4158     }
4159   }
4160   if (!legal) {
4161     ResourceMark rm(THREAD);
4162     Exceptions::fthrow(
4163       THREAD_AND_LOCATION,
4164       vmSymbolHandles::java_lang_ClassFormatError(),
4165       "Illegal class name \"%s\" in class file %s", bytes,
4166       _class_name->as_C_string()
4167     );
4168     return;
4169   }
4170 }
4171 
4172 // Checks if name is a legal field name.
4173 void ClassFileParser::verify_legal_field_name(symbolHandle name, TRAPS) {
4174   if (!_need_verify || _relax_verify) { return; }
4175 
4176   char buf[fixed_buffer_size];
4177   char* bytes = name->as_utf8_flexible_buffer(THREAD, buf, fixed_buffer_size);
4178   unsigned int length = name->utf8_length();
4179   bool legal = false;
4180 
4181   if (length > 0) {
4182     if (_major_version < JAVA_1_5_VERSION) {
4183       if (bytes[0] != '<') {
4184         char* p = skip_over_field_name(bytes, false, length);
4185         legal = (p != NULL) && ((p - bytes) == (int)length);
4186       }
4187     } else {
4188       // 4881221: relax the constraints based on JSR202 spec
4189       legal = verify_unqualified_name(bytes, length, LegalField);
4190     }
4191   }
4192 
4193   if (!legal) {
4194     ResourceMark rm(THREAD);
4195     Exceptions::fthrow(
4196       THREAD_AND_LOCATION,
4197       vmSymbolHandles::java_lang_ClassFormatError(),
4198       "Illegal field name \"%s\" in class %s", bytes,
4199       _class_name->as_C_string()
4200     );
4201     return;
4202   }
4203 }
4204 
4205 // Checks if name is a legal method name.
4206 void ClassFileParser::verify_legal_method_name(symbolHandle name, TRAPS) {
4207   if (!_need_verify || _relax_verify) { return; }
4208 
4209   assert(!name.is_null(), "method name is null");
4210   char buf[fixed_buffer_size];
4211   char* bytes = name->as_utf8_flexible_buffer(THREAD, buf, fixed_buffer_size);
4212   unsigned int length = name->utf8_length();
4213   bool legal = false;
4214 
4215   if (length > 0) {
4216     if (bytes[0] == '<') {
4217       if (name == vmSymbols::object_initializer_name() || name == vmSymbols::class_initializer_name()) {
4218         legal = true;
4219       }
4220     } else if (_major_version < JAVA_1_5_VERSION) {
4221       char* p;
4222       p = skip_over_field_name(bytes, false, length);
4223       legal = (p != NULL) && ((p - bytes) == (int)length);
4224     } else {
4225       // 4881221: relax the constraints based on JSR202 spec
4226       legal = verify_unqualified_name(bytes, length, LegalMethod);
4227     }
4228   }
4229 
4230   if (!legal) {
4231     ResourceMark rm(THREAD);
4232     Exceptions::fthrow(
4233       THREAD_AND_LOCATION,
4234       vmSymbolHandles::java_lang_ClassFormatError(),
4235       "Illegal method name \"%s\" in class %s", bytes,
4236       _class_name->as_C_string()
4237     );
4238     return;
4239   }
4240 }
4241 
4242 
4243 // Checks if signature is a legal field signature.
4244 void ClassFileParser::verify_legal_field_signature(symbolHandle name, symbolHandle signature, TRAPS) {
4245   if (!_need_verify) { return; }
4246 
4247   char buf[fixed_buffer_size];
4248   char* bytes = signature->as_utf8_flexible_buffer(THREAD, buf, fixed_buffer_size);
4249   unsigned int length = signature->utf8_length();
4250   char* p = skip_over_field_signature(bytes, false, length, CHECK);
4251 
4252   if (p == NULL || (p - bytes) != (int)length) {
4253     throwIllegalSignature("Field", name, signature, CHECK);
4254   }
4255 }
4256 
4257 // Checks if signature is a legal method signature.
4258 // Returns number of parameters
4259 int ClassFileParser::verify_legal_method_signature(symbolHandle name, symbolHandle signature, TRAPS) {
4260   if (!_need_verify) {
4261     // make sure caller's args_size will be less than 0 even for non-static
4262     // method so it will be recomputed in compute_size_of_parameters().
4263     return -2;
4264   }
4265 
4266   unsigned int args_size = 0;
4267   char buf[fixed_buffer_size];
4268   char* p = signature->as_utf8_flexible_buffer(THREAD, buf, fixed_buffer_size);
4269   unsigned int length = signature->utf8_length();
4270   char* nextp;
4271 
4272   // The first character must be a '('
4273   if ((length > 0) && (*p++ == JVM_SIGNATURE_FUNC)) {
4274     length--;
4275     // Skip over legal field signatures
4276     nextp = skip_over_field_signature(p, false, length, CHECK_0);
4277     while ((length > 0) && (nextp != NULL)) {
4278       args_size++;
4279       if (p[0] == 'J' || p[0] == 'D') {
4280         args_size++;
4281       }
4282       length -= nextp - p;
4283       p = nextp;
4284       nextp = skip_over_field_signature(p, false, length, CHECK_0);
4285     }
4286     // The first non-signature thing better be a ')'
4287     if ((length > 0) && (*p++ == JVM_SIGNATURE_ENDFUNC)) {
4288       length--;
4289       if (name->utf8_length() > 0 && name->byte_at(0) == '<') {
4290         // All internal methods must return void
4291         if ((length == 1) && (p[0] == JVM_SIGNATURE_VOID)) {
4292           return args_size;
4293         }
4294       } else {
4295         // Now we better just have a return value
4296         nextp = skip_over_field_signature(p, true, length, CHECK_0);
4297         if (nextp && ((int)length == (nextp - p))) {
4298           return args_size;
4299         }
4300       }
4301     }
4302   }
4303   // Report error
4304   throwIllegalSignature("Method", name, signature, CHECK_0);
4305   return 0;
4306 }
4307 
4308 
4309 // Unqualified names may not contain the characters '.', ';', or '/'.
4310 // Method names also may not contain the characters '<' or '>', unless <init> or <clinit>.
4311 // Note that method names may not be <init> or <clinit> in this method.
4312 // Because these names have been checked as special cases before calling this method
4313 // in verify_legal_method_name.
4314 bool ClassFileParser::verify_unqualified_name(char* name, unsigned int length, int type) {
4315   jchar ch;
4316 
4317   for (char* p = name; p != name + length; ) {
4318     ch = *p;
4319     if (ch < 128) {
4320       p++;
4321       if (ch == '.' || ch == ';') {
4322         return false;   // do not permit '.' or ';'
4323       }
4324       if (type != LegalClass && ch == '/') {
4325         return false;   // do not permit '/' unless it's class name
4326       }
4327       if (type == LegalMethod && (ch == '<' || ch == '>')) {
4328         return false;   // do not permit '<' or '>' in method names
4329       }
4330     } else {
4331       char* tmp_p = UTF8::next(p, &ch);
4332       p = tmp_p;
4333     }
4334   }
4335   return true;
4336 }
4337 
4338 
4339 // Take pointer to a string. Skip over the longest part of the string that could
4340 // be taken as a fieldname. Allow '/' if slash_ok is true.
4341 // Return a pointer to just past the fieldname.
4342 // Return NULL if no fieldname at all was found, or in the case of slash_ok
4343 // being true, we saw consecutive slashes (meaning we were looking for a
4344 // qualified path but found something that was badly-formed).
4345 char* ClassFileParser::skip_over_field_name(char* name, bool slash_ok, unsigned int length) {
4346   char* p;
4347   jchar ch;
4348   jboolean last_is_slash = false;
4349   jboolean not_first_ch = false;
4350 
4351   for (p = name; p != name + length; not_first_ch = true) {
4352     char* old_p = p;
4353     ch = *p;
4354     if (ch < 128) {
4355       p++;
4356       // quick check for ascii
4357       if ((ch >= 'a' && ch <= 'z') ||
4358           (ch >= 'A' && ch <= 'Z') ||
4359           (ch == '_' || ch == '$') ||
4360           (not_first_ch && ch >= '0' && ch <= '9')) {
4361         last_is_slash = false;
4362         continue;
4363       }
4364       if (slash_ok && ch == '/') {
4365         if (last_is_slash) {
4366           return NULL;  // Don't permit consecutive slashes
4367         }
4368         last_is_slash = true;
4369         continue;
4370       }
4371     } else {
4372       jint unicode_ch;
4373       char* tmp_p = UTF8::next_character(p, &unicode_ch);
4374       p = tmp_p;
4375       last_is_slash = false;
4376       // Check if ch is Java identifier start or is Java identifier part
4377       // 4672820: call java.lang.Character methods directly without generating separate tables.
4378       EXCEPTION_MARK;
4379       instanceKlassHandle klass (THREAD, SystemDictionary::Character_klass());
4380 
4381       // return value
4382       JavaValue result(T_BOOLEAN);
4383       // Set up the arguments to isJavaIdentifierStart and isJavaIdentifierPart
4384       JavaCallArguments args;
4385       args.push_int(unicode_ch);
4386 
4387       // public static boolean isJavaIdentifierStart(char ch);
4388       JavaCalls::call_static(&result,
4389                              klass,
4390                              vmSymbolHandles::isJavaIdentifierStart_name(),
4391                              vmSymbolHandles::int_bool_signature(),
4392                              &args,
4393                              THREAD);
4394 
4395       if (HAS_PENDING_EXCEPTION) {
4396         CLEAR_PENDING_EXCEPTION;
4397         return 0;
4398       }
4399       if (result.get_jboolean()) {
4400         continue;
4401       }
4402 
4403       if (not_first_ch) {
4404         // public static boolean isJavaIdentifierPart(char ch);
4405         JavaCalls::call_static(&result,
4406                                klass,
4407                                vmSymbolHandles::isJavaIdentifierPart_name(),
4408                                vmSymbolHandles::int_bool_signature(),
4409                                &args,
4410                                THREAD);
4411 
4412         if (HAS_PENDING_EXCEPTION) {
4413           CLEAR_PENDING_EXCEPTION;
4414           return 0;
4415         }
4416 
4417         if (result.get_jboolean()) {
4418           continue;
4419         }
4420       }
4421     }
4422     return (not_first_ch) ? old_p : NULL;
4423   }
4424   return (not_first_ch) ? p : NULL;
4425 }
4426 
4427 
4428 // Take pointer to a string. Skip over the longest part of the string that could
4429 // be taken as a field signature. Allow "void" if void_ok.
4430 // Return a pointer to just past the signature.
4431 // Return NULL if no legal signature is found.
4432 char* ClassFileParser::skip_over_field_signature(char* signature,
4433                                                  bool void_ok,
4434                                                  unsigned int length,
4435                                                  TRAPS) {
4436   unsigned int array_dim = 0;
4437   while (length > 0) {
4438     switch (signature[0]) {
4439       case JVM_SIGNATURE_VOID: if (!void_ok) { return NULL; }
4440       case JVM_SIGNATURE_BOOLEAN:
4441       case JVM_SIGNATURE_BYTE:
4442       case JVM_SIGNATURE_CHAR:
4443       case JVM_SIGNATURE_SHORT:
4444       case JVM_SIGNATURE_INT:
4445       case JVM_SIGNATURE_FLOAT:
4446       case JVM_SIGNATURE_LONG:
4447       case JVM_SIGNATURE_DOUBLE:
4448         return signature + 1;
4449       case JVM_SIGNATURE_CLASS: {
4450         if (_major_version < JAVA_1_5_VERSION) {
4451           // Skip over the class name if one is there
4452           char* p = skip_over_field_name(signature + 1, true, --length);
4453 
4454           // The next character better be a semicolon
4455           if (p && (p - signature) > 1 && p[0] == ';') {
4456             return p + 1;
4457           }
4458         } else {
4459           // 4900761: For class version > 48, any unicode is allowed in class name.
4460           length--;
4461           signature++;
4462           while (length > 0 && signature[0] != ';') {
4463             if (signature[0] == '.') {
4464               classfile_parse_error("Class name contains illegal character '.' in descriptor in class file %s", CHECK_0);
4465             }
4466             length--;
4467             signature++;
4468           }
4469           if (signature[0] == ';') { return signature + 1; }
4470         }
4471 
4472         return NULL;
4473       }
4474       case JVM_SIGNATURE_ARRAY:
4475         array_dim++;
4476         if (array_dim > 255) {
4477           // 4277370: array descriptor is valid only if it represents 255 or fewer dimensions.
4478           classfile_parse_error("Array type descriptor has more than 255 dimensions in class file %s", CHECK_0);
4479         }
4480         // The rest of what's there better be a legal signature
4481         signature++;
4482         length--;
4483         void_ok = false;
4484         break;
4485 
4486       default:
4487         return NULL;
4488     }
4489   }
4490   return NULL;
4491 }