Code Review for open

Prepared by:lancea on Thu Mar 1 19:08:27 EST 2018
Workspace:/Users/ljanders/Documents/hg-workspaces/openjdk10/jdk10-Feb10/open
Compare against: http://hg.openjdk.java.net/jdk/jdk
Summary of changes: 162 lines changed: 112 ins; 34 del; 16 mod; 3343 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/CompileJavaModules.gmk

4 lines changed: 4 ins; 0 del; 0 mod; 646 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/common/Modules.gmk

1 line changed: 1 ins; 0 del; 0 mod; 452 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/jdk/src/classes/build/tools/jigsaw/GenGraphs.java

1 line changed: 1 ins; 0 del; 0 mod; 258 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/jdk/src/classes/build/tools/jigsaw/technology-summary.html

5 lines changed: 0 ins; 0 del; 5 mod; 442 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.se/share/classes/module-info.java

1 line changed: 1 ins; 0 del; 0 mod; 60 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.sql/share/classes/module-info.java

3 lines changed: 1 ins; 1 del; 1 mod; 41 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/TEST.groups

1 line changed: 1 ins; 0 del; 0 mod; 441 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/jdeps/modules/DotFileTest.java

4 lines changed: 4 ins; 0 del; 0 mod; 130 unchg

------ ------ ------ ------ --- New Patch Raw src/java.transaction.xa/share/classes/javax/transaction/xa/XAException.java (was src/java.sql/share/classes/javax/transaction/xa/XAException.java)

0 lines changed: 0 ins; 0 del; 0 mod; 201 unchg

------ ------ ------ ------ --- New Patch Raw src/java.transaction.xa/share/classes/javax/transaction/xa/XAResource.java (was src/java.sql/share/classes/javax/transaction/xa/XAResource.java)

0 lines changed: 0 ins; 0 del; 0 mod; 306 unchg

------ ------ ------ ------ --- New Patch Raw src/java.transaction.xa/share/classes/javax/transaction/xa/Xid.java (was src/java.sql/share/classes/javax/transaction/xa/Xid.java)

0 lines changed: 0 ins; 0 del; 0 mod; 72 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.transaction.xa/share/classes/javax/transaction/xa/package-info.java (was src/java.sql/share/classes/javax/transaction/xa/package.html)

68 lines changed: 28 ins; 33 del; 7 mod; 1 unchg

------ ------ ------ ------ --- New Patch Raw src/java.transaction.xa/share/classes/module-info.java

36 lines changed: 36 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/javax/transaction/xa/testng/Driver.java (was test/jdk/javax/transaction/testng/Driver.java)

5 lines changed: 2 ins; 0 del; 3 mod; 28 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/javax/transaction/xa/testng/JavaSqlModuleDriver.java

33 lines changed: 33 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/javax/transaction/xa/testng/test/transaction/XAExceptionTests.java (was test/jdk/javax/transaction/testng/test/transaction/XAExceptionTests.java)

0 lines changed: 0 ins; 0 del; 0 mod; 98 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/javax/transaction/xa/testng/util/SerializedTransactionExceptions.java (was test/jdk/javax/transaction/testng/util/SerializedTransactionExceptions.java)

0 lines changed: 0 ins; 0 del; 0 mod; 167 unchg

This code review page was prepared using /Users/ljanders/Downloads/webrev.ksh (vers 25.16-hg+openjdk.java.net).