--- old/test/hotspot/jtreg/runtime/LoaderConstraints/itableLdrConstraint/Test.java 2018-06-13 19:39:40.370550128 -0400 +++ new/test/hotspot/jtreg/runtime/LoaderConstraints/itableLdrConstraint/Test.java 2018-06-13 19:39:38.899311544 -0400 @@ -35,22 +35,28 @@ public class Test { - static String expectedErrorMessage1 = + // Break expected error messages into 2 parts since the loader name includes its identity + // hash which is unique and can't be compared against. + static String expectedErrorMessage1_part1 = "loader constraint violation in interface itable initialization for class test.C: " + "when selecting method test.I.m()Ltest/Foo; " + - "the class loader \"\" (instance of PreemptingClassLoader, " + - "child of \"app\" jdk.internal.loader.ClassLoaders$AppClassLoader) " + - "for super interface test.I, and the class loader \"app\" " + + "the class loader PreemptingClassLoader @"; + static String expectedErrorMessage1_part2 = + " (instance of PreemptingClassLoader, " + + "child of 'app' jdk.internal.loader.ClassLoaders$AppClassLoader) " + + "for super interface test.I, and the class loader 'app' " + "(instance of jdk.internal.loader.ClassLoaders$AppClassLoader) " + "of the selected method's type, test.J have different Class objects " + "for the type test.Foo used in the signature"; - static String expectedErrorMessage2 = + static String expectedErrorMessage2_part1 = "loader constraint violation in interface itable initialization for class test.C: " + "when selecting method test.I.m()Ltest/Foo; " + - "the class loader \"ItableLdrCnstrnt_Test_Loader\" (instance of PreemptingClassLoader, " + - "child of \"app\" jdk.internal.loader.ClassLoaders$AppClassLoader) " + - "for super interface test.I, and the class loader \"app\" " + + "the class loader 'ItableLdrCnstrnt_Test_Loader' @"; + static String expectedErrorMessage2_part2 = + " (instance of PreemptingClassLoader, " + + "child of 'app' jdk.internal.loader.ClassLoaders$AppClassLoader) " + + "for super interface test.I, and the class loader 'app' " + "(instance of jdk.internal.loader.ClassLoaders$AppClassLoader) " + "of the selected method's type, test.J have different Class objects " + "for the type test.Foo used in the signature"; @@ -63,7 +69,9 @@ // type super interface J. The selected method is not an overpass method nor // otherwise excluded from loader constraint checking. So, a LinkageError // exception should be thrown because the loader constraint check will fail. - public static void test(String loaderName, String expectedErrorMessage) throws Exception { + public static void test(String loaderName, + String expectedErrorMessage_part1, + String expectedErrorMessage_part2) throws Exception { Class c = test.Foo.class; // Forces standard class loader to load Foo. String[] classNames = {"test.Task", "test.Foo", "test.C", "test.I"}; ClassLoader l = new PreemptingClassLoader(loaderName, classNames); @@ -73,8 +81,9 @@ throw new RuntimeException("Expected LinkageError exception not thrown"); } catch (LinkageError e) { String errorMsg = e.getMessage(); - if (!errorMsg.equals(expectedErrorMessage)) { - System.out.println("Expected: " + expectedErrorMessage + "\n" + + if (!errorMsg.contains(expectedErrorMessage_part1) || + !errorMsg.contains(expectedErrorMessage_part2)) { + System.out.println("Expected: " + expectedErrorMessage_part1 + "" + expectedErrorMessage_part2 + "\n" + "but got: " + errorMsg); throw new RuntimeException("Wrong LinkageError exception thrown: " + errorMsg); } @@ -83,7 +92,7 @@ } public static void main(String... args) throws Exception { - test(null, expectedErrorMessage1); - test("ItableLdrCnstrnt_Test_Loader", expectedErrorMessage2); + test(null, expectedErrorMessage1_part1, expectedErrorMessage1_part2); + test("ItableLdrCnstrnt_Test_Loader", expectedErrorMessage2_part1, expectedErrorMessage2_part2); } }