Code Review for open

Prepared by:lkorinth on Tue Nov 21 15:47:54 CET 2017
Workspace:/home/lkorinth/repos/hs/open
Compare against version:.^
Summary of changes: 29 lines changed: 9 ins; 13 del; 7 mod; 2977 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1ConcurrentMark.cpp

rev 47875 : 8190408: Run G1CMRemarkTask with the appropriate amount of threads instead of starting up everyone

Removing an if statement. The if-statement did safeguard that the
worker_id was always within the number of active tasks in _cm.

However the active number of tasks in _cm is set directly before the
remark task is created (set_concurrency_and_phase()). The value is
taken from the work gang (g1h->workers()->active_workers()). Thus, as
set_concurrency*() is not called during the actual remarking, the size
of the work-gang will be in sync with the _cm->active_tasks() -- at
least during the remark phase.

The code becomes somewhat easier to read, and hopefully one does not
get confused that we have too many threads running.
29 lines changed: 9 ins; 13 del; 7 mod; 2977 unchg

This code review page was prepared using /home/lkorinth/local/bin/webrev.ksh (vers 25.16-hg+openjdk.java.net).