Code Review for jdk

Prepared by:lucy on Tue May 21 15:54:31 CEST 2019
Workspace:
Compare against: http://hg.openjdk.java.net/jdk/jdk
Compare against version:54959
Summary of changes: 2996 lines changed: 2297 ins; 219 del; 480 mod; 73049 unchg
Changeset: jdk.changeset
Bug id: <title>[JDK-8213084] Rework and enhance Print[Opto]Assembly output - Java Bug System</title>
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/aarch64/assembler_aarch64.hpp

rev 54960 : 8213084: Rework and enhance Print[Opto]Assembly output
Reviewed-by: kvn, thartmann
8 lines changed: 8 ins; 0 del; 0 mod; 2775 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/aarch64/disassembler_aarch64.hpp

rev 54960 : 8213084: Rework and enhance Print[Opto]Assembly output
Reviewed-by: kvn, thartmann
20 lines changed: 20 ins; 0 del; 0 mod; 37 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/arm/assembler_arm_32.hpp

rev 54960 : 8213084: Rework and enhance Print[Opto]Assembly output
Reviewed-by: kvn, thartmann
8 lines changed: 8 ins; 0 del; 0 mod; 1255 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/arm/disassembler_arm.hpp

rev 54960 : 8213084: Rework and enhance Print[Opto]Assembly output
Reviewed-by: kvn, thartmann
20 lines changed: 20 ins; 0 del; 0 mod; 36 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/ppc/assembler_ppc.hpp

rev 54960 : 8213084: Rework and enhance Print[Opto]Assembly output
Reviewed-by: kvn, thartmann
6 lines changed: 2 ins; 0 del; 4 mod; 2449 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/ppc/disassembler_ppc.hpp

rev 54960 : 8213084: Rework and enhance Print[Opto]Assembly output
Reviewed-by: kvn, thartmann
20 lines changed: 19 ins; 0 del; 1 mod; 36 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/ppc/vm_version_ppc.cpp

rev 54960 : 8213084: Rework and enhance Print[Opto]Assembly output
Reviewed-by: kvn, thartmann
5 lines changed: 3 ins; 0 del; 2 mod; 974 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/s390/assembler_s390.hpp

rev 54960 : 8213084: Rework and enhance Print[Opto]Assembly output
Reviewed-by: kvn, thartmann
5 lines changed: 0 ins; 0 del; 5 mod; 3282 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/s390/assembler_s390.inline.hpp

rev 54960 : 8213084: Rework and enhance Print[Opto]Assembly output
Reviewed-by: kvn, thartmann
1 line changed: 0 ins; 0 del; 1 mod; 1462 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/s390/disassembler_s390.hpp

rev 54960 : 8213084: Rework and enhance Print[Opto]Assembly output
Reviewed-by: kvn, thartmann
28 lines changed: 25 ins; 0 del; 3 mod; 34 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/s390/s390.ad

rev 54960 : 8213084: Rework and enhance Print[Opto]Assembly output
Reviewed-by: kvn, thartmann
51 lines changed: 0 ins; 1 del; 50 mod; 10975 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/s390/vm_version_s390.cpp

rev 54960 : 8213084: Rework and enhance Print[Opto]Assembly output
Reviewed-by: kvn, thartmann
4 lines changed: 2 ins; 0 del; 2 mod; 1219 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/sparc/assembler_sparc.hpp

rev 54960 : 8213084: Rework and enhance Print[Opto]Assembly output
Reviewed-by: kvn, thartmann
8 lines changed: 8 ins; 0 del; 0 mod; 1331 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/sparc/disassembler_sparc.hpp

rev 54960 : 8213084: Rework and enhance Print[Opto]Assembly output
Reviewed-by: kvn, thartmann
20 lines changed: 20 ins; 0 del; 0 mod; 36 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/sparc/sparc.ad

rev 54960 : 8213084: Rework and enhance Print[Opto]Assembly output
Reviewed-by: kvn, thartmann
3 lines changed: 1 ins; 0 del; 2 mod; 10953 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/assembler_x86.hpp

rev 54960 : 8213084: Rework and enhance Print[Opto]Assembly output
Reviewed-by: kvn, thartmann
11 lines changed: 11 ins; 0 del; 0 mod; 2334 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/disassembler_x86.hpp

rev 54960 : 8213084: Rework and enhance Print[Opto]Assembly output
Reviewed-by: kvn, thartmann
21 lines changed: 21 ins; 0 del; 0 mod; 36 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/x86_64.ad

rev 54960 : 8213084: Rework and enhance Print[Opto]Assembly output
Reviewed-by: kvn, thartmann
25 lines changed: 0 ins; 0 del; 25 mod; 13061 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/zero/assembler_zero.hpp

rev 54960 : 8213084: Rework and enhance Print[Opto]Assembly output
Reviewed-by: kvn, thartmann
6 lines changed: 6 ins; 0 del; 0 mod; 62 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/zero/disassembler_zero.hpp

rev 54960 : 8213084: Rework and enhance Print[Opto]Assembly output
Reviewed-by: kvn, thartmann
20 lines changed: 20 ins; 0 del; 0 mod; 37 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/asm/codeBuffer.cpp

rev 54960 : 8213084: Rework and enhance Print[Opto]Assembly output
Reviewed-by: kvn, thartmann
23 lines changed: 17 ins; 0 del; 6 mod; 1214 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/asm/codeBuffer.hpp

rev 54960 : 8213084: Rework and enhance Print[Opto]Assembly output
Reviewed-by: kvn, thartmann
30 lines changed: 29 ins; 0 del; 1 mod; 669 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/code/codeBlob.cpp

rev 54960 : 8213084: Rework and enhance Print[Opto]Assembly output
Reviewed-by: kvn, thartmann
8 lines changed: 7 ins; 0 del; 1 mod; 677 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/code/codeBlob.hpp

rev 54960 : 8213084: Rework and enhance Print[Opto]Assembly output
Reviewed-by: kvn, thartmann
5 lines changed: 4 ins; 0 del; 1 mod; 733 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/code/exceptionHandlerTable.cpp

rev 54960 : 8213084: Rework and enhance Print[Opto]Assembly output
Reviewed-by: kvn, thartmann
19 lines changed: 14 ins; 0 del; 5 mod; 226 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/code/nmethod.cpp

rev 54960 : 8213084: Rework and enhance Print[Opto]Assembly output
Reviewed-by: kvn, thartmann
639 lines changed: 440 ins; 35 del; 164 mod; 2721 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/code/nmethod.hpp

rev 54960 : 8213084: Rework and enhance Print[Opto]Assembly output
Reviewed-by: kvn, thartmann
44 lines changed: 34 ins; 4 del; 6 mod; 627 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/code/pcDesc.cpp

rev 54960 : 8213084: Rework and enhance Print[Opto]Assembly output
Reviewed-by: kvn, thartmann
9 lines changed: 5 ins; 0 del; 4 mod; 59 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/code/pcDesc.hpp

rev 54960 : 8213084: Rework and enhance Print[Opto]Assembly output
Reviewed-by: kvn, thartmann
2 lines changed: 1 ins; 0 del; 1 mod; 98 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/code/vmreg.cpp

rev 54960 : 8213084: Rework and enhance Print[Opto]Assembly output
Reviewed-by: kvn, thartmann
1 line changed: 0 ins; 0 del; 1 mod; 51 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/code/vtableStubs.cpp

rev 54960 : 8213084: Rework and enhance Print[Opto]Assembly output
Reviewed-by: kvn, thartmann
1 line changed: 0 ins; 0 del; 1 mod; 330 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/compiler/disassembler.cpp

rev 54960 : 8213084: Rework and enhance Print[Opto]Assembly output
Reviewed-by: kvn, thartmann
739 lines changed: 462 ins; 168 del; 109 mod; 431 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/compiler/disassembler.hpp

rev 54960 : 8213084: Rework and enhance Print[Opto]Assembly output
Reviewed-by: kvn, thartmann
49 lines changed: 37 ins; 0 del; 12 mod; 81 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/compiler/oopMap.cpp

rev 54960 : 8213084: Rework and enhance Print[Opto]Assembly output
Reviewed-by: kvn, thartmann
22 lines changed: 11 ins; 2 del; 9 mod; 832 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/opto/block.cpp

rev 54960 : 8213084: Rework and enhance Print[Opto]Assembly output
Reviewed-by: kvn, thartmann
19 lines changed: 9 ins; 0 del; 10 mod; 1771 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/opto/compile.cpp

rev 54960 : 8213084: Rework and enhance Print[Opto]Assembly output
Reviewed-by: kvn, thartmann
75 lines changed: 27 ins; 8 del; 40 mod; 4649 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/opto/compile.hpp

rev 54960 : 8213084: Rework and enhance Print[Opto]Assembly output
Reviewed-by: kvn, thartmann
7 lines changed: 6 ins; 0 del; 1 mod; 1380 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/opto/output.cpp

rev 54960 : 8213084: Rework and enhance Print[Opto]Assembly output
Reviewed-by: kvn, thartmann
29 lines changed: 18 ins; 1 del; 10 mod; 2897 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/stubCodeGenerator.cpp

rev 54960 : 8213084: Rework and enhance Print[Opto]Assembly output
Reviewed-by: kvn, thartmann
6 lines changed: 3 ins; 0 del; 3 mod; 126 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/utilities/globalDefinitions.hpp

rev 54960 : 8213084: Rework and enhance Print[Opto]Assembly output
Reviewed-by: kvn, thartmann
20 lines changed: 20 ins; 0 del; 0 mod; 1093 unchg

------ ------ ------ ------ ------ --- New ----- Raw src/hotspot/cpu/ppc/disassembler_ppc.cpp

rev 54960 : 8213084: Rework and enhance Print[Opto]Assembly output
Reviewed-by: kvn, thartmann
201 lines changed: 201 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw src/hotspot/cpu/s390/disassembler_s390.cpp

rev 54960 : 8213084: Rework and enhance Print[Opto]Assembly output
Reviewed-by: kvn, thartmann
261 lines changed: 261 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw src/hotspot/share/compiler/abstractDisassembler.cpp

rev 54960 : 8213084: Rework and enhance Print[Opto]Assembly output
Reviewed-by: kvn, thartmann
379 lines changed: 379 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw src/hotspot/share/compiler/abstractDisassembler.hpp

rev 54960 : 8213084: Rework and enhance Print[Opto]Assembly output
Reviewed-by: kvn, thartmann
118 lines changed: 118 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /usr/work/openjdk/bin/webrev.ksh (vers 25.12-hg+openjdk.java.net).