Code Review for jdk

Prepared by:lucy on Thu Nov 14 17:03:12 CET 2019
Workspace:
Compare against: http://hg.openjdk.java.net/jdk/jdk
Compare against version:56940
Summary of changes: 1037 lines changed: 529 ins; 474 del; 34 mod; 23183 unchg
Changeset: jdk.changeset
Bug id: JDK-8233787
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw make/hotspot/lib/CompileJvm.gmk

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
5 lines changed: 0 ins; 0 del; 5 mod; 311 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/aarch64/vm_version_aarch64.cpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
2 lines changed: 1 ins; 1 del; 0 mod; 472 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/aarch64/vm_version_aarch64.hpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
2 lines changed: 1 ins; 1 del; 0 mod; 130 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/aarch64/vm_version_ext_aarch64.hpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
2 lines changed: 1 ins; 1 del; 0 mod; 53 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/arm/register_arm.hpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
1 line changed: 0 ins; 0 del; 1 mod; 439 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/arm/vm_version_arm.hpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
2 lines changed: 1 ins; 1 del; 0 mod; 112 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/arm/vm_version_arm_32.cpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
1 line changed: 0 ins; 0 del; 1 mod; 350 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/arm/vm_version_ext_arm.hpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
2 lines changed: 1 ins; 1 del; 0 mod; 53 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/ppc/vm_version_ext_ppc.hpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
2 lines changed: 1 ins; 1 del; 0 mod; 61 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/ppc/vm_version_ppc.cpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
2 lines changed: 1 ins; 1 del; 0 mod; 982 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/ppc/vm_version_ppc.hpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
2 lines changed: 1 ins; 1 del; 0 mod; 132 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/s390/register_s390.hpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
1 line changed: 0 ins; 0 del; 1 mod; 581 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/s390/vm_version_ext_s390.hpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
2 lines changed: 1 ins; 1 del; 0 mod; 61 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/s390/vm_version_s390.cpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
3 lines changed: 0 ins; 0 del; 3 mod; 1224 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/s390/vm_version_s390.hpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
2 lines changed: 1 ins; 1 del; 0 mod; 495 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/sparc/vm_version_ext_sparc.hpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
2 lines changed: 1 ins; 1 del; 0 mod; 68 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/sparc/vm_version_sparc.cpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
1 line changed: 0 ins; 0 del; 1 mod; 523 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/sparc/vm_version_sparc.hpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
2 lines changed: 1 ins; 1 del; 0 mod; 375 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/assembler_x86.hpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
1 line changed: 0 ins; 0 del; 1 mod; 2362 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/sharedRuntime_x86_32.cpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
2 lines changed: 1 ins; 1 del; 0 mod; 3308 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
2 lines changed: 1 ins; 1 del; 0 mod; 4064 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/vm_version_ext_x86.hpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
2 lines changed: 1 ins; 1 del; 0 mod; 105 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/vm_version_x86.cpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
2 lines changed: 1 ins; 1 del; 0 mod; 1754 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/vm_version_x86.hpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
2 lines changed: 1 ins; 1 del; 0 mod; 1008 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/zero/register_zero.hpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
1 line changed: 0 ins; 0 del; 1 mod; 120 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/zero/vm_version_ext_zero.hpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
2 lines changed: 1 ins; 1 del; 0 mod; 53 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/zero/vm_version_zero.cpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
1 line changed: 0 ins; 0 del; 1 mod; 44 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/zero/vm_version_zero.hpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
2 lines changed: 1 ins; 1 del; 0 mod; 36 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/os/bsd/os_perf_bsd.cpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
1 line changed: 0 ins; 0 del; 1 mod; 485 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/os/windows/os_perf_windows.cpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
1 line changed: 0 ins; 0 del; 1 mod; 1424 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/os_cpu/bsd_x86/vm_version_bsd_x86.cpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
1 line changed: 0 ins; 0 del; 1 mod; 26 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/os_cpu/bsd_zero/vm_version_bsd_zero.cpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
1 line changed: 0 ins; 0 del; 1 mod; 29 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/os_cpu/linux_aarch64/atomic_linux_aarch64.hpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
1 line changed: 0 ins; 0 del; 1 mod; 76 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/os_cpu/linux_aarch64/orderAccess_linux_aarch64.hpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
1 line changed: 0 ins; 0 del; 1 mod; 74 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/os_cpu/linux_aarch64/vm_version_linux_aarch64.cpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
1 line changed: 0 ins; 0 del; 1 mod; 28 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/os_cpu/linux_arm/atomic_linux_arm.hpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
1 line changed: 0 ins; 0 del; 1 mod; 139 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/os_cpu/linux_arm/orderAccess_linux_arm.hpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
1 line changed: 0 ins; 0 del; 1 mod; 105 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/os_cpu/linux_arm/vm_version_linux_arm_32.cpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
1 line changed: 0 ins; 0 del; 1 mod; 47 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/os_cpu/linux_s390/atomic_linux_s390.hpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
1 line changed: 0 ins; 0 del; 1 mod; 337 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/os_cpu/linux_s390/orderAccess_linux_s390.hpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
1 line changed: 0 ins; 0 del; 1 mod; 91 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/os_cpu/linux_sparc/vm_version_linux_sparc.cpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
1 line changed: 0 ins; 0 del; 1 mod; 351 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/os_cpu/linux_x86/vm_version_linux_x86.cpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
1 line changed: 0 ins; 0 del; 1 mod; 27 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/os_cpu/linux_zero/vm_version_linux_zero.cpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
1 line changed: 0 ins; 0 del; 1 mod; 29 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/os_cpu/solaris_sparc/vm_version_solaris_sparc.cpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
1 line changed: 0 ins; 0 del; 1 mod; 516 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/os_cpu/solaris_x86/vm_version_solaris_x86.cpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
1 line changed: 0 ins; 0 del; 1 mod; 27 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/os_cpu/windows_x86/vm_version_windows_x86.cpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
1 line changed: 0 ins; 0 del; 1 mod; 27 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/vm_version.cpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
291 lines changed: 0 ins; 291 del; 0 mod; 39 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/vm_version.hpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
165 lines changed: 0 ins; 164 del; 1 mod; 30 unchg

------ ------ ------ ------ ------ --- New ----- Raw src/hotspot/share/runtime/abstract_vm_version.cpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
316 lines changed: 316 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw src/hotspot/share/runtime/abstract_vm_version.hpp

rev 56941 : 8233787: Break cycle in vm_version* includes
Reviewed-by:
194 lines changed: 194 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /usr/work/openjdk/bin/webrev.ksh (vers 25.12-hg+openjdk.java.net).