# HG changeset patch # User mbaesken # Date 1541416745 -3600 # Mon Nov 05 12:19:05 2018 +0100 # Node ID 58568eda839ec400863d279cce7ef9584d72070e # Parent 89c73c4b1efe2e00e39c5a6b1db2c6c4a7ddfb64 8213366: windows: avoid handle leak in Java_sun_nio_fs_WindowsNativeDispatcher_FindFirstFile0 diff --git a/src/java.base/windows/native/libnio/fs/WindowsNativeDispatcher.c b/src/java.base/windows/native/libnio/fs/WindowsNativeDispatcher.c --- a/src/java.base/windows/native/libnio/fs/WindowsNativeDispatcher.c +++ b/src/java.base/windows/native/libnio/fs/WindowsNativeDispatcher.c @@ -311,8 +311,10 @@ HANDLE handle = FindFirstFileW(lpFileName, &data); if (handle != INVALID_HANDLE_VALUE) { jstring name = (*env)->NewString(env, data.cFileName, (jsize)wcslen(data.cFileName)); - if (name == NULL) + if (name == NULL) { + FindClose(handle); return; + } (*env)->SetLongField(env, obj, findFirst_handle, ptr_to_jlong(handle)); (*env)->SetObjectField(env, obj, findFirst_name, name); (*env)->SetIntField(env, obj, findFirst_attributes, data.dwFileAttributes);