Code Review for jdk_sunpkcs11

Prepared by:mbalao on Tue Sep 18 15:58:06 CEST 2018
Workspace:/home/martin/redhat/java/openjdk/repositories/public/jdk_sunpkcs11
Compare against: http://hg.openjdk.java.net/jdk/jdk
Summary of changes: 1270 lines changed: 919 ins; 126 del; 225 mod; 14892 unchg
Patch of changes: jdk_sunpkcs11.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11Cipher.java

65 lines changed: 32 ins; 21 del; 12 mod; 896 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11DHKeyFactory.java

16 lines changed: 12 ins; 0 del; 4 mod; 259 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11DSAKeyFactory.java

16 lines changed: 12 ins; 0 del; 4 mod; 259 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11Digest.java

8 lines changed: 6 ins; 0 del; 2 mod; 323 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11ECDHKeyAgreement.java

20 lines changed: 12 ins; 0 del; 8 mod; 206 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11ECKeyFactory.java

20 lines changed: 14 ins; 0 del; 6 mod; 327 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11Key.java

246 lines changed: 183 ins; 3 del; 60 mod; 1124 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11KeyAgreement.java

20 lines changed: 12 ins; 0 del; 8 mod; 359 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11KeyGenerator.java

2 lines changed: 0 ins; 0 del; 2 mod; 282 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11KeyPairGenerator.java

4 lines changed: 0 ins; 0 del; 4 mod; 425 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11KeyStore.java

26 lines changed: 16 ins; 2 del; 8 mod; 2674 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11Mac.java

85 lines changed: 22 ins; 37 del; 26 mod; 206 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11RSACipher.java

128 lines changed: 68 ins; 36 del; 24 mod; 617 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11RSAKeyFactory.java

24 lines changed: 18 ins; 0 del; 6 mod; 320 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11SecretKeyFactory.java

9 lines changed: 6 ins; 0 del; 3 mod; 355 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11Signature.java

88 lines changed: 33 ins; 27 del; 28 mod; 822 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsKeyMaterialGenerator.java

15 lines changed: 7 ins; 0 del; 8 mod; 216 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsMasterSecretGenerator.java

10 lines changed: 7 ins; 0 del; 3 mod; 166 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsPrfGenerator.java

22 lines changed: 14 ins; 0 del; 8 mod; 161 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsRsaPremasterSecretGenerator.java

1 line changed: 0 ins; 0 del; 1 mod; 136 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/PKCS11.java

38 lines changed: 38 ins; 0 del; 0 mod; 1828 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11_keymgmt.c

404 lines changed: 404 ins; 0 del; 0 mod; 773 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/native/libj2pkcs11/pkcs11t.h

1 line changed: 1 ins; 0 del; 0 mod; 1685 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/native/libj2pkcs11/pkcs11wrapper.h

2 lines changed: 2 ins; 0 del; 0 mod; 473 unchg

This code review page was prepared using /home/martin/redhat/java/openjdk/scripts/webrev.ksh (vers 25.16-hg+openjdk.java.net).