Code Review for jdk_tls12_sunpkcs11

Prepared by:mbalao on Tue May 22 17:08:51 ART 2018
Workspace:/home/martin/redhat/java/openjdk/repositories/public/jdk_tls12_sunpkcs11
Compare against: http://hg.openjdk.java.net/jdk/jdk
Summary of changes: 3491 lines changed: 3150 ins; 160 del; 181 mod; 10590 unchg
Patch of changes: jdk_tls12_sunpkcs11.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/module-info.java

1 line changed: 1 ins; 0 del; 0 mod; 363 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/ProtocolVersion.java

32 lines changed: 14 ins; 0 del; 18 mod; 297 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/Config.java

5 lines changed: 2 ins; 2 del; 1 mod; 1007 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsKeyMaterialGenerator.java

39 lines changed: 27 ins; 0 del; 12 mod; 212 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsMasterSecretGenerator.java

43 lines changed: 23 ins; 4 del; 16 mod; 149 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsPrfGenerator.java

41 lines changed: 39 ins; 0 del; 2 mod; 167 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsRsaPremasterSecretGenerator.java

18 lines changed: 10 ins; 1 del; 7 mod; 129 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/SunPKCS11.java

39 lines changed: 19 ins; 19 del; 1 mod; 1485 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK_ATTRIBUTE.java

3 lines changed: 3 ins; 0 del; 0 mod; 229 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK_MECHANISM.java

12 lines changed: 12 ins; 0 del; 0 mod; 166 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/Functions.java

3 lines changed: 3 ins; 0 del; 0 mod; 905 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/PKCS11Constants.java

8 lines changed: 8 ins; 0 del; 0 mod; 966 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11_convert.c

459 lines changed: 302 ins; 110 del; 47 mod; 1685 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11_keymgmt.c

185 lines changed: 87 ins; 24 del; 74 mod; 675 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/native/libj2pkcs11/pkcs11t.h

36 lines changed: 36 ins; 0 del; 0 mod; 1685 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/native/libj2pkcs11/pkcs11wrapper.h

8 lines changed: 5 ins; 0 del; 3 mod; 470 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK_TLS12_KEY_MAT_PARAMS.java

153 lines changed: 153 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK_TLS12_MASTER_KEY_DERIVE_PARAMS.java

67 lines changed: 67 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK_TLS_MAC_PARAMS.java

66 lines changed: 66 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/sun/security/pkcs11/tls/TestTLS12.java

2273 lines changed: 2273 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/martin/Programs/webrev.ksh (vers 25.16-hg+openjdk.java.net).