Code Review for jdk

Prepared by:mbalao on Fri Aug 28 16:54:19 -03 2020
Workspace:/home/martin/local_lab/dev/openjdk/repositories/public/jdk8u-dev/jdk
Compare against: ssh://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk
Compare against version:14128
Summary of changes: 182 lines changed: 173 ins; 0 del; 9 mod; 851 unchg
Changeset: jdk.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/pkcs11/Secmod.java

rev 14129 : 8165996: PKCS11 using NSS throws an error regarding secmod.db when NSS uses sqlite
Reviewed-by: weijun, andrew
Contributed-by: Martin Balao <mbalao@redhat.com>
15 lines changed: 10 ins; 0 del; 5 mod; 773 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/sun/security/pkcs11/SecmodTest.java

rev 14129 : 8165996: PKCS11 using NSS throws an error regarding secmod.db when NSS uses sqlite
Reviewed-by: weijun, andrew
Contributed-by: Martin Balao <mbalao@redhat.com>
19 lines changed: 15 ins; 0 del; 4 mod; 78 unchg

------ ------ ------ ------ --- New ----- Raw test/sun/security/pkcs11/Secmod/README-SQLITE

rev 14129 : 8165996: PKCS11 using NSS throws an error regarding secmod.db when NSS uses sqlite
Reviewed-by: weijun, andrew
Contributed-by: Martin Balao <mbalao@redhat.com>
8 lines changed: 8 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/sun/security/pkcs11/Secmod/TestNssDbSqlite.java

rev 14129 : 8165996: PKCS11 using NSS throws an error regarding secmod.db when NSS uses sqlite
Reviewed-by: weijun, andrew
Contributed-by: Martin Balao <mbalao@redhat.com>
127 lines changed: 127 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/sun/security/pkcs11/Secmod/cert9.db

rev 14129 : 8165996: PKCS11 using NSS throws an error regarding secmod.db when NSS uses sqlite
Reviewed-by: weijun, andrew
Contributed-by: Martin Balao <mbalao@redhat.com>
Unexpected Error occurred reading `diff -e /dev/null new/test/sun/security/pkcs11/Secmod/cert9.db`: $?=0, err= 1

------ ------ ------ ------ --- New ----- Raw test/sun/security/pkcs11/Secmod/key4.db

rev 14129 : 8165996: PKCS11 using NSS throws an error regarding secmod.db when NSS uses sqlite
Reviewed-by: weijun, andrew
Contributed-by: Martin Balao <mbalao@redhat.com>
Unexpected Error occurred reading `diff -e /dev/null new/test/sun/security/pkcs11/Secmod/key4.db`: $?=0, err= 1

------ ------ ------ ------ --- New ----- Raw test/sun/security/pkcs11/Secmod/nss-sqlite.cfg

rev 14129 : 8165996: PKCS11 using NSS throws an error regarding secmod.db when NSS uses sqlite
Reviewed-by: weijun, andrew
Contributed-by: Martin Balao <mbalao@redhat.com>
13 lines changed: 13 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/martin/local_lab/dev/openjdk/scripts/webrev.ksh (vers 25.18-hg+openjdk.java.net).