Code Review for jdk

Prepared by:Yingqi Lu on Thu Nov 12 21:35:57 PST 2015
Workspace:/home/jdk9-patch/jdk
Summary of changes: 654 lines changed: 621 ins; 2 del; 31 mod; 24288 unchg
Patch of changes: jdk.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/src/native/genconstants/ch/genSocketOptionRegistry.c

8 lines changed: 8 ins; 0 del; 0 mod; 131 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/AbstractPlainDatagramSocketImpl.java

6 lines changed: 6 ins; 0 del; 0 mod; 367 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/AbstractPlainSocketImpl.java

8 lines changed: 8 ins; 0 del; 0 mod; 726 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/DatagramSocket.java

67 lines changed: 67 ins; 0 del; 0 mod; 1406 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/DatagramSocketImpl.java

6 lines changed: 6 ins; 0 del; 0 mod; 383 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/MulticastSocket.java

20 lines changed: 20 ins; 0 del; 0 mod; 709 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/ServerSocket.java

67 lines changed: 67 ins; 0 del; 0 mod; 1014 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/Socket.java

63 lines changed: 63 ins; 0 del; 0 mod; 1823 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/SocketImpl.java

6 lines changed: 6 ins; 0 del; 0 mod; 467 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/SocketOptions.java

8 lines changed: 8 ins; 0 del; 0 mod; 331 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/StandardSocketOptions.java

30 lines changed: 30 ins; 0 del; 0 mod; 367 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/nio/channels/AsynchronousServerSocketChannel.java

4 lines changed: 4 ins; 0 del; 0 mod; 328 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/nio/channels/AsynchronousSocketChannel.java

4 lines changed: 4 ins; 0 del; 0 mod; 687 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/nio/channels/DatagramChannel.java

4 lines changed: 4 ins; 0 del; 0 mod; 592 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/nio/channels/MulticastChannel.java

6 lines changed: 6 ins; 0 del; 0 mod; 230 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/nio/channels/ServerSocketChannel.java

4 lines changed: 4 ins; 0 del; 0 mod; 292 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/nio/channels/SocketChannel.java

4 lines changed: 4 ins; 0 del; 0 mod; 526 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/net/Sockets.java

4 lines changed: 4 ins; 0 del; 0 mod; 312 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/ch/AsynchronousServerSocketChannelImpl.java

1 line changed: 1 ins; 0 del; 0 mod; 260 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/ch/AsynchronousSocketChannelImpl.java

1 line changed: 1 ins; 0 del; 0 mod; 605 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/ch/DatagramChannelImpl.java

1 line changed: 1 ins; 0 del; 0 mod; 1152 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/ch/DatagramSocketAdaptor.java

9 lines changed: 9 ins; 0 del; 0 mod; 410 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/ch/ServerSocketAdaptor.java

17 lines changed: 17 ins; 0 del; 0 mod; 205 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/ch/ServerSocketChannelImpl.java

1 line changed: 1 ins; 0 del; 0 mod; 444 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/ch/SocketAdaptor.java

8 lines changed: 8 ins; 0 del; 0 mod; 441 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/ch/SocketChannelImpl.java

1 line changed: 1 ins; 0 del; 0 mod; 1039 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/BaseSSLSocketImpl.java

26 lines changed: 26 ins; 0 del; 0 mod; 669 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/unix/native/libnet/PlainDatagramSocketImpl.c

4 lines changed: 4 ins; 0 del; 0 mod; 2289 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/unix/native/libnet/SdpSupport.c

5 lines changed: 5 ins; 0 del; 0 mod; 125 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/unix/native/libnet/net_util_md.c

3 lines changed: 3 ins; 0 del; 0 mod; 1650 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/unix/native/libnet/net_util_md.h

5 lines changed: 5 ins; 0 del; 0 mod; 153 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/unix/native/libnio/ch/Net.c

16 lines changed: 16 ins; 0 del; 0 mod; 801 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/unix/native/libnio/ch/nio_util.h

4 lines changed: 4 ins; 0 del; 0 mod; 53 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.management/share/classes/sun/management/jdp/JdpBroadcaster.java

1 line changed: 1 ins; 0 del; 0 mod; 163 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jdwp.agent/share/native/libdt_socket/socketTransport.c

11 lines changed: 11 ins; 0 del; 0 mod; 820 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jdwp.agent/unix/native/libdt_socket/socket_md.c

12 lines changed: 11 ins; 0 del; 1 mod; 340 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jdwp.agent/unix/native/libdt_socket/socket_md.h

4 lines changed: 4 ins; 0 del; 0 mod; 29 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/net/SocketOption/OptionsTest.java

98 lines changed: 74 ins; 1 del; 23 mod; 225 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/nio/channels/AsynchronousServerSocketChannel/Basic.java

19 lines changed: 19 ins; 0 del; 0 mod; 172 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/nio/channels/AsynchronousSocketChannel/Basic.java

10 lines changed: 9 ins; 0 del; 1 mod; 872 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/nio/channels/DatagramChannel/BasicMulticastTests.java

22 lines changed: 18 ins; 0 del; 4 mod; 217 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/nio/channels/DatagramChannel/MulticastSendReceiveTests.java

12 lines changed: 10 ins; 1 del; 1 mod; 252 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/nio/channels/DatagramChannel/SocketOptionTests.java

18 lines changed: 17 ins; 0 del; 1 mod; 123 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/nio/channels/ServerSocketChannel/SocketOptionTests.java

26 lines changed: 26 ins; 0 del; 0 mod; 88 unchg

This code review page was prepared using ./webrev.ksh (vers 25.14-hg+openjdk.java.net).