Code Review for jdk

Prepared by:Yingqi Lu on Wed Feb 10 13:53:37 PST 2016
Workspace:/home/jdk9-patch-v17/jdk
Summary of changes: 693 lines changed: 608 ins; 2 del; 83 mod; 19868 unchg
Patch of changes: jdk.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/mapfiles/libnet/mapfile-vers

5 lines changed: 4 ins; 0 del; 1 mod; 118 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/mapfiles/libnio/mapfile-linux

2 lines changed: 1 ins; 0 del; 1 mod; 207 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/mapfiles/libnio/mapfile-macosx

2 lines changed: 1 ins; 0 del; 1 mod; 184 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/mapfiles/libnio/mapfile-solaris

2 lines changed: 1 ins; 0 del; 1 mod; 193 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/src/native/genconstants/ch/genSocketOptionRegistry.c

17 lines changed: 16 ins; 0 del; 1 mod; 130 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/AbstractPlainDatagramSocketImpl.java

59 lines changed: 58 ins; 0 del; 1 mod; 366 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/AbstractPlainSocketImpl.java

58 lines changed: 57 ins; 0 del; 1 mod; 725 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/DatagramSocketImpl.java

7 lines changed: 6 ins; 0 del; 1 mod; 382 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/MulticastSocket.java

11 lines changed: 10 ins; 0 del; 1 mod; 708 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/SocketImpl.java

7 lines changed: 6 ins; 0 del; 1 mod; 474 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/SocketOptions.java

11 lines changed: 10 ins; 0 del; 1 mod; 330 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/StandardSocketOptions.java

24 lines changed: 23 ins; 0 del; 1 mod; 366 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/net/Sockets.java

30 lines changed: 28 ins; 0 del; 2 mod; 309 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/ch/AsynchronousServerSocketChannelImpl.java

4 lines changed: 3 ins; 0 del; 1 mod; 259 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/ch/AsynchronousSocketChannelImpl.java

4 lines changed: 3 ins; 0 del; 1 mod; 604 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/ch/DatagramChannelImpl.java

4 lines changed: 3 ins; 0 del; 1 mod; 1151 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/ch/Net.java

16 lines changed: 15 ins; 0 del; 1 mod; 656 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/ch/ServerSocketChannelImpl.java

5 lines changed: 3 ins; 1 del; 1 mod; 442 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/ch/SocketChannelImpl.java

4 lines changed: 3 ins; 0 del; 1 mod; 1038 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/native/libnet/net_util.c

12 lines changed: 10 ins; 1 del; 1 mod; 317 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/native/libnet/net_util.h

3 lines changed: 2 ins; 0 del; 1 mod; 196 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/unix/classes/java/net/PlainDatagramSocketImpl.java

22 lines changed: 19 ins; 0 del; 3 mod; 142 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/unix/classes/java/net/PlainSocketImpl.java

22 lines changed: 19 ins; 0 del; 3 mod; 135 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/unix/native/libnet/PlainDatagramSocketImpl.c

5 lines changed: 4 ins; 0 del; 1 mod; 2288 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/unix/native/libnet/SdpSupport.c

6 lines changed: 5 ins; 0 del; 1 mod; 124 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/unix/native/libnet/net_util_md.c

21 lines changed: 20 ins; 0 del; 1 mod; 1649 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/unix/native/libnet/net_util_md.h

14 lines changed: 13 ins; 0 del; 1 mod; 152 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/unix/native/libnio/ch/Net.c

7 lines changed: 6 ins; 0 del; 1 mod; 800 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/unix/native/libnio/ch/nio_util.h

13 lines changed: 12 ins; 0 del; 1 mod; 52 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/windows/classes/java/net/DualStackPlainDatagramSocketImpl.java

9 lines changed: 8 ins; 0 del; 1 mod; 296 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/windows/classes/java/net/DualStackPlainSocketImpl.java

9 lines changed: 8 ins; 0 del; 1 mod; 299 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/windows/classes/java/net/PlainSocketImpl.java

22 lines changed: 21 ins; 0 del; 1 mod; 344 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/windows/classes/java/net/TwoStacksPlainDatagramSocketImpl.java

7 lines changed: 6 ins; 0 del; 1 mod; 215 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/windows/classes/java/net/TwoStacksPlainSocketImpl.java

8 lines changed: 7 ins; 0 del; 1 mod; 242 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/windows/native/libnet/net_util_md.c

6 lines changed: 5 ins; 0 del; 1 mod; 1053 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/windows/native/libnet/net_util_md.h

4 lines changed: 4 ins; 0 del; 0 mod; 355 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/windows/native/libnio/ch/Net.c

8 lines changed: 7 ins; 0 del; 1 mod; 625 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/net/SocketOption/OptionsTest.java

55 lines changed: 32 ins; 0 del; 23 mod; 229 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/nio/channels/AsynchronousServerSocketChannel/Basic.java

11 lines changed: 10 ins; 0 del; 1 mod; 171 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/nio/channels/AsynchronousSocketChannel/Basic.java

13 lines changed: 11 ins; 0 del; 2 mod; 871 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/nio/channels/DatagramChannel/BasicMulticastTests.java

17 lines changed: 12 ins; 0 del; 5 mod; 216 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/nio/channels/DatagramChannel/MulticastSendReceiveTests.java

4 lines changed: 0 ins; 0 del; 4 mod; 250 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/nio/channels/DatagramChannel/SocketOptionTests.java

18 lines changed: 13 ins; 0 del; 5 mod; 119 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/nio/channels/ServerSocketChannel/SocketOptionTests.java

11 lines changed: 9 ins; 0 del; 2 mod; 86 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/unix/native/libnet/SocketImpl.c

47 lines changed: 47 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/windows/native/libnet/SocketImpl.c

47 lines changed: 47 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using ./webrev.ksh (vers 25.14-hg+openjdk.java.net).