Code Review for open

Prepared by:mchung on Fri Oct 12 20:21:29 PDT 2018
Workspace:/scratch/mchung/ws/jdk/unsafe-obj-to-ref/open
Compare against: http://hg.openjdk.java.net/jdk/jdk
Summary of changes: 634 lines changed: 42 ins; 2 del; 590 mod; 80947 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/gensrc/GensrcVarHandles.gmk

3 lines changed: 0 ins; 0 del; 3 mod; 171 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/c1/c1_Compiler.cpp

6 lines changed: 0 ins; 0 del; 6 mod; 252 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/c1/c1_GraphBuilder.cpp

6 lines changed: 0 ins; 0 del; 6 mod; 4406 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/c1/c1_LIRGenerator.cpp

1 line changed: 0 ins; 0 del; 1 mod; 3664 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/vmSymbols.cpp

18 lines changed: 0 ins; 0 del; 18 mod; 1040 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/vmSymbols.hpp

147 lines changed: 0 ins; 0 del; 147 mod; 1494 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/c2/g1BarrierSetC2.hpp

1 line changed: 0 ins; 0 del; 1 mod; 92 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/c2compiler.cpp

17 lines changed: 0 ins; 0 del; 17 mod; 593 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/library_call.cpp

62 lines changed: 0 ins; 0 del; 62 mod; 6576 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/unsafe.cpp

12 lines changed: 0 ins; 0 del; 12 mod; 1111 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/io/BufferedInputStream.java

2 lines changed: 0 ins; 0 del; 2 mod; 493 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/io/File.java

1 line changed: 0 ins; 0 del; 1 mod; 2296 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/io/ObjectStreamClass.java

2 lines changed: 0 ins; 0 del; 2 mod; 2437 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/Class.java

3 lines changed: 0 ins; 0 del; 3 mod; 4016 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/ClassLoader.java

1 line changed: 0 ins; 0 del; 1 mod; 3039 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/CallSite.java

1 line changed: 0 ins; 0 del; 1 mod; 339 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/ClassSpecializer.java

2 lines changed: 0 ins; 0 del; 2 mod; 1045 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/DirectMethodHandle.java

4 lines changed: 0 ins; 0 del; 4 mod; 895 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java

2 lines changed: 0 ins; 0 del; 2 mod; 1879 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/LambdaForm.java

4 lines changed: 0 ins; 0 del; 4 mod; 1866 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/MethodHandle.java

1 line changed: 0 ins; 0 del; 1 mod; 1683 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/MethodType.java

2 lines changed: 0 ins; 0 del; 2 mod; 1384 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/VarHandle.java

1 line changed: 0 ins; 0 del; 1 mod; 2084 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/VarHandles.java

5 lines changed: 0 ins; 0 del; 5 mod; 535 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/X-VarHandleByteArrayView.java.template

67 lines changed: 30 ins; 0 del; 37 mod; 909 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/math/BigDecimal.java

1 line changed: 0 ins; 0 del; 1 mod; 5600 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/math/BigInteger.java

1 line changed: 0 ins; 0 del; 1 mod; 4735 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/Inet6Address.java

1 line changed: 0 ins; 0 del; 1 mod; 920 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/InetAddress.java

1 line changed: 0 ins; 0 del; 1 mod; 1772 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/InetSocketAddress.java

1 line changed: 0 ins; 0 del; 1 mod; 409 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/Random.java

1 line changed: 0 ins; 0 del; 1 mod; 1226 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/concurrent/ConcurrentHashMap.java

3 lines changed: 0 ins; 0 del; 3 mod; 6379 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/concurrent/ThreadLocalRandom.java

3 lines changed: 0 ins; 0 del; 3 mod; 1094 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/concurrent/atomic/AtomicReferenceFieldUpdater.java

6 lines changed: 0 ins; 0 del; 6 mod; 471 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/concurrent/locks/LockSupport.java

2 lines changed: 0 ins; 0 del; 2 mod; 429 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/zip/ZipUtils.java

3 lines changed: 0 ins; 2 del; 1 mod; 301 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/misc/InnocuousThread.java

6 lines changed: 0 ins; 0 del; 6 mod; 175 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/misc/Unsafe.java

58 lines changed: 0 ins; 0 del; 58 mod; 3661 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/reflect/UnsafeObjectFieldAccessorImpl.java

2 lines changed: 0 ins; 0 del; 2 mod; 132 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/reflect/UnsafeQualifiedObjectFieldAccessorImpl.java

2 lines changed: 0 ins; 0 del; 2 mod; 134 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/reflect/UnsafeQualifiedStaticObjectFieldAccessorImpl.java

2 lines changed: 0 ins; 0 del; 2 mod; 132 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/reflect/UnsafeStaticObjectFieldAccessorImpl.java

2 lines changed: 0 ins; 0 del; 2 mod; 130 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java

2 lines changed: 0 ins; 0 del; 2 mod; 633 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.security.jgss/share/classes/sun/security/krb5/PrincipalName.java

1 line changed: 0 ins; 0 del; 1 mod; 708 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xml/internal/utils/SafeThread.java

2 lines changed: 0 ins; 0 del; 2 mod; 90 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotMemoryAccessProviderImpl.java

2 lines changed: 0 ins; 0 del; 2 mod; 325 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/CheckGraalIntrinsics.java

8 lines changed: 0 ins; 0 del; 8 mod; 588 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.aarch64/src/org/graalvm/compiler/replacements/aarch64/AArch64GraphBuilderPlugins.java

4 lines changed: 1 ins; 0 del; 3 mod; 206 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.amd64/src/org/graalvm/compiler/replacements/amd64/AMD64GraphBuilderPlugins.java

7 lines changed: 1 ins; 0 del; 6 mod; 272 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.jdk9.test/src/org/graalvm/compiler/replacements/jdk9/UnsafeReplacementsTest.java

28 lines changed: 0 ins; 0 del; 28 mod; 796 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/StandardGraphBuilderPlugins.java

10 lines changed: 2 ins; 0 del; 8 mod; 1312 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.serviceprovider/src/org/graalvm/compiler/serviceprovider/GraalServices.java

5 lines changed: 5 ins; 0 del; 0 mod; 313 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.unsupported/share/classes/sun/misc/Unsafe.java

7 lines changed: 0 ins; 0 del; 7 mod; 1239 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/c2/Test7190310_unsafe.java

9 lines changed: 0 ins; 0 del; 9 mod; 145 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/c2/aarch64/TestUnsafeVolatileCAS.java

1 line changed: 0 ins; 0 del; 1 mod; 79 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/c2/aarch64/TestUnsafeVolatileLoad.java

1 line changed: 0 ins; 0 del; 1 mod; 55 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/c2/aarch64/TestUnsafeVolatileStore.java

1 line changed: 0 ins; 0 del; 1 mod; 78 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/gcbarriers/UnsafeIntrinsicsTest.java

9 lines changed: 0 ins; 0 del; 9 mod; 367 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/intrinsics/unsafe/TestCAEAntiDep.java

2 lines changed: 0 ins; 0 del; 2 mod; 67 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/intrinsics/unsafe/TestUnsafeMismatchedArrayFieldAccess.java

1 line changed: 0 ins; 0 del; 1 mod; 64 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/profiling/UnsafeAccess.java

3 lines changed: 0 ins; 0 del; 3 mod; 89 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/regalloc/C1ObjectSpillInLogicOp.java

1 line changed: 0 ins; 0 del; 1 mod; 50 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/unsafe/GetUnsafeObjectG1PreBarrier.java

1 line changed: 0 ins; 0 del; 1 mod; 75 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/unsafe/JdkInternalMiscUnsafeAccessTestObject.java

36 lines changed: 0 ins; 0 del; 36 mod; 226 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/unsafe/MixedUnsafeStoreObject.java

2 lines changed: 0 ins; 0 del; 2 mod; 71 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/unsafe/OpaqueAccesses.java

6 lines changed: 0 ins; 0 del; 6 mod; 183 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/unsafe/UnsafeGetConstantField.java

5 lines changed: 3 ins; 0 del; 2 mod; 465 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/unsafe/UnsafeGetStableArrayElement.java

9 lines changed: 0 ins; 0 del; 9 mod; 330 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Unsafe/GetPutObject.java

4 lines changed: 0 ins; 0 del; 4 mod; 58 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Unsafe/RangeCheck.java

1 line changed: 0 ins; 0 del; 1 mod; 64 unchg

This code review page was prepared using /java/devtools/code-tools/webrev/webrev.ksh (vers 25.17-hg+openjdk.java.net).