Code Review for jdk9-jlink-plugins

Prepared by:mchung on Wed Dec 7 23:03:03 PST 2016
Workspace:/scratch/mchung/ws/jdk9/jdk9-jlink-plugins
Compare against: ssh://hg.openjdk.java.net/jdk9/dev
Summary of changes: 32922 lines changed: 3977 ins; 28884 del; 61 mod; 74327 unchg
Patch of changes: jdk9-jlink-plugins.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw common/autoconf/generated-configure.sh

7 lines changed: 6 ins; 0 del; 1 mod; 66983 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw common/autoconf/source-dirs.m4

6 lines changed: 6 ins; 0 del; 0 mod; 145 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw common/autoconf/spec.gmk.in

2 lines changed: 2 ins; 0 del; 0 mod; 846 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/CreateJmods.gmk

10 lines changed: 9 ins; 1 del; 0 mod; 137 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/Images.gmk

3 lines changed: 1 ins; 2 del; 0 mod; 468 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/InterimImage.gmk

1 line changed: 0 ins; 0 del; 1 mod; 59 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/Main.gmk

1 line changed: 0 ins; 0 del; 1 mod; 970 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/common/Modules.gmk

24 lines changed: 24 ins; 0 del; 0 mod; 330 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/make/copy/Copy-java.base.gmk

11 lines changed: 11 ins; 0 del; 0 mod; 235 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/make/copy/CopyCommon.gmk

1 line changed: 1 ins; 0 del; 0 mod; 36 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/java.base/share/classes/jdk/internal/jmod/JmodFile.java

39 lines changed: 17 ins; 17 del; 5 mod; 208 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jlink/share/classes/jdk/tools/jlink/builder/DefaultImageBuilder.java

86 lines changed: 69 ins; 5 del; 12 mod; 556 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/Archive.java

1 line changed: 1 ins; 0 del; 0 mod; 137 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ArchiveEntryResourcePoolEntry.java

14 lines changed: 6 ins; 4 del; 4 mod; 76 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JmodArchive.java

33 lines changed: 24 ins; 7 del; 2 mod; 151 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ResourcePoolEntryFactory.java

6 lines changed: 6 ins; 0 del; 0 mod; 66 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ResourcePoolManager.java

2 lines changed: 0 ins; 0 del; 2 mod; 461 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jlink/share/classes/jdk/tools/jlink/plugin/ResourcePoolEntry.java

37 lines changed: 34 ins; 2 del; 1 mod; 199 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins.properties

8 lines changed: 7 ins; 0 del; 1 mod; 217 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jlink/share/classes/jdk/tools/jmod/JmodTask.java

54 lines changed: 19 ins; 7 del; 28 mod; 1409 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jlink/share/classes/jdk/tools/jmod/resources/jmod.properties

2 lines changed: 1 ins; 0 del; 1 mod; 104 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jlink/share/classes/module-info.java

1 line changed: 1 ins; 0 del; 0 mod; 53 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/tools/jlink/CustomPluginTest.java

1 line changed: 0 ins; 0 del; 1 mod; 178 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/tools/jlink/JLinkTest.java

3 lines changed: 2 ins; 0 del; 1 mod; 303 unchg

------ ------ ------ ------ --- New Patch Raw jaxp/src/java.xml/share/legal/bcel.md

216 lines changed: 216 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jaxp/src/java.xml/share/legal/dom.md

59 lines changed: 59 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jaxp/src/java.xml/share/legal/jcup.md

21 lines changed: 21 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jaxp/src/java.xml/share/legal/xalan.md

223 lines changed: 223 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jaxp/src/java.xml/share/legal/xerces.md

253 lines changed: 253 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jaxp/src/java.xml/share/legal/xmlresolver.md

217 lines changed: 217 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jaxws/src/jdk.xml.bind/share/legal/rngom.md

23 lines changed: 23 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jaxws/src/jdk.xml.bind/share/legal/xmlresolver.md

217 lines changed: 217 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/java.base/share/legal/aes.md

33 lines changed: 33 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/java.base/share/legal/asm.md

33 lines changed: 33 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/java.base/share/legal/icu.md

60 lines changed: 60 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/java.base/share/legal/zlib.md

24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/java.desktop/share/legal/color-imaging.md

5 lines changed: 5 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/java.desktop/share/legal/giflib.md

23 lines changed: 23 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/java.desktop/share/legal/harfbuzz.md

59 lines changed: 59 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/java.desktop/share/legal/jpeg.md

80 lines changed: 80 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/java.desktop/share/legal/lcms.md

24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/java.desktop/share/legal/libpng.md

106 lines changed: 106 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/java.desktop/share/legal/mesa3d.md

25 lines changed: 25 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/java.desktop/share/legal/opengl.md

24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/java.desktop/unix/legal/fontconfig.md

21 lines changed: 21 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/java.desktop/unix/legal/xwindows.md

229 lines changed: 229 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/java.smartcardio/unix/legal/pcsclite.md

38 lines changed: 38 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/java.xml.crypto/share/legal/santuario.md

219 lines changed: 219 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/jdk.crypto.ec/share/legal/ecc.md

524 lines changed: 524 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/jdk.crypto.pkcs11/share/legal/pkcs11cryptotoken.md

17 lines changed: 17 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/jdk.crypto.pkcs11/share/legal/pkcs11wrapper.md

43 lines changed: 43 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/jdk.internal.le/share/legal/jline.md

36 lines changed: 36 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/jdk.internal.opt/share/legal/jopt-simple.md

24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ModuleSorter.java

110 lines changed: 110 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/SymLinkResourcePoolEntry.java

72 lines changed: 72 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/LegalNoticeFilePlugin.java

157 lines changed: 157 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/jdk.localedata/share/legal/cldr.md

39 lines changed: 39 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/jdk.localedata/share/legal/thaidict.md

28 lines changed: 28 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/tools/jlink/plugins/LegalFilePluginTest.java

342 lines changed: 342 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw langtools/src/jdk.javadoc/share/legal/jszip.md

23 lines changed: 23 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw nashorn/src/jdk.dynalink/share/legal/dynalink.md

28 lines changed: 28 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw nashorn/src/jdk.scripting.nashorn/share/legal/double-conversion.md

32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw nashorn/src/jdk.scripting.nashorn/share/legal/joni.md

23 lines changed: 23 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- THIRD_PARTY_README

3605 lines changed: 0 ins; 3605 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- corba/THIRD_PARTY_README

3605 lines changed: 0 ins; 3605 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- hotspot/THIRD_PARTY_README

3605 lines changed: 0 ins; 3605 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- jaxp/THIRD_PARTY_README

3604 lines changed: 0 ins; 3604 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- jaxws/THIRD_PARTY_README

3605 lines changed: 0 ins; 3605 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- jdk/THIRD_PARTY_README

3605 lines changed: 0 ins; 3605 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- langtools/THIRD_PARTY_README

3605 lines changed: 0 ins; 3605 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- nashorn/THIRD_PARTY_README

3605 lines changed: 0 ins; 3605 del; 0 mod; 0 unchg

This code review page was prepared using /java/devtools/code-tools/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).