Code Review for open

Prepared by:mchung on Mon Apr 13 21:04:15 PDT 2020
Workspace:/scratch/mchung/ws/valhalla/jdk-hidden-classes/open
Compare against: http://hg.openjdk.java.net/jdk/jdk
Compare against version:hidden-class-6
Summary of changes: 882 lines changed: 570 ins; 151 del; 161 mod; 45323 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/data/jdwp/jdwp.spec

rev 58770 : [mq]: svc-spec-update
32 lines changed: 18 ins; 5 del; 9 mod; 3289 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/instanceKlass.cpp

rev 58768 : 8238358: Implementation of JEP 371: Hidden Classes
Reviewed-by: alanb, cjplummer, coleenp, dholmes, dlong, forax, jlahoda, psandoz, plevart, vromero
Contributed-by: mandy.chung@oracle.com, lois.foltan@oracle.com, david.holmes@oracle.com, harold.seigel@oracle.com, serguei.spitsyn@oracle.com, alex.buckley@oracle.com, jamsheed.c.m@oracle.com, jan.lahoda@oracle.com, amy.lu@oracle.com
rev 58769 : imported patch type-descriptor-name
rev 58770 : [mq]: svc-spec-update
13 lines changed: 9 ins; 0 del; 4 mod; 4076 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/klass.cpp

rev 58768 : 8238358: Implementation of JEP 371: Hidden Classes
Reviewed-by: alanb, cjplummer, coleenp, dholmes, dlong, forax, jlahoda, psandoz, plevart, vromero
Contributed-by: mandy.chung@oracle.com, lois.foltan@oracle.com, david.holmes@oracle.com, harold.seigel@oracle.com, serguei.spitsyn@oracle.com, alex.buckley@oracle.com, jamsheed.c.m@oracle.com, jan.lahoda@oracle.com, amy.lu@oracle.com
rev 58769 : imported patch type-descriptor-name
rev 58770 : [mq]: svc-spec-update
9 lines changed: 7 ins; 0 del; 2 mod; 987 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/objArrayKlass.cpp

rev 58769 : imported patch type-descriptor-name
rev 58770 : [mq]: svc-spec-update
0 lines changed: 0 ins; 0 del; 0 mod; 512 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmti.xml

rev 58770 : [mq]: svc-spec-update
91 lines changed: 68 ins; 4 del; 19 mod; 14978 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/Class.java

rev 58768 : 8238358: Implementation of JEP 371: Hidden Classes
Reviewed-by: alanb, cjplummer, coleenp, dholmes, dlong, forax, jlahoda, psandoz, plevart, vromero
Contributed-by: mandy.chung@oracle.com, lois.foltan@oracle.com, david.holmes@oracle.com, harold.seigel@oracle.com, serguei.spitsyn@oracle.com, alex.buckley@oracle.com, jamsheed.c.m@oracle.com, jan.lahoda@oracle.com, amy.lu@oracle.com
rev 58769 : imported patch type-descriptor-name
93 lines changed: 73 ins; 6 del; 14 mod; 4298 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/MethodHandles.java

rev 58768 : 8238358: Implementation of JEP 371: Hidden Classes
Reviewed-by: alanb, cjplummer, coleenp, dholmes, dlong, forax, jlahoda, psandoz, plevart, vromero
Contributed-by: mandy.chung@oracle.com, lois.foltan@oracle.com, david.holmes@oracle.com, harold.seigel@oracle.com, serguei.spitsyn@oracle.com, alex.buckley@oracle.com, jamsheed.c.m@oracle.com, jan.lahoda@oracle.com, amy.lu@oracle.com
rev 58769 : imported patch type-descriptor-name
8 lines changed: 5 ins; 0 del; 3 mod; 7346 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/MethodType.java

rev 58769 : imported patch type-descriptor-name
rev 58770 : [mq]: svc-spec-update
59 lines changed: 53 ins; 1 del; 5 mod; 1403 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/TypeDescriptor.java

rev 58769 : imported patch type-descriptor-name
14 lines changed: 10 ins; 1 del; 3 mod; 184 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/invoke/util/BytecodeDescriptor.java

rev 58769 : imported patch type-descriptor-name
5 lines changed: 0 ins; 4 del; 1 mod; 159 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.instrument/share/classes/java/lang/instrument/Instrumentation.java

rev 58770 : [mq]: svc-spec-update
44 lines changed: 40 ins; 0 del; 4 mod; 750 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jdi/share/classes/com/sun/jdi/ClassLoaderReference.java

rev 58770 : [mq]: svc-spec-update
44 lines changed: 21 ins; 6 del; 17 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jdi/share/classes/com/sun/jdi/LocalVariable.java

rev 58770 : [mq]: svc-spec-update
3 lines changed: 1 ins; 1 del; 1 mod; 151 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jdi/share/classes/com/sun/jdi/ReferenceType.java

rev 58770 : [mq]: svc-spec-update
9 lines changed: 1 ins; 4 del; 4 mod; 846 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jdi/share/classes/com/sun/jdi/Type.java

rev 58770 : [mq]: svc-spec-update
14 lines changed: 5 ins; 3 del; 6 mod; 148 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jdi/share/classes/com/sun/jdi/TypeComponent.java

rev 58770 : [mq]: svc-spec-update
3 lines changed: 1 ins; 1 del; 1 mod; 127 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jdi/share/classes/com/sun/jdi/VirtualMachine.java

rev 58770 : [mq]: svc-spec-update
25 lines changed: 15 ins; 0 del; 10 mod; 910 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jdi/share/classes/com/sun/jdi/event/ClassUnloadEvent.java

rev 58770 : [mq]: svc-spec-update
8 lines changed: 6 ins; 0 del; 2 mod; 51 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jdi/share/classes/com/sun/tools/jdi/EventSetImpl.java

rev 58768 : 8238358: Implementation of JEP 371: Hidden Classes
Reviewed-by: alanb, cjplummer, coleenp, dholmes, dlong, forax, jlahoda, psandoz, plevart, vromero
Contributed-by: mandy.chung@oracle.com, lois.foltan@oracle.com, david.holmes@oracle.com, harold.seigel@oracle.com, serguei.spitsyn@oracle.com, alex.buckley@oracle.com, jamsheed.c.m@oracle.com, jan.lahoda@oracle.com, amy.lu@oracle.com
rev 58769 : imported patch type-descriptor-name
11 lines changed: 3 ins; 1 del; 7 mod; 916 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jdi/share/classes/com/sun/tools/jdi/JNITypeParser.java

rev 58768 : 8238358: Implementation of JEP 371: Hidden Classes
Reviewed-by: alanb, cjplummer, coleenp, dholmes, dlong, forax, jlahoda, psandoz, plevart, vromero
Contributed-by: mandy.chung@oracle.com, lois.foltan@oracle.com, david.holmes@oracle.com, harold.seigel@oracle.com, serguei.spitsyn@oracle.com, alex.buckley@oracle.com, jamsheed.c.m@oracle.com, jan.lahoda@oracle.com, amy.lu@oracle.com
rev 58769 : imported patch type-descriptor-name
20 lines changed: 8 ins; 2 del; 10 mod; 241 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jdwp.agent/share/native/libjdwp/util.c

rev 58769 : imported patch type-descriptor-name
9 lines changed: 9 ins; 0 del; 0 mod; 2872 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/serviceability/jvmti/HiddenClass/P/Q/HiddenClassSigTest.java

rev 58768 : 8238358: Implementation of JEP 371: Hidden Classes
Reviewed-by: alanb, cjplummer, coleenp, dholmes, dlong, forax, jlahoda, psandoz, plevart, vromero
Contributed-by: mandy.chung@oracle.com, lois.foltan@oracle.com, david.holmes@oracle.com, harold.seigel@oracle.com, serguei.spitsyn@oracle.com, alex.buckley@oracle.com, jamsheed.c.m@oracle.com, jan.lahoda@oracle.com, amy.lu@oracle.com
rev 58769 : imported patch type-descriptor-name
rev 58770 : [mq]: svc-spec-update
106 lines changed: 35 ins; 35 del; 36 mod; 161 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/serviceability/jvmti/HiddenClass/libHiddenClassSigTest.cpp

rev 58768 : 8238358: Implementation of JEP 371: Hidden Classes
Reviewed-by: alanb, cjplummer, coleenp, dholmes, dlong, forax, jlahoda, psandoz, plevart, vromero
Contributed-by: mandy.chung@oracle.com, lois.foltan@oracle.com, david.holmes@oracle.com, harold.seigel@oracle.com, serguei.spitsyn@oracle.com, alex.buckley@oracle.com, jamsheed.c.m@oracle.com, jan.lahoda@oracle.com, amy.lu@oracle.com
rev 58769 : imported patch type-descriptor-name
1 line changed: 0 ins; 0 del; 1 mod; 359 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/invoke/defineHiddenClass/BasicTest.java

rev 58768 : 8238358: Implementation of JEP 371: Hidden Classes
Reviewed-by: alanb, cjplummer, coleenp, dholmes, dlong, forax, jlahoda, psandoz, plevart, vromero
Contributed-by: mandy.chung@oracle.com, lois.foltan@oracle.com, david.holmes@oracle.com, harold.seigel@oracle.com, serguei.spitsyn@oracle.com, alex.buckley@oracle.com, jamsheed.c.m@oracle.com, jan.lahoda@oracle.com, amy.lu@oracle.com
rev 58769 : imported patch type-descriptor-name
rev 58770 : [mq]: svc-spec-update
10 lines changed: 8 ins; 0 del; 2 mod; 489 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/invoke/defineHiddenClass/TypeDescriptorTest.java

rev 58769 : imported patch type-descriptor-name
174 lines changed: 174 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html

rev 58770 : [mq]: svc-spec-update
77 lines changed: 0 ins; 77 del; 0 mod; 0 unchg

This code review page was prepared using /java/devtools/code-tools/webrev/webrev.ksh (vers 25.18-hg+openjdk.java.net).