Code Review for jdk

Prepared by:mcimadamore on Mon Jul 3 15:08:52 IST 2017
Workspace:/w/lt/valhalla/valhalla-10-openjdk/jdk
Compare against version:17254
Branch:mvt
Summary of changes: 2 lines changed: 2 ins; 0 del; 0 mod; 2286 unchg
Patch of changes: jdk.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/MethodHandleImpl.java

rev 17255 : imported patch 8183132.patch
rev 17233 : Initial commit of MVT prototype
rev 17105 : Reverted MVT merge
rev 17104 : Merge
rev 17102 : Add initial MethodHandle MVT support
rev 16994 : 8178387: Reduce memory churn when creating java.lang.invoke entities
Reviewed-by: psandoz, vlivanov
rev 16993 : 8178384: Reduce work in java.lang.invoke initializers
Reviewed-by: vlivanov, psandoz
rev 16665 : 8175233: Remove LambdaForm.debugName
Reviewed-by: vlivanov, psandoz, jrose
rev 16172 : 8133719: java.lang.InternalError in java.lang.invoke.MethodHandleImpl$BindCaller.bindCaller
Reviewed-by: psandoz
rev 15717 : 8151179: address issues raised by JCK team on JEP 274 API
Reviewed-by: jrose, redestad, psandoz
rev 15692 : 8161211: better inlining support for loop bytecode intrinsics
Reviewed-by: jrose, vlivanov, redestad
rev 15453 : 8164569: Generate non-customized invoker forms at link time
Reviewed-by: vlivanov
rev 15384 : 8164451: Generate all zero and identity forms at link time
Reviewed-by: shade, mhaupt, vlivanov
rev 15383 : 8164102: MethodHandles.countedLoop/4 works incorrect for start/end = Integer.MAX_VALUE
Reviewed-by: redestad
rev 15373 : 8164044: Generate corresponding simple DelegatingMethodHandles when generating a DirectMethodHandle at link time
Reviewed-by: vlivanov, mhaupt, shade
rev 15345 : 8163946: java/lang/String/concat/WithSecurityManager.java fails after 8163878
Reviewed-by: mhaupt
rev 15344 : 8163878: Remove unnecessary bridge methods, allocations in java.lang.invoke
Reviewed-by: mhaupt, shade
rev 15330 : 8163373: Rewrite GenerateJLIClassesPlugin to avoid reflective calls into java.lang.invoke
Reviewed-by: vlivanov, mchung
rev 15282 : 8161379: Force inline methods calling Reflection.getCallerClass
Reviewed-by: shade, mchung
rev 14940 : 8143211: provide bytecode intrinsics for loop and try/finally executors
Reviewed-by: psandoz, redestad, vlivanov
rev 14592 : 8157590: MethodHandles.arrayLength() lacks @since tag, implementation throws wrong exception
Reviewed-by: psandoz
rev 14542 : 8149574: Fix java/lang/invoke/MethodHandleImpl's use of Unsafe.defineAnonymousClass()
Reviewed-by: vlivanov, psandoz, sundar, mhaupt
rev 14496 : 8156915: introduce MethodHandle factory for array length
Reviewed-by: sundar
rev 14302 : 8155106: MHs.Lookup.findConstructor returns handles for array classes
Reviewed-by: shade, sundar
rev 14176 : 8137058: Clear out all non-Critical APIs from sun.reflect
Reviewed-by: alanb, jfranck, mchung
rev 14160 : 8150829: Enhanced drop-args, identity and default constant, varargs adjustment
Reviewed-by: psandoz, mhaupt, jrose
rev 14153 : 8153637: MethodHandles.countedLoop/3 initialises loop counter to 1 instead of 0
Reviewed-by: psandoz, redestad
rev 14076 : Merge
rev 14075 : 8149644: Integrate VarHandles
Reviewed-by: coffeys, mhaupt, vlivanov
Contributed-by: paul.sandoz@oracle.com, aleksey.shipilev@oracle.com
rev 13901 : 8142968: Module System implementation
Summary: Initial integration of JEP 200, JEP 260, JEP 261, and JEP 282
Reviewed-by: alanb, mchung, naoto, rriggs, psandoz, plevart, mullan, ascarpino, vinnie, prr, sherman, dfuchs, mhaupt
Contributed-by: alan.bateman@oracle.com, alex.buckley@oracle.com, jonathan.gibbons@oracle.com, karen.kinnear@oracle.com, mandy.chung@oracle.com, mark.reinhold@oracle.com, chris.hegarty@oracle.com, alexandr.scherbatiy@oracle.com, amy.lu@oracle.com, calvin.cheung@oracle.com, daniel.fuchs@oracle.com, erik.joelsson@oracle.com, harold.seigel@oracle.com, jaroslav.bachorik@oracle.com, jean-francois.denise@oracle.com, jan.lahoda@oracle.com, james.laskey@oracle.com, lois.foltan@oracle.com, miroslav.kos@oracle.com, huaming.li@oracle.com, sean.mullan@oracle.com, naoto.sato@oracle.com, masayoshi.okutsu@oracle.com, peter.levart@gmail.com, philip.race@oracle.com, claes.redestad@oracle.com, sergey.bylokhov@oracle.com, alexandre.iline@oracle.com, volker.simonis@gmail.com, staffan.larsen@oracle.com, stuart.marks@oracle.com, semyon.sadetsky@oracle.com, serguei.spitsyn@oracle.com, sundararajan.athijegannathan@oracle.com, valerie.peng@oracle.com, vincent.x.ryan@oracle.com, weijun.wang@oracle.com, yuri.nesterenko@oracle.com, yekaterina.kantserova@oracle.com, alexander.kulyakhtin@oracle.com, felix.yang@oracle.com, andrei.eremeev@oracle.com, frank.yuan@oracle.com, sergei.pikalev@oracle.com, sibabrata.sahoo@oracle.com, tiantian.du@oracle.com, sha.jiang@oracle.com
rev 13774 : 8148994: Replacing MH::invokeBasic with a direct call breaks LF customization
Reviewed-by: jrose, redestad
rev 13489 : Merge
rev 13482 : 8144223: Move j.l.invoke.{ForceInline, DontInline, Stable} to jdk.internal.vm.annotation package
Reviewed-by: jrose, vlivanov, mchung, roland
rev 13336 : 8144723: MethodHandleImpl.initStatics is no longer needed
Reviewed-by: vlivanov, mhaupt, forax
rev 13111 : 8139885: implement JEP 274: enhanced method handles
Reviewed-by: jrose, psandoz, vlivanov
rev 13083 : 8143142: AssertionError in MethodHandleImpl
Reviewed-by: psandoz, vlivanov
rev 13078 : 8142334: Improve lazy initialization of java.lang.invoke
Reviewed-by: psandoz, vlivanov, mhaupt
rev 12416 : 8062543: Replace uses of MethodHandleImpl.castReference with Class.cast
Reviewed-by: psandoz, vlivanov
rev 12352 : 8076112: Add @HotSpotIntrinsicCandidate annotation to indicate methods for which Java Runtime has intrinsics
Summary: Annotate possibly intrinsified methods with @HotSpotIntrinsicCandidate. Add checks omitted by intrinsics to the library code. Add CheckIntrinsics flags to check consistency of intrinsics.
Reviewed-by: jrose, kvn, thartmann, vlivanov, abuckley, darcy, ascarpino, briangoetz, alanb, aph, dnsimon
rev 11873 : Merge
rev 11844 : 8075263: MHI::checkCustomized isn't eliminated for inlined MethodHandles
Reviewed-by: jrose, kvn
rev 11805 : 8078467: Update core libraries to use diamond with anonymous classes
Reviewed-by: mchung, alanb
rev 11460 : 8071788: BlockInliningWrapper.asType() is broken
Reviewed-by: jrose
rev 11459 : 8071787: Don't block inlining when DONT_INLINE_THRESHOLD=0
Reviewed-by: jrose
rev 11458 : 8069591: Customize LambdaForms which are invoked using MH.invoke/invokeExact
Reviewed-by: jrose, plevart, forax
rev 11457 : 8063137: Never-taken branches should be pruned when GWT LambdaForms are shared
Reviewed-by: jrose, kvn
rev 11009 : 8063135: Enable full LF sharing by default
Reviewed-by: psandoz, shade
rev 10931 : 8062180: MethodHandleImpl.makeArrays throws and swallows java.lang.NoSuchFieldError in normal flow
Reviewed-by: vlivanov, shade
rev 10910 : 8059877: GWT branch frequencies pollution due to LF sharing
Reviewed-by: psandoz, jrose
rev 10797 : 8058892: FILL_ARRAYS and ARRAYS are eagely initialized in MethodHandleImpl
Reviewed-by: kvn, shade
rev 10677 : 8058291: Missing some checks during parameter validation
Reviewed-by: jrose
rev 10634 : 8057922: Improve LambdaForm sharing by using LambdaFormEditor more extensively
Reviewed-by: vlivanov, psandoz
Contributed-by: john.r.rose@oracle.com
rev 10633 : 8057042: LambdaFormEditor: derive new LFs from a base LF
Reviewed-by: vlivanov, psandoz
Contributed-by: john.r.rose@oracle.com
rev 10632 : 8056926: Improve caching of GuardWithTest combinator
Reviewed-by: vlivanov, psandoz
Contributed-by: john.r.rose@oracle.com
rev 10631 : 8057657: Annotate LambdaForm parameters with types
Reviewed-by: vlivanov, psandoz
Contributed-by: john.r.rose@oracle.com
rev 10628 : 8050887: Intrinsify constants for default values
Reviewed-by: vlivanov, psandoz
Contributed-by: john.r.rose@oracle.com
rev 10627 : 8050884: Intrinsify ValueConversions.identity() functions
Reviewed-by: vlivanov, psandoz
Contributed-by: john.r.rose@oracle.com
rev 10626 : 8050877: Improve code for pairwise argument conversions and value boxing/unboxing
Reviewed-by: vlivanov, psandoz
Contributed-by: john.r.rose@oracle.com
rev 10625 : 8050200: Make LambdaForm intrinsics detection more robust
Reviewed-by: vlivanov, psandoz
Contributed-by: john.r.rose@oracle.com
rev 10624 : 8050057: Improve caching of MethodHandle reinvokers
Reviewed-by: vlivanov, psandoz
Contributed-by: john.r.rose@oracle.com
rev 10623 : 8050174: Support overriding of isInvokeSpecial flag in WrappedMember
Reviewed-by: vlivanov, psandoz
Contributed-by: john.r.rose@oracle.com
rev 10622 : 8050173: Add j.l.i.MethodHandle.copyWith(MethodType, LambdaForm)
Reviewed-by: vlivanov, psandoz
Contributed-by: john.r.rose@oracle.com
rev 10621 : 8050166: Get rid of some package-private methods on arguments in j.l.i.MethodHandle
Reviewed-by: vlivanov, psandoz
Contributed-by: john.r.rose@oracle.com
rev 10619 : 8050052: Small cleanups in java.lang.invoke code
Reviewed-by: vlivanov, psandoz
Contributed-by: john.r.rose@oracle.com
rev 10618 : 8049555: Move varargsArray from sun.invoke.util package to java.lang.invoke
Reviewed-by: psandoz, iignatyev
rev 10617 : 8038261: JSR292: cache and reuse typed array accessors
Reviewed-by: vlivanov, psandoz
Contributed-by: john.r.rose@oracle.com
rev 10616 : 8037209: Improvements and cleanups to bytecode assembly for lambda forms
Reviewed-by: vlivanov, psandoz
Contributed-by: john.r.rose@oracle.com
rev 10471 : Merge
rev 10444 : 8054834: Modular Source Code
Reviewed-by: alanb, chegar, ihse, mduigou
Contributed-by: alan.bateman@oracle.com, alex.buckley@oracle.com, chris.hegarty@oracle.com, erik.joelsson@oracle.com, jonathan.gibbons@oracle.com, karen.kinnear@oracle.com, magnus.ihse.bursie@oracle.com, mandy.chung@oracle.com, mark.reinhold@oracle.com, paul.sandoz@oracle.com
2 lines changed: 2 ins; 0 del; 0 mod; 2286 unchg

This code review page was prepared using /home/maurizio/bin/webrev (vers 25.2-hg+openjdk.java.net).