Code Review for 8189749

Prepared by:mcimadamore on Tue Nov 28 14:09:12 GMT 2017
Workspace:/w/lt/10-consolidated-proto/8189749
Summary of changes: 726 lines changed: 137 ins; 248 del; 341 mod; 53357 unchg
Patch of changes: 8189749.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/code/Lint.java

1 line changed: 0 ins; 0 del; 1 mod; 407 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/code/Source.java

127 lines changed: 5 ins; 6 del; 116 mod; 133 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symtab.java

2 lines changed: 1 ins; 0 del; 1 mod; 828 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.java

4 lines changed: 1 ins; 0 del; 3 mod; 5178 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Analyzer.java

10 lines changed: 1 ins; 0 del; 9 mod; 761 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Annotate.java

4 lines changed: 2 ins; 0 del; 2 mod; 1357 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java

9 lines changed: 1 ins; 0 del; 8 mod; 5237 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java

36 lines changed: 1 ins; 25 del; 10 mod; 3934 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Flow.java

5 lines changed: 1 ins; 0 del; 4 mod; 2705 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Infer.java

3 lines changed: 2 ins; 0 del; 1 mod; 1944 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Modules.java

2 lines changed: 1 ins; 0 del; 1 mod; 1774 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java

5 lines changed: 1 ins; 0 del; 4 mod; 4778 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TransTypes.java

3 lines changed: 1 ins; 0 del; 2 mod; 989 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TypeEnter.java

3 lines changed: 1 ins; 0 del; 2 mod; 1163 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassReader.java

3 lines changed: 1 ins; 0 del; 2 mod; 3080 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/main/Arguments.java

1 line changed: 1 ins; 0 del; 0 mod; 961 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/main/JavaCompiler.java

3 lines changed: 1 ins; 0 del; 2 mod; 1842 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/model/JavacElements.java

2 lines changed: 1 ins; 0 del; 1 mod; 778 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavaTokenizer.java

51 lines changed: 13 ins; 14 del; 24 mod; 854 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java

159 lines changed: 4 ins; 130 del; 25 mod; 4253 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java

6 lines changed: 1 ins; 3 del; 2 mod; 1708 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties

144 lines changed: 49 ins; 65 del; 30 mod; 3081 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/util/Log.java

18 lines changed: 16 ins; 0 del; 2 mod; 842 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/RootDocImpl.java

2 lines changed: 1 ins; 0 del; 1 mod; 398 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/WorkArounds.java

2 lines changed: 1 ins; 0 del; 1 mod; 596 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/ElementsTable.java

2 lines changed: 1 ins; 0 del; 1 mod; 1298 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/CompletenessAnalyzer.java

7 lines changed: 6 ins; 0 del; 1 mod; 866 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/ReplParser.java

2 lines changed: 1 ins; 0 del; 1 mod; 259 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/jshell/CompilerOptionsTest.java

1 line changed: 0 ins; 0 del; 1 mod; 55 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/StringsInSwitch/BadlyTypedLabel1_6.out

3 lines changed: 0 ins; 0 del; 3 mod; 4 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/StringsInSwitch/BadlyTypedLabel2_6.out

3 lines changed: 0 ins; 0 del; 3 mod; 4 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/StringsInSwitch/NonConstantLabel6.out

3 lines changed: 0 ins; 0 del; 3 mod; 4 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/StringsInSwitch/OneCaseSwitches.out

3 lines changed: 0 ins; 0 del; 3 mod; 2 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/StringsInSwitch/RSCL1_6.out

3 lines changed: 0 ins; 0 del; 3 mod; 4 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/StringsInSwitch/RSCL2_6.out

3 lines changed: 0 ins; 0 del; 3 mod; 4 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/TryWithResources/BadTwr6.out

3 lines changed: 0 ins; 0 del; 3 mod; 3 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/TryWithResources/BadTwrSyntax6.out

3 lines changed: 0 ins; 0 del; 3 mod; 4 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/TryWithResources/TwrForVariable1.out

1 line changed: 0 ins; 0 del; 1 mod; 1 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/TryWithResources/TwrOnNonResource6.out

3 lines changed: 0 ins; 0 del; 3 mod; 3 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/TryWithResources/WeirdTwr.out

3 lines changed: 0 ins; 0 del; 3 mod; 3 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/annotations/repeatingAnnotations/WrongVersion6.out

1 line changed: 0 ins; 0 del; 1 mod; 1 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/annotations/repeatingAnnotations/WrongVersion7.out

1 line changed: 0 ins; 0 del; 1 mod; 1 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/annotations/typeAnnotations/failures/AnnotationVersion.out

1 line changed: 0 ins; 0 del; 1 mod; 1 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/annotations/typeAnnotations/failures/AnnotationVersion7.out

1 line changed: 0 ins; 0 del; 1 mod; 1 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/annotations/typeAnnotations/failures/CheckErrorsForSource7.java

5 lines changed: 0 ins; 3 del; 2 mod; 193 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/conditional/Conditional.out

1 line changed: 0 ins; 0 del; 1 mod; 3 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/defaultMethods/static/StaticInvokeQualified6.out

1 line changed: 0 ins; 0 del; 1 mod; 1 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/defaultMethods/static/StaticInvokeQualified7.out

1 line changed: 0 ins; 0 del; 1 mod; 1 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/defaultMethods/static/StaticInvokeSimple6.out

1 line changed: 0 ins; 0 del; 1 mod; 1 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/defaultMethods/static/StaticInvokeSimple7.out

1 line changed: 0 ins; 0 del; 1 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/depDocComment/SuppressDeprecation8.out

1 line changed: 0 ins; 0 del; 1 mod; 8 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples.not-yet.txt

1 line changed: 1 ins; 0 del; 0 mod; 154 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/AnnotationsAfterTypeParamsNotSupportedInSource.java

2 lines changed: 1 ins; 0 del; 1 mod; 33 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/DefaultMethodNotSupported.java

2 lines changed: 1 ins; 0 del; 1 mod; 28 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/DiamondAndAnonClass.java

2 lines changed: 1 ins; 0 del; 1 mod; 34 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/DiamondNotSupported.java

2 lines changed: 1 ins; 0 del; 1 mod; 32 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/IntersectionTypesInCastNotSupported.java

2 lines changed: 1 ins; 0 del; 1 mod; 28 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/LambdaNotSupported.java

2 lines changed: 1 ins; 0 del; 1 mod; 28 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/MethodReferencesNotSupported.java

2 lines changed: 1 ins; 0 del; 1 mod; 28 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/ModulesNotSupportedInSource/module-info.java

2 lines changed: 1 ins; 0 del; 1 mod; 28 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/MulticatchNotSupported.java

2 lines changed: 1 ins; 0 del; 1 mod; 41 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/PrivateInterfaceMethodsNotSupported.java

2 lines changed: 1 ins; 0 del; 1 mod; 29 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/RepeatableAnnotationsNotSupported.java

2 lines changed: 1 ins; 0 del; 1 mod; 31 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/StaticIntfMethodInvokeNotSupported.java

2 lines changed: 1 ins; 0 del; 1 mod; 31 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/StaticIntfMethodNotSupported.java

2 lines changed: 1 ins; 0 del; 1 mod; 28 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/StringSwitchNotSupported.java

2 lines changed: 1 ins; 0 del; 1 mod; 34 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/TryResourceNotSupported.java

2 lines changed: 1 ins; 0 del; 1 mod; 34 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/TypeAnnotationsNotSupported.java

2 lines changed: 1 ins; 0 del; 1 mod; 33 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/UnsupportedBinaryLiteral.java

2 lines changed: 1 ins; 0 del; 1 mod; 28 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/UnsupportedUnderscoreLiteral.java

2 lines changed: 1 ins; 0 del; 1 mod; 28 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/VarInTryWithResourcesNotSupportedInSource.java

2 lines changed: 1 ins; 0 del; 1 mod; 40 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/generics/diamond/neg/Neg09a.out

2 lines changed: 0 ins; 0 del; 2 mod; 2 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/generics/diamond/neg/Neg09b.out

2 lines changed: 0 ins; 0 del; 2 mod; 2 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/generics/diamond/neg/Neg09c.out

2 lines changed: 0 ins; 0 del; 2 mod; 2 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/generics/diamond/neg/Neg09d.out

1 line changed: 0 ins; 0 del; 1 mod; 3 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/generics/inference/6278587/T6278587Neg.out

1 line changed: 0 ins; 0 del; 1 mod; 3 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/generics/odersky/BadTest4.out

1 line changed: 0 ins; 0 del; 1 mod; 3 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/lambda/SourceLevelTest.out

4 lines changed: 0 ins; 0 del; 4 mod; 2 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/literals/BadBinaryLiterals.6.out

4 lines changed: 0 ins; 2 del; 2 mod; 4 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/literals/BadUnderscoreLiterals.6.out

2 lines changed: 0 ins; 0 del; 2 mod; 19 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/options/T6900037.out

1 line changed: 0 ins; 0 del; 1 mod; 3 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/parser/extend/TrialParser.java

2 lines changed: 1 ins; 0 del; 1 mod; 252 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/processing/warnings/gold_sv_warn_5_6.out

1 line changed: 0 ins; 0 del; 1 mod; 1 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/varargs/6313164/T6313164Source7.out

1 line changed: 0 ins; 0 del; 1 mod; 5 unchg

This code review page was prepared using /home/maurizio/bin/webrev (vers 25.16-hg+openjdk.java.net).