Code Review for dev

Prepared by:mcimadamore on Mon Dec 9 18:16:01 GMT 2019
Workspace:/w/lt/10-consolidated-proto/dev
Compare against version:57241
Summary of changes: 7865 lines changed: 7718 ins; 47 del; 100 mod; 19585 unchg
Patch of changes: dev.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/common/Modules.gmk

rev 57242 : imported patch 8234049.patch
2 lines changed: 2 ins; 0 del; 0 mod; 488 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/gensrc/GensrcVarHandles.gmk

rev 57242 : imported patch 8234049.patch
107 lines changed: 107 ins; 0 del; 0 mod; 175 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/ci/ciField.cpp

rev 57242 : imported patch 8234049.patch
3 lines changed: 2 ins; 0 del; 1 mod; 438 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/library_call.cpp

rev 57242 : imported patch 8234049.patch
rev 57243 : imported patch 8234049_v2
0 lines changed: 0 ins; 0 del; 0 mod; 6889 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/MethodHandleImpl.java

39 lines changed: 39 ins; 0 del; 0 mod; 2267 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/VarHandles.java

50 lines changed: 50 ins; 0 del; 0 mod; 575 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/X-VarHandleByteArrayView.java.template

rev 57244 : [mq]: 8234049_v3
6 lines changed: 5 ins; 0 del; 1 mod; 975 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/nio/Buffer.java

48 lines changed: 47 ins; 0 del; 1 mod; 744 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/nio/ByteBufferAs-X-Buffer.java.template

rev 57242 : imported patch 8234049.patch
16 lines changed: 5 ins; 0 del; 11 mod; 249 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/nio/Direct-X-Buffer-bin.java.template

rev 57242 : imported patch 8234049.patch
6 lines changed: 2 ins; 0 del; 4 mod; 129 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/nio/Direct-X-Buffer.java.template

rev 57242 : imported patch 8234049.patch
25 lines changed: 10 ins; 0 del; 15 mod; 602 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/nio/Heap-X-Buffer.java.template

rev 57242 : imported patch 8234049.patch
61 lines changed: 34 ins; 0 del; 27 mod; 660 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/nio/MappedByteBuffer.java

rev 57242 : imported patch 8234049.patch
8 lines changed: 2 ins; 0 del; 6 mod; 423 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/nio/StringCharBuffer.java

rev 57242 : imported patch 8234049.patch
2 lines changed: 0 ins; 0 del; 2 mod; 165 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/nio/X-Buffer.java.template

rev 57242 : imported patch 8234049.patch
15 lines changed: 9 ins; 0 del; 6 mod; 2009 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/access/JavaLangInvokeAccess.java

39 lines changed: 39 ins; 0 del; 0 mod; 109 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/access/JavaNioAccess.java

32 lines changed: 32 ins; 0 del; 0 mod; 42 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/module-info.java

rev 57242 : imported patch 8234049.patch
12 lines changed: 7 ins; 0 del; 5 mod; 376 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/ch/FileChannelImpl.java

150 lines changed: 86 ins; 47 del; 17 mod; 1240 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/ch/Util.java

rev 57242 : imported patch 8234049.patch
5 lines changed: 1 ins; 0 del; 4 mod; 531 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/TEST.groups

rev 57242 : imported patch 8234049.patch
rev 57244 : [mq]: 8234049_v3
4 lines changed: 4 ins; 0 del; 0 mod; 499 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/lang/invoke/AddressVarHandleGenerator.java

rev 57242 : imported patch 8234049.patch
rev 57243 : imported patch 8234049_v2
rev 57244 : [mq]: 8234049_v3
494 lines changed: 494 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/lang/invoke/VarHandleMemoryAddressBase.java

63 lines changed: 63 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/lang/invoke/X-VarHandleMemoryAddressView.java.template

513 lines changed: 513 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/jdk/internal/access/foreign/MemoryAddressProxy.java

42 lines changed: 42 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/jdk/internal/access/foreign/MemorySegmentProxy.java

rev 57242 : imported patch 8234049.patch
35 lines changed: 35 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/jdk/internal/access/foreign/UnmapperProxy.java

rev 57242 : imported patch 8234049.patch
36 lines changed: 36 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/AbstractLayout.java

rev 57242 : imported patch 8234049.patch
rev 57243 : imported patch 8234049_v2
178 lines changed: 178 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/GroupLayout.java

rev 57242 : imported patch 8234049.patch
rev 57243 : imported patch 8234049_v2
rev 57244 : [mq]: 8234049_v3
210 lines changed: 210 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/MemoryAddress.java

109 lines changed: 109 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/MemoryHandles.java

268 lines changed: 268 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/MemoryLayout.java

445 lines changed: 445 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/MemoryLayouts.java

rev 57242 : imported patch 8234049.patch
138 lines changed: 138 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/MemorySegment.java

430 lines changed: 430 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/PaddingLayout.java

rev 57242 : imported patch 8234049.patch
rev 57244 : [mq]: 8234049_v3
111 lines changed: 111 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/SequenceLayout.java

rev 57242 : imported patch 8234049.patch
rev 57243 : imported patch 8234049_v2
rev 57244 : [mq]: 8234049_v3
161 lines changed: 161 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/ValueLayout.java

rev 57242 : imported patch 8234049.patch
rev 57244 : [mq]: 8234049_v3
140 lines changed: 140 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/package-info.java

rev 57242 : imported patch 8234049.patch
rev 57244 : [mq]: 8234049_v3
90 lines changed: 90 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/unsafe/ForeignUnsafe.java

rev 57242 : imported patch 8234049.patch
68 lines changed: 68 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/LayoutPath.java

208 lines changed: 208 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/MemoryAddressImpl.java

rev 57242 : imported patch 8234049.patch
rev 57244 : [mq]: 8234049_v3
122 lines changed: 122 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/MemoryScope.java

rev 57242 : imported patch 8234049.patch
rev 57243 : imported patch 8234049_v2
93 lines changed: 93 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/MemorySegmentImpl.java

rev 57242 : imported patch 8234049.patch
rev 57244 : [mq]: 8234049_v3
210 lines changed: 210 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/Utils.java

rev 57242 : imported patch 8234049.patch
rev 57244 : [mq]: 8234049_v3
157 lines changed: 157 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.incubator.foreign/share/classes/module-info.java

rev 57242 : imported patch 8234049.patch
35 lines changed: 35 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/foreign/TEST.properties

rev 57242 : imported patch 8234049.patch
25 lines changed: 25 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/foreign/TestArrays.java

rev 57242 : imported patch 8234049.patch
145 lines changed: 145 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/foreign/TestByteBuffer.java

rev 57242 : imported patch 8234049.patch
rev 57244 : [mq]: 8234049_v3
555 lines changed: 555 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/foreign/TestLayoutConstants.java

rev 57242 : imported patch 8234049.patch
96 lines changed: 96 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/foreign/TestLayoutPaths.java

rev 57242 : imported patch 8234049.patch
137 lines changed: 137 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/foreign/TestLayouts.java

rev 57242 : imported patch 8234049.patch
270 lines changed: 270 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/foreign/TestMemoryAccess.java

rev 57242 : imported patch 8234049.patch
459 lines changed: 459 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/foreign/TestMemoryAlignment.java

rev 57242 : imported patch 8234049.patch
136 lines changed: 136 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/foreign/TestMemoryCopy.java

rev 57244 : [mq]: 8234049_v3
rev 57245 : [mq]: 8234049_v4
145 lines changed: 145 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/foreign/TestNative.java

rev 57242 : imported patch 8234049.patch
232 lines changed: 232 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/foreign/TestSegments.java

rev 57242 : imported patch 8234049.patch
196 lines changed: 196 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/foreign/TestSharedAccess.java

rev 57242 : imported patch 8234049.patch
82 lines changed: 82 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/foreign/TestSlices.java

rev 57242 : imported patch 8234049.patch
97 lines changed: 97 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/foreign/TestVarHandleCombinators.java

rev 57242 : imported patch 8234049.patch
189 lines changed: 189 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/foreign/libNativeAccess.c

rev 57242 : imported patch 8234049.patch
115 lines changed: 115 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/maurizio/bin/webrev (vers 25.16-hg+openjdk.java.net).