Code Review for jdk

Prepared by:mduigou on Mon Jun 17 21:37:52 PDT 2013
Workspace:/home/mike/code/jdk/tl8/jdk
Compare against: ssh://hg.openjdk.java.net/jdk8/tl-gate/jdk
Compare against version:7359
Summary of changes: 2651 lines changed: 1733 ins; 455 del; 463 mod; 19523 unchg
Changeset: jdk.changeset
Bug id: JDK-7129185 : (coll) Please add Collections.emptyNavigableSet()
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/java/util/AbstractMap.java

rev 7361 : 7129185: Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set}
Reviewed-by: dmocek, martin, smarks
2 lines changed: 2 ins; 0 del; 0 mod; 822 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/java/util/Collections.java

rev 7361 : 7129185: Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set}
Reviewed-by: dmocek, martin, smarks
967 lines changed: 808 ins; 103 del; 56 mod; 4563 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/java/util/HashMap.java

rev 7360 : 8016446: Improve forEach/replaceAll for Map, HashMap, Hashtable, IdentityHashMap, WeakHashMap, TreeMap
Reviewed-by: forax, duigou, psandoz
Contributed-by: Mike Duigou <mike.duigou@oracle.com>, Remi Forax <forax@univ-mlv.fr>
112 lines changed: 106 ins; 3 del; 3 mod; 3006 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/java/util/Hashtable.java

rev 7360 : 8016446: Improve forEach/replaceAll for Map, HashMap, Hashtable, IdentityHashMap, WeakHashMap, TreeMap
Reviewed-by: forax, duigou, psandoz
Contributed-by: Mike Duigou <mike.duigou@oracle.com>, Remi Forax <forax@univ-mlv.fr>
28 lines changed: 20 ins; 0 del; 8 mod; 1439 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/java/util/IdentityHashMap.java

rev 7360 : 8016446: Improve forEach/replaceAll for Map, HashMap, Hashtable, IdentityHashMap, WeakHashMap, TreeMap
Reviewed-by: forax, duigou, psandoz
Contributed-by: Mike Duigou <mike.duigou@oracle.com>, Remi Forax <forax@univ-mlv.fr>
34 lines changed: 34 ins; 0 del; 0 mod; 1558 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/java/util/LinkedHashMap.java

rev 7360 : 8016446: Improve forEach/replaceAll for Map, HashMap, Hashtable, IdentityHashMap, WeakHashMap, TreeMap
Reviewed-by: forax, duigou, psandoz
Contributed-by: Mike Duigou <mike.duigou@oracle.com>, Remi Forax <forax@univ-mlv.fr>
28 lines changed: 28 ins; 0 del; 0 mod; 473 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/java/util/Map.java

rev 7360 : 8016446: Improve forEach/replaceAll for Map, HashMap, Hashtable, IdentityHashMap, WeakHashMap, TreeMap
Reviewed-by: forax, duigou, psandoz
Contributed-by: Mike Duigou <mike.duigou@oracle.com>, Remi Forax <forax@univ-mlv.fr>
13 lines changed: 12 ins; 1 del; 0 mod; 1090 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/java/util/NavigableSet.java

rev 7361 : 7129185: Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set}
Reviewed-by: dmocek, martin, smarks
1 line changed: 0 ins; 0 del; 1 mod; 318 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/java/util/TreeMap.java

rev 7360 : 8016446: Improve forEach/replaceAll for Map, HashMap, Hashtable, IdentityHashMap, WeakHashMap, TreeMap
Reviewed-by: forax, duigou, psandoz
Contributed-by: Mike Duigou <mike.duigou@oracle.com>, Remi Forax <forax@univ-mlv.fr>
29 lines changed: 29 ins; 0 del; 0 mod; 2921 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/java/util/WeakHashMap.java

rev 7360 : 8016446: Improve forEach/replaceAll for Map, HashMap, Hashtable, IdentityHashMap, WeakHashMap, TreeMap
Reviewed-by: forax, duigou, psandoz
Contributed-by: Mike Duigou <mike.duigou@oracle.com>, Remi Forax <forax@univ-mlv.fr>
44 lines changed: 44 ins; 0 del; 0 mod; 1320 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/java/util/concurrent/ConcurrentMap.java

rev 7360 : 8016446: Improve forEach/replaceAll for Map, HashMap, Hashtable, IdentityHashMap, WeakHashMap, TreeMap
Reviewed-by: forax, duigou, psandoz
Contributed-by: Mike Duigou <mike.duigou@oracle.com>, Remi Forax <forax@univ-mlv.fr>
34 lines changed: 34 ins; 0 del; 0 mod; 186 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/util/Collections/CheckedIdentityMap.java

rev 7361 : 7129185: Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set}
Reviewed-by: dmocek, martin, smarks
42 lines changed: 10 ins; 27 del; 5 mod; 50 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/util/Collections/CheckedMapBash.java

rev 7361 : 7129185: Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set}
Reviewed-by: dmocek, martin, smarks
141 lines changed: 72 ins; 45 del; 24 mod; 80 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/util/Collections/CheckedSetBash.java

rev 7361 : 7129185: Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set}
Reviewed-by: dmocek, martin, smarks
107 lines changed: 33 ins; 7 del; 67 mod; 69 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/util/Collections/EmptyCollectionSerialization.java

rev 7361 : 7129185: Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set}
Reviewed-by: dmocek, martin, smarks
49 lines changed: 39 ins; 0 del; 10 mod; 50 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/util/Map/Defaults.java

rev 7360 : 8016446: Improve forEach/replaceAll for Map, HashMap, Hashtable, IdentityHashMap, WeakHashMap, TreeMap
Reviewed-by: forax, duigou, psandoz
Contributed-by: Mike Duigou <mike.duigou@oracle.com>, Remi Forax <forax@univ-mlv.fr>
169 lines changed: 102 ins; 8 del; 59 mod; 527 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/util/NavigableMap/LockStep.java

rev 7361 : 7129185: Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set}
Reviewed-by: dmocek, martin, smarks
24 lines changed: 19 ins; 1 del; 4 mod; 835 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/util/Collections/EmptyNavigableMap.java (was test/java/util/Collections/EmptySortedSet.java)

rev 7361 : 7129185: Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set}
Reviewed-by: dmocek, martin, smarks
438 lines changed: 178 ins; 156 del; 104 mod; 91 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/util/Collections/EmptyNavigableSet.java (was test/java/util/Collections/EmptySortedSet.java)

rev 7361 : 7129185: Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set}
Reviewed-by: dmocek, martin, smarks
389 lines changed: 163 ins; 104 del; 122 mod; 125 unchg

This code review page was prepared using ../make/scripts/webrev.ksh (vers 24.0-hg+jbs).