Code Review for jdk

Prepared by:mduigou on Thu Feb 14 15:42:34 PST 2013
Workspace:/home/mike/code/jdk/tl8/jdk
Compare against: ssh://hg.openjdk.java.net/jdk8/tl-gate/jdk
Compare against version:qparent
Summary of changes: 1290 lines changed: 1100 ins; 41 del; 149 mod; 5429 unchg
Patch of changes: jdk.patch
Bug id: 8004561
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/chrono/HijrahDeviationReader.java

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
4 lines changed: 0 ins; 0 del; 4 mod; 240 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/concurrent/atomic/AtomicInteger.java

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
4 lines changed: 0 ins; 0 del; 4 mod; 332 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/concurrent/atomic/AtomicIntegerArray.java

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
4 lines changed: 0 ins; 0 del; 4 mod; 359 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/concurrent/atomic/AtomicIntegerFieldUpdater.java

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
4 lines changed: 0 ins; 0 del; 4 mod; 497 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/concurrent/atomic/AtomicLong.java

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
4 lines changed: 0 ins; 0 del; 4 mod; 346 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/concurrent/atomic/AtomicLongArray.java

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
4 lines changed: 0 ins; 0 del; 4 mod; 358 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/concurrent/atomic/AtomicLongFieldUpdater.java

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
4 lines changed: 0 ins; 0 del; 4 mod; 600 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/concurrent/atomic/AtomicReference.java

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
4 lines changed: 0 ins; 0 del; 4 mod; 236 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/concurrent/atomic/AtomicReferenceArray.java

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
4 lines changed: 0 ins; 0 del; 4 mod; 328 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/concurrent/atomic/AtomicReferenceFieldUpdater.java

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
4 lines changed: 0 ins; 0 del; 4 mod; 436 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/concurrent/atomic/DoubleAccumulator.java

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
4 lines changed: 0 ins; 0 del; 4 mod; 235 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/concurrent/atomic/LongAccumulator.java

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
4 lines changed: 0 ins; 0 del; 4 mod; 232 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/concurrent/atomic/Striped64.java

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
4 lines changed: 0 ins; 0 del; 4 mod; 413 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/function/BinaryOperator.java

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
17 lines changed: 2 ins; 11 del; 4 mod; 33 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/function/DoubleBinaryOperator.java

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
11 lines changed: 4 ins; 4 del; 3 mod; 41 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/function/DoubleFunction.java

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
10 lines changed: 2 ins; 1 del; 7 mod; 38 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/function/DoubleSupplier.java

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
5 lines changed: 1 ins; 2 del; 2 mod; 40 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/function/DoubleUnaryOperator.java

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
6 lines changed: 2 ins; 0 del; 4 mod; 40 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/function/Function.java

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
6 lines changed: 1 ins; 1 del; 4 mod; 43 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/function/IntBinaryOperator.java

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
4 lines changed: 3 ins; 0 del; 1 mod; 44 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/function/IntFunction.java

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
10 lines changed: 2 ins; 1 del; 7 mod; 38 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/function/IntSupplier.java

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
5 lines changed: 1 ins; 2 del; 2 mod; 40 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/function/IntUnaryOperator.java

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
6 lines changed: 3 ins; 0 del; 3 mod; 40 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/function/LongBinaryOperator.java

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
4 lines changed: 3 ins; 0 del; 1 mod; 44 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/function/LongFunction.java

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
10 lines changed: 2 ins; 1 del; 7 mod; 38 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/function/LongSupplier.java

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
5 lines changed: 1 ins; 2 del; 2 mod; 40 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/function/LongUnaryOperator.java

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
4 lines changed: 3 ins; 0 del; 1 mod; 42 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/function/Predicate.java

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
56 lines changed: 55 ins; 0 del; 1 mod; 44 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/function/UnaryOperator.java

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
13 lines changed: 2 ins; 8 del; 3 mod; 34 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/function/package-info.java

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
54 lines changed: 36 ins; 1 del; 17 mod; 30 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/java/util/function/BiConsumer.java

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
50 lines changed: 50 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/java/util/function/BiFunction.java

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
51 lines changed: 51 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/java/util/function/BiPredicate.java

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
103 lines changed: 103 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/java/util/function/BooleanSupplier.java

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
44 lines changed: 44 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/function/Consumer.java (was src/share/classes/java/util/function/Block.java)

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
6 lines changed: 1 ins; 1 del; 4 mod; 40 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/function/DoubleConsumer.java (was src/share/classes/java/util/function/DoubleBlock.java)

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
11 lines changed: 1 ins; 2 del; 8 mod; 36 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/java/util/function/DoublePredicate.java

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
100 lines changed: 100 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/function/IntConsumer.java (was src/share/classes/java/util/function/IntBlock.java)

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
11 lines changed: 1 ins; 2 del; 8 mod; 36 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/java/util/function/IntPredicate.java

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
100 lines changed: 100 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/function/LongConsumer.java (was src/share/classes/java/util/function/LongBlock.java)

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
11 lines changed: 1 ins; 2 del; 8 mod; 36 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/java/util/function/LongPredicate.java

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
100 lines changed: 100 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/java/util/function/ObjDoubleConsumer.java

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
48 lines changed: 48 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/java/util/function/ObjIntConsumer.java

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
48 lines changed: 48 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/java/util/function/ObjLongConsumer.java

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
48 lines changed: 48 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/java/util/function/ToDoubleBiFunction.java

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
48 lines changed: 48 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/java/util/function/ToDoubleFunction.java

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
46 lines changed: 46 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/java/util/function/ToIntBiFunction.java

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
48 lines changed: 48 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/java/util/function/ToIntFunction.java

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
46 lines changed: 46 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/java/util/function/ToLongBiFunction.java

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
48 lines changed: 48 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/java/util/function/ToLongFunction.java

rev 6546 : 8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz
45 lines changed: 45 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using ../make/scripts/webrev.ksh (vers 23.18-hg+jbs).