Code Review for jdk

Prepared by:mduigou on Mon Aug 26 20:48:36 PDT 2013
Workspace:/home/mike/code/jdk/tl8/jdk
Compare against: ssh://hg.openjdk.java.net/jdk8/tl-gate/jdk
Compare against version:-2
Summary of changes: 778 lines changed: 468 ins; 174 del; 136 mod; 23364 unchg
Patch of changes: jdk.patch
Bug id: Bug ID: JDK-8021591 Additional NPE checks
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/Collections.java

rev 7932 : 8021591: Additional explicit null checks
Reviewed-by: psandoz, martin, alanb
1 line changed: 1 ins; 0 del; 0 mod; 5577 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/Hashtable.java

rev 7932 : 8021591: Additional explicit null checks
Reviewed-by: psandoz, martin, alanb
3 lines changed: 3 ins; 0 del; 0 mod; 1469 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/IdentityHashMap.java

rev 7932 : 8021591: Additional explicit null checks
Reviewed-by: psandoz, martin, alanb
2 lines changed: 2 ins; 0 del; 0 mod; 1598 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/Map.java

rev 7932 : 8021591: Additional explicit null checks
Reviewed-by: psandoz, martin, alanb
8 lines changed: 7 ins; 0 del; 1 mod; 1191 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/TreeMap.java

rev 7932 : 8021591: Additional explicit null checks
Reviewed-by: psandoz, martin, alanb
1 line changed: 0 ins; 0 del; 1 mod; 3004 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/concurrent/ConcurrentHashMap.java

rev 7932 : 8021591: Additional explicit null checks
Reviewed-by: psandoz, martin, alanb
3 lines changed: 3 ins; 0 del; 0 mod; 6174 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/security/auth/Subject.java

rev 7932 : 8021591: Additional explicit null checks
Reviewed-by: psandoz, martin, alanb
2 lines changed: 0 ins; 0 del; 2 mod; 1439 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/Collection/CollectionDefaults.java

rev 7932 : 8021591: Additional explicit null checks
Reviewed-by: psandoz, martin, alanb
73 lines changed: 39 ins; 1 del; 33 mod; 117 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/Collection/MOAT.java

rev 7932 : 8021591: Additional explicit null checks
Reviewed-by: psandoz, martin, alanb
2 lines changed: 0 ins; 2 del; 0 mod; 1279 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/Collection/testlibrary/CollectionAsserts.java

rev 7932 : 8021591: Additional explicit null checks
Reviewed-by: psandoz, martin, alanb
41 lines changed: 17 ins; 11 del; 13 mod; 187 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/Collection/testlibrary/CollectionSupplier.java

rev 7932 : 8021591: Additional explicit null checks
Reviewed-by: psandoz, martin, alanb
276 lines changed: 89 ins; 148 del; 39 mod; 117 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/Map/Defaults.java

rev 7932 : 8021591: Additional explicit null checks
Reviewed-by: psandoz, martin, alanb
37 lines changed: 26 ins; 2 del; 9 mod; 724 unchg

------ ------ ------ ------ --- New Patch Raw test/java/util/Collection/testlibrary/ExtendsAbstractCollection.java

rev 7932 : 8021591: Additional explicit null checks
Reviewed-by: psandoz, martin, alanb
86 lines changed: 86 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/util/Collection/testlibrary/ExtendsAbstractList.java

rev 7932 : 8021591: Additional explicit null checks
Reviewed-by: psandoz, martin, alanb
101 lines changed: 101 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/util/Collection/testlibrary/ExtendsAbstractSet.java

rev 7932 : 8021591: Additional explicit null checks
Reviewed-by: psandoz, martin, alanb
85 lines changed: 85 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/List/ListDefaults.java (was test/java/util/Collection/ListDefaults.java)

rev 7932 : 8021591: Additional explicit null checks
Reviewed-by: psandoz, martin, alanb
57 lines changed: 9 ins; 10 del; 38 mod; 488 unchg

This code review page was prepared using ../make/scripts/webrev.ksh (vers 24.0-hg+jbs).