Code Review for hotspot

Prepared by:Michael Haupt on Thu Jul 9 16:41:55 CEST 2015
Workspace:/Users/haupt/JPG/hs-comp/hotspot
Compare against version:8631
Summary of changes: 1880 lines changed: 1530 ins; 89 del; 261 mod; 4262 unchg
Changeset: hotspot.changeset
Bug id: JDK-6900757
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw .hgignore

rev 8632 : 6900757: minor bug fixes to LogCompilation tool
* improve internal error reporting (point to XML element causing trouble)
* fix comparator for sorting by name and start
* make tool more robust wrt. incorrect options and files not found
* make inlining decision output more clear
* adopt uncommon traps history printing
* properly mention compiler in generated logs
* add options for printing time stamps and omitting compilation IDs
* add option for comparing compilation logs
* overall code cleanup and API documentation
1 line changed: 1 ins; 0 del; 0 mod; 12 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/tools/LogCompilation/Makefile

rev 8632 : 6900757: minor bug fixes to LogCompilation tool
* improve internal error reporting (point to XML element causing trouble)
* fix comparator for sorting by name and start
* make tool more robust wrt. incorrect options and files not found
* make inlining decision output more clear
* adopt uncommon traps history printing
* properly mention compiler in generated logs
* add options for printing time stamps and omitting compilation IDs
* add option for comparing compilation logs
* overall code cleanup and API documentation
2 lines changed: 0 ins; 0 del; 2 mod; 73 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/BasicLogEvent.java

rev 8632 : 6900757: minor bug fixes to LogCompilation tool
* improve internal error reporting (point to XML element causing trouble)
* fix comparator for sorting by name and start
* make tool more robust wrt. incorrect options and files not found
* make inlining decision output more clear
* adopt uncommon traps history printing
* properly mention compiler in generated logs
* add options for printing time stamps and omitting compilation IDs
* add option for comparing compilation logs
* overall code cleanup and API documentation
30 lines changed: 20 ins; 1 del; 9 mod; 65 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/CallSite.java

rev 8632 : 6900757: minor bug fixes to LogCompilation tool
* improve internal error reporting (point to XML element causing trouble)
* fix comparator for sorting by name and start
* make tool more robust wrt. incorrect options and files not found
* make inlining decision output more clear
* adopt uncommon traps history printing
* properly mention compiler in generated logs
* add options for printing time stamps and omitting compilation IDs
* add option for comparing compilation logs
* overall code cleanup and API documentation
147 lines changed: 107 ins; 20 del; 20 mod; 244 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/Compilation.java

rev 8632 : 6900757: minor bug fixes to LogCompilation tool
* improve internal error reporting (point to XML element causing trouble)
* fix comparator for sorting by name and start
* make tool more robust wrt. incorrect options and files not found
* make inlining decision output more clear
* adopt uncommon traps history printing
* properly mention compiler in generated logs
* add options for printing time stamps and omitting compilation IDs
* add option for comparing compilation logs
* overall code cleanup and API documentation
134 lines changed: 110 ins; 2 del; 22 mod; 232 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogCleanupReader.java

rev 8632 : 6900757: minor bug fixes to LogCompilation tool
* improve internal error reporting (point to XML element causing trouble)
* fix comparator for sorting by name and start
* make tool more robust wrt. incorrect options and files not found
* make inlining decision output more clear
* adopt uncommon traps history printing
* properly mention compiler in generated logs
* add options for printing time stamps and omitting compilation IDs
* add option for comparing compilation logs
* overall code cleanup and API documentation
25 lines changed: 8 ins; 3 del; 14 mod; 195 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogCompilation.java

rev 8632 : 6900757: minor bug fixes to LogCompilation tool
* improve internal error reporting (point to XML element causing trouble)
* fix comparator for sorting by name and start
* make tool more robust wrt. incorrect options and files not found
* make inlining decision output more clear
* adopt uncommon traps history printing
* properly mention compiler in generated logs
* add options for printing time stamps and omitting compilation IDs
* add option for comparing compilation logs
* overall code cleanup and API documentation
375 lines changed: 339 ins; 9 del; 27 mod; 145 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogEvent.java

rev 8632 : 6900757: minor bug fixes to LogCompilation tool
* improve internal error reporting (point to XML element causing trouble)
* fix comparator for sorting by name and start
* make tool more robust wrt. incorrect options and files not found
* make inlining decision output more clear
* adopt uncommon traps history printing
* properly mention compiler in generated logs
* add options for printing time stamps and omitting compilation IDs
* add option for comparing compilation logs
* overall code cleanup and API documentation
21 lines changed: 18 ins; 1 del; 2 mod; 35 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogParser.java

rev 8632 : 6900757: minor bug fixes to LogCompilation tool
* improve internal error reporting (point to XML element causing trouble)
* fix comparator for sorting by name and start
* make tool more robust wrt. incorrect options and files not found
* make inlining decision output more clear
* adopt uncommon traps history printing
* properly mention compiler in generated logs
* add options for printing time stamps and omitting compilation IDs
* add option for comparing compilation logs
* overall code cleanup and API documentation
850 lines changed: 672 ins; 43 del; 135 mod; 488 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/MakeNotEntrantEvent.java

rev 8632 : 6900757: minor bug fixes to LogCompilation tool
* improve internal error reporting (point to XML element causing trouble)
* fix comparator for sorting by name and start
* make tool more robust wrt. incorrect options and files not found
* make inlining decision output more clear
* adopt uncommon traps history printing
* properly mention compiler in generated logs
* add options for printing time stamps and omitting compilation IDs
* add option for comparing compilation logs
* overall code cleanup and API documentation
15 lines changed: 12 ins; 1 del; 2 mod; 52 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/Method.java

rev 8632 : 6900757: minor bug fixes to LogCompilation tool
* improve internal error reporting (point to XML element causing trouble)
* fix comparator for sorting by name and start
* make tool more robust wrt. incorrect options and files not found
* make inlining decision output more clear
* adopt uncommon traps history printing
* properly mention compiler in generated logs
* add options for printing time stamps and omitting compilation IDs
* add option for comparing compilation logs
* overall code cleanup and API documentation
70 lines changed: 60 ins; 1 del; 9 mod; 120 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/NMethod.java

rev 8632 : 6900757: minor bug fixes to LogCompilation tool
* improve internal error reporting (point to XML element causing trouble)
* fix comparator for sorting by name and start
* make tool more robust wrt. incorrect options and files not found
* make inlining decision output more clear
* adopt uncommon traps history printing
* properly mention compiler in generated logs
* add options for printing time stamps and omitting compilation IDs
* add option for comparing compilation logs
* overall code cleanup and API documentation
13 lines changed: 11 ins; 0 del; 2 mod; 58 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/Phase.java

rev 8632 : 6900757: minor bug fixes to LogCompilation tool
* improve internal error reporting (point to XML element causing trouble)
* fix comparator for sorting by name and start
* make tool more robust wrt. incorrect options and files not found
* make inlining decision output more clear
* adopt uncommon traps history printing
* properly mention compiler in generated logs
* add options for printing time stamps and omitting compilation IDs
* add option for comparing compilation logs
* overall code cleanup and API documentation
26 lines changed: 22 ins; 0 del; 4 mod; 78 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/UncommonTrapEvent.java

rev 8632 : 6900757: minor bug fixes to LogCompilation tool
* improve internal error reporting (point to XML element causing trouble)
* fix comparator for sorting by name and start
* make tool more robust wrt. incorrect options and files not found
* make inlining decision output more clear
* adopt uncommon traps history printing
* properly mention compiler in generated logs
* add options for printing time stamps and omitting compilation IDs
* add option for comparing compilation logs
* overall code cleanup and API documentation
90 lines changed: 71 ins; 8 del; 11 mod; 65 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/compiler/compileBroker.cpp

rev 8632 : 6900757: minor bug fixes to LogCompilation tool
* improve internal error reporting (point to XML element causing trouble)
* fix comparator for sorting by name and start
* make tool more robust wrt. incorrect options and files not found
* make inlining decision output more clear
* adopt uncommon traps history printing
* properly mention compiler in generated logs
* add options for printing time stamps and omitting compilation IDs
* add option for comparing compilation logs
* overall code cleanup and API documentation
2 lines changed: 0 ins; 0 del; 2 mod; 2400 unchg

------ ------ ------ ------ --- New ----- Raw src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/UncommonTrap.java

rev 8632 : 6900757: minor bug fixes to LogCompilation tool
* improve internal error reporting (point to XML element causing trouble)
* fix comparator for sorting by name and start
* make tool more robust wrt. incorrect options and files not found
* make inlining decision output more clear
* adopt uncommon traps history printing
* properly mention compiler in generated logs
* add options for printing time stamps and omitting compilation IDs
* add option for comparing compilation logs
* overall code cleanup and API documentation
79 lines changed: 79 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /Users/haupt/JPG/webrev/webrev.ksh (vers 25.7-hg+openjdk.java.net).