Code Review for hotspot

Prepared by:Michael Haupt on Tue Jul 28 10:37:34 CEST 2015
Workspace:/Users/haupt/JPG/hs-comp/hotspot
Compare against version:8738
Summary of changes: 884 lines changed: 828 ins; 12 del; 44 mod; 16936 unchg
Changeset: hotspot.changeset
Bug id: JDK-8004073
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/addnode.hpp

rev 8739 : 8004073: Implement C2 Ideal node specific dump() method
Summary: add Node::dump_rel() to dump a node and its related nodes (the notion of "related" depends on the node at hand); add Node::dump_comp() to dump a node in compact representation; add Node::dump_rel_comp() to dump a node and its related nodes in compact representation; add the required machinery; extend some C2 IR nodes with compact and related dumping
Reviewed-by:
9 lines changed: 8 ins; 0 del; 1 mod; 251 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/arraycopynode.cpp

rev 8739 : 8004073: Implement C2 Ideal node specific dump() method
Summary: add Node::dump_rel() to dump a node and its related nodes (the notion of "related" depends on the node at hand); add Node::dump_comp() to dump a node in compact representation; add Node::dump_rel_comp() to dump a node and its related nodes in compact representation; add the required machinery; extend some C2 IR nodes with compact and related dumping
Reviewed-by:
5 lines changed: 5 ins; 0 del; 0 mod; 623 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/arraycopynode.hpp

rev 8739 : 8004073: Implement C2 Ideal node specific dump() method
Summary: add Node::dump_rel() to dump a node and its related nodes (the notion of "related" depends on the node at hand); add Node::dump_comp() to dump a node in compact representation; add Node::dump_rel_comp() to dump a node and its related nodes in compact representation; add the required machinery; extend some C2 IR nodes with compact and related dumping
Reviewed-by:
1 line changed: 1 ins; 0 del; 0 mod; 169 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/callnode.cpp

rev 8739 : 8004073: Implement C2 Ideal node specific dump() method
Summary: add Node::dump_rel() to dump a node and its related nodes (the notion of "related" depends on the node at hand); add Node::dump_comp() to dump a node in compact representation; add Node::dump_rel_comp() to dump a node and its related nodes in compact representation; add the required machinery; extend some C2 IR nodes with compact and related dumping
Reviewed-by:
70 lines changed: 70 ins; 0 del; 0 mod; 1951 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/callnode.hpp

rev 8739 : 8004073: Implement C2 Ideal node specific dump() method
Summary: add Node::dump_rel() to dump a node and its related nodes (the notion of "related" depends on the node at hand); add Node::dump_comp() to dump a node in compact representation; add Node::dump_rel_comp() to dump a node and its related nodes in compact representation; add the required machinery; extend some C2 IR nodes with compact and related dumping
Reviewed-by:
10 lines changed: 10 ins; 0 del; 0 mod; 1092 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/cfgnode.cpp

rev 8739 : 8004073: Implement C2 Ideal node specific dump() method
Summary: add Node::dump_rel() to dump a node and its related nodes (the notion of "related" depends on the node at hand); add Node::dump_comp() to dump a node in compact representation; add Node::dump_rel_comp() to dump a node and its related nodes in compact representation; add the required machinery; extend some C2 IR nodes with compact and related dumping
Reviewed-by:
34 lines changed: 33 ins; 0 del; 1 mod; 2242 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/cfgnode.hpp

rev 8739 : 8004073: Implement C2 Ideal node specific dump() method
Summary: add Node::dump_rel() to dump a node and its related nodes (the notion of "related" depends on the node at hand); add Node::dump_comp() to dump a node in compact representation; add Node::dump_rel_comp() to dump a node and its related nodes in compact representation; add the required machinery; extend some C2 IR nodes with compact and related dumping
Reviewed-by:
16 lines changed: 15 ins; 0 del; 1 mod; 567 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/convertnode.hpp

rev 8739 : 8004073: Implement C2 Ideal node specific dump() method
Summary: add Node::dump_rel() to dump a node and its related nodes (the notion of "related" depends on the node at hand); add Node::dump_comp() to dump a node in compact representation; add Node::dump_rel_comp() to dump a node and its related nodes in compact representation; add the required machinery; extend some C2 IR nodes with compact and related dumping
Reviewed-by:
9 lines changed: 8 ins; 0 del; 1 mod; 214 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/countbitsnode.hpp

rev 8739 : 8004073: Implement C2 Ideal node specific dump() method
Summary: add Node::dump_rel() to dump a node and its related nodes (the notion of "related" depends on the node at hand); add Node::dump_comp() to dump a node in compact representation; add Node::dump_rel_comp() to dump a node and its related nodes in compact representation; add the required machinery; extend some C2 IR nodes with compact and related dumping
Reviewed-by:
5 lines changed: 4 ins; 0 del; 1 mod; 93 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/divnode.hpp

rev 8739 : 8004073: Implement C2 Ideal node specific dump() method
Summary: add Node::dump_rel() to dump a node and its related nodes (the notion of "related" depends on the node at hand); add Node::dump_comp() to dump a node in compact representation; add Node::dump_rel_comp() to dump a node and its related nodes in compact representation; add the required machinery; extend some C2 IR nodes with compact and related dumping
Reviewed-by:
37 lines changed: 36 ins; 0 del; 1 mod; 186 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/ifnode.cpp

rev 8739 : 8004073: Implement C2 Ideal node specific dump() method
Summary: add Node::dump_rel() to dump a node and its related nodes (the notion of "related" depends on the node at hand); add Node::dump_comp() to dump a node in compact representation; add Node::dump_rel_comp() to dump a node and its related nodes in compact representation; add the required machinery; extend some C2 IR nodes with compact and related dumping
Reviewed-by:
33 lines changed: 31 ins; 1 del; 1 mod; 1666 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/movenode.cpp

rev 8739 : 8004073: Implement C2 Ideal node specific dump() method
Summary: add Node::dump_rel() to dump a node and its related nodes (the notion of "related" depends on the node at hand); add Node::dump_comp() to dump a node in compact representation; add Node::dump_rel_comp() to dump a node and its related nodes in compact representation; add the required machinery; extend some C2 IR nodes with compact and related dumping
Reviewed-by:
15 lines changed: 14 ins; 0 del; 1 mod; 397 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/movenode.hpp

rev 8739 : 8004073: Implement C2 Ideal node specific dump() method
Summary: add Node::dump_rel() to dump a node and its related nodes (the notion of "related" depends on the node at hand); add Node::dump_comp() to dump a node in compact representation; add Node::dump_rel_comp() to dump a node and its related nodes in compact representation; add the required machinery; extend some C2 IR nodes with compact and related dumping
Reviewed-by:
5 lines changed: 4 ins; 0 del; 1 mod; 151 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/mulnode.hpp

rev 8739 : 8004073: Implement C2 Ideal node specific dump() method
Summary: add Node::dump_rel() to dump a node and its related nodes (the notion of "related" depends on the node at hand); add Node::dump_comp() to dump a node in compact representation; add Node::dump_rel_comp() to dump a node and its related nodes in compact representation; add the required machinery; extend some C2 IR nodes with compact and related dumping
Reviewed-by:
32 lines changed: 31 ins; 0 del; 1 mod; 265 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/multnode.cpp

rev 8739 : 8004073: Implement C2 Ideal node specific dump() method
Summary: add Node::dump_rel() to dump a node and its related nodes (the notion of "related" depends on the node at hand); add Node::dump_comp() to dump a node in compact representation; add Node::dump_rel_comp() to dump a node and its related nodes in compact representation; add the required machinery; extend some C2 IR nodes with compact and related dumping
Reviewed-by:
15 lines changed: 14 ins; 0 del; 1 mod; 215 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/multnode.hpp

rev 8739 : 8004073: Implement C2 Ideal node specific dump() method
Summary: add Node::dump_rel() to dump a node and its related nodes (the notion of "related" depends on the node at hand); add Node::dump_comp() to dump a node in compact representation; add Node::dump_rel_comp() to dump a node and its related nodes in compact representation; add the required machinery; extend some C2 IR nodes with compact and related dumping
Reviewed-by:
2 lines changed: 1 ins; 0 del; 1 mod; 105 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/node.cpp

rev 8739 : 8004073: Implement C2 Ideal node specific dump() method
Summary: add Node::dump_rel() to dump a node and its related nodes (the notion of "related" depends on the node at hand); add Node::dump_comp() to dump a node in compact representation; add Node::dump_rel_comp() to dump a node and its related nodes in compact representation; add the required machinery; extend some C2 IR nodes with compact and related dumping
Reviewed-by:
257 lines changed: 227 ins; 10 del; 20 mod; 2158 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/node.hpp

rev 8739 : 8004073: Implement C2 Ideal node specific dump() method
Summary: add Node::dump_rel() to dump a node and its related nodes (the notion of "related" depends on the node at hand); add Node::dump_comp() to dump a node in compact representation; add Node::dump_rel_comp() to dump a node and its related nodes in compact representation; add the required machinery; extend some C2 IR nodes with compact and related dumping
Reviewed-by:
61 lines changed: 55 ins; 0 del; 6 mod; 1618 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/rootnode.cpp

rev 8739 : 8004073: Implement C2 Ideal node specific dump() method
Summary: add Node::dump_rel() to dump a node and its related nodes (the notion of "related" depends on the node at hand); add Node::dump_comp() to dump a node in compact representation; add Node::dump_rel_comp() to dump a node and its related nodes in compact representation; add the required machinery; extend some C2 IR nodes with compact and related dumping
Reviewed-by:
16 lines changed: 15 ins; 0 del; 1 mod; 89 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/rootnode.hpp

rev 8739 : 8004073: Implement C2 Ideal node specific dump() method
Summary: add Node::dump_rel() to dump a node and its related nodes (the notion of "related" depends on the node at hand); add Node::dump_comp() to dump a node in compact representation; add Node::dump_rel_comp() to dump a node and its related nodes in compact representation; add the required machinery; extend some C2 IR nodes with compact and related dumping
Reviewed-by:
5 lines changed: 4 ins; 0 del; 1 mod; 68 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/subnode.cpp

rev 8739 : 8004073: Implement C2 Ideal node specific dump() method
Summary: add Node::dump_rel() to dump a node and its related nodes (the notion of "related" depends on the node at hand); add Node::dump_comp() to dump a node in compact representation; add Node::dump_rel_comp() to dump a node and its related nodes in compact representation; add the required machinery; extend some C2 IR nodes with compact and related dumping
Reviewed-by:
49 lines changed: 46 ins; 1 del; 2 mod; 1510 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/subnode.hpp

rev 8739 : 8004073: Implement C2 Ideal node specific dump() method
Summary: add Node::dump_rel() to dump a node and its related nodes (the notion of "related" depends on the node at hand); add Node::dump_comp() to dump a node in compact representation; add Node::dump_rel_comp() to dump a node and its related nodes in compact representation; add the required machinery; extend some C2 IR nodes with compact and related dumping
Reviewed-by:
61 lines changed: 60 ins; 0 del; 1 mod; 568 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/vectornode.hpp

rev 8739 : 8004073: Implement C2 Ideal node specific dump() method
Summary: add Node::dump_rel() to dump a node and its related nodes (the notion of "related" depends on the node at hand); add Node::dump_comp() to dump a node in compact representation; add Node::dump_rel_comp() to dump a node and its related nodes in compact representation; add the required machinery; extend some C2 IR nodes with compact and related dumping
Reviewed-by:
137 lines changed: 136 ins; 0 del; 1 mod; 738 unchg

This code review page was prepared using /Users/haupt/JPG/webrev/webrev.ksh (vers 25.7-hg+openjdk.java.net).