Code Review for jdk

Prepared by:michaelm on Fri Apr 29 11:47:50 BST 2016
Workspace:/export/jdk9/jdk
Compare against: ssh://hg.openjdk.java.net/jdk9/dev/jdk
Summary of changes: 8081 lines changed: 7511 ins; 298 del; 272 mod; 8921 unchg
Patch of changes: jdk.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.httpclient/share/classes/java/net/http/AsyncEvent.java

22 lines changed: 12 ins; 1 del; 9 mod; 48 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.httpclient/share/classes/java/net/http/AuthenticationFilter.java

1 line changed: 0 ins; 0 del; 1 mod; 305 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.httpclient/share/classes/java/net/http/BufferHandler.java

14 lines changed: 12 ins; 0 del; 2 mod; 35 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.httpclient/share/classes/java/net/http/ConnectionPool.java

1 line changed: 0 ins; 0 del; 1 mod; 271 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.httpclient/share/classes/java/net/http/CookieFilter.java

1 line changed: 0 ins; 0 del; 1 mod; 65 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.httpclient/share/classes/java/net/http/Exchange.java

38 lines changed: 1 ins; 24 del; 13 mod; 382 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.httpclient/share/classes/java/net/http/Http1Exchange.java

24 lines changed: 0 ins; 20 del; 4 mod; 285 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.httpclient/share/classes/java/net/http/Http1Request.java

28 lines changed: 22 ins; 2 del; 4 mod; 356 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.httpclient/share/classes/java/net/http/Http1Response.java

1 line changed: 0 ins; 1 del; 0 mod; 289 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.httpclient/share/classes/java/net/http/Http2ClientImpl.java

128 lines changed: 122 ins; 0 del; 6 mod; 27 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.httpclient/share/classes/java/net/http/Http2Connection.java

760 lines changed: 731 ins; 6 del; 23 mod; 36 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.httpclient/share/classes/java/net/http/HttpClientImpl.java

143 lines changed: 58 ins; 42 del; 43 mod; 462 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.httpclient/share/classes/java/net/http/HttpConnection.java

106 lines changed: 38 ins; 54 del; 14 mod; 299 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.httpclient/share/classes/java/net/http/HttpHeadersImpl.java

41 lines changed: 1 ins; 32 del; 8 mod; 96 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.httpclient/share/classes/java/net/http/HttpRequestBuilderImpl.java

9 lines changed: 8 ins; 0 del; 1 mod; 176 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.httpclient/share/classes/java/net/http/HttpRequestImpl.java

98 lines changed: 58 ins; 28 del; 12 mod; 245 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.httpclient/share/classes/java/net/http/HttpResponse.java

11 lines changed: 7 ins; 0 del; 4 mod; 973 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.httpclient/share/classes/java/net/http/HttpResponseImpl.java

38 lines changed: 30 ins; 2 del; 6 mod; 149 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.httpclient/share/classes/java/net/http/Log.java

48 lines changed: 36 ins; 0 del; 12 mod; 165 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.httpclient/share/classes/java/net/http/MultiExchange.java

6 lines changed: 0 ins; 3 del; 3 mod; 269 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.httpclient/share/classes/java/net/http/Pair.java

5 lines changed: 5 ins; 0 del; 0 mod; 46 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.httpclient/share/classes/java/net/http/PlainHttpConnection.java

183 lines changed: 172 ins; 0 del; 11 mod; 217 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.httpclient/share/classes/java/net/http/PlainTunnelingConnection.java

1 line changed: 0 ins; 0 del; 1 mod; 142 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.httpclient/share/classes/java/net/http/RawChannel.java

49 lines changed: 22 ins; 16 del; 11 mod; 121 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.httpclient/share/classes/java/net/http/RedirectFilter.java

5 lines changed: 3 ins; 0 del; 2 mod; 94 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.httpclient/share/classes/java/net/http/ResponseHeaders.java

5 lines changed: 0 ins; 4 del; 1 mod; 475 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.httpclient/share/classes/java/net/http/SSLConnection.java

7 lines changed: 0 ins; 5 del; 2 mod; 171 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.httpclient/share/classes/java/net/http/SSLDelegate.java

31 lines changed: 23 ins; 4 del; 4 mod; 449 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.httpclient/share/classes/java/net/http/SSLTunnelConnection.java

6 lines changed: 0 ins; 4 del; 2 mod; 173 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.httpclient/share/classes/java/net/http/Stream.java

760 lines changed: 742 ins; 1 del; 17 mod; 83 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.httpclient/share/classes/java/net/http/Utils.java

194 lines changed: 152 ins; 23 del; 19 mod; 179 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.httpclient/share/classes/java/net/http/package-info.java

5 lines changed: 0 ins; 0 del; 5 mod; 35 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/java/net/httpclient/APIErrors.java

35 lines changed: 3 ins; 20 del; 12 mod; 175 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/java/net/httpclient/LightWeightHttpServer.java

4 lines changed: 0 ins; 0 del; 4 mod; 309 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/java/net/httpclient/ManyRequests.java

40 lines changed: 28 ins; 3 del; 9 mod; 182 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/java/net/httpclient/RequestBodyTest.java

4 lines changed: 2 ins; 1 del; 1 mod; 167 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/java/net/httpclient/SmokeTest.java

19 lines changed: 14 ins; 2 del; 3 mod; 944 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/java/net/httpclient/security/15.policy

1 line changed: 0 ins; 0 del; 1 mod; 26 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.httpclient/share/classes/java/net/http/AsyncConnection.java

68 lines changed: 68 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.httpclient/share/classes/java/net/http/AsyncSSLConnection.java

129 lines changed: 129 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.httpclient/share/classes/java/net/http/AsyncSSLDelegate.java

598 lines changed: 598 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.httpclient/share/classes/java/net/http/ByteBufferConsumer.java

188 lines changed: 188 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.httpclient/share/classes/java/net/http/ByteBufferGenerator.java

136 lines changed: 136 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.httpclient/share/classes/java/net/http/CharsetToolkit.java

159 lines changed: 159 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.httpclient/share/classes/java/net/http/ContinuationFrame.java

59 lines changed: 59 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.httpclient/share/classes/java/net/http/DataFrame.java

126 lines changed: 126 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.httpclient/share/classes/java/net/http/ErrorFrame.java

88 lines changed: 88 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.httpclient/share/classes/java/net/http/FrameReader.java

70 lines changed: 70 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.httpclient/share/classes/java/net/http/GoAwayFrame.java

104 lines changed: 104 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.httpclient/share/classes/java/net/http/HeaderFrame.java

77 lines changed: 77 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.httpclient/share/classes/java/net/http/HeadersFrame.java

138 lines changed: 138 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.httpclient/share/classes/java/net/http/Http2Frame.java

211 lines changed: 211 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.httpclient/share/classes/java/net/http/ImmutableHeaders.java

79 lines changed: 79 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.httpclient/share/classes/java/net/http/OutgoingHeaders.java

91 lines changed: 91 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.httpclient/share/classes/java/net/http/PingFrame.java

85 lines changed: 85 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.httpclient/share/classes/java/net/http/PriorityFrame.java

82 lines changed: 82 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.httpclient/share/classes/java/net/http/PushPromiseFrame.java

119 lines changed: 119 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.httpclient/share/classes/java/net/http/Queue.java

143 lines changed: 143 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.httpclient/share/classes/java/net/http/ResetFrame.java

61 lines changed: 61 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.httpclient/share/classes/java/net/http/SettingsFrame.java

165 lines changed: 165 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.httpclient/share/classes/java/net/http/WindowUpdateFrame.java

78 lines changed: 78 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/java/net/httpclient/EchoHandler.java

87 lines changed: 87 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/java/net/httpclient/TestKit.java

101 lines changed: 101 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/java/net/httpclient/TestKitTest.java

130 lines changed: 130 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/java/net/httpclient/http2/BasicTest.java

222 lines changed: 222 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/java/net/httpclient/http2/ServerPush.java

107 lines changed: 107 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/java/net/httpclient/http2/TEST.properties

1 line changed: 1 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/java/net/httpclient/http2/java.httpclient/java/net/http/BodyInputStream.java

107 lines changed: 107 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/java/net/httpclient/http2/java.httpclient/java/net/http/BodyOutputStream.java

106 lines changed: 106 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/java/net/httpclient/http2/java.httpclient/java/net/http/EchoHandler.java

78 lines changed: 78 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/java/net/httpclient/http2/java.httpclient/java/net/http/Http2Handler.java

18 lines changed: 18 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/java/net/httpclient/http2/java.httpclient/java/net/http/Http2TestExchange.java

126 lines changed: 126 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/java/net/httpclient/http2/java.httpclient/java/net/http/Http2TestServer.java

159 lines changed: 159 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/java/net/httpclient/http2/java.httpclient/java/net/http/Http2TestServerConnection.java

730 lines changed: 730 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/java/net/httpclient/http2/java.httpclient/java/net/http/OutgoingPushPromise.java

31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/java/net/httpclient/http2/java.httpclient/java/net/http/PushHandler.java

71 lines changed: 71 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/java/net/httpclient/http2/java.httpclient/java/net/http/TestUtil.java

81 lines changed: 81 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/mm72272/bin/webrev (vers 25.16-hg+openjdk.java.net).