Code Review for open

Prepared by:michaelm on Wed Aug 26 14:46:04 IST 2020
Workspace:/Users/mimcmah/hg/jdk-unixdomain/open
Compare against: ssh://hg.openjdk.java.net/jdk/jdk
Summary of changes: 6729 lines changed: 5754 ins; 605 del; 370 mod; 17097 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/NetPermission.java

10 lines changed: 10 ins; 0 del; 0 mod; 224 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/StandardProtocolFamily.java

7 lines changed: 6 ins; 0 del; 1 mod; 44 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/nio/channels/DatagramChannel.java

10 lines changed: 9 ins; 1 del; 0 mod; 632 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/nio/channels/ServerSocketChannel.java

91 lines changed: 62 ins; 2 del; 27 mod; 298 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/nio/channels/SocketChannel.java

149 lines changed: 114 ins; 4 del; 31 mod; 526 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/nio/channels/package-info.java

22 lines changed: 22 ins; 0 del; 0 mod; 340 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/nio/channels/spi/SelectorProvider.java

21 lines changed: 5 ins; 1 del; 15 mod; 350 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/module-info.java

2 lines changed: 2 ins; 0 del; 0 mod; 390 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/net/ext/ExtendedSocketOptions.java

21 lines changed: 20 ins; 0 del; 1 mod; 185 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/net/util/SocketExceptions.java

21 lines changed: 20 ins; 0 del; 1 mod; 88 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/ch/Net.java

6 lines changed: 6 ins; 0 del; 0 mod; 820 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/ch/Secrets.java

2 lines changed: 0 ins; 0 del; 2 mod; 61 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/ch/SelectorProviderImpl.java

23 lines changed: 18 ins; 0 del; 5 mod; 80 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/ch/ServerSocketAdaptor.java

3 lines changed: 0 ins; 0 del; 3 mod; 233 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/ch/ServerSocketChannelImpl.java

123 lines changed: 18 ins; 85 del; 20 mod; 514 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/ch/SocketAdaptor.java

3 lines changed: 0 ins; 0 del; 3 mod; 447 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/ch/SocketChannelImpl.java

169 lines changed: 18 ins; 115 del; 36 mod; 1256 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/native/libnet/net_util.h

9 lines changed: 9 ins; 0 del; 0 mod; 203 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/unix/classes/sun/nio/ch/InheritedChannel.java

45 lines changed: 25 ins; 1 del; 19 mod; 261 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/unix/native/libnet/net_util_md.h

3 lines changed: 3 ins; 0 del; 0 mod; 99 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/unix/native/libnio/ch/InheritedChannel.c

20 lines changed: 15 ins; 0 del; 5 mod; 185 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/unix/native/libnio/ch/Net.c

4 lines changed: 3 ins; 0 del; 1 mod; 949 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/windows/classes/sun/nio/ch/PipeImpl.java

29 lines changed: 22 ins; 5 del; 2 mod; 178 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/windows/classes/sun/nio/ch/SinkChannelImpl.java

8 lines changed: 8 ins; 0 del; 0 mod; 142 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/windows/classes/sun/nio/ch/WindowsSelectorImpl.java

2 lines changed: 0 ins; 0 del; 2 mod; 633 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/windows/classes/sun/nio/fs/WindowsPath.java

10 lines changed: 10 ins; 0 del; 0 mod; 932 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/windows/native/libnet/net_util_md.h

1 line changed: 1 ins; 0 del; 0 mod; 174 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/windows/native/libnio/ch/Net.c

15 lines changed: 11 ins; 0 del; 4 mod; 784 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jfr/share/classes/jdk/jfr/events/Handlers.java

2 lines changed: 2 ins; 0 del; 0 mod; 38 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jfr/share/classes/jdk/jfr/internal/instrument/JDKEvents.java

6 lines changed: 5 ins; 0 del; 1 mod; 178 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jfr/share/conf/jfr/profile.jfc

12 lines changed: 12 ins; 0 del; 0 mod; 992 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.net/linux/classes/jdk/net/LinuxSocketOptions.java

19 lines changed: 19 ins; 0 del; 0 mod; 120 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.net/linux/native/libextnet/LinuxSocketOptions.c

28 lines changed: 28 ins; 0 del; 0 mod; 220 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.net/macosx/classes/jdk/net/MacOSXSocketOptions.java

19 lines changed: 19 ins; 0 del; 0 mod; 89 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.net/macosx/native/libextnet/MacOSXSocketOptions.c

18 lines changed: 18 ins; 0 del; 0 mod; 152 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.net/share/classes/jdk/net/ExtendedSocketOptions.java

41 lines changed: 41 ins; 0 del; 0 mod; 396 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.sctp/unix/classes/sun/nio/ch/sctp/SctpChannelImpl.java

5 lines changed: 0 ins; 2 del; 3 mod; 1096 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/com/sun/nio/sctp/SctpServerChannel/NonBlockingAccept.java

6 lines changed: 0 ins; 6 del; 0 mod; 224 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/net/httpclient/whitebox/java.net.http/jdk/internal/net/http/ConnectionPoolTest.java

1 line changed: 1 ins; 0 del; 0 mod; 538 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/nio/channels/etc/ProtocolFamilies.java

16 lines changed: 13 ins; 0 del; 3 mod; 378 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/CloseTest.java

4 lines changed: 0 ins; 1 del; 3 mod; 95 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/EchoTest.java

1 line changed: 0 ins; 0 del; 1 mod; 184 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java

1 line changed: 1 ins; 0 del; 0 mod; 122 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/Launcher.java

81 lines changed: 33 ins; 19 del; 29 mod; 128 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/StateTest.java

4 lines changed: 0 ins; 0 del; 4 mod; 200 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/StateTestService.java

2 lines changed: 0 ins; 0 del; 2 mod; 112 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/UnixDomainChannelTest.java

100 lines changed: 55 ins; 8 del; 37 mod; 72 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/UnixSocketTest.java

53 lines changed: 21 ins; 9 del; 23 mod; 45 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/libInheritedChannel.c

134 lines changed: 0 ins; 133 del; 1 mod; 180 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jdk/nio/Basic.java

11 lines changed: 10 ins; 1 del; 0 mod; 276 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/net/UnixDomainSocketAddress.java

206 lines changed: 206 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/sun/nio/ch/InetServerSocketChannelImpl.java

191 lines changed: 191 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/sun/nio/ch/InetSocketChannelImpl.java

278 lines changed: 278 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/sun/nio/ch/UnixDomainNet.java

182 lines changed: 182 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/sun/nio/ch/UnixDomainServerSocketChannelImpl.java

218 lines changed: 218 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/ch/UnixDomainSocketChannelImpl.java (was src/java.base/unix/classes/sun/nio/ch/UnixDomainSocketChannelImpl.java)

226 lines changed: 36 ins; 108 del; 82 mod; 76 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/unix/classes/sun/nio/fs/PathUtil.java

43 lines changed: 43 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/unix/classes/sun/nio/fs/UnixUserGroupUtil.java

44 lines changed: 44 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/unix/native/libnio/ch/UnixNet.c

229 lines changed: 229 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/windows/classes/sun/nio/fs/PathUtil.java

44 lines changed: 44 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/windows/native/libnio/ch/UnixNet.c

218 lines changed: 218 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jfr/share/classes/jdk/jfr/events/UnixSocketReadEvent.java

56 lines changed: 56 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jfr/share/classes/jdk/jfr/events/UnixSocketWriteEvent.java

52 lines changed: 52 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jfr/share/classes/jdk/jfr/internal/instrument/InetSocketChannelImplInstrumentor.java (was src/jdk.jfr/share/classes/jdk/jfr/internal/instrument/SocketChannelImplInstrumentor.java)

16 lines changed: 10 ins; 3 del; 3 mod; 158 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jfr/share/classes/jdk/jfr/internal/instrument/UnixSocketChannelImplInstrumentor.java

150 lines changed: 150 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.net/share/classes/jdk/net/UnixDomainPrincipal.java

98 lines changed: 98 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/nio/channels/unixdomain/AddressTest.java

50 lines changed: 50 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/nio/channels/unixdomain/Bind.java

302 lines changed: 302 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/nio/channels/unixdomain/DummyPath.java

187 lines changed: 187 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/nio/channels/unixdomain/IOExchanges.java

1237 lines changed: 1237 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/nio/channels/unixdomain/LengthTest.java

99 lines changed: 99 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/nio/channels/unixdomain/NonBlockingAccept.java

58 lines changed: 58 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/nio/channels/unixdomain/NonWindowsDriver.java

34 lines changed: 34 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/nio/channels/unixdomain/Security.java

153 lines changed: 153 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/nio/channels/unixdomain/Shutdown.java

117 lines changed: 117 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/nio/channels/unixdomain/SocketOptions.java

128 lines changed: 128 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/nio/channels/unixdomain/UnixDomainSocketAddressSerializationTest.java

125 lines changed: 125 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/nio/channels/unixdomain/WindowsDriver.java

35 lines changed: 35 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/nio/channels/unixdomain/policy1

4 lines changed: 4 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/nio/channels/unixdomain/policy2

6 lines changed: 6 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/java/net/SocketChannelCompare.java

193 lines changed: 193 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/java/net/SocketChannelConnectionSetup.java

132 lines changed: 132 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/java/net/UnixSocketChannelReadWrite.java

124 lines changed: 124 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/UnixDomainSocket.java

101 lines changed: 0 ins; 101 del; 0 mod; 0 unchg

This code review page was prepared using /Users/mimcmah/bin/webrev (vers 25.16-hg+openjdk.java.net).