Code Review for hotspot

Prepared by:neliasso on Wed Oct 7 12:14:55 CEST 2015
Workspace:/home/neliasso/repos/compiler_control/hotspot
Compare against: ssh://hg.openjdk.java.net/jdk9/hs-comp/hotspot
Compare against version:9031
Summary of changes: 4070 lines changed: 3805 ins; 160 del; 105 mod; 65961 unchg
Patch of changes: hotspot.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/c1/c1_Compilation.cpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
8 lines changed: 3 ins; 2 del; 3 mod; 703 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/c1/c1_Compilation.hpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
3 lines changed: 2 ins; 0 del; 1 mod; 344 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/c1/c1_Compiler.cpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
2 lines changed: 0 ins; 0 del; 2 mod; 255 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/c1/c1_Compiler.hpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
2 lines changed: 1 ins; 0 del; 1 mod; 64 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/c1/c1_GraphBuilder.cpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
8 lines changed: 2 ins; 1 del; 5 mod; 4263 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/ci/ciEnv.cpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
16 lines changed: 11 ins; 1 del; 4 mod; 1279 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/ci/ciEnv.hpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
5 lines changed: 4 ins; 1 del; 0 mod; 468 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/ci/ciMethod.cpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
55 lines changed: 0 ins; 54 del; 1 mod; 1414 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/ci/ciMethod.hpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
11 lines changed: 2 ins; 8 del; 1 mod; 337 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/vmSymbols.cpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
9 lines changed: 0 ins; 8 del; 1 mod; 911 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/vmSymbols.hpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
1 line changed: 0 ins; 0 del; 1 mod; 1402 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/code/nmethod.cpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
15 lines changed: 0 ins; 14 del; 1 mod; 3126 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/compiler/abstractCompiler.hpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
5 lines changed: 2 ins; 0 del; 3 mod; 140 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/compiler/compileBroker.cpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
54 lines changed: 28 ins; 21 del; 5 mod; 2051 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/compiler/compileBroker.hpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
11 lines changed: 7 ins; 2 del; 2 mod; 363 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/compiler/compileTask.cpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
14 lines changed: 14 ins; 0 del; 0 mod; 391 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/compiler/compilerOracle.cpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
19 lines changed: 8 ins; 7 del; 4 mod; 881 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/compiler/compilerOracle.hpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
5 lines changed: 4 ins; 0 del; 1 mod; 87 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/compiler/methodMatcher.cpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
101 lines changed: 101 ins; 0 del; 0 mod; 347 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/compiler/methodMatcher.hpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
57 lines changed: 28 ins; 27 del; 2 mod; 97 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/block.cpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
2 lines changed: 1 ins; 0 del; 1 mod; 1769 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/block.hpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
1 line changed: 0 ins; 1 del; 0 mod; 890 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/bytecodeInfo.cpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
3 lines changed: 0 ins; 0 del; 3 mod; 732 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/c2_globals.hpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
2 lines changed: 0 ins; 0 del; 2 mod; 707 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/c2compiler.cpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
3 lines changed: 1 ins; 0 del; 2 mod; 434 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/c2compiler.hpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
2 lines changed: 1 ins; 0 del; 1 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/chaitin.cpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
1 line changed: 0 ins; 0 del; 1 mod; 2408 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/compile.cpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
30 lines changed: 9 ins; 2 del; 19 mod; 4395 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/compile.hpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
17 lines changed: 6 ins; 3 del; 8 mod; 1286 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/idealGraphPrinter.cpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
14 lines changed: 0 ins; 4 del; 10 mod; 719 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/idealGraphPrinter.hpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
6 lines changed: 1 ins; 0 del; 5 mod; 136 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/library_call.cpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
4 lines changed: 2 ins; 1 del; 1 mod; 6326 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/output.cpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
3 lines changed: 1 ins; 1 del; 1 mod; 2887 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/parse2.cpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
3 lines changed: 0 ins; 0 del; 3 mod; 2388 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/runtime.cpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
6 lines changed: 4 ins; 0 del; 2 mod; 1622 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/superword.cpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
1 line changed: 0 ins; 0 del; 1 mod; 3909 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/prims/jni.cpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
4 lines changed: 4 ins; 0 del; 0 mod; 4371 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/prims/whitebox.cpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
56 lines changed: 54 ins; 0 del; 2 mod; 1550 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/globals.hpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
10 lines changed: 9 ins; 0 del; 1 mod; 4194 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/init.cpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
4 lines changed: 2 ins; 0 del; 2 mod; 187 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/mutexLocker.cpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
2 lines changed: 2 ins; 0 del; 0 mod; 327 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/mutexLocker.hpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
1 line changed: 1 ins; 0 del; 0 mod; 369 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/sharedRuntime.cpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
6 lines changed: 6 ins; 0 del; 0 mod; 2848 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/vm_operations.cpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
1 line changed: 0 ins; 1 del; 0 mod; 497 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/services/diagnosticCommand.cpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
41 lines changed: 41 ins; 0 del; 0 mod; 900 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/services/diagnosticCommand.hpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
109 lines changed: 109 ins; 0 del; 0 mod; 616 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/shark/sharkCompiler.cpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
4 lines changed: 2 ins; 1 del; 1 mod; 368 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/shark/sharkCompiler.hpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
2 lines changed: 1 ins; 0 del; 1 mod; 133 unchg

------ ------ ------ ------ --- New Patch Raw src/share/vm/compiler/compilerDirectives.cpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
498 lines changed: 498 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/vm/compiler/compilerDirectives.hpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
183 lines changed: 183 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/vm/compiler/directivesParser.cpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
726 lines changed: 726 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/vm/compiler/directivesParser.hpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
139 lines changed: 139 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/vm/utilities/json.cpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
955 lines changed: 955 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/vm/utilities/json.hpp

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
125 lines changed: 125 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/compiler/compilercontrol/InlineMatcherTest.java

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
173 lines changed: 173 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/compiler/compilercontrol/TestCompilerDirectivesCompatibilityBase.java

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
113 lines changed: 113 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/compiler/compilercontrol/TestCompilerDirectivesCompatibilityCommandOff.java

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
70 lines changed: 70 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/compiler/compilercontrol/TestCompilerDirectivesCompatibilityCommandOn.java

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
70 lines changed: 70 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/compiler/compilercontrol/TestCompilerDirectivesCompatibilityFlag.java

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
70 lines changed: 70 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/compiler/compilercontrol/control_off.txt

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
6 lines changed: 6 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/compiler/compilercontrol/control_on.txt

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
6 lines changed: 6 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/serviceability/dcmd/compiler/CompilerDirectivesDCMDTest.java

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
158 lines changed: 158 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/serviceability/dcmd/compiler/control1.txt

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
17 lines changed: 17 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/serviceability/dcmd/compiler/control2.txt

rev 9032 : 8137167: JEP165: Compiler Control: Implementation task
Summary: Compiler Control JEP
Reviewed-by: roland, twisti
22 lines changed: 22 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/neliasso/tools/webrev.ksh (vers 23.18-hg-never-dev).