< prev index next >

src/hotspot/share/opto/split_if.cpp

Print this page
rev 54013 : 8219448: split-if update_uses accesses stale idom data
Reviewed-by:

@@ -521,11 +521,13 @@
       new_true = ifpx;
     }
   }
   _igvn.remove_dead_node(new_iff);
   // Lazy replace IDOM info with the region's dominator
-  lazy_replace( iff, region_dom );
+  lazy_replace(iff, region_dom);
+  lazy_update(region, region_dom); // idom must be update before handle_uses
+  region->set_req(0, NULL);        // Break the self-cycle. Required for lazy_update to work on region
 
   // Now make the original merge point go dead, by handling all its uses.
   small_cache region_cache;
   // Preload some control flow in region-cache
   region_cache.lru_insert( new_false, new_false );

@@ -564,16 +566,11 @@
     // calling get_ctrl calling get_ctrl_no_update looking for dead
     // regions).  So roll back the DUIterator innards.
     --k;
   } // End of while merge point has phis
 
-  assert(region->outcnt() == 1, "Only self reference should remain"); // Just Self on the Region
-  region->set_req(0, NULL);       // Break the self-cycle
+  _igvn.remove_dead_node(region);
 
-  // Any leftover bits in the splitting block must not have depended on local
-  // Phi inputs (these have already been split-up).  Hence it's safe to hoist
-  // these guys to the dominating point.
-  lazy_replace( region, region_dom );
 #ifndef PRODUCT
   if( VerifyLoopOptimizations ) verify();
 #endif
 }
< prev index next >