| Prepared by: | never on Fri Jun 26 13:02:56 PDT 2009 |
|---|---|
| Workspace: | /net/smite.sfbay/export/ws/baseline |
| Compare against: | ssh://hg.openjdk.java.net/jdk7/hotspot-comp-gate/hotspot |
| Summary of changes: | 39 lines changed: 18 ins; 3 del; 18 mod; 12048 unchg |
| Patch of changes: | 6818666.patch |
| Author comments: |
G1 needs to load the original value as part of it's prebarrier and to do this it needs a type for the result. The existing code tries to take that type from the value being stored which doesn't work for NULL since it's not an oop type. The fix is to require the caller to pass in the appropriate type since in almost all cases it knows the right value exactly. In the cases where it's unknown we attempt to derive the type from address expression. Tested with UseG1GC 32 and 64 bit x86 with CTW, runthese and nsk, plus original failing test case. |
| Legend: |
Modified file Deleted file New file |
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/share/vm/opto/graphKit.cpp
26 lines changed: 18 ins; 1 del; 7 mod; 3431 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/share/vm/opto/graphKit.hpp
5 lines changed: 0 ins; 1 del; 4 mod; 749 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/share/vm/opto/library_call.cpp
5 lines changed: 0 ins; 1 del; 4 mod; 5181 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/share/vm/opto/parse2.cpp
1 line changed: 0 ins; 0 del; 1 mod; 2226 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/share/vm/opto/parse3.cpp
2 lines changed: 0 ins; 0 del; 2 mod; 461 unchg
This code review page was prepared using /net/smite.sfbay/never/bin/webrev (vers 23.18-hg-never).