Code Review for 6868051

Prepared by:never on Tue Aug 4 13:19:44 PDT 2009
Workspace:/net/smite.sfbay/export/ws/baseline
Compare against: ssh://hg.openjdk.java.net/jdk7/hotspot-comp-gate/hotspot
Summary of changes: 29 lines changed: 13 ins; 13 del; 3 mod; 308 unchg
Patch of changes: 6868051.patch
Author comments:
The code for reading the size of a FreeChunk in compressed oops mode
is wrong. It's reading the value of the field and then passing that
address to the Mark constructor instead of passing the address to
Mark. Additionally the workaround logic in getLiveRegions is
incompatible with the new encoding of FreeChunks. Rearranging the
code to see if it's a free chunk first and then handling null case
last allows it to work correctly in all cases. Tested with failing
core file and repeatedly running jmap -F -histo against a jbb process
running with CMS and 32/64 bit both with and without compressed oops.

Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw agent/src/share/classes/sun/jvm/hotspot/memory/FreeChunk.java

2 lines changed: 0 ins; 0 del; 2 mod; 93 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw agent/src/share/classes/sun/jvm/hotspot/memory/CompactibleFreeListSpace.java

27 lines changed: 13 ins; 13 del; 1 mod; 215 unchg

This code review page was prepared using /net/smite.sfbay/never/bin/webrev (vers 23.18-hg-never).