Code Review for 6889869

Prepared by:never on Wed Oct 14 09:54:25 PDT 2009
Compare against: ssh://
Summary of changes: 10 lines changed: 8 ins; 1 del; 1 mod; 485 unchg
Patch of changes: 6889869.patch
Author comments:
6889869: assert(!Interpreter::bytecode_should_reexecute(code),"should not reexecute")
Reviewed-by: jrose, kvn, cfang

The changes for 6873116 moved the reexecute bit into the PcDesc but
didn't account for the code in DebugInformationRecorder that tries to
share them. Since the code isn't checking should_reexecute it can
merge PcDescs with different reexecute bits. The fix is to check that
when merging them. The original code in 6833129 doesn't have this
problem because the bit was in the stream. Tested with failing test
case from nightly and -XX:+DeoptimizeALot -XX:+PatchALot runs that
also showed the problem.

Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/code/pcDesc.hpp

8 lines changed: 8 ins; 0 del; 0 mod; 72 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/code/debugInfoRec.cpp

2 lines changed: 0 ins; 1 del; 1 mod; 413 unchg

This code review page was prepared using /never/bin/webrev (vers 23.18-hg-never).