Prepared by: | never on Thu Feb 25 11:03:56 PST 2010 |
---|---|
Workspace: | /net/smite.sfbay/export/ws/osr |
Compare against: | /net/smite.sfbay/export/ws/baseline |
Summary of changes: | 15 lines changed: 11 ins; 1 del; 3 mod; 2204 unchg |
Patch of changes: | 6915557.patch |
Author comments: |
6915557: assert(_gvn.type(l)->higher_equal(type),"must constrain OSR typestate") with debug build Reviewed-by: The fix for 6892079 to eliminate asserts about address types in OSR was insufficient because sometimes method liveness may consider locals to live that actually aren't because of the conservativeness of its analysis. I think the fix is simply to not check address types. If the OSR entry point has any live address we will fail this test but the resonsibility for making sure that we don't actually have a live jsr during OSR entry is managed by ciTypeFlow itself so it should be safe to simply skip the check. Tested with failing test case. Also tested with new OSRTheWorld mode that I will push separately. It reproduces the crash directly from the jar files used in tomcat. |
Legend: |
Modified file Deleted file New file |
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/share/vm/opto/parse1.cpp
15 lines changed: 11 ins; 1 del; 3 mod; 2204 unchg
This code review page was prepared using /never/bin/webrev (vers 23.18-hg-never).