Code Review for 6930398

Prepared by:never on Fri Feb 26 15:06:21 PST 2010
Workspace:/net/smite.sfbay/export/ws/baseline
Compare against: ssh://hg.openjdk.java.net/jdk7/hotspot-comp-gate/hotspot
Summary of changes: 1 line changed: 0 ins; 0 del; 1 mod; 2217 unchg
Patch of changes: 6930398.patch
Author comments:
6930398: fix for return address locals in OSR entries uses wrong test
Reviewed-by:

The fix for 6915557 is attempting to handle locals containing return
address specially but the test it's using is wrong. C2's type system
smears together T_ADDRESS with raw pointer types, so
TypePtr::NULL_PTr->basic_type() == T_ADDRESS so the logic will trigger
for locals which are provably null resulting in asserts later. The
correct fix is to test the ciType of the local which correctly
distinguishes these cases. Tested with failing tests from nightly.

Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/parse1.cpp

1 line changed: 0 ins; 0 del; 1 mod; 2217 unchg

This code review page was prepared using /never/bin/webrev (vers 23.18-hg-never).