Code Review for 6968348

Prepared by:never on Wed Sep 29 18:25:35 PDT 2010
Compare against: ssh://
Summary of changes: 95 lines changed: 58 ins; 37 del; 0 mod; 12814 unchg
Patch of changes: 6968348.patch
Author comments:
6968348: Byteswapped memory access can point to wrong location after JIT
Reviewed-by: has match rules for (Store (ReverseBytes val)) but the
definition is buggy since the val can be used in address of the store.
It also doesn't record that it changes the input value. The fix is to
simply remove these rules since they are no better than what we'd get
otherwise. doesn't have these rules. does but it
can generate better code for these forms because it can use the byte
swapped ASI and doesn't have to modify the register before storing it.
Tested with new test case.

Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/

37 lines changed: 0 ins; 37 del; 0 mod; 12814 unchg

------ ------ ------ ------ --- New Patch Raw test/compiler/6968348/

58 lines changed: 58 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /never/bin/webrev (vers 23.18-hg-never).