Prepared by: | never on Tue Oct 12 12:06:28 PDT 2010 |
---|---|
Workspace: | /net/smite.sfbay/export/ws/hse |
Compare against: | ssh://hg.openjdk.java.net/jdk7/hotspot-comp-gate/hotspot |
Summary of changes: | 722 lines changed: 336 ins; 343 del; 43 mod; 8924 unchg |
Patch of changes: | 6970683.patch |
Author comments: |
6970683: improvements to hs_err output Summary: Reviewed-by: There are a few things missing from the hs_err dump that would be useful. First we don't dump the sparc L and I registers. Second some information about the size and contents of the code cache would be useful. Third we should dump a larger region around the faulting instruction. Additionally the new register to memory mapping output can crash which stops us from getting the stack and instructions at the faulting pc, so I moved it into it's own section. block_start would assert in some cases so I augmented existing logic to just return null. I also changed the formatting to remove all the extra whitespace and made some of the output more compact and eliminated most of the useless whitespace. Tested by kill -SEGV processes and inspecting the hs_err files. |
Legend: |
Modified file Deleted file New file |
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/share/vm/utilities/vmError.cpp
17 lines changed: 16 ins; 0 del; 1 mod; 943 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/share/vm/runtime/os.hpp
2 lines changed: 1 ins; 0 del; 1 mod; 630 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/share/vm/runtime/os.cpp
16 lines changed: 6 ins; 0 del; 10 mod; 1241 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/share/vm/memory/heap.hpp
2 lines changed: 1 ins; 0 del; 1 mod; 160 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp
2 lines changed: 1 ins; 0 del; 1 mod; 970 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/share/vm/gc_implementation/includeDB_gc_parallelScavenge
1 line changed: 1 ins; 0 del; 0 mod; 459 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/share/vm/code/codeCache.hpp
1 line changed: 1 ins; 0 del; 0 mod; 174 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/share/vm/code/codeCache.cpp
11 lines changed: 11 ins; 0 del; 0 mod; 916 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/os_cpu/windows_x86/vm/os_windows_x86.cpp
133 lines changed: 42 ins; 88 del; 3 mod; 468 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp
143 lines changed: 45 ins; 95 del; 3 mod; 867 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp
146 lines changed: 77 ins; 52 del; 17 mod; 682 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/os_cpu/linux_x86/vm/os_linux_x86.cpp
144 lines changed: 45 ins; 95 del; 4 mod; 781 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp
104 lines changed: 89 ins; 13 del; 2 mod; 633 unchg
This code review page was prepared using /never/bin/webrev (vers 23.18-hg-never).