Prepared by: | never on Wed Sep 22 12:23:41 PDT 2010 |
---|---|
Workspace: | /net/smite.sfbay/export/ws/6982537 |
Compare against: | ssh://hg.openjdk.java.net/jdk7/hotspot-comp-gate/hotspot |
Summary of changes: | 19 lines changed: 2 ins; 0 del; 17 mod; 6852 unchg |
Patch of changes: | 6982537.patch |
Author comments: |
6982537: Crash in Node*step_through_mergemem Reviewed-by: Code which was examining the type of memory was attempting to introspect on the klass of TypeOopPtr but wasn't checking for NULL which led to crashes when it looked at a primitive array type. The fix is to check for NULL. I also updated similar code in escape.cpp and corrected variable names to match the types. Tested with failing test from bug report. |
Legend: |
Modified file Deleted file New file |
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/share/vm/opto/memnode.cpp
6 lines changed: 1 ins; 0 del; 5 mod; 4157 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/share/vm/opto/escape.cpp
13 lines changed: 1 ins; 0 del; 12 mod; 2695 unchg
This code review page was prepared using /never/bin/webrev (vers 23.18-hg-never).