Code Review for 6984979

Prepared by:never on Wed Sep 15 16:30:11 PDT 2010
Workspace:/net/smite.sfbay/export/ws/6969586
Compare against: ssh://closedjdk.sfbay/hsx/hsx19-gate/baseline
Summary of changes: 12 lines changed: 11 ins; 0 del; 1 mod; 2729 unchg
Patch of changes: 6984979.patch
Author comments:
6984979: OptimizeFill misses some cases with an odd memory graph
Reviewed-by:

The logic for the new OptimizeFill code misses a case where the Phi
usage is different than expected. Sometimes during transformation of
the loop there are uses of the memory phi outside the loop. This
appears to be a valid though slightly surprising structure but it
interferes with the fill matching logic that assumes the store in the
loop should be the only outgoing state. The fix is to allow the phi
to be used outside the loop and replace it with the outgoing memory of
the call to the fill. Tested with jbb, runthere and ctw.

Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/loopTransform.cpp

12 lines changed: 11 ins; 0 del; 1 mod; 2729 unchg

This code review page was prepared using /never/bin/webrev (vers 23.18-hg-never).