| Prepared by: | never on Tue May 10 14:36:24 PDT 2011 |
|---|---|
| Workspace: | /net/smite.us.oracle.com/export/ws/indy |
| Compare against: | ssh://hg.openjdk.java.net/jdk7/hotspot-comp-gate/hotspot |
| Summary of changes: | 23 lines changed: 10 ins; 6 del; 7 mod; 514 unchg |
| Patch of changes: | 7043040.patch |
| Author comments: |
7043040: JSR292: JRuby bench/shootout/binarytrees.ruby-2.ruby SEGV: constantPoolKlass::oop_follow_contents Reviewed-by: The logic in oop_push_constants was skipping JVM_CONSTANT_Object entries which would cause corruption in later GCs. The fix is to use is_pointer_entry to identify roots like all the other visitor. The verify_on method was also too weak so it missed the problem when run with the verify GC flags. Tested with failing test from report. |
| Bug id: | 7043040 JSR292: JRuby bench/shootout/binarytrees.ruby-2.ruby SEGV: constantPoolKlass::oop_follow_contents |
| Legend: |
Modified file Deleted file New file |
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/share/vm/oops/constantPoolKlass.cpp
23 lines changed: 10 ins; 6 del; 7 mod; 514 unchg
This code review page was prepared using /never/bin/webrev (vers 23.18-hg-never).