| Prepared by: | never on Mon May 9 15:56:02 PDT 2011 |
|---|---|
| Workspace: | /net/smite.us.oracle.com/export/ws/baseline |
| Compare against: | ssh://hg.openjdk.java.net/jdk7/hotspot-comp-gate/hotspot |
| Summary of changes: | 9 lines changed: 3 ins; 0 del; 6 mod; 5624 unchg |
| Patch of changes: | 7043301.patch |
| Author comments: |
7043301: assert(locals < caller->fp() || locals > (caller->fp() + 16)) failed: locals in save area Reviewed-by: During the fix for 7009361 I mistakenly simplified the computed_sp_adjustment by replacing it with rounded_cls but one is for the caller and the other is for the callee. This could result in some rare cases where the frame shrunk to be smaller than it should have been. The fix is to restore the original computation of this value. Tested with failing test case. I also corrected the frame validation code which should have complained about this. |
| Bug id: | Bug Database |
| Legend: |
Modified file Deleted file New file |
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/cpu/sparc/vm/templateInterpreter_sparc.cpp
4 lines changed: 3 ins; 0 del; 1 mod; 2095 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/cpu/sparc/vm/frame_sparc.cpp
1 line changed: 0 ins; 0 del; 1 mod; 838 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/cpu/x86/vm/frame_x86.cpp
1 line changed: 0 ins; 0 del; 1 mod; 667 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/share/vm/runtime/frame.hpp
1 line changed: 0 ins; 0 del; 1 mod; 548 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/share/vm/runtime/frame.cpp
2 lines changed: 0 ins; 0 del; 2 mod; 1476 unchg
This code review page was prepared using /never/bin/webrev (vers 23.18-hg-never).