Code Review for 7062856

Prepared by:never on Tue Jul 5 21:27:51 PDT 2011
Workspace:/net/smite.us.oracle.com/export/ws/baseline
Compare against: ssh://hg.openjdk.java.net/hsx/hotspot-comp-gate/hotspot
Summary of changes: 44 lines changed: 39 ins; 0 del; 5 mod; 573 unchg
Patch of changes: 7062856.patch
Author comments:
7062856: Disassembler needs to be smarter about finding hsdis after 1.7 launcher changes
Summary: do explicit lookup emulating old LD_LIBRARY_PATH search
Reviewed-by: kvn, jrose

Changes to launcher in the JDK7 removed the default setting of
LD_LIBRARY_PATH which was being used to find the disassembler. I
added explicit logic to perform a lookup equivalent to the previous
behaviour. Tested with truss to confirm search paths and
PrintNMethods.

I also fixed an annoyance where every separate invocation of the
disassembler emitted the "Disassembling ..." message so that it would
only print it again if it changed.

Bug id: Bug Database
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/compiler/disassembler.cpp

34 lines changed: 31 ins; 0 del; 3 mod; 486 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/tools/hsdis/README

10 lines changed: 8 ins; 0 del; 2 mod; 87 unchg

This code review page was prepared using /never/bin/webrev (vers 23.18-hg-never).