| Prepared by: | never on Mon Feb 13 21:43:32 PST 2012 |
|---|---|
| Workspace: | /net/smite.us.oracle.com/export/ws/crypto |
| Compare against: | ssh://hg.openjdk.java.net/hsx/hotspot-comp-gate/hotspot |
| Summary of changes: | 21 lines changed: 13 ins; 6 del; 2 mod; 427 unchg |
| Patch of changes: | 7144318.patch |
| Author comments: |
7144318: GCLocker assert failure: assert(_needs_gc || SafepointSynchronize::is_at_safepoint( Reviewed-by: The _needs_gc flag only changes from false to true during a safepoint but it can change from true to false at other times. The new asserts are too strict for the combined call is_active_and_needs_gc since _needs_gc is checked twice and may change in between. I was unable to reproduce the original failure but the failure mode is pretty clear. |
| Bug id: | 7144318 GCLocker assert failure: assert(_needs_gc || SafepointSynchronize::is_at_safepoint( |
| Legend: |
Modified file Deleted file New file |
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/share/vm/memory/gcLocker.inline.hpp
6 lines changed: 0 ins; 6 del; 0 mod; 72 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/share/vm/memory/gcLocker.hpp
15 lines changed: 13 ins; 0 del; 2 mod; 355 unchg
This code review page was prepared using /never/bin/webrev (vers 23.18-hg-never-dev).